Skip to contentSkip to conversation

COLO:Fix Colo doc, secondeary should be secondary

PATCH Superseded wangguang 4 participants 5 messages Mar 20, 2017 – Mar 21, 2017

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

wangguang

author
#0 lore raw

PATCH v3 1/1 COLO:Fix Colo doc, secondeary should be secondary

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt.
secondeary-disk0 should be secondary-disk0.

---

 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 
docs/COLO-FT.txt +0 -0
index e289be2..bec7547 100644 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',

'port': '8889'} } }
}
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', 'writable': true } }
+{'execute': 'nbd-server-add', 'arguments': {'device': 'Secondary-disk0', 'writable': true } }

Note:
a. The qmp command nbd-server-start and nbd-server-add must be run

Signature · 11 lines
2.9.3 

 





--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v3-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474158.html
Sent from the Developer mailing list archive at Nabble.com.
#1 lore raw
Quoted 14 lines · * wangguang ([email protected]) wrote:

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt.
secondeary-disk0 should be secondary-disk0.

---

 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 
docs/COLO-FT.txt +0 -0
index e289be2..bec7547 100644 

docs/COLO-FT.txt Secondary: · line 145

Quoted 8 lines
docs/COLO-FT.txt +1 -1
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
 'port': '8889'} } } 
 } 
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
 'writable': true } } 
+{'execute': 'nbd-server-add', 'arguments': {'device': 'Secondary-disk0',
 'writable': true } } 

That should be 's' not 'S' shouldn't it, to match the other uses in the same doc?

Dave

Quoted 16 lines

Note:
a. The qmp command nbd-server-start and nbd-server-add must be run

Signature · 11 lines
2.9.3 

 





--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v3-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474158.html
Sent from the Developer mailing list archive at Nabble.com.

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

author
#2 lore raw
In reply to wangguang

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by:
Guang Wang <[email protected]>--- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e289be2..bec7547 100644 --- a/docs/COLO-FT.txt +++ b/docs/COLO-FT.txt @@ -139,7 +139,7 @@ Secondary: { 'execute':
'nbd-server-start', 'arguments': {'addr': {'type': 'inet', 'data':
{'host': 'xx.xx.xx.xx', 'port': '8889'} } } } -{'execute':
'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', 'writable':
true } } +{'execute': 'nbd-server-add', 'arguments': {'device':
'secondary-disk0', 'writable': true } } Note: a. The qmp command
nbd-server-start and nbd-server-add must be run -- 2.9.3

--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v3-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474158p474432.html
Sent from the Developer mailing list archive at Nabble.com.

#3 lore raw
Quoted 5 lines · wangguang

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by:

--
View this message in context: http://qemu.11.n7.nabble.com/

Nabble may be a fine platform for viewing mailing list archives, and even for commenting on existing posts without having a subscription, but it is absolutely LOUSY at sending patches. Please don't try to abuse nabble for sending patches, but rather figure out how to get 'git send-email' working properly.

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#4 lore raw
Quoted 10 lines · Eric Blake
Quoted 4 lines · wangguang

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by:
--
View this message in context: http://qemu.11.n7.nabble.com/

Nabble may be a fine platform for viewing mailing list archives, and even for commenting on existing posts without having a subscription, but it is absolutely LOUSY at sending patches. Please don't try to abuse nabble for sending patches, but rather figure out how to get 'git send-email' working properly.

I agree.

Quoted 1 line
Signature · 2 lines
Thanks
Zhang Chen