Skip to contentSkip to conversation

ALSA: sound/isa: constify snd_kcontrol_new structures

PATCH In review Bhumika Goyal 3 participants 8 messages May 17, 2017 – May 22, 2017 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: sound/isa: constify snd_kcontrol_new structures

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

---
 sound/isa/gus/gus_main.c | 2 +-
 sound/isa/gus/gus_pcm.c  | 4 ++--
 sound/isa/sb/sb16_csp.c  | 4 ++--
 sound/isa/sb/sb16_main.c | 2 +-
 sound/isa/sscape.c       | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)
sound/isa/gus/gus_main.c +1 -1
index 4490ee4..3cf9b13 100644
@@ -82,7 +82,7 @@ static int snd_gus_joystick_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el
 	return change;
 }
 
-static struct snd_kcontrol_new snd_gus_joystick_control = {
+static const struct snd_kcontrol_new snd_gus_joystick_control = {
 	.iface = SNDRV_CTL_ELEM_IFACE_CARD,
 	.name = "Joystick Speed",
 	.info = snd_gus_joystick_info,
sound/isa/gus/gus_pcm.c +2 -2
index 0650599..33c1891 100644
@@ -809,7 +809,7 @@ static int snd_gf1_pcm_volume_put(struct snd_kcontrol *kcontrol, struct snd_ctl_
 	return change;
 }
 
-static struct snd_kcontrol_new snd_gf1_pcm_volume_control =
+static const struct snd_kcontrol_new snd_gf1_pcm_volume_control =
 {
 	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
 	.name = "PCM Playback Volume",
@@ -818,7 +818,7 @@ static struct snd_kcontrol_new snd_gf1_pcm_volume_control =
 	.put = snd_gf1_pcm_volume_put
 };
 
-static struct snd_kcontrol_new snd_gf1_pcm_volume_control1 =
+static const struct snd_kcontrol_new snd_gf1_pcm_volume_control1 =
 {
 	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
 	.name = "GPCM Playback Volume",
sound/isa/sb/sb16_csp.c +2 -2
index 48da227..fa5780b 100644
@@ -1029,7 +1029,7 @@ static int snd_sb_qsound_space_put(struct snd_kcontrol *kcontrol, struct snd_ctl
 	return change;
 }
 
-static struct snd_kcontrol_new snd_sb_qsound_switch = {
+static const struct snd_kcontrol_new snd_sb_qsound_switch = {
 	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
 	.name = "3D Control - Switch",
 	.info = snd_sb_qsound_switch_info,
@@ -1037,7 +1037,7 @@ static struct snd_kcontrol_new snd_sb_qsound_switch = {
 	.put = snd_sb_qsound_switch_put
 };
 
-static struct snd_kcontrol_new snd_sb_qsound_space = {
+static const struct snd_kcontrol_new snd_sb_qsound_space = {
 	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
 	.name = "3D Control - Space",
 	.info = snd_sb_qsound_space_info,
sound/isa/sb/sb16_main.c +1 -1
index 8b2d6c6..4be1350 100644
@@ -737,7 +737,7 @@ static int snd_sb16_dma_control_put(struct snd_kcontrol *kcontrol, struct snd_ct
 	return change;
 }
 
-static struct snd_kcontrol_new snd_sb16_dma_control = {
+static const struct snd_kcontrol_new snd_sb16_dma_control = {
 	.iface = SNDRV_CTL_ELEM_IFACE_CARD,
 	.name = "16-bit DMA Allocation",
 	.info = snd_sb16_dma_control_info,
sound/isa/sscape.c +1 -1
index 54f5758a..1cd2908 100644
@@ -671,7 +671,7 @@ static int sscape_midi_put(struct snd_kcontrol *kctl,
 	return change;
 }
 
-static struct snd_kcontrol_new midi_mixer_ctl = {
+static const struct snd_kcontrol_new midi_mixer_ctl = {
 	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
 	.name = "MIDI",
 	.info = sscape_midi_info,
Signature · 1 line
2.7.4
#1 lore raw
Quoted 24 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

Quoted 7 lines

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

As I already asked, could you send as a patchset if you have multiple similar patches?

thanks,

Takashi

#2 lore raw
Quoted 32 lines · Takashi Iwai
Quoted 30 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

Quoted 5 lines
Quoted 1 line

As I already asked, could you send as a patchset if you have multiple similar patches?

Sure. Will combine the already sent ones and some new ones into a patchset and send again.

Thanks,
Bhumika

Quoted 4 lines

thanks,

Takashi

#3 lore raw
Quoted 34 lines · Bhumika Goyal
Quoted 32 lines · Takashi Iwai
Quoted 30 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

As I already asked, could you send as a patchset if you have multiple similar patches?

Sure. Will combine the already sent ones and some new ones into a patchset and send again.

Well, since there haven't been new submissions and the patches are trivial, I applied the existing four patches. If you have newer ones, please submit as a patchset.

thanks,

Takashi

#4 lore raw
Quoted 42 lines · Takashi Iwai
Quoted 40 lines · Bhumika Goyal
Quoted 37 lines · Takashi Iwai
Quoted 24 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

Quoted 7 lines

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

As I already asked, could you send as a patchset if you have multiple similar patches?

Quoted 8 lines
Quoted 2 lines

Sure. Will combine the already sent ones and some new ones into a patchset and send again.

Well, since there haven't been new submissions and the patches are trivial, I applied the existing four patches. If you have newer ones, please submit as a patchset.

Hey,

Thanks for applying the patches.
I have a doubt that since some of my coming patches are for the sound subsystem containing similar changes and you will be applying those, so can I combine and put all the changes in a single patch or sending a patchset would be a correct way.

Thanks,
Bhumika

Quoted 3 lines

thanks,

Takashi

#5 lore raw
Quoted 52 lines · Bhumika Goyal
Quoted 42 lines · Takashi Iwai
Quoted 40 lines · Bhumika Goyal
Quoted 37 lines · Takashi Iwai
Quoted 24 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

Quoted 7 lines

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

As I already asked, could you send as a patchset if you have multiple similar patches?

Quoted 8 lines
Quoted 2 lines

Sure. Will combine the already sent ones and some new ones into a patchset and send again.

Well, since there haven't been new submissions and the patches are trivial, I applied the existing four patches. If you have newer ones, please submit as a patchset.

Quoted 7 lines

Hey,

Thanks for applying the patches.
I have a doubt that since some of my coming patches are for the sound subsystem containing similar changes and you will be applying those, so can I combine and put all the changes in a single patch or sending a patchset would be a correct way.

I think he means that when you have more sound patches, just do them all at once.

julia

#6 lore raw
Quoted 59 lines · Julia Lawall
Quoted 54 lines · Bhumika Goyal
Quoted 42 lines · Takashi Iwai
Quoted 40 lines · Bhumika Goyal
Quoted 37 lines · Takashi Iwai
Quoted 24 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

Quoted 7 lines

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

As I already asked, could you send as a patchset if you have multiple similar patches?

Quoted 8 lines
Quoted 2 lines

Sure. Will combine the already sent ones and some new ones into a patchset and send again.

Well, since there haven't been new submissions and the patches are trivial, I applied the existing four patches. If you have newer ones, please submit as a patchset.

Hey,

Quoted 8 lines
Quoted 5 lines

Thanks for applying the patches.
I have a doubt that since some of my coming patches are for the sound subsystem containing similar changes and you will be applying those, so can I combine and put all the changes in a single patch or sending a patchset would be a correct way.

I think he means that when you have more sound patches, just do them all at once.

Yes, that's my point.

You've sent each patch individually, and this made me difficult to pick up, as I had to wonder "is this really all?" (then 10 minutes later another patch arrived :)

At best, submit all the relevant patches via git-send-email with the proper cover letter in a single thread.

thanks,

Takashi

#7 lore raw
Quoted 70 lines · Takashi Iwai
Quoted 59 lines · Julia Lawall
Quoted 54 lines · Bhumika Goyal
Quoted 42 lines · Takashi Iwai
Quoted 40 lines · Bhumika Goyal
Quoted 37 lines · Takashi Iwai
Quoted 24 lines · Bhumika Goyal

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

Quoted 7 lines

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

As I already asked, could you send as a patchset if you have multiple similar patches?

Quoted 8 lines
Quoted 2 lines

Sure. Will combine the already sent ones and some new ones into a patchset and send again.

Well, since there haven't been new submissions and the patches are trivial, I applied the existing four patches. If you have newer ones, please submit as a patchset.

Hey,

Quoted 8 lines
Quoted 5 lines

Thanks for applying the patches.
I have a doubt that since some of my coming patches are for the sound subsystem containing similar changes and you will be applying those, so can I combine and put all the changes in a single patch or sending a patchset would be a correct way.

I think he means that when you have more sound patches, just do them all at once.

Quoted 9 lines

Yes, that's my point.

You've sent each patch individually, and this made me difficult to pick up, as I had to wonder "is this really all?" (then 10 minutes later another patch arrived :)

At best, submit all the relevant patches via git-send-email with the proper cover letter in a single thread.

Thanks Julia and Takashi for clearing my doubt. I will keep this point in mind for my future patches :)

Thanks,
Bhumika

Quoted 4 lines

thanks,

Takashi