lib/cfl: Add Coffeelake PCI IDs for S SKU.
PATCH 1/3 lib/cfl: Add Coffeelake PCI IDs for S SKU.
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
v2: update IDs
--- lib/i915_pciids.h | 10 ++++++++++ lib/intel_device_info.c | 2 ++ 2 files changed, 12 insertions(+)
lib/i915_pciids.h +10 -0
@@ -334,4 +334,14 @@INTEL_KBL_GT3_IDS (info), \ INTEL_KBL_GT4_IDS(info) +#define INTEL_CFL_S_IDS (info) \ + INTEL_VGA_DEVICE(0x3E90, info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E93 , info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E91 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ + INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_IDS(info) +#endif /* _I915_PCIIDS_H */
lib/intel_device_info.c +2 -0
@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {INTEL_GLK_IDS (&intel_geminilake_info), +INTEL_CFL_IDS (&intel_coffeelake_info), + INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info), };
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 lib/cfl: Add PCI IDs to H SKU in CFl
From: anushasr <[email protected]>
Follow the spec and add the ID for H SKU in
CFL.
v2: Update IDs.
--- lib/i915_pciids.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
lib/i915_pciids.h +7 -1
@@ -341,7 +341,13 @@INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_H_IDS (info) \ + INTEL_VGA_DEVICE(0x3E9B, info),/* Halo GT2 */ \ + INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ +#define INTEL_CFL_IDS (info) \ - INTEL_CFL_S_IDS(info) + INTEL_CFL_S_IDS(info), \ + INTEL_CFL_H_IDS(info)#endif /* _I915_PCIIDS_H */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl
Quoted 18 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Follow the spec and add the ID for H SKU in
CFL.v2: Update IDs.
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- lib/i915_pciids.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)lib/i915_pciids.h +0
-0
lib/i915_pciids.h line 348
Quoted 8 lines
lib/i915_pciids.h +5
-0@@ -341,7 +341,13 @@INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_H_IDS (info) \ + INTEL_VGA_DEVICE(0x3E9B, info),/* Halo GT2 */ \ +INTEL_VGA_DEVICE (0x3E94 , info)/* Halo GT2 */ +
Device ID's Matches current documentation
lib/i915_pciids.h line 353
Quoted 6 lines
lib/i915_pciids.h +2
-1#define INTEL_CFL_IDS (info) \ - INTEL_CFL_S_IDS(info) + INTEL_CFL_S_IDS(info), \ + INTEL_CFL_H_IDS(info)#endif /* _I915_PCIIDS_H */
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 lib/cfl: Add PCI Ids for U SKU in CFl
In reply to Anusha SrivatsaFrom: anushasr <[email protected]>
Follow the spec and add ID for U SKU
v2: Update IDs.
--- lib/i915_pciids.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
lib/i915_pciids.h +8 -1
@@ -346,8 +346,15 @@INTEL_VGA_DEVICE (0x3E9B , info),/* Halo GT2 */ \ INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ +#define INTEL_CFL_U_IDS (info) \ + INTEL_VGA_DEVICE(0x3EA5, info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA6 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA7 , info),/* ULT GT3 */ \ + INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */ +#define INTEL_CFL_IDS (info) \ INTEL_CFL_S_IDS(info), \ - INTEL_CFL_H_IDS(info) + INTEL_CFL_H_IDS(info), \ + INTEL_CFL_U_IDS(info)#endif /* _I915_PCIIDS_H */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
Quoted 17 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Follow the spec and add ID for U SKU
v2: Update IDs.
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- lib/i915_pciids.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)lib/i915_pciids.h +0
-0
lib/i915_pciids.h line 353
Quoted 8 lines
lib/i915_pciids.h +5
-0@@ -346,8 +346,15 @@INTEL_VGA_DEVICE (0x3E9B , info),/* Halo GT2 */ \ INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ +#define INTEL_CFL_U_IDS (info) \ + INTEL_VGA_DEVICE(0x3EA5, info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA6 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA7 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA8 , info)/* ULT GT3 */
0x3EA8 is marked as not POR in the current documentation.
-Clint
lib/i915_pciids.h line 360
Quoted 8 lines
lib/i915_pciids.h +3
-1+#define INTEL_CFL_IDS (info) \ INTEL_CFL_S_IDS(info), \ - INTEL_CFL_H_IDS(info) + INTEL_CFL_H_IDS(info), \ + INTEL_CFL_U_IDS(info)#endif /* _I915_PCIIDS_H */
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
Quoted 32 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Clint Taylor
Sent: Wednesday, June 21, 2017 12:48 PM
To: [email protected]
Subject: Re: [Intel-gfx] [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFlQuoted 20 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Follow the spec and add ID for U SKU
v2: Update IDs.
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- lib/i915_pciids.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)lib/i915_pciids.h index renamed from lib/i915_pciids.h +0
-0c319e37..71cce60 100644
lib/i915_pciids.h +0
-0@@ -346,8 +346,15 @@INTEL_VGA_DEVICE (0x3E9B , info),/* Halo GT2 */ \INTEL_VGA_DEVICE (0x3E94 , info)/* Halo GT2 */
Quoted 6 lines
lib/i915_pciids.h line 353
Quoted 5 lines
lib/i915_pciids.h +5
-0+#define INTEL_CFL_U_IDS (info) \ + INTEL_VGA_DEVICE(0x3EA5, info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA6 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA7 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA8 , info)/* ULT GT3 */
0x3EA8is marked as not POR in the current documentation.
Wanted to match the IDs everywhere. The above list of IDs is the same even in kernel code and in libdrm .
Anusha
Quoted 10 lines
-Clint
Quoted 7 lines
lib/i915_pciids.h +3
-1+#define INTEL_CFL_IDS (info) \ INTEL_CFL_S_IDS(info), \ - INTEL_CFL_H_IDS(info) + INTEL_CFL_H_IDS(info), \ + INTEL_CFL_U_IDS(info)
Quoted 6 lines
lib/i915_pciids.h line 360
Quoted 1 line
lib/i915_pciids.h +0
-0#endif /* _I915_PCIIDS_H */ _______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Anusha Srivatsa (2017-06-21 17:34:57)
Quoted 3 lines
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
i915_pciids.h is just a copy from the kernel. So copy across and cite the upstream kernel commits.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 18 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
v2: update IDs
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- lib/i915_pciids.h | 10 ++++++++++ lib/intel_device_info.c | 2 ++ 2 files changed, 12 insertions(+)lib/i915_pciids.h +0
-0
lib/i915_pciids.h line 343
Quoted 10 lines
lib/i915_pciids.h +7
-0@@ -334,4 +334,14 @@INTEL_KBL_GT3_IDS (info), \ INTEL_KBL_GT4_IDS(info) +#define INTEL_CFL_S_IDS (info) \ + INTEL_VGA_DEVICE(0x3E90, info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E93 , info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E91 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E96 , info)/* SRV GT2 */ +
Matches current documentation
Quoted 9 lines
lib/i915_pciids.h +3
-0+#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_IDS(info) +#endif /* _I915_PCIIDS_H */ lib/intel_device_info.c +0
-0
lib/intel_device_info.c static const struct pci_id_match intel_device_match[] = { · line 248
Quoted 8 lines
lib/intel_device_info.c +2
-0@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {INTEL_GLK_IDS (&intel_geminilake_info), +INTEL_CFL_IDS (&intel_coffeelake_info), + INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info), };
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx