lib/cfl: Add Coffeelake PCI IDs for S SKU.
PATCH RESEND 1/3 lib/cfl: Add Coffeelake PCI IDs for S SKU.
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
v2: update IDs following the kernel commit:b056f8f3d6b900e8afd19f312719160346d263b4 (Chris)
--- lib/i915_pciids.h | 10 ++++++++++ lib/intel_device_info.c | 2 ++ 2 files changed, 12 insertions(+)
lib/i915_pciids.h +10 -0
@@ -334,4 +334,14 @@INTEL_KBL_GT3_IDS (info), \ INTEL_KBL_GT4_IDS(info) +#define INTEL_CFL_S_IDS (info) \ + INTEL_VGA_DEVICE(0x3E90, info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E93 , info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E91 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ + INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_IDS(info) +#endif /* _I915_PCIIDS_H */
lib/intel_device_info.c +2 -0
@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {INTEL_GLK_IDS (&intel_geminilake_info), +INTEL_CFL_IDS (&intel_coffeelake_info), + INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info), };
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH RESEND 2/3 lib/cfl: Add PCI IDs to H SKU in CFl
From: anushasr <[email protected]>
Follow the spec and add the ID for H SKU in
CFL.
v2: Update IDs following kernel commit:ccfd13215fd25a0e8c28221f3acc0dcaec11cd15 (Chris)
--- lib/i915_pciids.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
lib/i915_pciids.h +7 -1
@@ -341,7 +341,13 @@INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_H_IDS (info) \ + INTEL_VGA_DEVICE(0x3E9B, info),/* Halo GT2 */ \ + INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ +#define INTEL_CFL_IDS (info) \ - INTEL_CFL_S_IDS(info) + INTEL_CFL_S_IDS(info), \ + INTEL_CFL_H_IDS(info)#endif /* _I915_PCIIDS_H */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH RESEND 3/3 lib/cfl: Add PCI Ids for U SKU in CFl
In reply to Anusha SrivatsaFrom: anushasr <[email protected]>
Follow the spec and add ID for U SKU
v2: Update IDs in accordance to the kernel commit:d29fe702c9cb682df99146d24d06e5455f043101 (Chris)
--- lib/i915_pciids.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
lib/i915_pciids.h +8 -1
@@ -346,8 +346,15 @@INTEL_VGA_DEVICE (0x3E9B , info),/* Halo GT2 */ \ INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ +#define INTEL_CFL_U_IDS (info) \ + INTEL_VGA_DEVICE(0x3EA5, info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA6 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA7 , info),/* ULT GT3 */ \ + INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */ +#define INTEL_CFL_IDS (info) \ INTEL_CFL_S_IDS(info), \ - INTEL_CFL_H_IDS(info) + INTEL_CFL_H_IDS(info), \ + INTEL_CFL_U_IDS(info)#endif /* _I915_PCIIDS_H */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RESEND i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
Quoted 18 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Follow the spec and add ID for U SKU
v2: Update IDs in accordance to the kernel commit:
d29fe702c9cb682df99146d24d06e5455f043101(Chris)Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- lib/i915_pciids.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)lib/i915_pciids.h +0
-0
lib/i915_pciids.h line 354
Quoted 9 lines
lib/i915_pciids.h +6
-0@@ -346,8 +346,15 @@INTEL_VGA_DEVICE (0x3E9B , info),/* Halo GT2 */ \ INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ +#define INTEL_CFL_U_IDS (info) \ + INTEL_VGA_DEVICE(0x3EA5, info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA6 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA7 , info),/* ULT GT3 */ \ +INTEL_VGA_DEVICE (0x3EA8 , info)/* ULT GT3 */ +
Added devices match i915 driver IDs.
lib/i915_pciids.h line 360
Quoted 7 lines
lib/i915_pciids.h +2
-1#define INTEL_CFL_IDS (info) \ INTEL_CFL_S_IDS(info), \ - INTEL_CFL_H_IDS(info) + INTEL_CFL_H_IDS(info), \ + INTEL_CFL_U_IDS(info)#endif /* _I915_PCIIDS_H */
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 39 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
v2: update IDs following the kernel commit:
b056f8f3d6b900e8afd19f312719160346d263b4(Chris)Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Clint Taylor <[email protected]>--- lib/i915_pciids.h | 10 ++++++++++ lib/intel_device_info.c | 2 ++ 2 files changed, 12 insertions(+)lib/i915_pciids.h +10
-0@@ -334,4 +334,14 @@INTEL_KBL_GT3_IDS (info), \ INTEL_KBL_GT4_IDS(info) +#define INTEL_CFL_S_IDS (info) \ + INTEL_VGA_DEVICE(0x3E90, info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E93 , info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E91 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ + INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_IDS(info) +#endif /* _I915_PCIIDS_H */ lib/intel_device_info.c +0
-0
lib/intel_device_info.c static const struct pci_id_match intel_device_match[] = { · line 244
Quoted 4 lines
lib/intel_device_info.c +1
-0@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {INTEL_GLK_IDS (&intel_geminilake_info), + INTEL_CFL_IDS(&intel_coffeelake_info),
BTW, having
"From: anushasr <[email protected]>"
on your patches resulting in quite unusual authorship lines.
Please consider using git config --global user.name "Your Full Name" on the machines you are creating the patches with if this is not intentional.
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 41 lines · Arkadiusz Hiler
Quoted 40 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
v2: update IDs following the kernel commit:
b056f8f3d6b900e8afd19f312719160346d263b4(Chris)Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Clint Taylor <[email protected]>--- lib/i915_pciids.h | 10 ++++++++++ lib/intel_device_info.c | 2 ++ 2 files changed, 12 insertions(+)lib/i915_pciids.h +10
-0@@ -334,4 +334,14 @@INTEL_KBL_GT3_IDS (info), \ INTEL_KBL_GT4_IDS(info) +#define INTEL_CFL_S_IDS (info) \ + INTEL_VGA_DEVICE(0x3E90, info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E93 , info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E91 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ + INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_IDS(info) +#endif /* _I915_PCIIDS_H */ lib/intel_device_info.c +0
-0@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {
Quoted 3 lines
lib/intel_device_info.c static const struct pci_id_match intel_device_match[] = { · line 244
Quoted 3 lines
lib/intel_device_info.c +1
-0INTEL_GLK_IDS (&intel_geminilake_info), + INTEL_CFL_IDS(&intel_coffeelake_info),
Cut the important part accidentally before sending. Here it is:
Hey,
The series does not compile and intel_coffeelake_info is nowhere to be found.
Maybe you are missing a patch from the series?
Quoted 11 lines
BTW, having
"From: anushasr <[email protected]>"
on your patches resulting in quite unusual authorship lines.Please consider using
git config --global user.name "Your Full Name"on the machines you are creating the patches with if this is not intentional.Signature · 2 lines
Cheers, Arek
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 59 lines
-----Original Message-----
From: Hiler, Arkadiusz
Sent: Wednesday, June 28, 2017 5:20 AM
To: Srivatsa, Anusha <[email protected]>
Cc: [email protected]; Vivi, Rodrigo <[email protected]>
Subject: Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.Quoted 42 lines · Arkadiusz Hiler
Quoted 41 lines · Anusha Srivatsa
From: anushasr <[email protected]>
Just following the spec and adding these extra IDs.
v2: update IDs following the kernel commit:
b056f8f3d6b900e8afd19f312719160346d263b4(Chris)Cc Rodrigo Vivi <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Clint Taylor <[email protected]>--- lib/i915_pciids.h | 10 ++++++++++ lib/intel_device_info.c | 2 ++ 2 files changed, 12 insertions(+)lib/i915_pciids.h index renamed from lib/i915_pciids.h +0
-027e0dba..02f43d9 100644
lib/i915_pciids.h +10
-0@@ -334,4 +334,14 @@INTEL_KBL_GT3_IDS (info), \ INTEL_KBL_GT4_IDS(info) +#define INTEL_CFL_S_IDS (info) \ + INTEL_VGA_DEVICE(0x3E90, info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E93 , info),/* SRV GT1 */ \ +INTEL_VGA_DEVICE (0x3E91 , info),/* SRV GT2 */ \ +INTEL_VGA_DEVICE (0x3E92 , info),/* SRV GT2 */ \ + INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */ + +#define INTEL_CFL_IDS (info) \ + INTEL_CFL_S_IDS(info) +#endif /* _I915_PCIIDS_H */ lib/intel_device_info.c index renamed from lib/intel_device_info.c +0
-0199fa2d..2c46aba 100644
lib/intel_device_info.c +0
-0@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {Quoted 3 lines
lib/intel_device_info.c static const struct pci_id_match intel_device_match[] = { · line 244
Quoted 3 lines
lib/intel_device_info.c +1
-0INTEL_GLK_IDS (&intel_geminilake_info), + INTEL_CFL_IDS(&intel_coffeelake_info),Cut the important part accidentally before sending. Here it is:
Quoted 5 lines
Hey,
The series does not compile and
intel_coffeelake_infois nowhere to be found.Maybe you are missing a patch from the series?
Intel_coffeelake_info is part of "Introduce Coffeelake platform definition" - 8c47cc5eca.... authored by Rodrigo Vivi.
Once that patch is merged, this one compiles. I thought its already merged.
I need to send the patches with correct authorship anyway, will check again Arek.
Thanks ,
Anusha
Quoted 11 lines
Quoted 11 lines
BTW, having
"From: anushasr <[email protected]>"
on your patches resulting in quite unusual authorship lines.Please consider using
git config --global user.name "Your Full Name"on the machines you are creating the patches with if this is not intentional.--
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx