Skip to contentSkip to conversation

Staging: rtl8712 : os_intfs.c: use octal permission representation

PATCH In review Jaya Durga 2 participants 2 messages Jun 27, 2017 – Jun 29, 2017 Staging

lore
Share & tools
lore

Jaya Durga

author
#0 lore raw

PATCH v2 1/2 Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.

---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/os_intfs.c +1 -1
index 8836b31..e698f6e 100644
@@ -93,7 +93,7 @@
  */
 static int wifi_test;
 
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
 module_param(wifi_test, int, 0644);
 module_param(initmac, charp, 0644);
 module_param(video_mode, int, 0644);
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 7 lines · Jaya Durga

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.

---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I have a bizarre series of oddly numbered patches from you, and no where is a whole, correctly numbered, set of patches that I can sort correctly and apply to my tree knowing that I did not miss any.

So I've now dropped all of your patches you have sent to me from my queue. Please redo them all and resend them properly numbered in a manner that makes it _obvious_ what ones I should review and what order they should be applied in.

thanks,

greg k-h