Staging: rtl8712 : os_intfs.c: use octal

PATCH Superseded Jaya Durga 2 participants 2 messages Jun 22, 2017 – Jun 23, 2017 Staging

Share & tools

Jaya Durga

author

2017-06-22 10:17 UTC #0 lore raw

PATCH 2/2 Staging: rtl8712 : os_intfs.c: use octal

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.Consider using octal permissions '0644'.

Signed-off-by Jaya Durga <[email protected]>

--6

---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/rtl8712/os_intfs.c +1 -1

index 8836b31..e698f6e 100644
@@ -93,7 +93,7 @@
  */
 static int wifi_test;
 
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
 module_param(wifi_test, int, 0644);
 module_param(initmac, charp, 0644);
 module_param(video_mode, int, 0644);

--
1.9.1

Greg KH

maintainer

2017-06-23 20:24 UTC #1 lore raw

Quoted 5 lines · Jaya Durga

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.Consider using octal permissions '0644'.
Signed-off-by Jaya Durga <[email protected]>
--6

What is this last line for? Please fix up and resend.

thanks,

greg k-h