bonding: Fix some issues for fail_over_mac
Subsystems (2)
v3 cover bonding: Fix some issues for fail_over_mac
The parameter fail_over_mac only affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.
v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so I add mode checking together with fail_over_mac during enslavement and rebuild the patches.
v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing to check the mode in addition to fail_over_mac when setting a slave's MAC during enslavement. The change active slave processing already only calls the fail_over_mac function when in active-backup mode.
Remove the cleanup patch because the net-next is frozen now.
Regards
Ding
Ding Tianhong (2):
bonding: bonding: fail_over_mac should only affect AB mode at
enslave and removal processing
bonding: fail_over_mac should only affect AB mode in
bond_set_mac_address()
drivers/net/bonding/bond_main.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.0
David Miller
maintainerFrom: Ding Tianhong <[email protected]>
Date: Sat, 25 Jan 2014 12:58:35 +0800
Quoted 10 lines
The parameter
fail_over_maconly affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.
v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so I add mode checking together withfail_over_macduring enslavement and rebuild the patches.
Quoted 7 lines
v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing to check the mode in addition tofail_over_macwhen setting a slave's MAC during enslavement. The change active slave processing already only calls thefail_over_macfunction when in active-backup mode.Remove the cleanup patch because the net-next is frozen now.
This series has been rotting in patchwork for a week, and desperately needs someone to review it.
Quoted 16 lines · Ding Tianhong
The parameter
fail_over_maconly affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.
v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so I add mode checking together withfail_over_macduring enslavement and rebuild the patches.
v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing to check the mode in addition tofail_over_macwhen setting a slave's MAC during enslavement. The change active slave processing already only calls thefail_over_macfunction when in active-backup mode.
Quoted 4 lines
Remove the cleanup patch because the net-next is frozen now.
Regards
Ding
Both patches look good to me.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [email protected]
David Miller
maintainerFrom: Jay Vosburgh <[email protected]>
Date: Tue, 04 Feb 2014 12:00:31 -0800
Quoted 18 lines
Quoted 16 lines · Ding Tianhong
The parameter
fail_over_maconly affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.
v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so I add mode checking together withfail_over_macduring enslavement and rebuild the patches.
v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing to check the mode in addition tofail_over_macwhen setting a slave's MAC during enslavement. The change active slave processing already only calls thefail_over_macfunction when in active-backup mode.
Quoted 8 lines
Quoted 4 lines
Remove the cleanup patch because the net-next is frozen now.
Regards
DingBoth patches look good to me.
Signed-off-by Jay Vosburgh <[email protected]>
Series applied, thanks.