YCBCR 4:2:0 handling in i915 layer
Subsystems (2)
v5 cover YCBCR 4:2:0 handling in i915 layer
This patch series is a subset of series "YCBCR 4:2:0 handling in DRM layer" Published and reviewed here: https://patchwork.freedesktop.org/series/26973/
The original series had 14 patches, out of which first 8 (which were in DRM layer) are reviewed merged. These 6 patches are the I915 layer handling of YCBCR 4:2:0 output.
V4: Addressed review comments from Ville.
V5: Addressed review comments from Imre.
Shashank Sharma (6):
drm/i915: add config function for YCBCR420 outputs drm/i915: prepare scaler for YCBCR420 modeset drm/i915: prepare pipe for YCBCR420 output drm/i915: prepare csc unit for YCBCR420 output drm/i915: set colorspace for YCBCR420 outputs drm/i915/glk: set HDMI 2.0 identifier
drivers/gpu/drm/i915/i915_reg.h | 3 ++ drivers/gpu/drm/i915/intel_color.c | 45 ++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_ddi.c | 3 ++ drivers/gpu/drm/i915/intel_display.c | 28 ++++++++++++++++ drivers/gpu/drm/i915/intel_drv.h | 3 ++ drivers/gpu/drm/i915/intel_hdmi.c | 64 ++++++++++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_panel.c | 3 +- 7 files changed, 144 insertions(+), 5 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 1/6 drm/i915: add config function for YCBCR420 outputs
This patch checks encoder level support for YCBCR420 outputs. The logic goes as simple as this:
If the input mode is YCBCR420-only mode: prepare HDMI for YCBCR420 output, else continue with RGB output mode.
It checks if the mode is YCBCR420 and source can support this output then it marks the ycbcr_420 output indicator into crtc state, for further staging in driver.
V2: Split the patch into two, kept helper functions in DRM layer.
V3: Changed the compute_config function based on new DRM API.
V4: Rebase
V5: Rebase
V6: Check and handle YCBCR420-only modes, discard the property
based approach (Ville)
V7: Addressed review comments from Ville
- add else case in 12BPC check.
- extract ycbcr420 state inside hdmi_12bpc_possible function.
V8: Addressed review comments from Ville
- Remove extra blank lines.
- Remove "HDMI" from the description of ycbcr420 state variable.
- Remove local variable, use crtc_state->ycbcr420 instead. Added r-b from Ville.
V9: Rebase
V10: Added r-b from Imre
--- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 40 +++++++++++++++++++++++++++++++++--- 3 files changed, 41 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -0
@@ -11299,6 +11299,7 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,PIPE_CONF_CHECK_I (hdmi_scrambling);PIPE_CONF_CHECK_I (hdmi_high_tmds_clock_ratio);PIPE_CONF_CHECK_I (has_infoframe); +PIPE_CONF_CHECK_I (ycbcr420);PIPE_CONF_CHECK_I (has_audio);
drivers/gpu/drm/i915/intel_drv.h +3 -0
@@ -780,6 +780,9 @@ struct intel_crtc_state {/* HDMI High TMDS char rate ratio */ bool hdmi_high_tmds_clock_ratio; + +/* output format is YCBCR 4:2:0 */ +bool ycbcr420; };struct intel_crtc {
drivers/gpu/drm/i915/intel_hdmi.c +37 -3
@@ -1330,8 +1330,15 @@ static bool hdmi_12bpc_possible(struct intel_crtc_state *crtc_state)if (connector_state->crtc != crtc_state->base.crtc)continue ; -if ((info->edid_hdmi_dc_modes &DRM_EDID_HDMI_DC_36 ) ==0 ) -return false; +if (crtc_state->ycbcr420) { +const struct drm_hdmi_info *hdmi = &info->hdmi; + +if (!(hdmi->y420_dc_modes &DRM_EDID_YCBCR420_DC_36 )) +return false; + }else { +if (!(info->edid_hdmi_dc_modes &DRM_EDID_HDMI_DC_36 )) +return false; + } }/* Display Wa #1139 */
@@ -1342,6 +1349,24 @@ static bool hdmi_12bpc_possible(struct intel_crtc_state *crtc_state)return true; } +static bool +intel_hdmi_ycbcr420_config (struct drm_connector *connector, +struct intel_crtc_state *config, +int *clock_12bpc,int *clock_8bpc) +{ +if (!connector->ycbcr_420_allowed) { +DRM_ERROR ("Platform doesn't support YCBCR420 output\n" ); +return false; + } + +/* YCBCR420 TMDS rate requirement is half the pixel clock */ + config->port_clock /=2 ; + *clock_12bpc /=2 ; + *clock_8bpc /=2 ; + config->ycbcr420 = true; +return true; +} +bool intel_hdmi_compute_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config,struct drm_connector_state *conn_state)
@@ -1349,7 +1374,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,struct intel_hdmi *intel_hdmi =enc_to_intel_hdmi (&encoder->base);struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode; -struct drm_scdc *scdc = &conn_state->connector->display_info.hdmi.scdc; +struct drm_connector *connector = conn_state->connector; +struct drm_scdc *scdc = &connector->display_info.hdmi.scdc;struct intel_digital_connector_state *intel_conn_state =to_intel_digital_connector_state (conn_state);int clock_8bpc = pipe_config->base.adjusted_mode.crtc_clock;
@@ -1379,6 +1405,14 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, clock_12bpc *=2 ; } +if (drm_mode_is_420_only (&connector->display_info, adjusted_mode)) { +if (!intel_hdmi_ycbcr420_config (connector, pipe_config, + &clock_12bpc, &clock_8bpc)) { +DRM_ERROR ("Can't support YCBCR420 output\n" ); +return false; + } + } +if (HAS_PCH_SPLIT (dev_priv) && !HAS_DDI (dev_priv)) pipe_config->has_pch_encoder = true;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 2/6 drm/i915: prepare scaler for YCBCR420 modeset
In reply to Shashank SharmaTo get a YCBCR420 output from intel platforms, we need one scaler to scale down YCBCR444 samples to YCBCR420 samples.
This patch:
- Does scaler allocation for HDMI ycbcr420 outputs.
- Programs PIPE_MISC register for ycbcr420 output.
V2: rebase
V3: rebase
V4: rebase
V5: addressed review comments from Ander:
- No need to check both scaler_user && hdmi_output. Check for scaler_user is enough.
V6: rebase
V7: Do not create a new scaler user, use existing pipe scaler user.
V8: rebase
V9: Addressed review comments from Ville:
- Remove leftover comment for HDMI scaler user.
- Remove unnecessary blank line.
- Make scaler alocation failure a DEBUG log instead of ERROR. Added r-b from Ville
V10: Update commit message as per latest code (Imre)
Added r-b from Imre
--- drivers/gpu/drm/i915/intel_display.c | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 12 ++++++++++++ drivers/gpu/drm/i915/intel_panel.c | 3 ++- 3 files changed, 17 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +3 -0
@@ -4586,6 +4586,9 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,*/ need_scaling = src_w != dst_w || src_h != dst_h; +if (crtc_state->ycbcr420 && scaler_user ==SKL_CRTC_INDEX ) + need_scaling = true; +/* * Scaling/fitting not supported in IF-ID mode in GEN9+ * TODO: Interlace fetch mode doesn't support YUV420 planar formats.
drivers/gpu/drm/i915/intel_hdmi.c +12 -0
@@ -1354,6 +1354,8 @@ intel_hdmi_ycbcr420_config(struct drm_connector *connector,struct intel_crtc_state *config, int *clock_12bpc, int *clock_8bpc) { + struct intel_crtc *intel_crtc = to_intel_crtc(config->base.crtc); +if (!connector->ycbcr_420_allowed) {DRM_ERROR ("Platform doesn't support YCBCR420 output\n" );return false;
@@ -1364,6 +1366,16 @@ intel_hdmi_ycbcr420_config(struct drm_connector *connector, *clock_12bpc /=2 ; *clock_8bpc /=2 ; config->ycbcr420 = true; + +/* YCBCR 420 output conversion needs a scaler */ +if (skl_update_scaler_crtc (config)) { +DRM_DEBUG_KMS ("Scaler allocation for output failed\n" ); +return false; + } + +intel_pch_panel_fitting (intel_crtc, config, +DRM_MODE_SCALE_FULLSCREEN ); +return true; }
drivers/gpu/drm/i915/intel_panel.c +2 -1
@@ -110,7 +110,8 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,/* Native modes don't need fitting */ if (adjusted_mode->crtc_hdisplay == pipe_config->pipe_src_w && - adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h) + adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h && + !pipe_config->ycbcr420) goto done;switch (fitting_mode) {
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 3/6 drm/i915: prepare pipe for YCBCR420 output
In reply to Shashank SharmaTo get HDMI YCBCR420 output, the PIPEMISC register should be programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in full blend mode to use the scaler in 5x3 ratio (bits 26 and 27)
This patch:
- Adds definition of these bits.
- Programs PIPEMISC for YCBCR420 outputs.
- Adds readouts to compare HW and SW states.
V2: rebase
V3: rebase
V4: rebase
V5: added r-b from Ander
V6: Handle only YCBCR420 outputs (ville)
V7: rebase
V8: Addressed review comments from Ville
- Add readouts for state->ycbcr420 and 420 pixel_clock.
- Handle warning due to mismatch in clock for ycbcr420 clock.
- Rename PIPEMISC macros to match the Bspec.
- Add a debug print stating if YCBCR 4:2:0 output enabled. Added r-b from Ville
V9: Addressed review comments from Imre:
- Add 420 mode clock adjustment in intel_hdmi_mode_valid to prevent 420_only modes getting rejected for high clock.
- Add port clock adjustment for ycbcr420 modes in ddi_get_clock
- Rename macros as per Ville's suggestion.
- Remove unnecessary wl changes.
V10: Added r-b from Imre
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 4 files changed, 23 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -5227,6 +5227,9 @@ enum {#define _PIPE_MISC_A 0x70030#define _PIPE_MISC_B 0x71030 +#define PIPEMISC_YUV420_ENABLE (1<<27) +#define PIPEMISC_YUV420_MODE_FULL_BLEND (1<<26) +#define PIPEMISC_OUTPUT_COLORSPACE_YUV (1<<11)#define PIPEMISC_DITHER_BPC_MASK (7<<5)#define PIPEMISC_DITHER_8_BPC (0<<5)#define PIPEMISC_DITHER_10_BPC (1<<5)
drivers/gpu/drm/i915/intel_ddi.c +3 -0
@@ -1174,6 +1174,9 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)else dotclock = pipe_config->port_clock; +if (pipe_config->ycbcr420) + dotclock = pipe_config->port_clock /2 ; +if (pipe_config->pixel_multiplier) dotclock /= pipe_config->pixel_multiplier;
drivers/gpu/drm/i915/intel_display.c +14 -0
@@ -8034,6 +8034,7 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->dev);struct intel_crtc *intel_crtc =to_intel_crtc (crtc); +struct intel_crtc_state *config = intel_crtc->config;if (IS_BROADWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=9 ) {u32 val =0 ;
@@ -8059,6 +8060,12 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc)if (intel_crtc->config->dither) val |=PIPEMISC_DITHER_ENABLE |PIPEMISC_DITHER_TYPE_SP ; +if (config->ycbcr420) { + val |=PIPEMISC_OUTPUT_COLORSPACE_YUV | +PIPEMISC_YUV420_ENABLE | +PIPEMISC_YUV420_MODE_FULL_BLEND ; + } +I915_WRITE (PIPEMISC (intel_crtc->pipe), val); } }
@@ -9128,6 +9135,10 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->scaler_state.scaler_users &= ~(1 <<SKL_CRTC_INDEX ); } +if (IS_GEMINILAKE (dev_priv)) + pipe_config->ycbcr420 =I915_READ (PIPEMISC (crtc->pipe)) & +PIPEMISC_YUV420_ENABLE ; + power_domain =POWER_DOMAIN_PIPE_PANEL_FITTER (crtc->pipe);if (intel_display_power_get_if_enabled (dev_priv, power_domain)) { power_domain_mask |=BIT_ULL (power_domain);
@@ -10731,6 +10742,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->fdi_lanes, &pipe_config->fdi_m_n); +if (pipe_config->ycbcr420) +DRM_DEBUG_KMS ("YCbCr 4:2:0 output enabled\n" ); +if (intel_crtc_has_dp_encoder (pipe_config)) {intel_dump_m_n_config (pipe_config,"dp m_n" , pipe_config->lane_count, &pipe_config->dp_m_n);
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -1295,6 +1295,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLCLK ) clock *=2 ; +if (drm_mode_is_420_only (&connector->display_info, mode)) + clock /=2 ; +/* check if we can do 8bpc */ status =hdmi_port_clock_valid (hdmi, clock, true, force_dvi);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v5 3/6] drm/i915: prepare pipe for YCBCR420 output
Quoted 66 lines · Shashank Sharma
To get HDMI YCBCR420 output, the PIPEMISC register should be programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in full blend mode to use the scaler in 5x3 ratio (bits 26 and 27)This patch:
- Adds definition of these bits.
- Programs PIPEMISC for YCBCR420 outputs.
- Adds readouts to compare HW and SW states.V2: rebase
V3: rebase
V4: rebase
V5: added r-b from Ander
V6: Handle only YCBCR420 outputs (ville)
V7: rebase
V8: Addressed review comments from Ville
- Add readouts forstate->ycbcr420and 420pixel_clock.
- Handle warning due to mismatch in clock for ycbcr420 clock.
- Rename PIPEMISC macros to match the Bspec.
- Add a debug print stating if YCBCR 4:2:0 output enabled. Added r-b from Ville
V9: Addressed review comments from Imre:
- Add 420 mode clock adjustment inintel_hdmi_mode_validto prevent 420_only modes getting rejected for high clock.
- Add port clock adjustment for ycbcr420 modes inddi_get_clock
- Rename macros as per Ville's suggestion.
- Remove unnecessary wl changes.
V10: Added r-b from ImreCc Ville Syrjala <[email protected]>Cc Ander Conselvan de Oliveira <[email protected]>Cc Daniel Vetter <[email protected]>Cc Imre Deak <[email protected]>Reviewed-by Ander Conselvan de Oliveira <[email protected]>Reviewed-by Ville Syrjala <[email protected]>Reviewed-by Imre Deak <[email protected]>Signed-off-by Shashank Sharma <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 4 files changed, 23 insertions(+)drivers/gpu/drm/i915/i915_reg.h +3
-0@@ -5227,6 +5227,9 @@ enum {#define _PIPE_MISC_A 0x70030#define _PIPE_MISC_B 0x71030 +#define PIPEMISC_YUV420_ENABLE (1<<27) +#define PIPEMISC_YUV420_MODE_FULL_BLEND (1<<26) +#define PIPEMISC_OUTPUT_COLORSPACE_YUV (1<<11)#define PIPEMISC_DITHER_BPC_MASK (7<<5)#define PIPEMISC_DITHER_8_BPC (0<<5)#define PIPEMISC_DITHER_10_BPC (1<<5)drivers/gpu/drm/i915/intel_ddi.c +0
-0
drivers/gpu/drm/i915/intel_ddi.c static void ddi_dotclock_get(struct intel_crtc_state *pipe_config) · line 1178
Quoted 5 lines
drivers/gpu/drm/i915/intel_ddi.c +2
-0@@ -1174,6 +1174,9 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)else dotclock = pipe_config->port_clock; +if (pipe_config->ycbcr420) + dotclock = pipe_config->port_clock /2 ;
I see, it's Friday afternoon, so who cares about some statecheck WARNs in dmesg?;) It's '* 2'. Moreover it'd be incorrect for YUV420 12bpc, so just
dotclock *= 2;
Quoted 30 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+if (pipe_config->pixel_multiplier) dotclock /= pipe_config->pixel_multiplier;drivers/gpu/drm/i915/intel_display.c +7
-0@@ -8034,6 +8034,7 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->dev);struct intel_crtc *intel_crtc =to_intel_crtc (crtc); +struct intel_crtc_state *config = intel_crtc->config;if (IS_BROADWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=9 ) {u32 val =0 ;@@ -8059,6 +8060,12 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc)if (intel_crtc->config->dither) val |=PIPEMISC_DITHER_ENABLE |PIPEMISC_DITHER_TYPE_SP ; +if (config->ycbcr420) { + val |=PIPEMISC_OUTPUT_COLORSPACE_YUV | +PIPEMISC_YUV420_ENABLE | +PIPEMISC_YUV420_MODE_FULL_BLEND ; + } +I915_WRITE (PIPEMISC (intel_crtc->pipe), val); } }
drivers/gpu/drm/i915/intel_display.c static bool haswell_get_pipe_config(struct intel_crtc *crtc, · line 9140
Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +3
-0@@ -9128,6 +9135,10 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->scaler_state.scaler_users &= ~(1 <<SKL_CRTC_INDEX ); } +if (IS_GEMINILAKE (dev_priv)) + pipe_config->ycbcr420 =I915_READ (PIPEMISC (crtc->pipe)) & +PIPEMISC_YUV420_ENABLE ;
You missed my last comments about this part (it was a separate email from the rest of my comments).
Quoted 31 lines
drivers/gpu/drm/i915/intel_display.c +4
-0+ power_domain =POWER_DOMAIN_PIPE_PANEL_FITTER (crtc->pipe);if (intel_display_power_get_if_enabled (dev_priv, power_domain)) { power_domain_mask |=BIT_ULL (power_domain);@@ -10731,6 +10742,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->fdi_lanes, &pipe_config->fdi_m_n); +if (pipe_config->ycbcr420) +DRM_DEBUG_KMS ("YCbCr 4:2:0 output enabled\n" ); +if (intel_crtc_has_dp_encoder (pipe_config)) {intel_dump_m_n_config (pipe_config,"dp m_n" , pipe_config->lane_count, &pipe_config->dp_m_n);drivers/gpu/drm/i915/intel_hdmi.c +3
-0@@ -1295,6 +1295,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLCLK ) clock *=2 ; +if (drm_mode_is_420_only (&connector->display_info, mode)) + clock /=2 ; +/* check if we can do 8bpc */ status =hdmi_port_clock_valid (hdmi, clock, true, force_dvi);Signature · 1 line
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v5 3/6] drm/i915: prepare pipe for YCBCR420 output
Regards
Shashank
Quoted 70 lines · Imre Deak
Quoted 69 lines · Shashank Sharma
To get HDMI YCBCR420 output, the PIPEMISC register should be programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in full blend mode to use the scaler in 5x3 ratio (bits 26 and 27)This patch:
- Adds definition of these bits.
- Programs PIPEMISC for YCBCR420 outputs.
- Adds readouts to compare HW and SW states.V2: rebase
V3: rebase
V4: rebase
V5: added r-b from Ander
V6: Handle only YCBCR420 outputs (ville)
V7: rebase
V8: Addressed review comments from Ville
- Add readouts forstate->ycbcr420and 420pixel_clock.
- Handle warning due to mismatch in clock for ycbcr420 clock.
- Rename PIPEMISC macros to match the Bspec.
- Add a debug print stating if YCBCR 4:2:0 output enabled. Added r-b from Ville
V9: Addressed review comments from Imre:
- Add 420 mode clock adjustment inintel_hdmi_mode_validto prevent 420_only modes getting rejected for high clock.
- Add port clock adjustment for ycbcr420 modes inddi_get_clock
- Rename macros as per Ville's suggestion.
- Remove unnecessary wl changes.
V10: Added r-b from ImreCc Ville Syrjala <[email protected]>Cc Ander Conselvan de Oliveira <[email protected]>Cc Daniel Vetter <[email protected]>Cc Imre Deak <[email protected]>Reviewed-by Ander Conselvan de Oliveira <[email protected]>Reviewed-by Ville Syrjala <[email protected]>Reviewed-by Imre Deak <[email protected]>Signed-off-by Shashank Sharma <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 4 files changed, 23 insertions(+)drivers/gpu/drm/i915/i915_reg.h +3
-0@@ -5227,6 +5227,9 @@ enum {#define _PIPE_MISC_A 0x70030#define _PIPE_MISC_B 0x71030 +#define PIPEMISC_YUV420_ENABLE (1<<27) +#define PIPEMISC_YUV420_MODE_FULL_BLEND (1<<26) +#define PIPEMISC_OUTPUT_COLORSPACE_YUV (1<<11)#define PIPEMISC_DITHER_BPC_MASK (7<<5)#define PIPEMISC_DITHER_8_BPC (0<<5)#define PIPEMISC_DITHER_10_BPC (1<<5)drivers/gpu/drm/i915/intel_ddi.c +0
-0@@ -1174,6 +1174,9 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)else dotclock = pipe_config->port_clock;
Quoted 7 lines
drivers/gpu/drm/i915/intel_ddi.c static void ddi_dotclock_get(struct intel_crtc_state *pipe_config) · line 1178
Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +2
-0+if (pipe_config->ycbcr420) + dotclock = pipe_config->port_clock /2 ;I see, it's Friday afternoon, so who cares about some statecheck WARNs in dmesg?;) It's '* 2'. Moreover it'd be incorrect for YUV420 12bpc, so just
dotclock *= 2;
Embarrassing, let me too blame it to Friday evening ;-), but I seriously looked for warnings in dmesg. Let me check it on Monday, why dint I get it in dmesg and come back !
Quoted 33 lines
Quoted 33 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+if (pipe_config->pixel_multiplier) dotclock /= pipe_config->pixel_multiplier;drivers/gpu/drm/i915/intel_display.c +7
-0@@ -8034,6 +8034,7 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->dev);struct intel_crtc *intel_crtc =to_intel_crtc (crtc); +struct intel_crtc_state *config = intel_crtc->config;if (IS_BROADWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=9 ) {u32 val =0 ;@@ -8059,6 +8060,12 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc)if (intel_crtc->config->dither) val |=PIPEMISC_DITHER_ENABLE |PIPEMISC_DITHER_TYPE_SP ; +if (config->ycbcr420) { + val |=PIPEMISC_OUTPUT_COLORSPACE_YUV | +PIPEMISC_YUV420_ENABLE | +PIPEMISC_YUV420_MODE_FULL_BLEND ; + } +I915_WRITE (PIPEMISC (intel_crtc->pipe), val); } }@@ -9128,6 +9135,10 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->scaler_state.scaler_users &= ~(1 <<SKL_CRTC_INDEX ); }
Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c static bool haswell_get_pipe_config(struct intel_crtc *crtc, · line 9140
Quoted 3 lines
drivers/gpu/drm/i915/intel_display.c +3
-0+if (IS_GEMINILAKE (dev_priv)) + pipe_config->ycbcr420 =I915_READ (PIPEMISC (crtc->pipe)) & +PIPEMISC_YUV420_ENABLE ;You missed my last comments about this part (it was a separate email from the rest of my comments).
Yes, sorry about that, will get it done !
- Shashank
Quoted 29 lines
Quoted 29 lines
drivers/gpu/drm/i915/intel_display.c +4
-0+ power_domain =POWER_DOMAIN_PIPE_PANEL_FITTER (crtc->pipe);if (intel_display_power_get_if_enabled (dev_priv, power_domain)) { power_domain_mask |=BIT_ULL (power_domain);@@ -10731,6 +10742,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->fdi_lanes, &pipe_config->fdi_m_n); +if (pipe_config->ycbcr420) +DRM_DEBUG_KMS ("YCbCr 4:2:0 output enabled\n" ); +if (intel_crtc_has_dp_encoder (pipe_config)) {intel_dump_m_n_config (pipe_config,"dp m_n" , pipe_config->lane_count, &pipe_config->dp_m_n);drivers/gpu/drm/i915/intel_hdmi.c +3
-0@@ -1295,6 +1295,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLCLK ) clock *=2 ; +if (drm_mode_is_420_only (&connector->display_info, mode)) + clock /=2 ; +/* check if we can do 8bpc */ status =hdmi_port_clock_valid (hdmi, clock, true, force_dvi);
Quoted 3 lines
Quoted 3 lines
Signature · 1 line
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 3/6 drm/i915: prepare pipe for YCBCR420 output
In reply to Imre DeakTo get HDMI YCBCR420 output, the PIPEMISC register should be programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in full blend mode to use the scaler in 5x3 ratio (bits 26 and 27)
This patch:
- Adds definition of these bits.
- Programs PIPEMISC for YCBCR420 outputs.
- Adds readouts to compare HW and SW states.
V2: rebase
V3: rebase
V4: rebase
V5: added r-b from Ander
V6: Handle only YCBCR420 outputs (ville)
V7: rebase
V8: Addressed review comments from Ville
- Add readouts for state->ycbcr420 and 420 pixel_clock.
- Handle warning due to mismatch in clock for ycbcr420 clock.
- Rename PIPEMISC macros to match the Bspec.
- Add a debug print stating if YCBCR 4:2:0 output enabled. Added r-b from Ville
V9: Addressed review comments from Imre:
- Add 420 mode clock adjustment in intel_hdmi_mode_valid to prevent 420_only modes getting rejected for high clock.
- Add port clock adjustment for ycbcr420 modes in ddi_get_clock
- Rename macros as per Ville's suggestion.
- Remove unnecessary wl changes.
V10: Added r-b from Imre
V11: Fixed faulty dotclock handling, and addressed missing comment
from previous set of review comments (Imre)
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 4 files changed, 34 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -5227,6 +5227,9 @@ enum {#define _PIPE_MISC_A 0x70030#define _PIPE_MISC_B 0x71030 +#define PIPEMISC_YUV420_ENABLE (1<<27) +#define PIPEMISC_YUV420_MODE_FULL_BLEND (1<<26) +#define PIPEMISC_OUTPUT_COLORSPACE_YUV (1<<11)#define PIPEMISC_DITHER_BPC_MASK (7<<5)#define PIPEMISC_DITHER_8_BPC (0<<5)#define PIPEMISC_DITHER_10_BPC (1<<5)
drivers/gpu/drm/i915/intel_ddi.c +3 -0
@@ -1174,6 +1174,9 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)else dotclock = pipe_config->port_clock; +if (pipe_config->ycbcr420) + dotclock = pipe_config->port_clock *2 ; +if (pipe_config->pixel_multiplier) dotclock /= pipe_config->pixel_multiplier;
drivers/gpu/drm/i915/intel_display.c +25 -0
@@ -8034,6 +8034,7 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->dev);struct intel_crtc *intel_crtc =to_intel_crtc (crtc); +struct intel_crtc_state *config = intel_crtc->config;if (IS_BROADWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=9 ) {u32 val =0 ;
@@ -8059,6 +8060,12 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc)if (intel_crtc->config->dither) val |=PIPEMISC_DITHER_ENABLE |PIPEMISC_DITHER_TYPE_SP ; +if (config->ycbcr420) { + val |=PIPEMISC_OUTPUT_COLORSPACE_YUV | +PIPEMISC_YUV420_ENABLE | +PIPEMISC_YUV420_MODE_FULL_BLEND ; + } +I915_WRITE (PIPEMISC (intel_crtc->pipe), val); } }
@@ -9128,6 +9135,21 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->scaler_state.scaler_users &= ~(1 <<SKL_CRTC_INDEX ); } +if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +u32 tmp =I915_READ (PIPEMISC (crtc->pipe)); +bool clrspace_yuv = tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV ; +bool blend_mode_420 = tmp &PIPEMISC_YUV420_MODE_FULL_BLEND ; + +if (IS_GEMINILAKE (dev_priv) || dev_priv->info.gen >=10 ) { + pipe_config->ycbcr420 = tmp &PIPEMISC_YUV420_ENABLE ; +if (pipe_config->ycbcr420 != clrspace_yuv || + pipe_config->ycbcr420 != blend_mode_420) +DRM_DEBUG_KMS ("Bad 4:2:0 mode (%08x)\n" , tmp); + }else if (clrspace_yuv || blend_mode_420) { +DRM_DEBUG_KMS ("YCbCr 4:2:0 Unsupported\n" ); + } + } + power_domain =POWER_DOMAIN_PIPE_PANEL_FITTER (crtc->pipe);if (intel_display_power_get_if_enabled (dev_priv, power_domain)) { power_domain_mask |=BIT_ULL (power_domain);
@@ -10731,6 +10753,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->fdi_lanes, &pipe_config->fdi_m_n); +if (pipe_config->ycbcr420) +DRM_DEBUG_KMS ("YCbCr 4:2:0 output enabled\n" ); +if (intel_crtc_has_dp_encoder (pipe_config)) {intel_dump_m_n_config (pipe_config,"dp m_n" , pipe_config->lane_count, &pipe_config->dp_m_n);
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -1295,6 +1295,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLCLK ) clock *=2 ; +if (drm_mode_is_420_only (&connector->display_info, mode)) + clock /=2 ; +/* check if we can do 8bpc */ status =hdmi_port_clock_valid (hdmi, clock, true, force_dvi);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v6 3/6] drm/i915: prepare pipe for YCBCR420 output
Quoted 68 lines · Shashank Sharma
To get HDMI YCBCR420 output, the PIPEMISC register should be programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in full blend mode to use the scaler in 5x3 ratio (bits 26 and 27)This patch:
- Adds definition of these bits.
- Programs PIPEMISC for YCBCR420 outputs.
- Adds readouts to compare HW and SW states.V2: rebase
V3: rebase
V4: rebase
V5: added r-b from Ander
V6: Handle only YCBCR420 outputs (ville)
V7: rebase
V8: Addressed review comments from Ville
- Add readouts forstate->ycbcr420and 420pixel_clock.
- Handle warning due to mismatch in clock for ycbcr420 clock.
- Rename PIPEMISC macros to match the Bspec.
- Add a debug print stating if YCBCR 4:2:0 output enabled. Added r-b from Ville
V9: Addressed review comments from Imre:
- Add 420 mode clock adjustment inintel_hdmi_mode_validto prevent 420_only modes getting rejected for high clock.
- Add port clock adjustment for ycbcr420 modes inddi_get_clock
- Rename macros as per Ville's suggestion.
- Remove unnecessary wl changes.
V10: Added r-b from Imre
V11: Fixed faulty dotclock handling, and addressed missing comment
from previous set of review comments (Imre)Cc Ville Syrjala <[email protected]>Cc Ander Conselvan de Oliveira <[email protected]>Cc Daniel Vetter <[email protected]>Cc Imre Deak <[email protected]>Reviewed-by Ander Conselvan de Oliveira <[email protected]>Reviewed-by Ville Syrjala <[email protected]>Reviewed-by Imre Deak <[email protected]>Signed-off-by Shashank Sharma <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 4 files changed, 34 insertions(+)drivers/gpu/drm/i915/i915_reg.h +3
-0@@ -5227,6 +5227,9 @@ enum {#define _PIPE_MISC_A 0x70030#define _PIPE_MISC_B 0x71030 +#define PIPEMISC_YUV420_ENABLE (1<<27) +#define PIPEMISC_YUV420_MODE_FULL_BLEND (1<<26) +#define PIPEMISC_OUTPUT_COLORSPACE_YUV (1<<11)#define PIPEMISC_DITHER_BPC_MASK (7<<5)#define PIPEMISC_DITHER_8_BPC (0<<5)#define PIPEMISC_DITHER_10_BPC (1<<5)drivers/gpu/drm/i915/intel_ddi.c +0
-0
drivers/gpu/drm/i915/intel_ddi.c static void ddi_dotclock_get(struct intel_crtc_state *pipe_config) · line 1178
Quoted 5 lines
drivers/gpu/drm/i915/intel_ddi.c +2
-0@@ -1174,6 +1174,9 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)else dotclock = pipe_config->port_clock; +if (pipe_config->ycbcr420) + dotclock = pipe_config->port_clock *2 ;
This is still incorrect for 12bpc. So:
if (pipe_config->ycbcr420)
dotclock *= 2;
Quoted 30 lines
drivers/gpu/drm/i915/intel_ddi.c +1
-0+if (pipe_config->pixel_multiplier) dotclock /= pipe_config->pixel_multiplier;drivers/gpu/drm/i915/intel_display.c +7
-0@@ -8034,6 +8034,7 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->dev);struct intel_crtc *intel_crtc =to_intel_crtc (crtc); +struct intel_crtc_state *config = intel_crtc->config;if (IS_BROADWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=9 ) {u32 val =0 ;@@ -8059,6 +8060,12 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc)if (intel_crtc->config->dither) val |=PIPEMISC_DITHER_ENABLE |PIPEMISC_DITHER_TYPE_SP ; +if (config->ycbcr420) { + val |=PIPEMISC_OUTPUT_COLORSPACE_YUV | +PIPEMISC_YUV420_ENABLE | +PIPEMISC_YUV420_MODE_FULL_BLEND ; + } +I915_WRITE (PIPEMISC (intel_crtc->pipe), val); } }
drivers/gpu/drm/i915/intel_display.c static bool haswell_get_pipe_config(struct intel_crtc *crtc, · line 9141
Quoted 7 lines
drivers/gpu/drm/i915/intel_display.c +4
-0@@ -9128,6 +9135,21 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->scaler_state.scaler_users &= ~(1 <<SKL_CRTC_INDEX ); } +if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +u32 tmp =I915_READ (PIPEMISC (crtc->pipe)); +bool clrspace_yuv = tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV ; +bool blend_mode_420 = tmp &PIPEMISC_YUV420_MODE_FULL_BLEND ;
The YUV420 blend mode flag is only defined for GLK and GEN >= 10, so it must be checked only on those platforms.
Quoted 41 lines
drivers/gpu/drm/i915/intel_display.c +14
-0+ +if (IS_GEMINILAKE (dev_priv) || dev_priv->info.gen >=10 ) { + pipe_config->ycbcr420 = tmp &PIPEMISC_YUV420_ENABLE ; +if (pipe_config->ycbcr420 != clrspace_yuv || + pipe_config->ycbcr420 != blend_mode_420) +DRM_DEBUG_KMS ("Bad 4:2:0 mode (%08x)\n" , tmp); + }else if (clrspace_yuv || blend_mode_420) { +DRM_DEBUG_KMS ("YCbCr 4:2:0 Unsupported\n" ); + } + } + power_domain =POWER_DOMAIN_PIPE_PANEL_FITTER (crtc->pipe);if (intel_display_power_get_if_enabled (dev_priv, power_domain)) { power_domain_mask |=BIT_ULL (power_domain);@@ -10731,6 +10753,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->fdi_lanes, &pipe_config->fdi_m_n); +if (pipe_config->ycbcr420) +DRM_DEBUG_KMS ("YCbCr 4:2:0 output enabled\n" ); +if (intel_crtc_has_dp_encoder (pipe_config)) {intel_dump_m_n_config (pipe_config,"dp m_n" , pipe_config->lane_count, &pipe_config->dp_m_n);drivers/gpu/drm/i915/intel_hdmi.c +3
-0@@ -1295,6 +1295,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLCLK ) clock *=2 ; +if (drm_mode_is_420_only (&connector->display_info, mode)) + clock /=2 ; +/* check if we can do 8bpc */ status =hdmi_port_clock_valid (hdmi, clock, true, force_dvi);Signature · 1 line
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v7 3/6 drm/i915: prepare pipe for YCBCR420 output
To get HDMI YCBCR420 output, the PIPEMISC register should be programmed to:
- Generate YCBCR output (bit 11)
- In case of YCBCR420 outputs, it should be programmed in full blend mode to use the scaler in 5x3 ratio (bits 26 and 27)
This patch:
- Adds definition of these bits.
- Programs PIPEMISC for YCBCR420 outputs.
- Adds readouts to compare HW and SW states.
V2: rebase
V3: rebase
V4: rebase
V5: added r-b from Ander
V6: Handle only YCBCR420 outputs (ville)
V7: rebase
V8: Addressed review comments from Ville
- Add readouts for state->ycbcr420 and 420 pixel_clock.
- Handle warning due to mismatch in clock for ycbcr420 clock.
- Rename PIPEMISC macros to match the Bspec.
- Add a debug print stating if YCBCR 4:2:0 output enabled. Added r-b from Ville
V9: Addressed review comments from Imre:
- Add 420 mode clock adjustment in intel_hdmi_mode_valid to prevent 420_only modes getting rejected for high clock.
- Add port clock adjustment for ycbcr420 modes in ddi_get_clock
- Rename macros as per Ville's suggestion.
- Remove unnecessary wl changes.
V10: Added r-b from Imre
V11: Fixed faulty dotclock handling, and addressed missing comment
from previous set of review comments (Imre)
V12: Fixed dotclock for 12bpc too, removed 420 check for GEN < 10
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 27 +++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 4 files changed, 36 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -5227,6 +5227,9 @@ enum {#define _PIPE_MISC_A 0x70030#define _PIPE_MISC_B 0x71030 +#define PIPEMISC_YUV420_ENABLE (1<<27) +#define PIPEMISC_YUV420_MODE_FULL_BLEND (1<<26) +#define PIPEMISC_OUTPUT_COLORSPACE_YUV (1<<11)#define PIPEMISC_DITHER_BPC_MASK (7<<5)#define PIPEMISC_DITHER_8_BPC (0<<5)#define PIPEMISC_DITHER_10_BPC (1<<5)
drivers/gpu/drm/i915/intel_ddi.c +3 -0
@@ -1174,6 +1174,9 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)else dotclock = pipe_config->port_clock; +if (pipe_config->ycbcr420) + dotclock *=2 ; +if (pipe_config->pixel_multiplier) dotclock /= pipe_config->pixel_multiplier;
drivers/gpu/drm/i915/intel_display.c +27 -0
@@ -7933,6 +7933,7 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->dev);struct intel_crtc *intel_crtc =to_intel_crtc (crtc); +struct intel_crtc_state *config = intel_crtc->config;if (IS_BROADWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=9 ) {u32 val =0 ;
@@ -7958,6 +7959,12 @@ static void haswell_set_pipemisc(struct drm_crtc *crtc)if (intel_crtc->config->dither) val |=PIPEMISC_DITHER_ENABLE |PIPEMISC_DITHER_TYPE_SP ; +if (config->ycbcr420) { + val |=PIPEMISC_OUTPUT_COLORSPACE_YUV | +PIPEMISC_YUV420_ENABLE | +PIPEMISC_YUV420_MODE_FULL_BLEND ; + } +I915_WRITE (PIPEMISC (intel_crtc->pipe), val); } }
@@ -9022,6 +9029,23 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, pipe_config->gamma_mode =I915_READ (GAMMA_MODE (crtc->pipe)) &GAMMA_MODE_MODE_MASK ; +if (IS_BROADWELL (dev_priv) || dev_priv->info.gen >=9 ) { +u32 tmp =I915_READ (PIPEMISC (crtc->pipe)); +bool clrspace_yuv = tmp &PIPEMISC_OUTPUT_COLORSPACE_YUV ; + +if (IS_GEMINILAKE (dev_priv) || dev_priv->info.gen >=10 ) { +bool blend_mode_420 = tmp & +PIPEMISC_YUV420_MODE_FULL_BLEND ; + + pipe_config->ycbcr420 = tmp &PIPEMISC_YUV420_ENABLE ; +if (pipe_config->ycbcr420 != clrspace_yuv || + pipe_config->ycbcr420 != blend_mode_420) +DRM_DEBUG_KMS ("Bad 4:2:0 mode (%08x)\n" , tmp); + }else if (clrspace_yuv) { +DRM_DEBUG_KMS ("YCbCr 4:2:0 Unsupported\n" ); + } + } + power_domain =POWER_DOMAIN_PIPE_PANEL_FITTER (crtc->pipe);if (intel_display_power_get_if_enabled (dev_priv, power_domain)) { power_domain_mask |=BIT_ULL (power_domain);
@@ -10401,6 +10425,9 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->fdi_lanes, &pipe_config->fdi_m_n); +if (pipe_config->ycbcr420) +DRM_DEBUG_KMS ("YCbCr 4:2:0 output enabled\n" ); +if (intel_crtc_has_dp_encoder (pipe_config)) {intel_dump_m_n_config (pipe_config,"dp m_n" , pipe_config->lane_count, &pipe_config->dp_m_n);
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -1295,6 +1295,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLCLK ) clock *=2 ; +if (drm_mode_is_420_only (&connector->display_info, mode)) + clock /=2 ; +/* check if we can do 8bpc */ status =hdmi_port_clock_valid (hdmi, clock, true, force_dvi);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 4/6 drm/i915: prepare csc unit for YCBCR420 output
In reply to Shashank SharmaTo support ycbcr output, we need a pipe CSC block to do RGB->YCBCR conversion.
Current Intel platforms have only one pipe CSC unit, so we can either do color correction using it, or we can perform RGB->YCBCR conversion.
This function adds a csc handler, which uses recommended bspec values to perform RGB->YCBCR conversion (target color space BT709)
V2: Rebase
V3: Rebase
V4: Rebase
V5: Addressed review comments from Ander
- Remove extra line added in the patch
- Add the spec details in the commit message
- Combine two if(cond) while calling intel_crtc_compute_config
V6: Handle YCBCR420 outputs only (Ville)
V7: Addressed review comments from Ville:
- Add description about target colorspace
- Remove the comments from CSC function
- DRM_DEBUG->DEBUG_KMS for atomic failure due to CSC unit busy
- Remove unnecessary debug message about YCBCR420 possibe
V8: Addressed review comments from Ville:
- Remove extra comment, not required.
- Do not add extra variable for CTM, reuse pipe_config Added r-b from Ville
V9: Remove extra whitespace (Imre)
V10: Added r-b from Imre
--- drivers/gpu/drm/i915/intel_color.c | 45 +++++++++++++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_display.c | 10 ++++++++ 2 files changed, 54 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_color.c +44 -1
@@ -41,6 +41,22 @@#define LEGACY_LUT_LENGTH (sizeof(struct drm_color_lut) * 256) +/* Post offset values for RGB->YCBCR conversion */ +#define POSTOFF_RGB_TO_YUV_HI 0x800 +#define POSTOFF_RGB_TO_YUV_ME 0x100 +#define POSTOFF_RGB_TO_YUV_LO 0x800 + +/* +* These values are direct register values specified in the Bspec, +* for RGB->YUV conversion matrix (colorspace BT709) +*/ +#define CSC_RGB_TO_YUV_RU_GU 0x2ba809d8 +#define CSC_RGB_TO_YUV_BU 0x37e80000 +#define CSC_RGB_TO_YUV_RY_GY 0x1e089cc0 +#define CSC_RGB_TO_YUV_BY 0xb5280000 +#define CSC_RGB_TO_YUV_RV_GV 0xbce89ad8 +#define CSC_RGB_TO_YUV_BV 0x1e080000 +/* * Extract the CSC coefficient from a CTM coefficient (in U32.32 fixed point * format). This macro takes the coefficient we want transformed and the
@@ -91,6 +107,30 @@ static void ctm_mult_by_limited(uint64_t *result, int64_t *input) } } +void i9xx_load_ycbcr_conversion_matrix (struct intel_crtc *intel_crtc) +{ +int pipe = intel_crtc->pipe; +struct drm_i915_private *dev_priv =to_i915 (intel_crtc->base.dev); + +I915_WRITE (PIPE_CSC_PREOFF_HI (pipe),0 ); +I915_WRITE (PIPE_CSC_PREOFF_ME (pipe),0 ); +I915_WRITE (PIPE_CSC_PREOFF_LO (pipe),0 ); + +I915_WRITE (PIPE_CSC_COEFF_RU_GU (pipe),CSC_RGB_TO_YUV_RU_GU ); +I915_WRITE (PIPE_CSC_COEFF_BU (pipe),CSC_RGB_TO_YUV_BU ); + +I915_WRITE (PIPE_CSC_COEFF_RY_GY (pipe),CSC_RGB_TO_YUV_RY_GY ); +I915_WRITE (PIPE_CSC_COEFF_BY (pipe),CSC_RGB_TO_YUV_BY ); + +I915_WRITE (PIPE_CSC_COEFF_RV_GV (pipe),CSC_RGB_TO_YUV_RV_GV ); +I915_WRITE (PIPE_CSC_COEFF_BV (pipe),CSC_RGB_TO_YUV_BV ); + +I915_WRITE (PIPE_CSC_POSTOFF_HI (pipe),POSTOFF_RGB_TO_YUV_HI ); +I915_WRITE (PIPE_CSC_POSTOFF_ME (pipe),POSTOFF_RGB_TO_YUV_ME ); +I915_WRITE (PIPE_CSC_POSTOFF_LO (pipe),POSTOFF_RGB_TO_YUV_LO ); +I915_WRITE (PIPE_CSC_MODE (pipe),0 ); +} +/* Set up the pipe CSC unit. */ static void i9xx_load_csc_matrix (struct drm_crtc_state *crtc_state) {
@@ -101,7 +141,10 @@ static void i9xx_load_csc_matrix(struct drm_crtc_state *crtc_state)uint16_t coeffs[9 ] = {0 , };struct intel_crtc_state *intel_crtc_state =to_intel_crtc_state (crtc_state); -if (crtc_state->ctm) { +if (intel_crtc_state->ycbcr420) { +i9xx_load_ycbcr_conversion_matrix (intel_crtc); +return ; + }else if (crtc_state->ctm) {struct drm_color_ctm *ctm = (struct drm_color_ctm *)crtc_state->ctm->data;uint64_t input[9 ] = {0 , };
drivers/gpu/drm/i915/intel_display.c +10 -0
@@ -6241,6 +6241,16 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc,return -EINVAL ; } +if (pipe_config->ycbcr420 && pipe_config->base.ctm) { +/* +* There is only one pipe CSC unit per pipe, and we need that +* for output conversion from RGB->YCBCR. So if CTM is already +* applied we can't support YCBCR420 output. +*/ +DRM_DEBUG_KMS ("YCBCR420 and CTM together are not possible\n" ); +return -EINVAL ; + } +/* * Pipe horizontal size must be even in: * - DVO ganged mode
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 5/6 drm/i915: set colorspace for YCBCR420 outputs
In reply to Shashank SharmaWhen output colorspace is YCBCR420, we have to load the corresponding colorspace in AVI infoframe. This patch fills the colorspace of AVI infoframe as per the output mode.
V2: Rebase
V3: Rebase
V4: Rebase
V5: Added r-b from Ander
V6: Checking RGB/YCBCR420 output only (Ville)
V7: Add colorspace info in driver(not drm layer) (Ville)
V8: Rebase
V9: Added r-b from Ville
V10: Added r-b from Imre
--- drivers/gpu/drm/i915/intel_hdmi.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +6 -0
@@ -472,12 +472,18 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder,return ; } +if (crtc_state->ycbcr420) + frame.avi.colorspace =HDMI_COLORSPACE_YUV420 ; +else + frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +drm_hdmi_avi_infoframe_quant_range (&frame.avi, adjusted_mode, crtc_state->limited_color_range ?HDMI_QUANTIZATION_RANGE_LIMITED :HDMI_QUANTIZATION_RANGE_FULL , intel_hdmi->rgb_quant_range_selectable); +/* TODO: handle pixel repetition for YCBCR420 outputs */ intel_write_infoframe (encoder, crtc_state, &frame); }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 6/6 drm/i915/glk: set HDMI 2.0 identifier
In reply to Shashank SharmaThis patch sets the is_hdmi2_src identifier in drm connector for GLK platform. GLK contains a native HDMI 2.0 controller. This identifier will help the EDID handling functions to save lot of work which is specific to HDMI 2.0 sources.
V3: Added this patch
V4: Rebase
V4: Rebase
V5: Added r-b from Ander
V6: Rebase
V7: Rebase
V8: Rebase
V9: Added r-b from Ville
V9: Added r-b from Imre
--- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -1917,6 +1917,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, connector->doublescan_allowed =0 ; connector->stereo_allowed =1 ; +if (IS_GEMINILAKE (dev_priv)) + connector->ycbcr_420_allowed = true; + intel_hdmi->ddc_bus =intel_hdmi_ddc_pin (dev_priv, port);switch (port) {
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for YCBCR 4:2:0 handling in i915 layer (rev2)
In reply to Shashank Sharma== Series Details ==
== Series Details ==
Series: YCBCR 4:2:0 handling in i915 layer (rev2)
URL : https://patchwork.freedesktop.org/series/27412/
State : success
== Summary ==
Series 27412v2 YCBCR 4:2:0 handling in i915 layer
https://patchwork.freedesktop.org/api/1.0/series/27412/revisions/2/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (fi-pnv-d510) fdo#101597
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-n2820) fdo#101705fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101597 https://bugs.freedesktop.org/show_bug.cgi?id=101597
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:442s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:429s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:354s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:528s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:521s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:490s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:486s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:598s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:439s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:421s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:414s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:503s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:492s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:464s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:573s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:584s fi-pnv-d510 total:279 pass:221 dwarn:3 dfail:0 fail:0 skip:55 time:560s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:464s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:588s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:476s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:437s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:477s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:543s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:404s
2a4f73050a961e1a176d35561e39386da9ea9c67 drm-tip: 2017y-07m-21d-15h-30m-47s UTC integration manifest 306bf87 drm/i915: prepare scaler for YCBCR420 modeset
1f9ce32 drm/i915: add config function for YCBCR420 outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5260/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for YCBCR 4:2:0 handling in i915 layer (rev3)
In reply to Shashank Sharma== Series Details ==
== Series Details ==
Series: YCBCR 4:2:0 handling in i915 layer (rev3)
URL : https://patchwork.freedesktop.org/series/27412/
State : success
== Summary ==
Series 27412v3 YCBCR 4:2:0 handling in i915 layer
https://patchwork.freedesktop.org/api/1.0/series/27412/revisions/3/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007 +1
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (fi-pnv-d510) fdo#101597
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-n2820) fdo#101705fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101597 https://bugs.freedesktop.org/show_bug.cgi?id=101597
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:445s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:441s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:358s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:545s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:512s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:494s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:482s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:597s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:435s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:414s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:411s fi-ivb-3520m total:279 pass:260 dwarn:0 dfail:0 fail:1 skip:18 time:506s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:477s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:466s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:578s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:588s fi-pnv-d510 total:279 pass:221 dwarn:3 dfail:0 fail:0 skip:55 time:558s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:469s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:583s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:474s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:476s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:436s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:476s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:413s
2a4f73050a961e1a176d35561e39386da9ea9c67 drm-tip: 2017y-07m-21d-15h-30m-47s UTC integration manifest 6cd2245 drm/i915: prepare scaler for YCBCR420 modeset
e7f1b4c drm/i915: add config function for YCBCR420 outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5265/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for YCBCR 4:2:0 handling in i915 layer (rev4)
In reply to Shashank Sharma== Series Details ==
== Series Details ==
Series: YCBCR 4:2:0 handling in i915 layer (rev4)
URL : https://patchwork.freedesktop.org/series/27412/
State : success
== Summary ==
Series 27412v4 YCBCR 4:2:0 handling in i915 layer
https://patchwork.freedesktop.org/api/1.0/series/27412/revisions/4/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:441s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:433s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:356s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:541s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:512s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:490s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:489s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:600s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:435s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:416s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:415s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:504s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:456s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:573s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:590s fi-pnv-d510 total:279 pass:222 dwarn:2 dfail:0 fail:0 skip:55 time:560s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:466s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:586s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:470s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:436s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:477s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:546s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:404s
2a4f73050a961e1a176d35561e39386da9ea9c67 drm-tip: 2017y-07m-21d-15h-30m-47s UTC integration manifest 9959a2f drm/i915/glk: set HDMI 2.0 identifier
c7dde1f drm/i915: set colorspace for YCBCR420 outputs
38b8b12 drm/i915: prepare csc unit for YCBCR420 output
fd738aa drm/i915: prepare pipe for YCBCR420 output
21dfa85 drm/i915: prepare scaler for YCBCR420 modeset
1493aee drm/i915: add config function for YCBCR420 outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5267/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for YCBCR 4:2:0 handling in i915 layer (rev4)
Quoted 10 lines · Patchwork
== Series Details ==
Series: YCBCR 4:2:0 handling in i915 layer (rev4)
URL : https://patchwork.freedesktop.org/series/27412/
State : success== Summary ==
Series 27412v4 YCBCR 4:2:0 handling in i915 layer
https://patchwork.freedesktop.org/api/1.0/series/27412/revisions/4/mbox/
Thanks for the patches and reviews, I pushed the patches to -dinq.
A note about commit logs for the future: you should only add your own Signed-off-by line, whoever commits it will add their own.
Quoted 41 lines
Test
gem_exec_flush:Subgroup basic-batch-kernel-default-uc: fail -> PASS (fi-snb-2600) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:441s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:433s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:356s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:541s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:512s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:490s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:489s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:600s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:435s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:416s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:415s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:504s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:456s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:573s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:590s fi-pnv-d510 total:279 pass:222 dwarn:2 dfail:0 fail:0 skip:55 time:560s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:466s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:586s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:470s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:436s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:477s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:546s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:404s
2a4f73050a961e1a176d35561e39386da9ea9c67drm-tip: 2017y-07m-21d-15h-30m-47s UTC integration manifest 9959a2f drm/i915/glk: set HDMI 2.0 identifier
c7dde1f drm/i915: set colorspace for YCBCR420 outputs
38b8b12 drm/i915: prepare csc unit for YCBCR420 output
fd738aa drm/i915: prepare pipe for YCBCR420 output
21dfa85 drm/i915: prepare scaler for YCBCR420 modeset
1493aee drm/i915: add config function for YCBCR420 outputs
Quoted 7 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5267/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for YCBCR 4:2:0 handling in i915 layer (rev4)
Quoted 9 lines · Imre Deak
Quoted 8 lines · Patchwork
== Series Details ==
Series: YCBCR 4:2:0 handling in i915 layer (rev4)
URL : https://patchwork.freedesktop.org/series/27412/
State : success== Summary ==
Quoted 7 lines
Quoted 2 lines
Series 27412v4 YCBCR 4:2:0 handling in i915 layer
https://patchwork.freedesktop.org/api/1.0/series/27412/revisions/4/mbox/Thanks for the patches and reviews, I pushed the patches to -dinq.
A note about commit logs for the future: you should only add your own Signed-off-by line, whoever commits it will add their own.
The above Signed-off-by lines for me weren't actually added by you, but dim apply-queued automatically, so the patches you sent were fine.
Sorry for the noise,
Imre
Quoted 49 lines
Quoted 42 lines
Test
gem_exec_flush:Subgroup basic-batch-kernel-default-uc: fail -> PASS (fi-snb-2600) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:441s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:433s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:356s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:541s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:512s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:490s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:489s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:600s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:435s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:416s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:415s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:504s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:456s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:573s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:590s fi-pnv-d510 total:279 pass:222 dwarn:2 dfail:0 fail:0 skip:55 time:560s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:466s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:586s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:470s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:436s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:477s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:546s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:404s
2a4f73050a961e1a176d35561e39386da9ea9c67drm-tip: 2017y-07m-21d-15h-30m-47s UTC integration manifest 9959a2f drm/i915/glk: set HDMI 2.0 identifier
c7dde1f drm/i915: set colorspace for YCBCR420 outputs
38b8b12 drm/i915: prepare csc unit for YCBCR420 output
fd738aa drm/i915: prepare pipe for YCBCR420 output
21dfa85 drm/i915: prepare scaler for YCBCR420 modeset
1493aee drm/i915: add config function for YCBCR420 outputsQuoted 7 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5267/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx