Skip to contentSkip to conversation

perf config: Simple bugfixes & refactoring

PATCH Applied Taeung Song 1 participant 1 message Sep 7, 2017

lore
Share & tools
lore
#0 lore raw

v5 cover perf config: Simple bugfixes & refactoring

Hi all,

This is simple patchset for perf-config
to fix small bugs and refactor code.

I'd appreciate some feedback on this patchset.

The code is also available at 'config/refactoring-v5' branch on

git://github.com/taeung/linux-perf.git

Thanks,
Taeung

v5:
- rebase on current acme/perf/core
- adjust commit log messages to be more proper

v4:
- rebase on current acme/perf/core
- simplify commit log messages
- remove needless two patches

v3:
- fix a bug of no checked 'ret' in the loop in cmd_config() (Arnaldo)
- modify commit log messages to be more clear (Aranaldo)
- return -1 if show_spec_config() cannot show the config
- initialize 'ret' with -1 instead of 0 for more compact code in cmd_config()
- Add a error message when perf_config_set__new() failed in cmd_config()

v2:
- there is no need to consider empty config file (Arnaldo)

Taeung Song (3):
perf config: Check not only section->from_system_config but also
item's
perf config: Once write a config file in the end, not a repeat perf config: Allow creating empty config set for config file
autogeneration

 tools/perf/builtin-config.c | 24 +++++++++++++++++-------
 tools/perf/util/config.c    |  5 +----
 2 files changed, 18 insertions(+), 11 deletions(-)
Signature · 1 line
2.7.4