Skip to contentSkip to conversation

panel: display: Add support for Mitsubishi aa070mc01 TFT panel

PATCH Superseded Lukasz Majewski 2 participants 4 messages Sep 8, 2017 – Oct 19, 2017

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 panel: display: Add support for Mitsubishi aa070mc01 TFT panel

This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).

---
 drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +35 -0
index 3d2cb8b..0c64ec6 100644
@@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
 	},
 };
 
+static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
+	.clock = 30400,
+	.hdisplay = 800,
+	.hsync_start = 800 + 0,
+	.hsync_end = 800 + 1,
+	.htotal = 800 + 0 + 1 + 160,
+	.vdisplay = 480,
+	.vsync_start = 480 + 0,
+	.vsync_end = 480 + 48 + 1,
+	.vtotal = 480 + 48 + 1 + 0,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc mitsubishi_aa070mc01 = {
+	.modes = &mitsubishi_aa070mc01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+
+	.delay = {
+		.enable = 200,
+		.unprepare = 200,
+		.disable = 400,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};
+
 static const struct drm_display_mode innolux_n116bge_mode = {
 	.clock = 76420,
 	.hdisplay = 1366,
@@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,g121x1-l03",
 		.data = &innolux_g121x1_l03,
 	}, {
+		.compatible = "mitsubishi,aa070mc01-ca1",
+		.data = &mitsubishi_aa070mc01,
+	}, {
 		.compatible = "innolux,n116bge",
 		.data = &innolux_n116bge,
 	}, {
Signature · 1 line
2.1.4
#1 lore raw
Quoted 4 lines · Lukasz Majewski

This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).

Gentle ping on this patch.....

Anyone could express their opinion?

Thanks in advance,
Łukasz

Quoted 58 lines
---
  drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
  1 file changed, 35 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +35 -0
index 3d2cb8b..0c64ec6 100644
@@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
  	},
  };
 
+static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
+	.clock = 30400,
+	.hdisplay = 800,
+	.hsync_start = 800 + 0,
+	.hsync_end = 800 + 1,
+	.htotal = 800 + 0 + 1 + 160,
+	.vdisplay = 480,
+	.vsync_start = 480 + 0,
+	.vsync_end = 480 + 48 + 1,
+	.vtotal = 480 + 48 + 1 + 0,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc mitsubishi_aa070mc01 = {
+	.modes = &mitsubishi_aa070mc01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+
+	.delay = {
+		.enable = 200,
+		.unprepare = 200,
+		.disable = 400,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};
+
  static const struct drm_display_mode innolux_n116bge_mode = {
  	.clock = 76420,
  	.hdisplay = 1366,
@@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
  		.compatible = "innolux,g121x1-l03",
  		.data = &innolux_g121x1_l03,
  	}, {
+		.compatible = "mitsubishi,aa070mc01-ca1",
+		.data = &mitsubishi_aa070mc01,
+	}, {
  		.compatible = "innolux,n116bge",
  		.data = &innolux_n116bge,
  	}, {
Signature · 9 lines
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Lukasz Majewski
Quoted 7 lines · Lukasz Majewski

This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).

---
 drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

This is missing a device tree binding.

Quoted 29 lines
drivers/gpu/drm/panel/panel-simple.c +21 -0
index 3d2cb8b..0c64ec6 100644
@@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
 	},
 };
 
+static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
+	.clock = 30400,
+	.hdisplay = 800,
+	.hsync_start = 800 + 0,
+	.hsync_end = 800 + 1,
+	.htotal = 800 + 0 + 1 + 160,
+	.vdisplay = 480,
+	.vsync_start = 480 + 0,
+	.vsync_end = 480 + 48 + 1,
+	.vtotal = 480 + 48 + 1 + 0,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc mitsubishi_aa070mc01 = {
+	.modes = &mitsubishi_aa070mc01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 152,
+		.height = 91,

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc innolux_g121x1_l03 = { · line 1174

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+	},
+
+	.delay = {
+		.enable = 200,
+		.unprepare = 200,
+		.disable = 400,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};

And this isn't sorted properly.

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 2066

Quoted 11 lines
drivers/gpu/drm/panel/panel-simple.c +4 -0
+
 static const struct drm_display_mode innolux_n116bge_mode = {
 	.clock = 76420,
 	.hdisplay = 1366,
@@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,g121x1-l03",
 		.data = &innolux_g121x1_l03,
 	}, {
+		.compatible = "mitsubishi,aa070mc01-ca1",
+		.data = &mitsubishi_aa070mc01,
+	}, {

Same here.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

HI Thierry,

Quoted 67 lines · Lukasz Majewski
Quoted 7 lines

This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).

---
 drivers/gpu/drm/panel/panel-simple.c | 35

+++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)

This is missing a device tree binding.

Quoted 29 lines
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index 3d2cb8b..0c64ec6 100644

drivers/gpu/drm/panel/panel-simple.c +21 -0
@@ -1141,6 +1141,38 @@ static const struct panel_desc
 innolux_g121x1_l03 = { },
 };
 
+static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
+	.clock = 30400,
+	.hdisplay = 800,
+	.hsync_start = 800 + 0,
+	.hsync_end = 800 + 1,
+	.htotal = 800 + 0 + 1 + 160,
+	.vdisplay = 480,
+	.vsync_start = 480 + 0,
+	.vsync_end = 480 + 48 + 1,
+	.vtotal = 480 + 48 + 1 + 0,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc mitsubishi_aa070mc01 = {
+	.modes = &mitsubishi_aa070mc01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 152,
+		.height = 91,

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc · line 1174

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+	},
+
+	.delay = {
+		.enable = 200,
+		.unprepare = 200,
+		.disable = 400,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};

And this isn't sorted properly.

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2066

Quoted 11 lines
drivers/gpu/drm/panel/panel-simple.c +4 -0
+
 static const struct drm_display_mode innolux_n116bge_mode = {
 	.clock = 76420,
 	.hdisplay = 1366,
@@ -2029,6 +2061,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,g121x1-l03",
 		.data = &innolux_g121x1_l03,
 	}, {
+		.compatible = "mitsubishi,aa070mc01-ca1",
+		.data = &mitsubishi_aa070mc01,
+	}, {

Same here.

Quoted 1 line

Thierry

I will prepare ./Documentation/device-tree description for this patch and sort those entries.

Thanks for your comments :-)

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]