ARM: dts: Add initial Pistachio i.mx6q board support.
Subsystems (3)
PATCH v3 1/1 ARM: dts: Add initial Pistachio i.mx6q board support.
From: YuanCheng Cheng <[email protected]>
Working items:
- 800MHz CPU
- 2GB of RAM (DDR3)
- 4GB of NAND FLASH
- 1T1R WiFi 2.4 GHz
- Power management support
- 1x 10/100/1000 Mbps Ethernet WAN port
- 2x USB 2.0 Host
- PCIe
- HDMI/VGA/LVDS display
- 1x UART for RS232/422/485
- 2x UART for RS232
- 1x UART for serial console
- 1x CAN bus
Specification: http://nutsboard.org/pistachio
--- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-pistachio.dts | 687 ++++++++++++++++++++++++++++++++++ 2 files changed, 688 insertions(+) create mode 100644 arch/arm/boot/dts/imx6q-pistachio.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -427,6 +427,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6q-nitrogen6_som2.dtb \ imx6q-novena.dtb \ imx6q-phytec-pbab01.dtb \ + imx6q-pistachio.dtb \ imx6q-rex-pro.dtb \ imx6q-sabreauto.dtb \ imx6q-sabrelite.dtb \
arch/arm/boot/dts/imx6q-pistachio.dts new file +687 -0
687 lines not on this page · raw message
Signature · 1 line
2.7.4
Fabio Estevam
reviewerarch/arm/boot/dts/imx6q-pistachio.dts line 655
Quoted 9 lines · Wig C
+&usdhc2 {
arch/arm/boot/dts/imx6q-pistachio.dts new file +8
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2>; + bus-width = <4>; + vmmc-supply = <&wlan_en_reg>; + no-1-8-v; + keep-power-in-suspend; + non-removable; + cap-power-off-card;
As I mentioned previously the indentation is not correct here.
You should use tab instead of spaces.
checkpatch also complains about it:
WARNING: please, no spaces at the start of a line #699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+ non-removable;$
WARNING: please, no spaces at the start of a line #700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+ cap-power-off-card;$
Review
Quoted 3 lines
+&wdog1 {
(quoted diff) +2
-0+ status = "okay"; +};
Why don't you use like this as you intended in the original patch?
&wdog1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
fsl,ext-reset-output;
status = "okay";
};PATCH v3 1/1 ARM: dts: Add initial Pistachio i.mx6q board support.
In reply to Wig Carch/arm/boot/dts/imx6q-pistachio.dts line 655
Quoted 9 lines · Wig C
+&usdhc2 {
arch/arm/boot/dts/imx6q-pistachio.dts new file +8
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2>; + bus-width = <4>; + vmmc-supply = <&wlan_en_reg>; + no-1-8-v; + keep-power-in-suspend; + non-removable; + cap-power-off-card;
As I mentioned previously the indentation is not correct here.
You should use tab instead of spaces.
checkpatch also complains about it:
WARNING: please, no spaces at the start of a line #699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+ non-removable;$
WARNING: please, no spaces at the start of a line #700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+ cap-power-off-card;$
Hello Fabio:
I will fix this on next patch, sorry I miss it.
Review
Quoted 3 lines
+&wdog1 {
(quoted diff) +2
-0+ status = "okay"; +};
Why don't you use like this as you intended in the original patch?
&wdog1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
fsl,ext-reset-output;
status = "okay";
};My original patch has never support hardware watch dog as following link:
https://www.spinics.net/lists/kernel/msg2594724.html
I used soft reset on Pistachio, sorry for cause your misunderstand, and thanks for your kindly correction.
Wig
Fabio Estevam
reviewerQuoted 5 lines · Wig C
My original patch has never support hardware watch dog as following link:
https://www.spinics.net/lists/kernel/msg2594724.htmlI used soft reset on Pistachio, sorry for cause your misunderstand, and thanks for your kindly correction.
Ok, understood. Please fix the usdhc2 indentation for v4 and it should be fine :-)