Skip to contentSkip to conversation

rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig

PATCH Superseded Anup Patel 2 participants 2 messages Sep 24, 2017 – Oct 2, 2017 Remote processor messaging (rpmsg)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Anup Patel

author
#0 lore raw

PATCH 1/1 rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig

Currently, RPMSG_VIRTIO can only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.

This patch updates RPMSG_VIRTIO kconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.

---
 drivers/rpmsg/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rpmsg/Kconfig +1 -1
index 0fe6eac..7e29b30 100644
@@ -47,7 +47,7 @@ config RPMSG_QCOM_SMD
 	  platforms.
 
 config RPMSG_VIRTIO
-	tristate
+	tristate "Virtio RPMSG bus driver"
 	select RPMSG
 	select VIRTIO
 
Signature · 1 line
2.7.4
#1 lore raw
url: https://github.com/0day-ci/linux/commits/Anup-Patel/rpmsg-Allow-RPMSG_VIRTIO-to-be-enabled-via-menuconfig-or-defconfig/20170926-121327 config: um-allyesconfig (attached as .config) compiler…

Hi Anup,

[auto build test ERROR on v4.14-rc2]
[cannot apply to rpmsg/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Anup-Patel/rpmsg-Allow-RPMSG_VIRTIO-to-be-enabled-via-menuconfig-or-defconfig/20170926-121327
config: um-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

        # save the attached .config to linux build tree
        make ARCH=um 

All errors (new ones prefixed by >>):

arch/um/drivers/vde.o: In function `vde_open_real':
(.text+0xfb1): warning: Using 'getgrnam' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/vde.o: In function `vde_open_real':
(.text+0xdfc): warning: Using 'getpwuid' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/vde.o: In function `vde_open_real':
(.text+0x1115): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/pcap.o: In function `pcap_nametoaddr':
(.text+0xe475): warning: Using 'gethostbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/pcap.o: In function `pcap_nametonetaddr':
(.text+0xe515): warning: Using 'getnetbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/pcap.o: In function `pcap_nametoproto':
(.text+0xe735): warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/pcap.o: In function `pcap_nametoport':
(.text+0xe567): warning: Using 'getservbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking drivers/auxdisplay/img-ascii-lcd.o: In function `img_ascii_lcd_probe':
drivers/auxdisplay/img-ascii-lcd.c:386: undefined reference to `devm_ioremap_resource'
drivers/rpmsg/virtio_rpmsg_bus.o: In function `rpmsg_remove':

>> include/linux/dma-mapping.h:528: undefined reference to `bad_dma_ops'

include/linux/dma-mapping.h:534: undefined reference to bad_dma_ops' drivers/rpmsg/virtio_rpmsg_bus.o: In function rpmsg_probe':
include/linux/dma-mapping.h:507: undefined reference to bad_dma_ops' include/linux/dma-mapping.h:534: undefined reference to bad_dma_ops' drivers/virtio/virtio_ring.o: In function `vring_unmap_one':
include/linux/dma-mapping.h:251: undefined reference to bad_dma_ops' drivers/virtio/virtio_ring.o:include/linux/dma-mapping.h:315: more undefined references to bad_dma_ops' follow
collect2: error: ld returned 1 exit status

vim +528 include/linux/dma-mapping.h

e1c7e324 Christoph Hellwig   2016-01-20  521  
e1c7e324 Christoph Hellwig   2016-01-20  522  static inline void dma_free_attrs(struct device *dev, size_t size,
e1c7e324 Christoph Hellwig   2016-01-20  523  				     void *cpu_addr, dma_addr_t dma_handle,
00085f1e Krzysztof Kozlowski 2016-08-03  524  				     unsigned long attrs)
e1c7e324 Christoph Hellwig   2016-01-20  525  {
5299709d Bart Van Assche     2017-01-20  526  	const struct dma_map_ops *ops = get_dma_ops(dev);
e1c7e324 Christoph Hellwig   2016-01-20  527  
e1c7e324 Christoph Hellwig   2016-01-20 @528  	BUG_ON(!ops);
e1c7e324 Christoph Hellwig   2016-01-20  529  	WARN_ON(irqs_disabled());
e1c7e324 Christoph Hellwig   2016-01-20  530  
43fc509c Vladimir Murzin     2017-07-20  531  	if (dma_release_from_dev_coherent(dev, get_order(size), cpu_addr))
e1c7e324 Christoph Hellwig   2016-01-20  532  		return;
e1c7e324 Christoph Hellwig   2016-01-20  533  
d6b7eaeb Zhen Lei            2016-03-09  534  	if (!ops->free || !cpu_addr)
e1c7e324 Christoph Hellwig   2016-01-20  535  		return;
e1c7e324 Christoph Hellwig   2016-01-20  536  
e1c7e324 Christoph Hellwig   2016-01-20  537  	debug_dma_free_coherent(dev, size, cpu_addr, dma_handle);
e1c7e324 Christoph Hellwig   2016-01-20  538  	ops->free(dev, size, cpu_addr, dma_handle, attrs);
e1c7e324 Christoph Hellwig   2016-01-20  539  }
e1c7e324 Christoph Hellwig   2016-01-20  540  

:::::: The code at line 528 was first introduced by commit
:::::: e1c7e324539ada3b2b13ca2898bcb4948a9ef9db dma-mapping: always provide the dma_map_ops based implementation

:::::: TO: Christoph Hellwig <[email protected]>
:::::: CC: Linus Torvalds <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation