rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig
PATCH v2 1/1 rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig
Currently, RPMSG_VIRTIO can only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.
This patch updates RPMSG_VIRTIO kconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.
---
Changes since v1:
- Add depends on HAS_DMA to avoid build failures on archs (such as um) with NO_DMA=y. For most archs, HAS_DMA=y so having depends on HAS_DMA is fine.
drivers/rpmsg/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/rpmsg/Kconfig +2 -1
@@ -47,7 +47,8 @@ config RPMSG_QCOM_SMD platforms. config RPMSG_VIRTIO - tristate + tristate "Virtio RPMSG bus driver" + depends on HAS_DMA select RPMSG select VIRTIO
Signature · 1 line
2.7.4
Quoted 10 lines · Anup Patel
Currently,
RPMSG_VIRTIOcan only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.This patch updates
RPMSG_VIRTIOkconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.Signed-off-by Anup Patel <[email protected]>---
This part looks good (and really I think this is the right thing to do). But turning RPMSG_VIRTIO into a user selectable item makes it invalid to "select RPMSG_VIRTIO" from drivers/remoteproc/Kconfig.
Can you please as part of this change remove those selects and as a separate patch add CONFIG_RPMSG_VIRTIO=m to arch/arm/configs/multi_v7_defconfig?
Thanks,
Bjorn
Quoted 26 lines
Changes since v1:
- Add depends onHAS_DMAto avoid build failures on archs (such as um) with NO_DMA=y. For most archs, HAS_DMA=y so having depends onHAS_DMAis fine.drivers/rpmsg/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/rpmsg/Kconfig +2
-1@@ -47,7 +47,8 @@ config RPMSG_QCOM_SMD platforms. config RPMSG_VIRTIO - tristate + tristate "Virtio RPMSG bus driver" + depends on HAS_DMA select RPMSG select VIRTIOSignature · 1 line
2.7.4
Quoted 13 lines · Bjorn Andersson
Quoted 10 lines · Anup Patel
Currently,
RPMSG_VIRTIOcan only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.This patch updates
RPMSG_VIRTIOkconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.Signed-off-by Anup Patel <[email protected]>---
Quoted 7 lines
This part looks good (and really I think this is the right thing to do). But turning
RPMSG_VIRTIOinto a user selectable item makes it invalid to "selectRPMSG_VIRTIO" fromdrivers/remoteproc/Kconfig.Can you please as part of this change remove those selects and as a separate patch add
CONFIG_RPMSG_VIRTIO=mtoarch/arm/configs/multi_v7_defconfig?
Sure, I will update the patch as-per your suggestion and also send separate patch to add CONFIG_RPMSG_VIRTIO=m in arch/arm/configs/multi_v7_defconfig.
Regards,
Anup