Skip to contentSkip to conversation

rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig

PATCH Superseded Anup Patel 2 participants 3 messages Oct 2, 2017 – Oct 5, 2017 Remote processor messaging (rpmsg)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Anup Patel

author
#0 lore raw

PATCH v2 1/1 rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig

Currently, RPMSG_VIRTIO can only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.

This patch updates RPMSG_VIRTIO kconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.

---

Changes since v1:
- Add depends on HAS_DMA to avoid build failures on archs (such as um) with NO_DMA=y. For most archs, HAS_DMA=y so having depends on HAS_DMA is fine.

 drivers/rpmsg/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/rpmsg/Kconfig +2 -1
index 0fe6eac..65a9f6b 100644
@@ -47,7 +47,8 @@ config RPMSG_QCOM_SMD
 	  platforms.
 
 config RPMSG_VIRTIO
-	tristate
+	tristate "Virtio RPMSG bus driver"
+	depends on HAS_DMA
 	select RPMSG
 	select VIRTIO
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 10 lines · Anup Patel

Currently, RPMSG_VIRTIO can only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.

This patch updates RPMSG_VIRTIO kconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.

---

This part looks good (and really I think this is the right thing to do). But turning RPMSG_VIRTIO into a user selectable item makes it invalid to "select RPMSG_VIRTIO" from drivers/remoteproc/Kconfig.

Can you please as part of this change remove those selects and as a separate patch add CONFIG_RPMSG_VIRTIO=m to arch/arm/configs/multi_v7_defconfig?

Thanks,
Bjorn

Quoted 26 lines

Changes since v1:
- Add depends on HAS_DMA to avoid build failures on archs (such as um) with NO_DMA=y. For most archs, HAS_DMA=y so having depends on HAS_DMA is fine.

 drivers/rpmsg/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/rpmsg/Kconfig +2 -1
index 0fe6eac..65a9f6b 100644
@@ -47,7 +47,8 @@ config RPMSG_QCOM_SMD
 	  platforms.
 
 config RPMSG_VIRTIO
-	tristate
+	tristate "Virtio RPMSG bus driver"
+	depends on HAS_DMA
 	select RPMSG
 	select VIRTIO
 
Signature · 1 line
2.7.4
author
#2 lore raw
Quoted 13 lines · Bjorn Andersson
Quoted 10 lines · Anup Patel

Currently, RPMSG_VIRTIO can only be enabled if some other kconfig option selects it. This does not allow it to be enabled for virtualized systems where Virtio RPMSG is available over Virtio MMIO or PCI transport.

This patch updates RPMSG_VIRTIO kconfig option so that we can enable the VirtIO RPMSG driver via menuconfig or defconfig.

---

Quoted 7 lines

This part looks good (and really I think this is the right thing to do). But turning RPMSG_VIRTIO into a user selectable item makes it invalid to "select RPMSG_VIRTIO" from drivers/remoteproc/Kconfig.

Can you please as part of this change remove those selects and as a separate patch add CONFIG_RPMSG_VIRTIO=m to arch/arm/configs/multi_v7_defconfig?

Sure, I will update the patch as-per your suggestion and also send separate patch to add CONFIG_RPMSG_VIRTIO=m in arch/arm/configs/multi_v7_defconfig.

Regards,
Anup