manpage: update mount.cifs manpage with info about default version being mounted
Subsystems (2)
PATCH v2 1/1 manpage: update mount.cifs manpage with info about default version being mounted
From: Jeff Layton <[email protected]>
--- mount.cifs.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Thanks Aurelien. I dropped Ronnie's Reviewed-by since this is a bit different. Let me know if you'd like me to add it back.
mount.cifs.rst +4 -2
@@ -517,7 +517,7 @@ prefixpath=arg vers=arg SMB protocol version. Allowed values are: - - 1.0 - The classic CIFS/SMBv1 protocol. This is the default. + - 1.0 - The classic CIFS/SMBv1 protocol. - 2.0 - The SMBv2.002 protocol. This was initially introduced in Windows Vista Service Pack 1, and Windows Server 2008. Note that the initial release version of Windows Vista spoke a slightly
@@ -529,6 +529,9 @@ vers=arg Note too that while this option governs the protocol version used, not all features of each version are available. + In kernels v4.13 and later, the client and server negotiate a version greater + than or equal to ``2.1``. In kernels prior to v4.13, the default is ``1.0``. + --verbose Print additional debugging information for the mount. Note that this parameter must be specified before the ``-o`` . For example::
@@ -857,4 +860,3 @@ Steve French The maintainer of the Linux cifs vfs and the userspace tool mount.cifs is Steve French. The Linux CIFS Mailing list is the preferred place to ask questions regarding these programs. -
Signature · 1 line
2.13.6
A message that is not in the archive (sent off-list or not yet received): 20171031160224.12523-1-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
2017-10-31 9:02 GMT-07:00 Jeff Layton <[email protected]>:
Quoted 24 lines
From: Jeff Layton <[email protected]>
Signed-off-by Jeff Layton <[email protected]>--- mount.cifs.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)Thanks Aurelien. I dropped Ronnie's Reviewed-by since this is a bit different. Let me know if you'd like me to add it back.
mount.cifs.rst +1
-1@@ -517,7 +517,7 @@ prefixpath=arg vers=arg SMB protocol version. Allowed values are: - - 1.0 - The classic CIFS/SMBv1 protocol. This is the default. + - 1.0 - The classic CIFS/SMBv1 protocol. - 2.0 - The SMBv2.002 protocol. This was initially introduced in Windows Vista Service Pack 1, and Windows Server 2008. Note that the initial release version of Windows Vista spoke a slightly
mount.cifs.rst vers=arg · line 534
Quoted 6 lines
mount.cifs.rst +3
-0@@ -529,6 +529,9 @@ vers=arg Note too that while this option governs the protocol version used, not all features of each version are available. + In kernels v4.13 and later, the client and server negotiate a version greater + than or equal to ``2.1``. In kernels prior to v4.13, the default is ``1.0``. +
The multi-dialect negotiation (version 2.1 and above) was added in v4.13.5 kernel. Should we mention the specific stable version in the doc?
--
Best regards,
Pavel Shilovsky
A message that is not in the archive (sent off-list or not yet received): CAKywueR4DpsM72EK6u=6PHRm+uD6m8vJWnmHfhYzUuYfFn1oNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 28 lines · Pavel Shilovsky
2017-10-31 9:02 GMT-07:00 Jeff Layton <[email protected]>:
Quoted 27 lines
From: Jeff Layton <[email protected]>
Signed-off-by Jeff Layton <[email protected]>--- mount.cifs.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)Thanks Aurelien. I dropped Ronnie's Reviewed-by since this is a bit different. Let me know if you'd like me to add it back.
mount.cifs.rst +1
-1@@ -517,7 +517,7 @@ prefixpath=arg vers=arg SMB protocol version. Allowed values are: - - 1.0 - The classic CIFS/SMBv1 protocol. This is the default. + - 1.0 - The classic CIFS/SMBv1 protocol. - 2.0 - The SMBv2.002 protocol. This was initially introduced in Windows Vista Service Pack 1, and Windows Server 2008. Note that the initial release version of Windows Vista spoke a slightly@@ -529,6 +529,9 @@ vers=arg Note too that while this option governs the protocol version used, not all features of each version are available.
Quoted 8 lines
mount.cifs.rst vers=arg · line 534
Quoted 3 lines
mount.cifs.rst +3
-0+ In kernels v4.13 and later, the client and server negotiate a version greater + than or equal to ``2.1``. In kernels prior to v4.13, the default is ``1.0``. +The multi-dialect negotiation (version 2.1 and above) was added in v4.13.5 kernel. Should we mention the specific stable version in the doc?
It would be very odd to make that sort of change in a stable series kernel. What patch actually flipped the default to autonegotiate?
I was assuming that it was eef914a9eb5eb83e60eb498315a491cd1edc13a1:
$ git tag --contains eef914a9eb5eb83e60eb498315a491cd1edc13a1 | grep v4.13$
v4.13git says that that commit went into v4.13. Was it a different one?
Signature · 1 line
Jeff Layton <[email protected]>
A message that is not in the archive (sent off-list or not yet received): [email protected]
2017-11-04 4:33 GMT-07:00 Jeff Layton <[email protected]>:
Quoted 41 lines · Pavel Shilovsky
Quoted 28 lines
2017-10-31 9:02 GMT-07:00 Jeff Layton <[email protected]>:
Quoted 27 lines
From: Jeff Layton <[email protected]>
Signed-off-by Jeff Layton <[email protected]>--- mount.cifs.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)Thanks Aurelien. I dropped Ronnie's Reviewed-by since this is a bit different. Let me know if you'd like me to add it back.
mount.cifs.rst +1
-1@@ -517,7 +517,7 @@ prefixpath=arg vers=arg SMB protocol version. Allowed values are: - - 1.0 - The classic CIFS/SMBv1 protocol. This is the default. + - 1.0 - The classic CIFS/SMBv1 protocol. - 2.0 - The SMBv2.002 protocol. This was initially introduced in Windows Vista Service Pack 1, and Windows Server 2008. Note that the initial release version of Windows Vista spoke a slightly@@ -529,6 +529,9 @@ vers=arg Note too that while this option governs the protocol version used, not all features of each version are available.Quoted 8 lines
mount.cifs.rst vers=arg · line 534
Quoted 3 lines
mount.cifs.rst +3
-0+ In kernels v4.13 and later, the client and server negotiate a version greater + than or equal to ``2.1``. In kernels prior to v4.13, the default is ``1.0``. +The multi-dialect negotiation (version 2.1 and above) was added in v4.13.5 kernel. Should we mention the specific stable version in the doc?
It would be very odd to make that sort of change in a stable series kernel. What patch actually flipped the default to autonegotiate?
Quoted 8 lines
I was assuming that it was
eef914a9eb5eb83e60eb498315a491cd1edc13a1:$ git tag --contains eef914a9eb5eb83e60eb498315a491cd1edc13a1 | grep v4.13$ v4.13git says that that commit went into v4.13. Was it a different one? --
Jeff Layton <[email protected]>
Yes, it was 9764c02fcbad40001fd3f63558d918e4d519bb75
(https://github.com/torvalds/linux/commit/9764c02fcbad40001fd3f63558d918e4d519bb75).
The one you mentioned changed the default from vers=1.0 to vers=3.0 which broke the existing setups against SMB 1.0 only servers. It was done with subsequent auto-negotiate patch in mind. That's why the latter patch should went to v4.13.y.
--
Best regards,
Pavel Shilovsky