ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address
From: Fabio Estevam <[email protected]>
ads7846 is connected to SPI chip select 0, so pass the unit address accordingly to fix the following build warning with W=1:
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (unit_address_vs_reg): Node /soc/aipi at 10000000/cspi at 1000e000/ads7846 has a reg or ranges property, but no unit name
--- arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts +1 -1
@@ -84,7 +84,7 @@ cs-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>; status = "okay"; - ads7846 { + ads7846 at 0 { compatible = "ti,ads7846"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_touch>;
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 2/2 ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node
From: Fabio Estevam <[email protected]>
clock node should not have a 'simple-bus' compatible string, so remove it in order to fix the following build warning with W=1:
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (simple_bus_reg): Node /clocks/osc26m missing or empty reg/ranges property
--- arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi +0 -1
@@ -23,7 +23,6 @@ clocks { #address-cells = <1>; #size-cells = <0>; - compatible = "simple-bus"; clk14745600: clock at 0 { #clock-cells = <0>;
Signature · 1 line
2.7.4
PATCH 2/2 ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node
Quoted 17 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
clock node should not have a 'simple-bus' compatible string, so remove it in order to fix the following build warning with W=1:
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (simple_bus_reg): Node /clocks/osc26m missing or empty reg/ranges propertySigned-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi | 1 - 1 file changed, 1 deletion(-)arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi +0
-0
arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi line 28
Quoted 7 lines
arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi +0
-1@@ -23,7 +23,6 @@ clocks { #address-cells = <1>; #size-cells = <0>; - compatible = "simple-bus"; clk14745600: clock at 0 { #clock-cells = <0>;
We should probably fix it in another way - put the node directly under root with a unique node name and drop unit-address.
Shawn
Shawn Guo
AppliedPATCH 1/2 ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address
In reply to Fabio EstevamQuoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
ads7846 is connected to SPI chip select 0, so pass the unit address accordingly to fix the following build warning with W=1:
arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (unit_address_vs_reg): Node /soc/aipi at 10000000/cspi at 1000e000/ads7846 has a reg or ranges property, but no unit nameSigned-off-by Fabio Estevam <[email protected]>
Applied, thanks.