ASoC: wm9712: Use empty struct initializer
Subsystems (4)
PATCH 1/2 ASoC: wm9712: Use empty struct initializer
From: Fabio Estevam <[email protected]>
{ 0 } only clears the first member of the structure.
The first member of the snd_soc_dapm_update struct is pointer, so wrting 0 to a pointer results in the following sparse warning:
sound/soc/codecs/wm9712.c:229:47: warning: Using plain integer as NULL pointer
Use the empty struct initializer that clears all the struct members and fixes the sparse warning.
--- sound/soc/codecs/wm9712.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm9712.c +1 -1
@@ -226,7 +226,7 @@ static int wm9712_hp_mixer_put(struct snd_kcontrol *kcontrol,struct soc_mixer_control *mc = (struct soc_mixer_control *)kcontrol->private_value;unsigned int mixer, mask, shift, old; -struct snd_soc_dapm_update update = {0 }; +struct snd_soc_dapm_update update = {};bool change; mixer = mc->shift >>8 ;
Signature · 1 line
2.7.4
PATCH 2/2 ASoC: tlv320aic3x: Use empty struct initializer
From: Fabio Estevam <[email protected]>
{ 0 } only clears the first member of the structure.
The first member of the snd_soc_dapm_update struct is pointer, so wrting 0 to a pointer results in the following sparse warning:
sound/soc/codecs/tlv320aic3x.c:175:47: warning: Using plain integer as NULL pointer
Use the empty struct initializer that clears all the struct members and fixes the sparse warning.
--- sound/soc/codecs/tlv320aic3x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320aic3x.c +1 -1
@@ -172,7 +172,7 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol,unsigned int mask = (1 <<fls (max)) -1 ;unsigned int invert = mc->invert;unsigned short val; -struct snd_soc_dapm_update update = {0 }; +struct snd_soc_dapm_update update = {};int connect, change; val = (ucontrol->value.integer.value[0 ] & mask);
Signature · 1 line
2.7.4
Mark Brown
maintainerApplied "ASoC: tlv320aic3x: Use empty struct initializer" to the asoc tree
The patch
ASoC: tlv320aic3x: Use empty struct initializer
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
68fb425baea14f5647743eb56dc6675fcd8d93b3Mon Sep 17 00:00:00 2001
From: Fabio Estevam <[email protected]>
Date: Tue, 13 Feb 2018 17:37:51 -0200
Subject: [PATCH] ASoC: tlv320aic3x: Use empty struct initializer
{ 0 } only clears the first member of the structure.
The first member of the snd_soc_dapm_update struct is a pointer, and writing 0 to a pointer results in the following sparse warning:
sound/soc/codecs/tlv320aic3x.c:175:47: warning: Using plain integer as NULL pointer
Use the empty struct initializer that clears all the struct members and fixes the sparse warning.
--- sound/soc/codecs/tlv320aic3x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320aic3x.c +1 -1
@@ -172,7 +172,7 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol,unsigned int mask = (1 <<fls (max)) -1 ;unsigned int invert = mc->invert;unsigned short val; -struct snd_soc_dapm_update update = {0 }; +struct snd_soc_dapm_update update = {};int connect, change; val = (ucontrol->value.integer.value[0 ] & mask);
Signature · 1 line
2.16.1
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
{ 0 } only clears the first member of the structure.
The first member of the
snd_soc_dapm_updatestruct is pointer, so wrting 0 to a pointer results in the following sparse warning:
Quoted 7 lines
sound/soc/codecs/wm9712.c:229:47: warning: Using plain integer as NULL pointerUse the empty struct initializer that clears all the struct members and fixes the sparse warning.
Signed-off-by Fabio Estevam <[email protected]>---
Thanks,
Charles
Mark Brown
maintainerApplied "ASoC: wm9712: Use empty struct initializer" to the asoc tree
In reply to Fabio EstevamThe patch
ASoC: wm9712: Use empty struct initializer
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
60edb2006030894a4e45c84b04369cb70939d695Mon Sep 17 00:00:00 2001
From: Fabio Estevam <[email protected]>
Date: Tue, 13 Feb 2018 17:37:50 -0200
Subject: [PATCH] ASoC: wm9712: Use empty struct initializer
{ 0 } only clears the first member of the structure.
The first member of the snd_soc_dapm_update struct is a pointer, and writing 0 to a pointer results in the following sparse warning:
sound/soc/codecs/wm9712.c:229:47: warning: Using plain integer as NULL pointer
Use the empty struct initializer that clears all the struct members and fixes the sparse warning.
--- sound/soc/codecs/wm9712.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm9712.c +1 -1
@@ -226,7 +226,7 @@ static int wm9712_hp_mixer_put(struct snd_kcontrol *kcontrol,struct soc_mixer_control *mc = (struct soc_mixer_control *)kcontrol->private_value;unsigned int mixer, mask, shift, old; -struct snd_soc_dapm_update update = {0 }; +struct snd_soc_dapm_update update = {};bool change; mixer = mc->shift >>8 ;
Signature · 1 line
2.16.1