Skip to contentSkip to conversation

arm: socfpga: cyclone5: Enable Macronix flash support

PATCH Superseded chin.liang.see at intel.com 4 participants 7 messages Feb 21, 2018 – Feb 22, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

---
 configs/socfpga_cyclone5_defconfig    | 1 +
 configs/socfpga_is1_defconfig         | 1 +
 configs/socfpga_sockit_defconfig      | 1 +
 configs/socfpga_socrates_defconfig    | 1 +
 configs/socfpga_sr1500_defconfig      | 1 +
 configs/socfpga_vining_fpga_defconfig | 1 +
 6 files changed, 6 insertions(+)
configs/socfpga_cyclone5_defconfig +1 -0
index 6ebd8a9..aa535c6 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_is1_defconfig +1 -0
index 08628ab..7be720a 100644
@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y
 # CONFIG_MMC is not set
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
configs/socfpga_sockit_defconfig +1 -0
index 8ebe394..6edb47f 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_socrates_defconfig +1 -0
index 9f42481..7c2428a 100644
@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHY_MICREL=y
configs/socfpga_sr1500_defconfig +1 -0
index f9ed1a3..df1ee31 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
 CONFIG_DM_ETH=y
configs/socfpga_vining_fpga_defconfig +1 -0
index 6670b9f..512d701 100644
@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
Signature · 1 line
2.2.2
#1 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

Quoted 3 lines · chin.liang.see at intel.com

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

Do these boards actually have a macronix flash ? Most of the ones I know of do not.

Quoted 83 lines
---
 configs/socfpga_cyclone5_defconfig    | 1 +
 configs/socfpga_is1_defconfig         | 1 +
 configs/socfpga_sockit_defconfig      | 1 +
 configs/socfpga_socrates_defconfig    | 1 +
 configs/socfpga_sr1500_defconfig      | 1 +
 configs/socfpga_vining_fpga_defconfig | 1 +
 6 files changed, 6 insertions(+)
configs/socfpga_cyclone5_defconfig +1 -0
index 6ebd8a9..aa535c6 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_is1_defconfig +1 -0
index 08628ab..7be720a 100644
@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y
 # CONFIG_MMC is not set
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
configs/socfpga_sockit_defconfig +1 -0
index 8ebe394..6edb47f 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_socrates_defconfig +1 -0
index 9f42481..7c2428a 100644
@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHY_MICREL=y
configs/socfpga_sr1500_defconfig +1 -0
index f9ed1a3..df1ee31 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
 CONFIG_DM_ETH=y
configs/socfpga_vining_fpga_defconfig +1 -0
index 6670b9f..512d701 100644
@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

Quoted 8 lines · Marek Vasut
Quoted 4 lines · chin.liang.see at intel.com

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

Do these boards actually have a macronix flash ? Most of the ones I know
of do not.

Good question.

Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.

Thanks
Chin Liang

Quoted 92 lines
Quoted 91 lines

---
 configs/socfpga_cyclone5_defconfig    | 1 +
 configs/socfpga_is1_defconfig         | 1 +
 configs/socfpga_sockit_defconfig      | 1 +
 configs/socfpga_socrates_defconfig    | 1 +
 configs/socfpga_sr1500_defconfig      | 1 +
 configs/socfpga_vining_fpga_defconfig | 1 +

 6 files changed, 6 insertions(+)
configs/socfpga_cyclone5_defconfig +0 -0
index 6ebd8a9..aa535c6 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y

 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set

configs/socfpga_is1_defconfig +0 -0
index 08628ab..7be720a 100644
@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y
  # CONFIG_MMC is not set

 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y

configs/socfpga_sockit_defconfig +0 -0
index 8ebe394..6edb47f 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y

 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set

configs/socfpga_socrates_defconfig +0 -0
index 9f42481..7c2428a 100644
@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y

 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHY_MICREL=y

configs/socfpga_sr1500_defconfig +0 -0
index f9ed1a3..df1ee31 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y

 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
 CONFIG_DM_ETH=y

configs/socfpga_vining_fpga_defconfig +0 -0
index 6670b9f..512d701 100644
@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y

 CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
 CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set

#3 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

Quoted 5 lines · Chin Liang
Quoted 4 lines · Marek Vasut
Quoted 3 lines · chin.liang.see at intel.com

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

Quoted 8 lines
Quoted 3 lines

Do these boards actually have a macronix flash ? Most of the ones I know
of do not.

Good question.

Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.

But at least the Socrates seems to be out of production. I don't see why we would have to change the defconfig here.

Simon

Quoted 97 lines

Thanks
Chin Liang

Quoted 81 lines
Quoted 81 lines
---
  configs/socfpga_cyclone5_defconfig    | 1 +
  configs/socfpga_is1_defconfig         | 1 +
  configs/socfpga_sockit_defconfig      | 1 +
  configs/socfpga_socrates_defconfig    | 1 +
  configs/socfpga_sr1500_defconfig      | 1 +
  configs/socfpga_vining_fpga_defconfig | 1 +
  6 files changed, 6 insertions(+)
configs/socfpga_cyclone5_defconfig +1 -0
index 6ebd8a9..aa535c6 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
  CONFIG_MMC_DW=y
  CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_SPANSION=y
  CONFIG_SPI_FLASH_STMICRO=y
  # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_is1_defconfig +1 -0
index 08628ab..7be720a 100644
@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y
  # CONFIG_MMC is not set
  CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_STMICRO=y
  CONFIG_PHY_MICREL=y
  CONFIG_PHY_MICREL_KSZ90X1=y
configs/socfpga_sockit_defconfig +1 -0
index 8ebe394..6edb47f 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
  CONFIG_MMC_DW=y
  CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_SPANSION=y
  CONFIG_SPI_FLASH_STMICRO=y
  # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_socrates_defconfig +1 -0
index 9f42481..7c2428a 100644
@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y
  CONFIG_MMC_DW=y
  CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_SPANSION=y
  CONFIG_SPI_FLASH_STMICRO=y
  CONFIG_PHY_MICREL=y
configs/socfpga_sr1500_defconfig +1 -0
index f9ed1a3..df1ee31 100644
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y
  CONFIG_MMC_DW=y
  CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_STMICRO=y
  # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
  CONFIG_DM_ETH=y
configs/socfpga_vining_fpga_defconfig +0 -0
index 6670b9f..512d701 100644
@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y
Quoted 8 lines

configs/socfpga_vining_fpga_defconfig CONFIG_LED_STATUS_CMD=y · line 75

Quoted 8 lines
configs/socfpga_vining_fpga_defconfig +1 -0
  CONFIG_DM_MMC=y
  CONFIG_MMC_DW=y
  CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_SPANSION=y
  CONFIG_SPI_FLASH_STMICRO=y
  # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#4 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

In reply to See
Quoted 10 lines · Chin Liang
Quoted 8 lines · Marek Vasut
Quoted 4 lines · chin.liang.see at intel.com

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

Do these boards actually have a macronix flash ? Most of the ones I know
of do not.

Quoted 5 lines

Good question.Â

Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.

I'm quite sure better half of those boards won't . If you want to enable the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type.

[...]

Signature · 2 lines
Best regards,
Marek Vasut
#5 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

Quoted 16 lines · Marek Vasut
Quoted 15 lines · Chin Liang
Quoted 11 lines · Marek Vasut
Quoted 5 lines · chin.liang.see at intel.com

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

Do these boards actually have a macronix flash ? Most of the ones I
know
of do not.

Good question.Â

Quoted 8 lines
Quoted 4 lines

Actually they are pin compatible and customer can replace the existing
one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.

I'm quite sure better half of those boards won't . If you want to enable
the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type.

Actually the way the code works is detecting JEDEC ID and associate it with correct flash drivers like Micron, Spansion or Macronix. Hence it would not yield any issue except slightly larger code. But I can take out sr1500 and vining if it yield a concern.

Thanks
Chin Liang

Quoted 3 lines

[...]

#6 lore raw

PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support

Quoted 21 lines · Chin Liang
Quoted 20 lines · Marek Vasut
Quoted 19 lines · Chin Liang
Quoted 11 lines · Marek Vasut
Quoted 5 lines · chin.liang.see at intel.com

From: Chin Liang See <[email protected]>

Enable Macronix flash support for Cyclone5 SoC

Do these boards actually have a macronix flash ? Most of the ones I
know
of do not.

Good question.Â

Actually they are pin compatible and customer can replace the existing
one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.

Quoted 8 lines
Quoted 4 lines

I'm quite sure better half of those boards won't . If you want to enable
the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type.

Actually the way the code works is detecting JEDEC ID and associate it with correct flash drivers like Micron, Spansion or Macronix. Hence it would not yield any issue except slightly larger code.

Which on those boards I listed is useless dead code.

Quoted 2 lines

But I can take
out sr1500 and vining if it yield a concern.

IS1 too.

Signature · 2 lines
Best regards,
Marek Vasut