arm: socfpga: cyclone5: Enable Macronix flash support
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
--- configs/socfpga_cyclone5_defconfig | 1 + configs/socfpga_is1_defconfig | 1 + configs/socfpga_sockit_defconfig | 1 + configs/socfpga_socrates_defconfig | 1 + configs/socfpga_sr1500_defconfig | 1 + configs/socfpga_vining_fpga_defconfig | 1 + 6 files changed, 6 insertions(+)
configs/socfpga_cyclone5_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_is1_defconfig +1 -0
@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y # CONFIG_MMC is not set CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y
configs/socfpga_sockit_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
configs/socfpga_socrates_defconfig +1 -0
@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=y
configs/socfpga_sr1500_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_DM_ETH=y
configs/socfpga_vining_fpga_defconfig +1 -0
@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
Signature · 1 line
2.2.2
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
Quoted 3 lines · chin.liang.see at intel.com
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
Do these boards actually have a macronix flash ? Most of the ones I know of do not.
Quoted 83 lines
Signed-off-by Chin Liang See <[email protected]>--- configs/socfpga_cyclone5_defconfig | 1 + configs/socfpga_is1_defconfig | 1 + configs/socfpga_sockit_defconfig | 1 + configs/socfpga_socrates_defconfig | 1 + configs/socfpga_sr1500_defconfig | 1 + configs/socfpga_vining_fpga_defconfig | 1 + 6 files changed, 6 insertions(+)configs/socfpga_cyclone5_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not setconfigs/socfpga_is1_defconfig +1
-0@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y # CONFIG_MMC is not set CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=yconfigs/socfpga_sockit_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not setconfigs/socfpga_socrates_defconfig +1
-0@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=yconfigs/socfpga_sr1500_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_DM_ETH=yconfigs/socfpga_vining_fpga_defconfig +1
-0@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
Signature · 2 lines
Best regards, Marek Vasut
See
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
Quoted 8 lines · Marek Vasut
Quoted 4 lines · chin.liang.see at intel.com
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
Do these boards actually have a macronix flash ? Most of the ones I know
of do not.
Good question.
Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.
Thanks
Chin Liang
Quoted 92 lines
Quoted 91 lines
Signed-off-by Chin Liang See <[email protected]>---
configs/socfpga_cyclone5_defconfig | 1 +
configs/socfpga_is1_defconfig | 1 +
configs/socfpga_sockit_defconfig | 1 +
configs/socfpga_socrates_defconfig | 1 +
configs/socfpga_sr1500_defconfig | 1 +
configs/socfpga_vining_fpga_defconfig | 1 +6 files changed, 6 insertions(+)configs/socfpga_cyclone5_defconfig +0
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=yCONFIG_MMC_DW=y
CONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_SPI_FLASH_STMICRO=y
#CONFIG_SPI_FLASH_USE_4K_SECTORSis not setconfigs/socfpga_is1_defconfig +0
-0@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y # CONFIG_MMC is not setCONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_STMICRO=y
CONFIG_PHY_MICREL=y
CONFIG_PHY_MICREL_KSZ90X1=yconfigs/socfpga_sockit_defconfig +0
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=yCONFIG_MMC_DW=y
CONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_SPI_FLASH_STMICRO=y
#CONFIG_SPI_FLASH_USE_4K_SECTORSis not setconfigs/socfpga_socrates_defconfig +0
-0@@ -54,6 +54,7 @@ CONFIG_DM_MMC=yCONFIG_MMC_DW=y
CONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_SPI_FLASH_STMICRO=y
CONFIG_PHY_MICREL=yconfigs/socfpga_sr1500_defconfig +0
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=yCONFIG_MMC_DW=y
CONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_STMICRO=y
#CONFIG_SPI_FLASH_USE_4K_SECTORSis not set
CONFIG_DM_ETH=yconfigs/socfpga_vining_fpga_defconfig +0
-0@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=yCONFIG_DM_MMC=y
CONFIG_MMC_DW=y
CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_SPI_FLASH_STMICRO=y
#CONFIG_SPI_FLASH_USE_4K_SECTORSis not set
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
Quoted 5 lines · Chin Liang
Quoted 4 lines · Marek Vasut
Quoted 3 lines · chin.liang.see at intel.com
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
Quoted 8 lines
Quoted 3 lines
Do these boards actually have a macronix flash ? Most of the ones I know
of do not.Good question.
Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.
But at least the Socrates seems to be out of production. I don't see why we would have to change the defconfig here.
Simon
Quoted 97 lines
Thanks
Chin LiangQuoted 81 lines
Quoted 81 lines
Signed-off-by Chin Liang See <[email protected]>--- configs/socfpga_cyclone5_defconfig | 1 + configs/socfpga_is1_defconfig | 1 + configs/socfpga_sockit_defconfig | 1 + configs/socfpga_socrates_defconfig | 1 + configs/socfpga_sr1500_defconfig | 1 + configs/socfpga_vining_fpga_defconfig | 1 + 6 files changed, 6 insertions(+)configs/socfpga_cyclone5_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not setconfigs/socfpga_is1_defconfig +1
-0@@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y # CONFIG_MMC is not set CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=yconfigs/socfpga_sockit_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not setconfigs/socfpga_socrates_defconfig +1
-0@@ -54,6 +54,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=yconfigs/socfpga_sr1500_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_DM_ETH=yconfigs/socfpga_vining_fpga_defconfig +0
-0@@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=yQuoted 8 lines
configs/socfpga_vining_fpga_defconfig CONFIG_LED_STATUS_CMD=y · line 75
Quoted 8 lines
configs/socfpga_vining_fpga_defconfig +1
-0CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
In reply to SeeQuoted 10 lines · Chin Liang
Quoted 8 lines · Marek Vasut
Quoted 4 lines · chin.liang.see at intel.com
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
Do these boards actually have a macronix flash ? Most of the ones I know
of do not.
Quoted 5 lines
Good question.Â
Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.
I'm quite sure better half of those boards won't . If you want to enable the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type.
[...]
Signature · 2 lines
Best regards, Marek Vasut
See
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
Quoted 16 lines · Marek Vasut
Quoted 15 lines · Chin Liang
Quoted 11 lines · Marek Vasut
Quoted 5 lines · chin.liang.see at intel.com
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
Do these boards actually have a macronix flash ? Most of the ones I
know
of do not.Good question.Â
Quoted 8 lines
Quoted 4 lines
Actually they are pin compatible and customer can replace the existing
one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.I'm quite sure better half of those boards won't . If you want to enable
the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type.
Actually the way the code works is detecting JEDEC ID and associate it with correct flash drivers like Micron, Spansion or Macronix. Hence it would not yield any issue except slightly larger code. But I can take out sr1500 and vining if it yield a concern.
Thanks
Chin Liang
Quoted 3 lines
[...]
PATCH 1/2 arm: socfpga: cyclone5: Enable Macronix flash support
Quoted 21 lines · Chin Liang
Quoted 20 lines · Marek Vasut
Quoted 19 lines · Chin Liang
Quoted 11 lines · Marek Vasut
Quoted 5 lines · chin.liang.see at intel.com
From: Chin Liang See <[email protected]>
Enable Macronix flash support for Cyclone5 SoC
Do these boards actually have a macronix flash ? Most of the ones I
know
of do not.Good question.Â
Actually they are pin compatible and customer can replace the existing
one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list.
Quoted 8 lines
Quoted 4 lines
I'm quite sure better half of those boards won't . If you want to enable
the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type.Actually the way the code works is detecting JEDEC ID and associate it with correct flash drivers like Micron, Spansion or Macronix. Hence it would not yield any issue except slightly larger code.
Which on those boards I listed is useless dead code.
Quoted 2 lines
But I can take
out sr1500 and vining if it yield a concern.
IS1 too.
Signature · 2 lines
Best regards, Marek Vasut