Add suppport for sn65dsi86 bridge chip and Innolux 2k edp panel

Hi Sandeep,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.17-rc3 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sandeep-Panda/Add-suppport-for-sn65dsi86-bridge-chip-and-Innolux-2k-edp-panel/20180430-035839
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:9: sparse: undefined identifier 'drm_edid_to_eld' drivers/gpu/drm/bridge/ti-sn65dsi86.c:400:5: sparse: symbol 'ti_sn_bridge_ref_clk_table' was not declared. Should it be static? drivers/gpu/drm/bridge/ti-sn65dsi86.c:553:6: sparse: symbol 'ti_sn_bridge_pre_enable' was not declared. Should it be static? drivers/gpu/drm/bridge/ti-sn65dsi86.c:563:6: sparse: symbol 'ti_sn_bridge_post_disable' was not declared. Should it be static? drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:24: sparse: call with no type! drivers/gpu/drm/bridge/ti-sn65dsi86.c: In function 'ti_sn_bridge_connector_get_modes':

>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:2: error: implicit declaration of function 'drm_edid_to_eld'; did you mean 'drm_edid_to_sad'? [-Werror=implicit-function-declaration]
     drm_edid_to_eld(connector, edid);
     ^~~~~~~~~~~~~~~
     drm_edid_to_sad

cc1: some warnings being treated as errors

sparse warnings: (new ones prefixed by >>)

drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:9: sparse: undefined identifier 'drm_edid_to_eld'

>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:400:5: sparse: symbol 'ti_sn_bridge_ref_clk_table' was not declared. Should it be static?
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:553:6: sparse: symbol 'ti_sn_bridge_pre_enable' was not declared. Should it be static?
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:563:6: sparse: symbol 'ti_sn_bridge_post_disable' was not declared. Should it be static?
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:24: sparse: call with no type!
   drivers/gpu/drm/bridge/ti-sn65dsi86.c: In function 'ti_sn_bridge_connector_get_modes':
   drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:2: error: implicit declaration of function 'drm_edid_to_eld'; did you mean 'drm_edid_to_sad'? [-Werror=implicit-function-declaration]
     drm_edid_to_eld(connector, edid);
     ^~~~~~~~~~~~~~~
     drm_edid_to_sad

cc1: some warnings being treated as errors

vim +173 drivers/gpu/drm/bridge/ti-sn65dsi86.c

148
149 static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector)
150 {
151 struct ti_sn_bridge *pdata = connector_to_ti_sn_bridge(connector);
152 struct drm_panel *panel = pdata->panel;
153 struct edid *edid;
154
155 if (panel) {
156 DRM_DEBUG("get mode from connected drm_panel\n");
157 pdata->num_modes = drm_panel_get_modes(panel);
158 return pdata->num_modes;
159 }
160
161 /* get from EDID */
162 if (!pdata->ddc)
163 return 0;
164
165 ti_sn_bridge_power_ctrl(pdata, true);
166 edid = drm_get_edid(connector, pdata->ddc);
167 ti_sn_bridge_power_ctrl(pdata, false);
168 if (!edid)
169 return 0;
170
171 drm_mode_connector_update_edid_property(connector, edid);
172 pdata->num_modes = drm_add_edid_modes(connector, edid);

 > 173		drm_edid_to_eld(connector, edid);

174 kfree(edid);
175
176 return pdata->num_modes;
177 }
178

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

Hi Sandeep,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.17-rc3 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sandeep-Panda/Add-suppport-for-sn65dsi86-bridge-chip-and-Innolux-2k-edp-panel/20180430-035839
base:   git://people.freedesktop.org/~airlied/linux.git drm-next

coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:711:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

From: Fengguang Wu <[email protected]>

drivers/gpu/drm/bridge/ti-sn65dsi86.c:711:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

---

 ti-sn65dsi86.c |    1 -
 1 file changed, 1 deletion(-)

@@ -708,7 +708,6 @@ MODULE_DEVICE_TABLE(of, ti_sn_bridge_mat
 static struct i2c_driver ti_sn_bridge_driver = {
 	.driver = {
 		.name = "ti_sn65dsi86",
-		.owner = THIS_MODULE,
 		.of_match_table = ti_sn_bridge_match_table,
 	},
 	.probe = ti_sn_bridge_probe,

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

Hi Sandeep,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.17-rc3 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sandeep-Panda/Add-suppport-for-sn65dsi86-bridge-chip-and-Innolux-2k-edp-panel/20180430-035839
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: openrisc-allyesconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc

All errors (new ones prefixed by >>):

drivers/gpu/drm/bridge/ti-sn65dsi86.c: In function 'ti_sn_bridge_connector_get_modes':

>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:2: error: implicit declaration of function 'drm_edid_to_eld' [-Werror=implicit-function-declaration]
     drm_edid_to_eld(connector, edid);
     ^~~~~~~~~~~~~~~

cc1: some warnings being treated as errors

vim +/drm_edid_to_eld +173 drivers/gpu/drm/bridge/ti-sn65dsi86.c

148
149 static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector)
150 {
151 struct ti_sn_bridge *pdata = connector_to_ti_sn_bridge(connector);
152 struct drm_panel *panel = pdata->panel;
153 struct edid *edid;
154
155 if (panel) {
156 DRM_DEBUG("get mode from connected drm_panel\n");
157 pdata->num_modes = drm_panel_get_modes(panel);
158 return pdata->num_modes;
159 }
160
161 /* get from EDID */
162 if (!pdata->ddc)
163 return 0;
164
165 ti_sn_bridge_power_ctrl(pdata, true);
166 edid = drm_get_edid(connector, pdata->ddc);
167 ti_sn_bridge_power_ctrl(pdata, false);
168 if (!edid)
169 return 0;
170
171 drm_mode_connector_update_edid_property(connector, edid);
172 pdata->num_modes = drm_add_edid_modes(connector, edid);

 > 173		drm_edid_to_eld(connector, edid);

174 kfree(edid);
175
176 return pdata->num_modes;
177 }
178

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno