phy: qcom: Updates for USB PHYs on SDM845
Subsystems (7)
v5 cover phy: qcom: Updates for USB PHYs on SDM845
SDM845 has two USB instances each with QUSB2 and QMP PHYs. One of the QMP PHY is USB-DP (DisplayPort) combo PHY where as other one is single lane UNI-PHY (without DP support). Changes are related to PHY configuration for electrical parameters tuning to improve eye-diagram and some fixes.
First gcc-msm8996 driver patch is dependent on following patch which is now applied by Stephen.
https://patchwork.kernel.org/patch/10375043/
Changes since v4:
- Addressed Doug's review comments to have QUSB2 PHY tuning values in header file.
- Updated msm8996-gcc patch to use BRANCH_HALT_SKIP flag added by patch - https://patchwork.kernel.org/patch/10375041/
Changes since v3:
- As per Doug's review comments added device tree parameters to handle board level differences in PHY tuning values instead of adding separate device tree bindings.
- Replace PHY version specific bindings names with SOC name as no one is going to use generic binding names.
- Update halt_check to not check for pipe clock status that allows to simplify pipe_clk handling in QMP driver.
Changes since v2:
- Use separate phy_ops for USB to not register power_on op.
- And other minor changes as per review comments from Stephen.
Changes since v1:
- Updated qusb2 compatibility name as per comment from Vivek.
Manu Gautam (7):
clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
phy: qcom-qmp: Enable pipe_clk before PHY initialization
phy: qcom-qusb2: Fix crash if nvmem cell not specified
dt-bindings: phy-qcom-qmp: Update bindings for sdm845
phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support for sdm845
dt-bindings: phy-qcom-usb2: Add support to override tuning values
phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845
.../devicetree/bindings/phy/qcom-qmp-phy.txt | 3 +- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 ++- drivers/clk/qcom/gcc-msm8996.c | 4 + drivers/phy/qualcomm/phy-qcom-qmp.c | 169 +++++++++++++++++++-- drivers/phy/qualcomm/phy-qcom-qmp.h | 5 + drivers/phy/qualcomm/phy-qcom-qusb2.c | 130 +++++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 +++++ 7 files changed, 346 insertions(+), 25 deletions(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v5 1/7 clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
The USB and PCIE pipe clocks are sourced from external clocks inside the QMP USB/PCIE PHYs. Enabling or disabling of PIPE RCG clocks is dependent on PHY initialization sequence hence update halt_check to BRANCH_HALT_SKIP for these clocks so that clock status bit is not polled when enabling or disabling the clocks. It allows to simplify PHY client driver code which is both user and source of the pipe_clk and avoid error logging related status check on clk_disable/enable.
--- drivers/clk/qcom/gcc-msm8996.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/clk/qcom/gcc-msm8996.c +4 -0
@@ -1418,6 +1418,7 @@ enum {static struct clk_branch gcc_usb3_phy_pipe_clk = { .halt_reg =0x50004 , + .halt_check =BRANCH_HALT_SKIP , .clkr = { .enable_reg =0x50004 , .enable_mask =BIT (0 ),
@@ -2472,6 +2473,7 @@ enum {static struct clk_branch gcc_pcie_0_pipe_clk = { .halt_reg =0x6b018 , + .halt_check =BRANCH_HALT_SKIP , .clkr = { .enable_reg =0x6b018 , .enable_mask =BIT (0 ),
@@ -2547,6 +2549,7 @@ enum {static struct clk_branch gcc_pcie_1_pipe_clk = { .halt_reg =0x6d018 , + .halt_check =BRANCH_HALT_SKIP , .clkr = { .enable_reg =0x6d018 , .enable_mask =BIT (0 ),
@@ -2622,6 +2625,7 @@ enum {static struct clk_branch gcc_pcie_2_pipe_clk = { .halt_reg =0x6e018 , + .halt_check =BRANCH_HALT_SKIP , .clkr = { .enable_reg =0x6e018 , .enable_mask =BIT (0 ),
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
kbuild test robot
build botRe: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
Thank you for the patch! Yet something to improve:
Hi Manu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on phy/next]
[also build test ERROR on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Manu-Gautam/phy-qcom-Updates-for-USB-PHYs-on-SDM845/20180503-163006 base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/clk//qcom/gcc-msm8996.c:1421:16: error: 'BRANCH_HALT_SKIP' undeclared here (not in a function); did you mean 'BRANCH_HALT_VOTED'?
.halt_check = BRANCH_HALT_SKIP,
^~~~~~~~~~~~~~~~
BRANCH_HALT_VOTED
vim +1421 drivers/clk//qcom/gcc-msm8996.c
1418
1419 static struct clk_branch gcc_usb3_phy_pipe_clk = {
1420 .halt_reg = 0x50004,
> 1421 .halt_check = BRANCH_HALT_SKIP,
1422 .clkr = {
1423 .enable_reg = 0x50004,
1424 .enable_mask = BIT(0),
1425 .hw.init = &(struct clk_init_data){
1426 .name = "gcc_usb3_phy_pipe_clk",
1427 .parent_names = (const char *[]){ "usb3_phy_pipe_clk_src" },
1428 .num_parents = 1,
1429 .flags = CLK_SET_RATE_PARENT,
1430 .ops = &clk_branch2_ops,
1431 },
1432 },
1433 };
1434
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
In reply to Manu GautamHi,
Quoted 9 lines · Manu Gautam
The USB and PCIE pipe clocks are sourced from external clocks inside the QMP USB/PCIE PHYs. Enabling or disabling of PIPE RCG clocks is dependent on PHY initialization sequence hence update
halt_checktoBRANCH_HALT_SKIPfor these clocks so that clock status bit is not polled when enabling or disabling the clocks. It allows to simplify PHY client driver code which is both user and source of thepipe_clkand avoid error logging related status check on clk_disable/enable.
Quoted 4 lines
Signed-off-by Manu Gautam <[email protected]>--- drivers/clk/qcom/gcc-msm8996.c | 4 ++++ 1 file changed, 4 insertions(+)
FWIW this matches my understanding of what Stephen and you agreed upon. Thus:
Re: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
In reply to Manu GautamQuoting Manu Gautam (2018-05-02 14:06:08)
Quoted 11 lines
The USB and PCIE pipe clocks are sourced from external clocks inside the QMP USB/PCIE PHYs. Enabling or disabling of PIPE RCG clocks is dependent on PHY initialization sequence hence update
halt_checktoBRANCH_HALT_SKIPfor these clocks so that clock status bit is not polled when enabling or disabling the clocks. It allows to simplify PHY client driver code which is both user and source of thepipe_clkand avoid error logging related status check on clk_disable/enable.Signed-off-by Manu Gautam <[email protected]>---
Applied to clk-next
PATCH v5 2/7 phy: qcom-qmp: Enable pipe_clk before PHY initialization
In reply to Manu GautamQMP PHY for USB/PCIE requires pipe_clk for locking of retime buffers at the pipe interface. Driver checks for PHY_STATUS without enabling pipe_clk due to which phy_init() fails with initialization timeout. Though pipe_clk is output from PHY (after PLL is programmed during initialization sequence) to GCC clock_ctl and then fed back to PHY but for PHY_STATUS register to reflect successful initialization pipe_clk from GCC must be present. Since, clock driver now ignores status_check for pipe_clk on clk_enable/disable, driver can safely enable/disable pipe_clk from phy_init/exit.
--- drivers/phy/qualcomm/phy-qcom-qmp.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp.c +8 -14
@@ -793,19 +793,6 @@ static void qcom_qmp_phy_configure(void __iomem *base, } } -static int qcom_qmp_phy_poweron (struct phy *phy) -{ -struct qmp_phy *qphy =phy_get_drvdata (phy); -struct qcom_qmp *qmp = qphy->qmp; -int ret; - - ret =clk_prepare_enable (qphy->pipe_clk); -if (ret) -dev_err (qmp->dev,"pipe_clk enable failed, err=%d\n" , ret); - -return ret; -} -static int qcom_qmp_phy_com_init (struct qcom_qmp *qmp) {const struct qmp_phy_cfg *cfg = qmp->cfg;
@@ -974,6 +961,12 @@ static int qcom_qmp_phy_init(struct phy *phy) } } + ret =clk_prepare_enable (qphy->pipe_clk); +if (ret) { +dev_err (qmp->dev,"pipe_clk enable failed err=%d\n" , ret); + goto err_clk_enable; + } +/* Tx, Rx, and PCS configurations */ qcom_qmp_phy_configure (tx, cfg->regs, cfg->tx_tbl, cfg->tx_tbl_num);/* Configuration for other LANE for USB-DP combo PHY */
@@ -1019,6 +1012,8 @@ static int qcom_qmp_phy_init(struct phy *phy)return ret; err_pcs_ready: +clk_disable_unprepare (qphy->pipe_clk); +err_clk_enable:if (cfg->has_lane_rst)reset_control_assert (qphy->lane_rst); err_lane_rst:
@@ -1283,7 +1278,6 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np)static const struct phy_ops qcom_qmp_phy_gen_ops = { .init = qcom_qmp_phy_init, .exit = qcom_qmp_phy_exit, - .power_on = qcom_qmp_phy_poweron, .set_mode = qcom_qmp_phy_set_mode, .owner =THIS_MODULE , };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v5 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization
Hi,
Quoted 12 lines · Manu Gautam
QMP PHY for USB/PCIE requires
pipe_clkfor locking of retime buffers at the pipe interface. Driver checks forPHY_STATUSwithout enablingpipe_clkdue to whichphy_init()fails with initialization timeout. Thoughpipe_clkis output from PHY (after PLL is programmed during initialization sequence) to GCCclock_ctland then fed back to PHY but forPHY_STATUSregister to reflect successful initializationpipe_clkfrom GCC must be present. Since, clock driver now ignoresstatus_checkforpipe_clkon clk_enable/disable, driver can safely enable/disablepipe_clkfrom phy_init/exit.
Quoted 4 lines
Signed-off-by Manu Gautam <[email protected]>--- drivers/phy/qualcomm/phy-qcom-qmp.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
Given the agreement with Stephen Boyd that we'll just BRANCH_HALT_SKIP for now, this all looks good to me.
PATCH v5 3/7 phy: qcom-qusb2: Fix crash if nvmem cell not specified
In reply to Manu GautamDriver currently crashes due to NULL pointer deference while updating PHY tune register if nvmem cell is NULL. Since, fused value for Tune1/2 register is optional, we'd rather bail out.
--- drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/phy/qualcomm/phy-qcom-qusb2.c +4 -0
@@ -315,6 +315,10 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy)const struct qusb2_phy_cfg *cfg = qphy->cfg;u8 *val; +/* efuse register is optional */ +if (!qphy->cell) +return ; +/* * Read efuse register having TUNE2/1 parameter's high nibble. * If efuse register shows value as 0x0, or if we fail to find
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v5 4/7 dt-bindings: phy-qcom-qmp: Update bindings for sdm845
In reply to Manu GautamUpdate compatible strings for USB3 PHYs on SDM845. One is QMPv3 DisplayPort-USB combo PHY and other one is USB UNI PHY which is single lane USB3 PHY without DP capability. While at it also remove "qcom,qmp-v3-usb3-phy" compatible string which was earlier added for sdm845 only as there wouldn't be any user of same.
--- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +2 -1
@@ -9,7 +9,8 @@ Required properties: "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074 "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996, "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, - "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy. + "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, + "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845. - reg: offset and length of register set for PHY's common serdes block.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v5 4/7] dt-bindings: phy-qcom-qmp: Update bindings for sdm845
Quoted 7 lines · Manu Gautam
Update compatible strings for USB3 PHYs on SDM845. One is QMPv3 DisplayPort-USB combo PHY and other one is USB UNI PHY which is single lane USB3 PHY without DP capability. While at it also remove "qcom,qmp-v3-usb3-phy" compatible string which was earlier added for sdm845 only as there wouldn't be any user of same.
Quoted 5 lines
Reviewed-by Douglas Anderson <[email protected]>Signed-off-by Manu Gautam <[email protected]>--- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
PATCH v5 5/7 phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support for sdm845
In reply to Manu GautamQMP V3 UNI PHY is a single lane USB3 PHY without support for DisplayPort (DP).
Main difference from DP combo QMPv3 PHY is that UNI PHY doesn't have dual RX/TX lanes and no separate DP_COM block for configuration related to type-c or DP. Also remove "qcom,qmp-v3-usb3-phy" compatible string which was earlier added for sdm845 only as there wouldn't be any user of same.
While at it, fix has_pwrdn_delay attribute for USB-DP PHY configuration and.
--- drivers/phy/qualcomm/phy-qcom-qmp.c | 147 +++++++++++++++++++++++++++++++++++- drivers/phy/qualcomm/phy-qcom-qmp.h | 5 ++ 2 files changed, 151 insertions(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-qmp.c +146 -1
@@ -490,6 +490,118 @@ enum qphy_reg_layout { QMP_PHY_INIT_CFG(QPHY_V3_PCS_RXEQTRAINING_RUN_TIME, 0x13), }; +static const struct qmp_phy_init_tbl qmp_v3_usb3_uniphy_serdes_tbl[] = { +QMP_PHY_INIT_CFG (QSERDES_V3_COM_PLL_IVCO ,0x07 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SYSCLK_EN_SEL ,0x14 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_BIAS_EN_CLKBUFLR_EN ,0x04 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_CLK_SELECT ,0x30 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SYS_CLK_CTRL ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_RESETSM_CNTRL2 ,0x08 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_CMN_CONFIG ,0x06 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SVS_MODE_CLK_SEL ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_HSCLK_SEL ,0x80 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_DEC_START_MODE0 ,0x82 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_DIV_FRAC_START1_MODE0 ,0xab ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_DIV_FRAC_START2_MODE0 ,0xea ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_DIV_FRAC_START3_MODE0 ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_CP_CTRL_MODE0 ,0x06 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_PLL_RCTRL_MODE0 ,0x16 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_PLL_CCTRL_MODE0 ,0x36 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_INTEGLOOP_GAIN1_MODE0 ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_INTEGLOOP_GAIN0_MODE0 ,0x3f ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_VCO_TUNE2_MODE0 ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_VCO_TUNE1_MODE0 ,0xc9 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_CORECLK_DIV_MODE0 ,0x0a ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_LOCK_CMP3_MODE0 ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_LOCK_CMP2_MODE0 ,0x34 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_LOCK_CMP1_MODE0 ,0x15 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_LOCK_CMP_EN ,0x04 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_CORE_CLK_EN ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_LOCK_CMP_CFG ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_VCO_TUNE_MAP ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SYSCLK_BUF_ENABLE ,0x0a ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_EN_CENTER ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_PER1 ,0x31 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_PER2 ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_ADJ_PER1 ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_ADJ_PER2 ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_STEP_SIZE1 ,0x85 ), +QMP_PHY_INIT_CFG (QSERDES_V3_COM_SSC_STEP_SIZE2 ,0x07 ), +}; + +static const struct qmp_phy_init_tbl qmp_v3_usb3_uniphy_tx_tbl[] = { +QMP_PHY_INIT_CFG (QSERDES_V3_TX_HIGHZ_DRVR_EN ,0x10 ), +QMP_PHY_INIT_CFG (QSERDES_V3_TX_RCV_DETECT_LVL_2 ,0x12 ), +QMP_PHY_INIT_CFG (QSERDES_V3_TX_LANE_MODE_1 ,0xc6 ), +QMP_PHY_INIT_CFG (QSERDES_V3_TX_RES_CODE_LANE_OFFSET_RX ,0x06 ), +QMP_PHY_INIT_CFG (QSERDES_V3_TX_RES_CODE_LANE_OFFSET_TX ,0x06 ), +}; + +static const struct qmp_phy_init_tbl qmp_v3_usb3_uniphy_rx_tbl[] = { +QMP_PHY_INIT_CFG (QSERDES_V3_RX_VGA_CAL_CNTRL2 ,0x0c ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_RX_MODE_00 ,0x50 ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_UCDR_FASTLOCK_FO_GAIN ,0x0b ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL2 ,0x0e ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL3 ,0x4e ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL4 ,0x18 ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_RX_EQ_OFFSET_ADAPTOR_CNTRL1 ,0x77 ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_RX_OFFSET_ADAPTOR_CNTRL2 ,0x80 ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_SIGDET_CNTRL ,0x03 ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_SIGDET_DEGLITCH_CNTRL ,0x1c ), +QMP_PHY_INIT_CFG (QSERDES_V3_RX_UCDR_SO_SATURATION_AND_ENABLE ,0x75 ), +}; + +static const struct qmp_phy_init_tbl qmp_v3_usb3_uniphy_pcs_tbl[] = { +/* FLL settings */ +QMP_PHY_INIT_CFG (QPHY_V3_PCS_FLL_CNTRL2 ,0x83 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_FLL_CNT_VAL_L ,0x09 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_FLL_CNT_VAL_H_TOL ,0xa2 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_FLL_MAN_CODE ,0x40 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_FLL_CNTRL1 ,0x02 ), + +/* Lock Det settings */ +QMP_PHY_INIT_CFG (QPHY_V3_PCS_LOCK_DETECT_CONFIG1 ,0xd1 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_LOCK_DETECT_CONFIG2 ,0x1f ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_LOCK_DETECT_CONFIG3 ,0x47 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_POWER_STATE_CONFIG2 ,0x1b ), + +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RX_SIGDET_LVL ,0xba ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXMGN_V0 ,0x9f ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXMGN_V1 ,0x9f ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXMGN_V2 ,0xb5 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXMGN_V3 ,0x4c ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXMGN_V4 ,0x64 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXMGN_LS ,0x6a ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M6DB_V0 ,0x15 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M3P5DB_V0 ,0x0d ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M6DB_V1 ,0x15 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M3P5DB_V1 ,0x0d ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M6DB_V2 ,0x15 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M3P5DB_V2 ,0x0d ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M6DB_V3 ,0x15 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M3P5DB_V3 ,0x1d ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M6DB_V4 ,0x15 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M3P5DB_V4 ,0x0d ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M6DB_LS ,0x15 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TXDEEMPH_M3P5DB_LS ,0x0d ), + +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RATE_SLEW_CNTRL ,0x02 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_PWRUP_RESET_DLY_TIME_AUXCLK ,0x04 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_TSYNC_RSYNC_TIME ,0x44 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_PWRUP_RESET_DLY_TIME_AUXCLK ,0x04 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RCVR_DTCT_DLY_P1U2_L ,0xe7 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RCVR_DTCT_DLY_P1U2_H ,0x03 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RCVR_DTCT_DLY_U3_L ,0x40 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RCVR_DTCT_DLY_U3_H ,0x00 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RXEQTRAINING_WAIT_TIME ,0x75 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_LFPS_TX_ECSTART_EQTLOCK ,0x86 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_RXEQTRAINING_RUN_TIME ,0x13 ), + +QMP_PHY_INIT_CFG (QPHY_V3_PCS_REFGEN_REQ_CONFIG1 ,0x21 ), +QMP_PHY_INIT_CFG (QPHY_V3_PCS_REFGEN_REQ_CONFIG2 ,0x60 ), +}; + +/* struct qmp_phy_cfg - per-PHY initialization config */ struct qmp_phy_cfg {/* phy-type - PCIE/UFS/USB */
@@ -766,6 +878,7 @@ static inline void qphy_clrbits(void __iomem *base, u32 offset, u32 val) .pwrdn_ctrl = SW_PWRDN, .mask_pcs_ready = PHYSTATUS, + .has_pwrdn_delay = true, .pwrdn_delay_min = POWER_DOWN_DELAY_US_MIN, .pwrdn_delay_max = POWER_DOWN_DELAY_US_MAX,
@@ -774,6 +887,35 @@ static inline void qphy_clrbits(void __iomem *base, u32 offset, u32 val) .rx_b_lane_offset = 0x400, }; +static const struct qmp_phy_cfg qmp_v3_usb3_uniphy_cfg = { + .type =PHY_TYPE_USB3 , + .nlanes =1 , + + .serdes_tbl = qmp_v3_usb3_uniphy_serdes_tbl, + .serdes_tbl_num =ARRAY_SIZE (qmp_v3_usb3_uniphy_serdes_tbl), + .tx_tbl = qmp_v3_usb3_uniphy_tx_tbl, + .tx_tbl_num =ARRAY_SIZE (qmp_v3_usb3_uniphy_tx_tbl), + .rx_tbl = qmp_v3_usb3_uniphy_rx_tbl, + .rx_tbl_num =ARRAY_SIZE (qmp_v3_usb3_uniphy_rx_tbl), + .pcs_tbl = qmp_v3_usb3_uniphy_pcs_tbl, + .pcs_tbl_num =ARRAY_SIZE (qmp_v3_usb3_uniphy_pcs_tbl), + .clk_list = qmp_v3_phy_clk_l, + .num_clks =ARRAY_SIZE (qmp_v3_phy_clk_l), + .reset_list = msm8996_usb3phy_reset_l, + .num_resets =ARRAY_SIZE (msm8996_usb3phy_reset_l), + .vreg_list = msm8996_phy_vreg_l, + .num_vregs =ARRAY_SIZE (msm8996_phy_vreg_l), + .regs = qmp_v3_usb3phy_regs_layout, + + .start_ctrl =SERDES_START |PCS_START , + .pwrdn_ctrl =SW_PWRDN , + .mask_pcs_ready =PHYSTATUS , + + .has_pwrdn_delay = true, + .pwrdn_delay_min =POWER_DOWN_DELAY_US_MIN , + .pwrdn_delay_max =POWER_DOWN_DELAY_US_MAX , +}; + static void qcom_qmp_phy_configure(void __iomem *base, const unsigned int *regs, const struct qmp_phy_init_tbl tbl[],
@@ -1375,8 +1517,11 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id) .compatible = "qcom,ipq8074-qmp-pcie-phy", .data = &ipq8074_pciephy_cfg, }, { - .compatible = "qcom,qmp-v3-usb3-phy", + .compatible = "qcom,sdm845-qmp-usb3-phy", .data = &qmp_v3_usb3phy_cfg, + }, { + .compatible = "qcom,sdm845-qmp-usb3-uni-phy", + .data = &qmp_v3_usb3_uniphy_cfg, }, { }, };
drivers/phy/qualcomm/phy-qcom-qmp.h +5 -0
@@ -214,6 +214,8 @@#define QSERDES_V3_RX_UCDR_FASTLOCK_FO_GAIN 0x030#define QSERDES_V3_RX_UCDR_SO_SATURATION_AND_ENABLE 0x034#define QSERDES_V3_RX_RX_TERM_BW 0x07c +#define QSERDES_V3_RX_VGA_CAL_CNTRL1 0x0bc +#define QSERDES_V3_RX_VGA_CAL_CNTRL2 0x0c0#define QSERDES_V3_RX_RX_EQ_GAIN2_LSB 0x0c8#define QSERDES_V3_RX_RX_EQ_GAIN2_MSB 0x0cc#define QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL2 0x0d4
@@ -227,6 +229,7 @@#define QSERDES_V3_RX_SIGDET_DEGLITCH_CNTRL 0x10c#define QSERDES_V3_RX_RX_BAND 0x110#define QSERDES_V3_RX_RX_INTERFACE_MODE 0x11c +#define QSERDES_V3_RX_RX_MODE_00 0x164/* Only for QMP V3 PHY - PCS registers */ #define QPHY_V3_PCS_POWER_DOWN_CONTROL 0x004
@@ -273,6 +276,8 @@#define QPHY_V3_PCS_FLL_CNT_VAL_H_TOL 0x0d0#define QPHY_V3_PCS_FLL_MAN_CODE 0x0d4#define QPHY_V3_PCS_RX_SIGDET_LVL 0x1d8 +#define QPHY_V3_PCS_REFGEN_REQ_CONFIG1 0x20c +#define QPHY_V3_PCS_REFGEN_REQ_CONFIG2 0x210/* Only for QMP V3 PHY - PCS_MISC registers */ #define QPHY_V3_PCS_MISC_CLAMP_ENABLE 0x0c
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v5 6/7 dt-bindings: phy-qcom-usb2: Add support to override tuning values
In reply to Manu GautamTo improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier added for sdm845 only.
--- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.h
Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +22 -1
@@ -6,7 +6,7 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. Required properties: - compatible: compatible list, contains "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. + "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. - reg: offset and length of the PHY register set. - #phy-cells: must be 0.
@@ -27,6 +27,27 @@ Optional properties: tuning parameter value for qusb2 phy. - qcom,tcsr-syscon: Phandle to TCSR syscon register region. + - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY + tuning parameter that may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY (sdm845). + - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX + output current. + Possible range is - 15mA to 24mA (stepsize of 600 uA). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 22.2mA for sdm845. + - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. + Possible range is 0 to 15% (stepsize of 5%). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 10% for sdm845. +- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX + pre-emphasis (specified using qcom,preemphasis-level) must be in + effect. Duration could be half-bit of full-bit. + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is full-bit width for sdm845. Example: hsusb_phy: phy@7411000 {
include/dt-bindings/phy/phy-qcom-qusb2.h new file +37 -0
@@ -0,0 +1,37 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2018, The Linux Foundation. All rights reserved. +*/ + +#ifndef _DT_BINDINGS_QCOM_PHY_QUSB2_H_ +#define _DT_BINDINGS_QCOM_PHY_QUSB2_H_ + +/* PHY HSTX TRIM bit values (24mA to 15mA) */ +#define QUSB2_V2_HSTX_TRIM_24_0_MA 0x0 +#define QUSB2_V2_HSTX_TRIM_23_4_MA 0x1 +#define QUSB2_V2_HSTX_TRIM_22_8_MA 0x2 +#define QUSB2_V2_HSTX_TRIM_22_2_MA 0x3 +#define QUSB2_V2_HSTX_TRIM_21_6_MA 0x4 +#define QUSB2_V2_HSTX_TRIM_21_0_MA 0x5 +#define QUSB2_V2_HSTX_TRIM_20_4_MA 0x6 +#define QUSB2_V2_HSTX_TRIM_19_8_MA 0x7 +#define QUSB2_V2_HSTX_TRIM_19_2_MA 0x8 +#define QUSB2_V2_HSTX_TRIM_18_6_MA 0x9 +#define QUSB2_V2_HSTX_TRIM_18_0_MA 0xa +#define QUSB2_V2_HSTX_TRIM_17_4_MA 0xb +#define QUSB2_V2_HSTX_TRIM_16_8_MA 0xc +#define QUSB2_V2_HSTX_TRIM_16_2_MA 0xd +#define QUSB2_V2_HSTX_TRIM_15_6_MA 0xe +#define QUSB2_V2_HSTX_TRIM_15_0_MA 0xf + +/* PHY PREEMPHASIS bit values */ +#define QUSB2_V2_PREEMPHASIS_NONE 0 +#define QUSB2_V2_PREEMPHASIS_5_PERCENT 1 +#define QUSB2_V2_PREEMPHASIS_10_PERCENT 2 +#define QUSB2_V2_PREEMPHASIS_15_PERCENT 3 + +/* PHY PREEMPHASIS-WIDTH bit values */ +#define QUSB2_V2_PREEMPHASIS_WIDTH_FULL_BIT 0 +#define QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT 1 + +#endif
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values
Hi,
Quoted 7 lines · Manu Gautam
To improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier added for sdm845 only.
Quoted 6 lines
Signed-off-by Manu Gautam <[email protected]>--- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.h
Thanks for adding the #defines, describing the defaults, and including which SoCs the new properties work on. This looks great to me now, thanks!
Rob Herring
maintainerRe: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values
In reply to Manu GautamQuoted 39 lines · Manu Gautam
To improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier added for sdm845 only.
Signed-off-by Manu Gautam <[email protected]>--- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.hDocumentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +9
-1@@ -6,7 +6,7 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. Required properties: - compatible: compatible list, contains "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. + "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. - reg: offset and length of the PHY register set. - #phy-cells: must be 0.@@ -27,6 +27,27 @@ Optional properties: tuning parameter value for qusb2 phy. - qcom,tcsr-syscon: Phandle to TCSR syscon register region. + - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY + tuning parameter that may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY (sdm845). + - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX + output current. + Possible range is - 15mA to 24mA (stepsize of 600 uA). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt Optional properties: · line 47
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +10
-0+ This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 22.2mA for sdm845. + - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. + Possible range is 0 to 15% (stepsize of 5%). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 10% for sdm845. +- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX + pre-emphasis (specified using qcom,preemphasis-level) must be in + effect. Duration could be half-bit of full-bit.
s/of/or/
But I'd just make this a boolean instead: qcom,preemphasis-half-bit
Quoted 3 lines
Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +3
-0+ See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is full-bit width for sdm845.
Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values
Rob,
Quoted 53 lines · Rob Herring
Quoted 39 lines · Manu Gautam
To improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier added for sdm845 only.
Signed-off-by Manu Gautam <[email protected]>--- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.hDocumentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +9
-1@@ -6,7 +6,7 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. Required properties: - compatible: compatible list, contains "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. + "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. - reg: offset and length of the PHY register set. - #phy-cells: must be 0.@@ -27,6 +27,27 @@ Optional properties: tuning parameter value for qusb2 phy. - qcom,tcsr-syscon: Phandle to TCSR syscon register region. + - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY + tuning parameter that may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY (sdm845). + - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX + output current. + Possible range is - 15mA to 24mA (stepsize of 600 uA). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt Optional properties: · line 47
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +10
-0+ This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 22.2mA for sdm845. + - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. + Possible range is 0 to 15% (stepsize of 5%). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 10% for sdm845. +- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX + pre-emphasis (specified using qcom,preemphasis-level) must be in + effect. Duration could be half-bit of full-bit.s/of/or/
Quoted 1 line
But I'd just make this a boolean instead: qcom,preemphasis-half-bit
I had this same comment in the post of v4. See
Quoted 5 lines · <https://patchwork.kernel.org/patch/10314923/>. Specifically, I said:
Perhaps just make this a boolean property. If it exists then you get the non-default case. AKA: if the default is full bit width, then you'd allow a boolean property "qcom,preemphasis-half-width" to override. If the default is half bit width then you'd allow "qcom,preemphasis-full-width" to override.
Manu replied:
Quoted 5 lines
Default property value for an SOC is specified in driver and could vary from soc to soc. Hence, from board devicetree for different SOCs we might need to select separate widths overriding default driver values. Alternative is to have two bool properties each for half and full-width. Did you actually mean that?
IMHO given Manu's argument it seems fine to specify it the way he did. Please advise if you agree or disagree.
-Doug
Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values
Quoted 76 lines · Doug Anderson
Rob,
Quoted 53 lines · Rob Herring
Quoted 39 lines · Manu Gautam
To improve eye diagram for PHYs on different boards of same SOC, some parameters may need to be changed. Provide device tree properties to override these from board specific device tree files. While at it, replace "qcom,qusb2-v2-phy" with compatible string for USB2 PHY on sdm845 which was earlier added for sdm845 only.
Signed-off-by Manu Gautam <[email protected]>--- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.hDocumentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +9
-1@@ -6,7 +6,7 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. Required properties: - compatible: compatible list, contains "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. + "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. - reg: offset and length of the PHY register set. - #phy-cells: must be 0.@@ -27,6 +27,27 @@ Optional properties: tuning parameter value for qusb2 phy. - qcom,tcsr-syscon: Phandle to TCSR syscon register region. + - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY + tuning parameter that may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY (sdm845). + - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX + output current. + Possible range is - 15mA to 24mA (stepsize of 600 uA). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt Optional properties: · line 47
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +10
-0+ This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 22.2mA for sdm845. + - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. + Possible range is 0 to 15% (stepsize of 5%). + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. + This property is applicable to only QUSB2 v2 PHY (sdm845). + Default value is 10% for sdm845. +- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX + pre-emphasis (specified using qcom,preemphasis-level) must be in + effect. Duration could be half-bit of full-bit.s/of/or/
Quoted 1 line
But I'd just make this a boolean instead: qcom,preemphasis-half-bit
I had this same comment in the post of v4. See
Quoted 5 lines · <https://patchwork.kernel.org/patch/10314923/>. Specifically, I said:
Perhaps just make this a boolean property. If it exists then you get the non-default case. AKA: if the default is full bit width, then you'd allow a boolean property "qcom,preemphasis-half-width" to override. If the default is half bit width then you'd allow "qcom,preemphasis-full-width" to override.
Manu replied:
Quoted 5 lines
Default property value for an SOC is specified in driver and could vary from soc to soc. Hence, from board devicetree for different SOCs we might need to select separate widths overriding default driver values. Alternative is to have two bool properties each for half and full-width. Did you actually mean that?
Quoted 2 lines
IMHO given Manu's argument it seems fine to specify it the way he did. Please advise if you agree or disagree.
Okay.
PATCH v5 7/7 phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845
In reply to Manu GautamThere are two QUSB2 PHYs present on sdm845. In order to improve eye diagram for both the PHYs some parameters need to be changed. Provide device tree properties to override these from board specific device tree files.
--- drivers/phy/qualcomm/phy-qcom-qusb2.c | 126 +++++++++++++++++++++++++++++++--- 1 file changed, 118 insertions(+), 8 deletions(-)
drivers/phy/qualcomm/phy-qcom-qusb2.c +118 -8
@@ -20,6 +20,8 @@#include <linux/reset.h> #include <linux/slab.h> +#include <dt-bindings/phy/phy-qcom-qusb2.h> +#define QUSB2PHY_PLL_TEST 0x04#define CLK_REF_SEL BIT(7)
@@ -60,6 +62,17 @@#define CORE_RESET BIT(5)#define CORE_RESET_MUX BIT(6) +/* QUSB2PHY_IMP_CTRL1 register bits */ +#define IMP_RES_OFFSET_MASK GENMASK(5, 0) +#define IMP_RES_OFFSET_SHIFT 0x0 + +/* QUSB2PHY_PORT_TUNE1 register bits */ +#define HSTX_TRIM_MASK GENMASK(7, 4) +#define HSTX_TRIM_SHIFT 0x4 +#define PREEMPH_WIDTH_HALF_BIT BIT(2) +#define PREEMPHASIS_EN_MASK GENMASK(1, 0) +#define PREEMPHASIS_EN_SHIFT 0x0 +#define QUSB2PHY_PLL_ANALOG_CONTROLS_TWO 0x04#define QUSB2PHY_PLL_CLOCK_INVERTERS 0x18c#define QUSB2PHY_PLL_CMODE 0x2c
@@ -139,7 +152,7 @@ enum qusb2phy_reg_layout { QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00), }; -static const unsigned int qusb2_v2_regs_layout[] = { +static const unsigned int sdm845_regs_layout[] = { [QUSB2PHY_PLL_CORE_INPUT_OVERRIDE ] =0xa8 , [QUSB2PHY_PLL_STATUS ] =0x1a0 , [QUSB2PHY_PORT_TUNE1 ] =0x240 ,
@@ -153,7 +166,7 @@ enum qusb2phy_reg_layout { [QUSB2PHY_INTR_CTRL] = 0x230, }; -static const struct qusb2_phy_init_tbl qusb2_v2_init_tbl[] = { +static const struct qusb2_phy_init_tbl sdm845_init_tbl[] = {QUSB2_PHY_INIT_CFG (QUSB2PHY_PLL_ANALOG_CONTROLS_TWO ,0x03 ),QUSB2_PHY_INIT_CFG (QUSB2PHY_PLL_CLOCK_INVERTERS ,0x7c ),QUSB2_PHY_INIT_CFG (QUSB2PHY_PLL_CMODE ,0x80 ),
@@ -208,10 +221,10 @@ struct qusb2_phy_cfg { .autoresume_en = BIT(3), }; -static const struct qusb2_phy_cfg qusb2_v2_phy_cfg = { - .tbl = qusb2_v2_init_tbl, - .tbl_num =ARRAY_SIZE (qusb2_v2_init_tbl), - .regs = qusb2_v2_regs_layout, +static const struct qusb2_phy_cfg sdm845_phy_cfg = { + .tbl = sdm845_init_tbl, + .tbl_num =ARRAY_SIZE (sdm845_init_tbl), + .regs = sdm845_regs_layout, .disable_ctrl = (PWR_CTRL1_VREF_SUPPLY_TRIM |PWR_CTRL1_CLAMP_N_EN |POWER_DOWN ),
@@ -241,6 +254,15 @@ struct qusb2_phy_cfg {* @tcsr: TCSR syscon register map * @cell: nvmem cell containing phy tuning value * +* @override_imp_res_offset: PHY should use different rescode offset +* @imp_res_offset_value: rescode offset to be updated in IMP_CTRL1 register +* @override_hstx_trim: PHY should use different HSTX o/p current value +* @hstx_trim_value: HSTX_TRIM value to be updated in TUNE1 register +* @override_preemphasis: PHY should use different pre-amphasis amplitude +* @preemphasis_level: Amplitude Pre-Emphasis to be updated in TUNE1 register +* @override_preemphasis_width: PHY should use different pre-emphasis duration +* @preemphasis_width: half/full-width Pre-Emphasis updated via TUNE1 +* * @cfg: phy config data * @has_se_clk_scheme: indicate if PHY has single-ended ref clock scheme * @phy_initialized: indicate if PHY has been initialized
@@ -259,12 +281,35 @@ struct qusb2_phy {struct regmap *tcsr;struct nvmem_cell *cell; +bool override_imp_res_offset; +u8 imp_res_offset_value; +bool override_hstx_trim; +u8 hstx_trim_value; +bool override_preemphasis; +u8 preemphasis_level; +bool override_preemphasis_width; +u8 preemphasis_width; +const struct qusb2_phy_cfg *cfg;bool has_se_clk_scheme;bool phy_initialized;enum phy_mode mode; }; +static inline void qusb2_write_mask (void __iomem *base,u32 offset, +u32 val,u32 mask) +{ +u32 reg; + + reg =readl (base + offset); + reg &= ~mask; + reg |= val & mask; +writel (reg, base + offset); + +/* Ensure above write is completed */ +readl (base + offset); +} +static inline void qusb2_setbits (void __iomem *base,u32 offset,u32 val) {u32 reg;
@@ -305,6 +350,42 @@ void qcom_qusb2_phy_configure(void __iomem *base, }/* +* Update board specific PHY tuning override values if specified from +* device tree. +*/ +static void qusb2_phy_override_phy_params (struct qusb2_phy *qphy) +{ +const struct qusb2_phy_cfg *cfg = qphy->cfg; + +if (qphy->override_imp_res_offset) +qusb2_write_mask (qphy->base,QUSB2PHY_IMP_CTRL1 , + qphy->imp_res_offset_value <<IMP_RES_OFFSET_SHIFT , +IMP_RES_OFFSET_MASK ); + +if (qphy->override_hstx_trim) +qusb2_write_mask (qphy->base, cfg->regs[QUSB2PHY_PORT_TUNE1 ], + qphy->hstx_trim_value <<HSTX_TRIM_SHIFT , +HSTX_TRIM_MASK ); + +if (qphy->override_preemphasis) +qusb2_write_mask (qphy->base, cfg->regs[QUSB2PHY_PORT_TUNE1 ], + qphy->preemphasis_level <<PREEMPHASIS_EN_SHIFT , +PREEMPHASIS_EN_MASK ); + +if (qphy->override_preemphasis_width) { +if (qphy->preemphasis_width == +QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT ) +qusb2_setbits (qphy->base, + cfg->regs[QUSB2PHY_PORT_TUNE1 ], +PREEMPH_WIDTH_HALF_BIT ); +else +qusb2_clrbits (qphy->base, + cfg->regs[QUSB2PHY_PORT_TUNE1 ], +PREEMPH_WIDTH_HALF_BIT ); + } +} + +/* * Fetches HS Tx tuning value from nvmem and sets the * QUSB2PHY_PORT_TUNE1/2 register. * For error case, skip setting the value and use the default value.
@@ -525,6 +606,9 @@ static int qusb2_phy_init(struct phy *phy)qcom_qusb2_phy_configure (qphy->base, cfg->regs, cfg->tbl, cfg->tbl_num); +/* Override board specific PHY tuning values */ +qusb2_phy_override_phy_params (qphy); +/* Set efuse value for tuning the PHY */ qusb2_phy_set_tune2_param (qphy);
@@ -647,8 +731,8 @@ static int qusb2_phy_exit(struct phy *phy) .compatible = "qcom,msm8996-qusb2-phy", .data = &msm8996_phy_cfg, }, { - .compatible = "qcom,qusb2-v2-phy", - .data = &qusb2_v2_phy_cfg, + .compatible = "qcom,sdm845-qusb2-phy", + .data = &sdm845_phy_cfg, }, { }, };
@@ -668,6 +752,7 @@ static int qusb2_phy_probe(struct platform_device *pdev)struct resource *res;int ret, i;int num; +u32 value; qphy =devm_kzalloc (dev,sizeof (*qphy),GFP_KERNEL );if (!qphy)
@@ -736,6 +821,31 @@ static int qusb2_phy_probe(struct platform_device *pdev) qphy->cell =NULL ;dev_dbg (dev,"failed to lookup tune2 hstx trim value\n" ); } + +if (!of_property_read_u32 (dev->of_node,"qcom,imp-res-offset-value" , + &value)) { + qphy->imp_res_offset_value = (u8 )value; + qphy->override_imp_res_offset = true; + } + +if (!of_property_read_u32 (dev->of_node,"qcom,hstx-trim-value" , + &value)) { + qphy->hstx_trim_value = (u8 )value; + qphy->override_hstx_trim = true; + } + +if (!of_property_read_u32 (dev->of_node,"qcom,preemphasis-level" , + &value)) { + qphy->preemphasis_level = (u8 )value; + qphy->override_preemphasis = true; + } + +if (!of_property_read_u32 (dev->of_node,"qcom,preemphasis-width" , + &value)) { + qphy->preemphasis_width = (u8 )value; + qphy->override_preemphasis_width = true; + } +pm_runtime_set_active (dev);pm_runtime_enable (dev);/*
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v5 7/7] phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845
Hi,
Quoted 9 lines · Manu Gautam
There are two QUSB2 PHYs present on sdm845. In order to improve eye diagram for both the PHYs some parameters need to be changed. Provide device tree properties to override these from board specific device tree files.
Signed-off-by Manu Gautam <[email protected]>--- drivers/phy/qualcomm/phy-qcom-qusb2.c | 126 +++++++++++++++++++++++++++++++--- 1 file changed, 118 insertions(+), 8 deletions(-)
I confirmed that all my previous comments were fixed and this looks nice to me now.