phy: qcom: Updates for USB PHYs on SDM845
Status from this message: Applied to clk-next
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest posting 2/27 patches 9 repliesApplied
- v5 posting 1/20 of 7 patches 0 repliesSuperseded
- v47 patches 20 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 6 patches | 18 replies | Superseded | |
| v2 | 6 patches | 2 replies | Superseded | |
| v1 | 6 patches | 9 replies | Superseded |
Changes in v5 from the cover letter
- Addressed Doug's review comments to have QUSB2 PHY tuning values in header file.
- Updated msm8996-gcc patch to use BRANCH_HALT_SKIP flag added by patch - https://patchwork.kernel.org/patch/10375041/
Patches in v5 posting 2/2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clkdrivers/ | +4 | 2 replies | |
| 2/7 | phy: qcom-qmp: Enable pipe_clk before PHY initializationdrivers/ | +8 | 1 reply | |
| 3/7 | phy: qcom-qusb2: Fix crash if nvmem cell not specifieddrivers/ | +4 | 0 replies | |
| 4/7 | dt-bindings: phy-qcom-qmp: Update bindings for sdm845Documentation/ | +2 | 1 reply | |
| 5/7 | phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support for sdm845drivers/ drivers/ | +151 | 0 replies | |
| 6/7 | dt-bindings: phy-qcom-usb2: Add support to override tuning valuesDocumentation/ include/ | +59 | 4 replies | |
| 7/7 | phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845drivers/ | +118 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Vivek Gautam | Evan Green | Douglas Anderson | Rob Herring |
|---|---|---|---|---|
| 1/7 | R-b | |||
| 2/7 | R-b | |||
| 3/7 | R-b | R-b | ||
| 4/7 | R-b | R-b | ||
| 5/7 | R-b | |||
| 6/7 | R-b | R-b | ||
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 0/7] phy: qcom: Updates for USB PHYs on SDM845
SDM845 has two USB instances each with QUSB2 and QMP PHYs. One of the QMP PHY is USB-DP (DisplayPort) combo PHY where as other one is single lane UNI-PHY (without DP support). Changes are related to PHY configuration for electrical parameters tuning to improve eye-diagram and some fixes.
First gcc-msm8996 driver patch is dependent on following patch which is now applied by Stephen.
https://patchwork.kernel.org/patch/10375043/
Changes since v4:
- Addressed Doug's review comments to have QUSB2 PHY tuning values in header file.
- Updated msm8996-gcc patch to use BRANCH_HALT_SKIP flag added by patch - https://patchwork.kernel.org/patch/10375041/
Changes since v3:
- As per Doug's review comments added device tree parameters to handle board level differences in PHY tuning values instead of adding separate device tree bindings.
- Replace PHY version specific bindings names with SOC name as no one is going to use generic binding names.
- Update halt_check to not check for pipe clock status that allows to simplify pipe_clk handling in QMP driver.
Changes since v2:
- Use separate phy_ops for USB to not register power_on op.
- And other minor changes as per review comments from Stephen.
Changes since v1:
- Updated qusb2 compatibility name as per comment from Vivek.
Manu Gautam (7):
clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
phy: qcom-qmp: Enable pipe_clk before PHY initialization
phy: qcom-qusb2: Fix crash if nvmem cell not specified
dt-bindings: phy-qcom-qmp: Update bindings for sdm845
phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support for sdm845
dt-bindings: phy-qcom-usb2: Add support to override tuning values
phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845
.../devicetree/bindings/phy/qcom-qmp-phy.txt | 3 +- .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 ++- drivers/clk/qcom/gcc-msm8996.c | 4 + drivers/phy/qualcomm/phy-qcom-qmp.c | 169 +++++++++++++++++++-- drivers/phy/qualcomm/phy-qcom-qmp.h | 5 + drivers/phy/qualcomm/phy-qcom-qusb2.c | 130 +++++++++++++++- include/dt-bindings/phy/phy-qcom-qusb2.h | 37 +++++ 7 files changed, 346 insertions(+), 25 deletions(-) create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project