Skip to contentSkip to conversation

drm/i915: add kvmgt as i915's soft dependency

PATCH Superseded [email protected] 3 participants 7 messages Jun 22, 2018 2 messages not in the archive

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: add kvmgt as i915's soft dependency

From: Hang Yuan <[email protected]>

This helps kvmgt included in initramfs and got loaded after i915.

---
 drivers/gpu/drm/i915/i915_pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +2 -0
index 062e91b..a0fb51f 100644
@@ -773,3 +773,5 @@ MODULE_AUTHOR("Intel Corporation");
 
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+
+MODULE_SOFTDEP("post: kvmgt");
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting [email protected] (2018-06-22 08:32:57)

Quoted 14 lines

From: Hang Yuan <[email protected]>

This helps kvmgt included in initramfs and got loaded after i915.

---
 drivers/gpu/drm/i915/i915_pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index 062e91b..a0fb51f 100644

drivers/gpu/drm/i915/i915_pci.c MODULE_AUTHOR("Intel Corporation"); · line 777

Quoted 5 lines
drivers/gpu/drm/i915/i915_pci.c +2 -0
@@ -773,3 +773,5 @@ MODULE_AUTHOR("Intel Corporation");
 
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+
+MODULE_SOFTDEP("post: kvmgt");

The dependency is added by gvt, so what's it doing here? -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#2 lore raw
Quoted 16 lines · Chris Wilson

Quoting [email protected] (2018-06-22 08:32:57)

Quoted 15 lines

From: Hang Yuan <[email protected]>

This helps kvmgt included in initramfs and got loaded after i915.

---
 drivers/gpu/drm/i915/i915_pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index 062e91b..a0fb51f 100644
@@ -773,3 +773,5 @@ MODULE_AUTHOR("Intel Corporation");
 
Quoted 7 lines

drivers/gpu/drm/i915/i915_pci.c MODULE_AUTHOR("Intel Corporation"); · line 777

Quoted 4 lines
drivers/gpu/drm/i915/i915_pci.c +2 -0
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+
+MODULE_SOFTDEP("post: kvmgt");

The dependency is added by gvt, so what's it doing here? -Chris

It wants to indicate the soft dependency between i915 and kvmgt. So kvmgt can be loaded automatically after i915 module, for example, in initramfs. Do you see any problem here?
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#3 lore raw
Quoted 17 lines · On Fri, Jun 22, 2018 at 04:33:21PM +0800…
Quoted 16 lines · Chris Wilson

Quoting [email protected] (2018-06-22 08:32:57)

Quoted 15 lines

From: Hang Yuan <[email protected]>

This helps kvmgt included in initramfs and got loaded after i915.

---
 drivers/gpu/drm/i915/i915_pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index 062e91b..a0fb51f 100644
@@ -773,3 +773,5 @@ MODULE_AUTHOR("Intel Corporation");
 
Quoted 8 lines
Quoted 7 lines

drivers/gpu/drm/i915/i915_pci.c MODULE_AUTHOR("Intel Corporation"); · line 777

Quoted 4 lines
drivers/gpu/drm/i915/i915_pci.c +2 -0
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+
+MODULE_SOFTDEP("post: kvmgt");

The dependency is added by gvt, so what's it doing here? -Chris

It wants to indicate the soft dependency between i915 and kvmgt. So kvmgt can be loaded automatically after i915 module, for example, in initramfs. Do you see any problem here?

Sorry I made the field "From" with wrong account in my last email.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#6 lore raw
Quoted 32 lines · Chris Wilson

Quoting Hang Yuan (2018-06-22 09:18:02)

Quoted 17 lines · Chris Wilson
Quoted 16 lines

Quoting [email protected] (2018-06-22 08:32:57)

Quoted 15 lines

From: Hang Yuan <[email protected]>

This helps kvmgt included in initramfs and got loaded after i915.

---
 drivers/gpu/drm/i915/i915_pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index 062e91b..a0fb51f 100644
@@ -773,3 +773,5 @@ MODULE_AUTHOR("Intel Corporation");
 
Quoted 8 lines
Quoted 7 lines

drivers/gpu/drm/i915/i915_pci.c MODULE_AUTHOR("Intel Corporation"); · line 777

Quoted 4 lines
drivers/gpu/drm/i915/i915_pci.c +2 -0
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+
+MODULE_SOFTDEP("post: kvmgt");

The dependency is added by gvt, so what's it doing here? -Chris

It wants to indicate the soft dependency between kvmgt and i915. So kvmgt can be loaded after i915 module in initramfs. Do you think it's ok?

#if IS_ENABLED(CONFIG_DRM_I915_GVT_KVMGT)
                /* not in Xen. Try KVMGT */
                intel_gvt_host.mpt = try_then_request_module(
                                symbol_get(kvmgt_mpt), "kvmgt");
                intel_gvt_host.hypervisor_type = INTEL_GVT_HYPERVISOR_KVM;
Quoted 6 lines

#endif

Does not look all too soft, conditional and a pre-dependency not post. Also only required if gvt + gvt-kvmgt is compiled in. Not part of the base i915 module.
-Chris

Thanks for the comments. I will re-consider the implementation.

Regards,
Henry

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.BAT: success for drm/i915: add kvmgt as i915's soft dependency

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: add kvmgt as i915's soft dependency
URL : https://patchwork.freedesktop.org/series/45227/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4368 -> Patchwork_9395 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/45227/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9395 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

== Participating hosts (43 -> 37) ==

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-bsw-cyan fi-ctg-p8600 fi-kbl-x1275

== Build changes ==

* Linux: CI_DRM_4368 -> Patchwork_9395

CI_DRM_4368: f9f621dc095a8bfd2157fba018ddb542260d8daa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4528: 6be300d405de5974b262e8b93a445be4ac618e6a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9395: f5ee28a8420d0a00046383a63225bed0c0744d3b @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

f5ee28a8420d drm/i915: add kvmgt as i915's soft dependency

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9395/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.IGT: success for drm/i915: add kvmgt as i915's soft dependency

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: add kvmgt as i915's soft dependency
URL : https://patchwork.freedesktop.org/series/45227/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4368_full -> Patchwork_9395_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9395_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9395_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9395_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-ctx-dirty-render:
      shard-kbl:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_9395_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      shard-glk:          NOTRUN -> DMESG-FAIL (fdo#106560, fdo#106947)

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          PASS -> FAIL (fdo#105454, fdo#106509)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-hsw:          PASS -> FAIL (fdo#103925, fdo#104724)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_workarounds@suspend-resume-context:
      shard-apl:          FAIL (fdo#103375) -> PASS +1

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#102887) -> PASS

    igt@kms_flip@modeset-vs-vblank-race-interruptible:
      shard-glk:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip_tiling@flip-y-tiled:
      shard-glk:          FAIL (fdo#103822, fdo#104724) -> PASS

    igt@perf_pmu@busy-idle-check-all-rcs0:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> FAIL (fdo#105347)

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4368 -> Patchwork_9395

CI_DRM_4368: f9f621dc095a8bfd2157fba018ddb542260d8daa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4528: 6be300d405de5974b262e8b93a445be4ac618e6a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9395: f5ee28a8420d0a00046383a63225bed0c0744d3b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9395/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx