Skip to contentSkip to conversation

Patch "mtd: cfi_cmdset_0002: Change erase functions to retry for error" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 10, 2018 Memory technology devices (MTD)

lore
Share & tools
lore

[email protected]

author Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: cfi_cmdset_0002: Change erase functions to retry for error

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-cfi_cmdset_0002-change-erase-functions-to-retry-for-error.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 45f75b8a919a4255f52df454f1ffdee0e42443b2 Mon Sep 17 00:00:00 2001

From: Tokunori Ikegami <[email protected]>
Date: Wed, 30 May 2018 18:32:28 +0900
Subject: mtd: cfi_cmdset_0002: Change erase functions to retry for error

From: Tokunori Ikegami <[email protected]>

commit 45f75b8a919a4255f52df454f1ffdee0e42443b2 upstream.

For the word write functions it is retried for error. But it is not implemented to retry for the erase functions. To make sure for the erase functions change to retry as same.

This is needed to prevent the flash erase error caused only once. It was caused by the error case of chip_good() in the do_erase_oneblock(). Also it was confirmed on the MACRONIX flash device MX29GL512FHT2I-11G. But the error issue behavior is not able to reproduce at this moment. The flash controller is parallel Flash interface integrated on BCM53003.

Signed-off-by Tokunori Ikegami <[email protected]>
Reviewed-by Joakim Tjernlund <[email protected]>
Cc Chris Packham <[email protected]>
Cc Brian Norris <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Boris Brezillon <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc Cyrille Pitchen <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Boris Brezillon <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 drivers/mtd/chips/cfi_cmdset_0002.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/mtd/chips/cfi_cmdset_0002.c +10 -0
@@ -2237,6 +2237,7 @@ static int __xipram do_erase_chip(struct
 	unsigned long int adr;
 	DECLARE_WAITQUEUE(wait, current);
 	int ret = 0;
+	int retry_cnt = 0;
 
 	adr = cfi->addr_unlock1;
 

@@ -2254,6 +2255,7 @@ static int __xipram do_erase_chip(struct
 	ENABLE_VPP(map);
 	xip_disable(map, chip, adr);
 
+ retry:
 	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);

@@ -2308,6 +2310,9 @@ static int __xipram do_erase_chip(struct
 		map_write( map, CMD(0xF0), chip->start );
 		/* FIXME - should have reset delay before continuing */
 
+		if (++retry_cnt <= MAX_RETRIES)
+			goto retry;
+
 		ret = -EIO;
 	}
 

@@ -2327,6 +2332,7 @@ static int __xipram do_erase_oneblock(st
 	unsigned long timeo = jiffies + HZ;
 	DECLARE_WAITQUEUE(wait, current);
 	int ret = 0;
+	int retry_cnt = 0;
 
 	adr += chip->start;
 

@@ -2344,6 +2350,7 @@ static int __xipram do_erase_oneblock(st
 	ENABLE_VPP(map);
 	xip_disable(map, chip, adr);
 
+ retry:
 	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);
 	cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);

@@ -2401,6 +2408,9 @@ static int __xipram do_erase_oneblock(st
 		map_write( map, CMD(0xF0), chip->start );
 		/* FIXME - should have reset delay before continuing */
 
+		if (++retry_cnt <= MAX_RETRIES)
+			goto retry;
+
 		ret = -EIO;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/mtd-cfi_cmdset_0002-change-erase-functions-to-retry-for-error.patch queue-4.9/mtd-cfi_cmdset_0002-change-erase-functions-to-check-chip-good-only.patch queue-4.9/mtd-cfi_cmdset_0002-change-definition-naming-to-retry-write-operation.patch