x86/intel_rdt: Show missing resctrl mount options
PATCH 1/1 x86/intel_rdt: Show missing resctrl mount options
In resctrl filesystem, we have some mount options to enable L3/L2 CDP and MBA Software Controller features if platform supports them:
mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl
But currently only "cdp" option can be displayed. "cdpl2" and "mba_MBps" options are not showed even when they are active mount options.
Before this patch:
#mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl #grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0
After this patch:
#mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl #grep resctrl /proc/mountts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0
--- arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++ 1 file changed, 7 insertions(+)
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +7 -0
@@ -2760,6 +2760,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf) {if (rdt_resources_all[RDT_RESOURCE_L3DATA ].alloc_enabled)seq_puts (seq,",cdp" ); + +if (rdt_resources_all[RDT_RESOURCE_L2DATA ].alloc_enabled) +seq_puts (seq,",cdpl2" ); + +if (is_mba_sc (&rdt_resources_all[RDT_RESOURCE_MBA ])) +seq_puts (seq,",mba_MBps" ); +return 0 ; }
Signature · 1 line
2.18.0
Quoted 3 lines · Fenghua Yu
Signed-off-by Xiaochen Shen <[email protected]>Signed-off-by Fenghua Yu <[email protected]>
Sigh. Am I supposed to assume that this patch is authored by Xiaochen?
Come on, you are around long enough to do it proper.
Thanks,
tglx
Quoted 6 lines · Thomas Gleixner
Quoted 3 lines · Fenghua Yu
Signed-off-by Xiaochen Shen <[email protected]>Signed-off-by Fenghua Yu <[email protected]>Sigh. Am I supposed to assume that this patch is authored by Xiaochen?
Yes, Xiaochen is the author. Sorry for the mistake.
I just now sent out v2 patch to use right author Xiaochen in the patch.
Thanks.
-Fenghua