Skip to contentSkip to conversation

drm/panel: Add support for Truly NT35597 panel driver

PATCH Superseded Abhinav Kumar 2 participants 6 messages Sep 29, 2018 – Oct 5, 2018

Subsystems (5)

v9 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

PATCH v9 1/2 drm/panel: Add support for Truly NT35597 panel driver

Add support for Truly NT35597 panel driver used in MSM reference platforms. This panel driver supports both single DSI and dual DSI modes.

However, this patch series adds support only for dual DSI mode.

Changes in v9:
- Sorted headers alphabetically
- Remove void type for commands
- Reduce number of lines used by comments
- Fix return value in probe
- Fix driver name to use '-' instead of '_'

---
 drivers/gpu/drm/panel/Kconfig               |   7 +
 drivers/gpu/drm/panel/Makefile              |   1 +
 drivers/gpu/drm/panel/panel-truly-nt35597.c | 675 ++++++++++++++++++++++++++++
 3 files changed, 683 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-truly-nt35597.c
drivers/gpu/drm/panel/Kconfig +7 -0
index 6020c30..073ffa0 100644
@@ -186,4 +186,11 @@ config DRM_PANEL_SITRONIX_ST7789V
 	  Say Y here if you want to enable support for the Sitronix
 	  ST7789V controller for 240x320 LCD panels
 
+config DRM_PANEL_TRULY_NT35597_WQXGA
+	tristate "Truly WQXGA"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	help
+	  Say Y here if you want to enable support for Truly NT35597 WQXGA Dual DSI
+	  Video Mode panel
 endmenu
drivers/gpu/drm/panel/Makefile +1 -0
index 5ccaaa9..80fd19f 100644
@@ -19,3 +19,4 @@ obj-$(CONFIG_DRM_PANEL_SEIKO_43WVF1G) += panel-seiko-43wvf1g.o
 obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += panel-sharp-lq101r1sx01.o
 obj-$(CONFIG_DRM_PANEL_SHARP_LS043T1LE01) += panel-sharp-ls043t1le01.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
+obj-$(CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA) += panel-truly-nt35597.o
drivers/gpu/drm/panel/panel-truly-nt35597.c new file +675 -0

675 lines not on this page · raw message

Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH v9 2/2 dt-bindings: Add Truly NT35597 panel driver bindings

Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI.

However, this patch series supports only dual DSI.

Changes in v9:
- None

---
 .../devicetree/bindings/display/truly,nt35597.txt  | 60 ++++++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/truly,nt35597.txt
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +60 -0
new file mode 100644
index 0000000..46b29eb
@@ -0,0 +1,60 @@
+Truly model NT35597 DSI display driver
+
+The Truly NT35597 is a generic display driver, currently only configured
+for use in the 2K display on the Qualcomm SDM845.
+
+Required properties:
+- compatible: should be "truly,nt35597-2K-display"
+- vdda-supply: phandle of the regulator that provides the supply voltage
+  Power IC supply
+- vdispp-supply: phandle of the regulator that provides the supply voltage
+  for positive LCD bias
+- vdispn-supply: phandle of the regulator that provides the supply voltage
+  for negative LCD bias
+- reset-gpios: phandle of gpio for reset line
+  This should be 8mA, gpio can be configured using mux, pinctrl, pinctrl-names
+  (active low)
+- mode-gpios: phandle of the gpio for choosing the mode of the display
+  for single DSI or Dual DSI
+  (active high)
+  This should be low for dual DSI and high for single DSI mode
+- ports: This device has two video ports driven by two DSIs. Their connections
+  are modelled using the OF graph bindings specified in
+  Documentation/devicetree/bindings/graph.txt.
+  - port@0: DSI input port driven by master DSI
+  - port@1: DSI input port driven by secondary DSI
+
+Example:
+
+	dsi@ae94000 {
+		panel@0 {
+			compatible = "truly,nt35597-2K-display";
+			reg = <0>;
+			vdda-supply = <&pm8998_l14>;
+			vdispp-supply = <&lab_regulator>;
+			vdispn-supply = <&ibb_regulator>;
+			pinctrl-names = "default", "suspend";
+			pinctrl-0 = <&dpu_dsi_active>;
+			pinctrl-1 = <&dpu_dsi_suspend>;
+
+			reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+			mode-gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port@0 {
+					reg = <0>;
+					panel0_in: endpoint {
+						remote-endpoint = <&dsi0_out>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+					panel1_in: endpoint {
+						remote-endpoint = <&dsi1_out>;
+					};
+				};
+			};
+		};
+	};
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

If you want DT bindings reviewed, you have to cc the DT list. (Or wait for Sean Paul to ping me on IRC)

Quoted 3 lines · Abhinav Kumar

Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI.

By driver, you means drives panel timing signals or a Linux driver? The former is okay, the latter is not.

Quoted 20 lines

However, this patch series supports only dual DSI.

Changes in v9:
- None

---
 .../devicetree/bindings/display/truly,nt35597.txt  | 60 ++++++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/truly,nt35597.txt
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +0 -0
new file mode 100644
index 0000000..46b29eb

Documentation/devicetree/bindings/display/truly,nt35597.txt line 4

Quoted 4 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +4 -0
@@ -0,0 +1,60 @@
+Truly model NT35597 DSI display driver
+
+The Truly NT35597 is a generic display driver, currently only configured
+for use in the 2K display on the Qualcomm SDM845.

So this is for *all* SDM845 based boards?

Quoted 5 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +5 -0
+
+Required properties:
+- compatible: should be "truly,nt35597-2K-display"
+- vdda-supply: phandle of the regulator that provides the supply voltage
+  Power IC supply

Documentation/devicetree/bindings/display/truly,nt35597.txt line 19

Quoted 10 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +10 -0
+- vdispp-supply: phandle of the regulator that provides the supply voltage
+  for positive LCD bias
+- vdispn-supply: phandle of the regulator that provides the supply voltage
+  for negative LCD bias
+- reset-gpios: phandle of gpio for reset line
+  This should be 8mA, gpio can be configured using mux, pinctrl, pinctrl-names
+  (active low)
+- mode-gpios: phandle of the gpio for choosing the mode of the display
+  for single DSI or Dual DSI
+  (active high)

active high doesn't really make sense for this.

Documentation/devicetree/bindings/display/truly,nt35597.txt line 22

Quoted 3 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +3 -0
+  This should be low for dual DSI and high for single DSI mode
+- ports: This device has two video ports driven by two DSIs. Their connections
+  are modelled using the OF graph bindings specified in

modeled

Quoted 39 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +38 -1
+  Documentation/devicetree/bindings/graph.txt.
+  - port@0: DSI input port driven by master DSI
+  - port@1: DSI input port driven by secondary DSI
+
+Example:
+
+       dsi@ae94000 {
+               panel@0 {
+                       compatible = "truly,nt35597-2K-display";
+                       reg = <0>;
+                       vdda-supply = <&pm8998_l14>;
+                       vdispp-supply = <&lab_regulator>;
+                       vdispn-supply = <&ibb_regulator>;
+                       pinctrl-names = "default", "suspend";
+                       pinctrl-0 = <&dpu_dsi_active>;
+                       pinctrl-1 = <&dpu_dsi_suspend>;
+
+                       reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+                       mode-gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
+                       ports {
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+                               port@0 {
+                                       reg = <0>;
+                                       panel0_in: endpoint {
+                                               remote-endpoint = <&dsi0_out>;
+                                       };
+                               };
+
+                               port@1 {
+                                       reg = <1>;
+                                       panel1_in: endpoint {
+                                               remote-endpoint = <&dsi1_out>;
+                                       };
+                               };
+                       };
+               };
+       };
--
Quoted 3 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

Hi Rob

Thanks for the review. Will copy the DT list in the next patchset.

Some comments inline.

Thanks

Abhinav

Quoted 10 lines · Rob Herring

If you want DT bindings reviewed, you have to cc the DT list. (Or wait for Sean Paul to ping me on IRC)

Quoted 3 lines · Abhinav Kumar

Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI.

By driver, you means drives panel timing signals or a Linux driver? The former is okay, the latter is not.

Yes, I mean it driver panel timing signals.

Quoted 17 lines
Quoted 17 lines

However, this patch series supports only dual DSI.

Changes in v9:
- None

---
 .../devicetree/bindings/display/truly,nt35597.txt  | 60 
++++++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 

Documentation/devicetree/bindings/display/truly,nt35597.txt

Quoted 13 lines
Quoted 11 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +3 -0
new file mode 100644
index 0000000..46b29eb
@@ -0,0 +1,60 @@
+Truly model NT35597 DSI display driver
+
+The Truly NT35597 is a generic display driver, currently only 

configured
+for use in the 2K display on the Qualcomm SDM845.

So this is for *all* SDM845 based boards?

This is for SDM845 MTP board. Let me mention that as well.

Quoted 15 lines
Quoted 15 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +4 -0
+
+Required properties:
+- compatible: should be "truly,nt35597-2K-display"
+- vdda-supply: phandle of the regulator that provides the supply 

voltage
+ Power IC supply
+- vdispp-supply: phandle of the regulator that provides the supply voltage
+ for positive LCD bias
+- vdispn-supply: phandle of the regulator that provides the supply voltage

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +3 -0
+  for negative LCD bias
+- reset-gpios: phandle of gpio for reset line
+  This should be 8mA, gpio can be configured using mux, pinctrl, 
Quoted 8 lines

Documentation/devicetree/bindings/display/truly,nt35597.txt line 19

Quoted 6 lines

pinctrl-names
+ (active low)
+- mode-gpios: phandle of the gpio for choosing the mode of the display

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +2 -0
+  for single DSI or Dual DSI
+  (active high)

active high doesn't really make sense for this.

Alright, will remove this.

Quoted 44 lines
Quoted 5 lines

+ This should be low for dual DSI and high for single DSI mode +- ports: This device has two video ports driven by two DSIs. Their connections
+ are modelled using the OF graph bindings specified in

modeled

Quoted 36 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +26 -0
+  Documentation/devicetree/bindings/graph.txt.
+  - port@0: DSI input port driven by master DSI
+  - port@1: DSI input port driven by secondary DSI
+
+Example:
+
+       dsi@ae94000 {
+               panel@0 {
+                       compatible = "truly,nt35597-2K-display";
+                       reg = <0>;
+                       vdda-supply = <&pm8998_l14>;
+                       vdispp-supply = <&lab_regulator>;
+                       vdispn-supply = <&ibb_regulator>;
+                       pinctrl-names = "default", "suspend";
+                       pinctrl-0 = <&dpu_dsi_active>;
+                       pinctrl-1 = <&dpu_dsi_suspend>;
+
+                       reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+                       mode-gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
+                       ports {
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+                               port@0 {
+                                       reg = <0>;
+                                       panel0_in: endpoint {
+                                               remote-endpoint = 

<&dsi0_out>;

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +7 -0
+                                       };
+                               };
+
+                               port@1 {
+                                       reg = <1>;
+                                       panel1_in: endpoint {
+                                               remote-endpoint = 

<&dsi1_out>;
+ };

Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +4 -1
+                               };
+                       };
+               };
+       };
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

Hi Rob

Had one question on below comment. Can you please help to clarify?

Thanks

Abhinav

Quoted 76 lines · Abhinav Kumar

Hi Rob

Thanks for the review. Will copy the DT list in the next patchset.

Some comments inline.

Thanks

Abhinav

Quoted 10 lines · Rob Herring

If you want DT bindings reviewed, you have to cc the DT list. (Or wait for Sean Paul to ping me on IRC)

Quoted 3 lines · Abhinav Kumar

Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI.

By driver, you means drives panel timing signals or a Linux driver? The former is okay, the latter is not.

Yes, I mean it driver panel timing signals.

Quoted 17 lines
Quoted 17 lines

However, this patch series supports only dual DSI.

Changes in v9:
- None

---
 .../devicetree/bindings/display/truly,nt35597.txt  | 60 
++++++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 

Documentation/devicetree/bindings/display/truly,nt35597.txt

Quoted 13 lines
Quoted 11 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +3 -0
new file mode 100644
index 0000000..46b29eb
@@ -0,0 +1,60 @@
+Truly model NT35597 DSI display driver
+
+The Truly NT35597 is a generic display driver, currently only 

configured
+for use in the 2K display on the Qualcomm SDM845.

So this is for *all* SDM845 based boards?

This is for SDM845 MTP board. Let me mention that as well.

Quoted 15 lines
Quoted 15 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +4 -0
+
+Required properties:
+- compatible: should be "truly,nt35597-2K-display"
+- vdda-supply: phandle of the regulator that provides the supply 

voltage
+ Power IC supply
+- vdispp-supply: phandle of the regulator that provides the supply voltage
+ for positive LCD bias
+- vdispn-supply: phandle of the regulator that provides the supply voltage

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +3 -0
+  for negative LCD bias
+- reset-gpios: phandle of gpio for reset line
+  This should be 8mA, gpio can be configured using mux, pinctrl, 
Quoted 8 lines

Documentation/devicetree/bindings/display/truly,nt35597.txt line 19

Quoted 6 lines

pinctrl-names
+ (active low)
+- mode-gpios: phandle of the gpio for choosing the mode of the display

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +2 -0
+  for single DSI or Dual DSI
+  (active high)

active high doesn't really make sense for this.

Quoted 1 line

Alright, will remove this.

Here you would prefer us to make this GPIO active low right?
OR you were just mentioning that I can remove the active high documentation?

Quoted 44 lines
Quoted 44 lines
Quoted 5 lines

+ This should be low for dual DSI and high for single DSI mode +- ports: This device has two video ports driven by two DSIs. Their connections
+ are modelled using the OF graph bindings specified in

modeled

Quoted 36 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +26 -0
+  Documentation/devicetree/bindings/graph.txt.
+  - port@0: DSI input port driven by master DSI
+  - port@1: DSI input port driven by secondary DSI
+
+Example:
+
+       dsi@ae94000 {
+               panel@0 {
+                       compatible = "truly,nt35597-2K-display";
+                       reg = <0>;
+                       vdda-supply = <&pm8998_l14>;
+                       vdispp-supply = <&lab_regulator>;
+                       vdispn-supply = <&ibb_regulator>;
+                       pinctrl-names = "default", "suspend";
+                       pinctrl-0 = <&dpu_dsi_active>;
+                       pinctrl-1 = <&dpu_dsi_suspend>;
+
+                       reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+                       mode-gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
+                       ports {
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+                               port@0 {
+                                       reg = <0>;
+                                       panel0_in: endpoint {
+                                               remote-endpoint = 

<&dsi0_out>;

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +7 -0
+                                       };
+                               };
+
+                               port@1 {
+                                       reg = <1>;
+                                       panel1_in: endpoint {
+                                               remote-endpoint = 

<&dsi1_out>;
+ };

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/display/truly,nt35597.txt new file +4 -1
+                               };
+                       };
+               };
+       };
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

Quoted 24 lines · Abhinav Kumar

Hi Rob

Had one question on below comment. Can you please help to clarify?

Thanks

Abhinav

Quoted 15 lines · Abhinav Kumar

Hi Rob

Thanks for the review. Will copy the DT list in the next patchset.

Some comments inline.

Thanks

Abhinav

Quoted 4 lines · Rob Herring

If you want DT bindings reviewed, you have to cc the DT list. (Or wait for Sean Paul to ping me on IRC)

On Fri, Sep 28, 2018 at 7:39 PM Abhinav Kumar

[...]

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
+- reset-gpios: phandle of gpio for reset line
+  This should be 8mA, gpio can be configured using mux, pinctrl,

pinctrl-names
+ (active low)
+- mode-gpios: phandle of the gpio for choosing the mode of the display

Documentation/devicetree/bindings/display/truly,nt35597.txt new file +2 -0
+  for single DSI or Dual DSI
+  (active high)
Quoted 3 lines
Quoted 2 lines
Quoted 1 line

active high doesn't really make sense for this.

Alright, will remove this.

Here you would prefer us to make this GPIO active low right?

No, because both states are active.

Quoted 2 lines

OR you were just mentioning that I can remove the active high documentation?

Correct.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel