Skip to contentSkip to conversation

MAINTAINERS: Add an entry for the 'collie' machine

PATCH Applied Thomas Huth 4 participants 9 messages Nov 6, 2018 – Nov 8, 2018

lore
Share & tools
lore

Thomas Huth

author
#0 lore raw

PATCH 1/1 MAINTAINERS: Add an entry for the 'collie' machine

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

Signed-off-by Thomas Huth <[email protected]>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
index 0499e11..471cf72 100644
@@ -592,6 +592,12 @@ F: hw/*/pxa2xx*
 F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h
 
+Sharp SL-5500 (Collie) PDA
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/collie.c
+F: hw/arm/strongarm*
+
 Stellaris
 M: Peter Maydell <[email protected]>
 L: [email protected]
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

Regardless the one choosed:

Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 24 lines
Signed-off-by Thomas Huth <[email protected]>
---
  MAINTAINERS | 6 ++++++
  1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
index 0499e11..471cf72 100644
@@ -592,6 +592,12 @@ F: hw/*/pxa2xx*
  F: hw/misc/mst_fpga.c
  F: include/hw/arm/pxa.h
 
+Sharp SL-5500 (Collie) PDA
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/collie.c
+F: hw/arm/strongarm*
+
  Stellaris
  M: Peter Maydell <[email protected]>
  L: [email protected]
author
#2 lore raw
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

I'll leave it up to Peter for the final decision...

Quoted 2 lines

Regardless the one choosed:

Reviewed-by Philippe Mathieu-Daudé <[email protected]>

Thanks,
Thomas

#3 lore raw
Quoted 9 lines · Thomas Huth
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

I'll leave it up to Peter for the final decision...

I think we're not very consistent[*] in our usage of the various statuses in the MAINTAINERS file. I guess "Odd Fixes" makes sense in that, well, if you send a patch to this
code and cc me I'll review it and put it in the tree. (This is true of any of the arm boards we have.)

[*] We have one thing tagged Orphan, which is bsd-user/, and some things tagged Odd Fixes with no listed maintainer, and some things tagged Odd Fixes which are in practice more like Orphan (for instance sh4), and we list "fpu/" as Odd Fixes despite having given it a pretty thorough overhaul very recently, and so on...

If you wanted a mechanizable rule, you could try something like "every file which is in status Odd Fixes or better must list with M: at least one named individual who has submitted a pull request in the last nine months" :-)

thanks
-- PMM

#4 lore raw
Quoted 24 lines · Peter Maydell
Quoted 9 lines · Thomas Huth
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

I'll leave it up to Peter for the final decision...

I think we're not very consistent[*] in our usage of the various statuses in the MAINTAINERS file. I guess "Odd Fixes" makes sense in that, well, if you send a patch to this
code and cc me I'll review it and put it in the tree. (This is true of any of the arm boards we have.)

[*] We have one thing tagged Orphan, which is bsd-user/, and some things tagged Odd Fixes with no listed maintainer, and some things tagged Odd Fixes which are in practice more like Orphan (for instance sh4), and we list "fpu/" as Odd Fixes despite having given it a pretty thorough overhaul very recently, and so on...

Quoted 4 lines

If you wanted a mechanizable rule, you could try something like "every file which is in status Odd Fixes or better must list with M: at least one named individual who has submitted a pull request in the last nine months" :-)

Sounds like an excellent idea to me!

author
#5 lore raw
Quoted 26 lines · Markus Armbruster
Quoted 24 lines · Peter Maydell
Quoted 9 lines · Thomas Huth
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

I'll leave it up to Peter for the final decision...

I think we're not very consistent[*] in our usage of the various statuses in the MAINTAINERS file. I guess "Odd Fixes" makes sense in that, well, if you send a patch to this
code and cc me I'll review it and put it in the tree. (This is true of any of the arm boards we have.)

[*] We have one thing tagged Orphan, which is bsd-user/, and some things tagged Odd Fixes with no listed maintainer, and some things tagged Odd Fixes which are in practice more like Orphan (for instance sh4), and we list "fpu/" as Odd Fixes despite having given it a pretty thorough overhaul very recently, and so on...

Quoted 6 lines
Quoted 4 lines

If you wanted a mechanizable rule, you could try something like "every file which is in status Odd Fixes or better must list with M: at least one named individual who has submitted a pull request in the last nine months" :-)

Sounds like an excellent idea to me!

Well, for me "odd fixes" means that there is someone around who might pick up the patch and throw it into a PULL request. "Orphan" means it's mostly in vain to send patches for this subsystem, since there is nobody going to pick up your patch. So for the ARM boards, I'd say that "odd fixes" is a better choice, since Peter still picks up most of the patches via the "L: [email protected]" (big thanks for this, by the way!).

Thomas

#6 lore raw
Quoted 32 lines · Thomas Huth
Quoted 31 lines · Markus Armbruster
Quoted 28 lines · Peter Maydell
Quoted 9 lines · Thomas Huth
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

I'll leave it up to Peter for the final decision...

I think we're not very consistent[*] in our usage of the various statuses in the MAINTAINERS file. I guess "Odd Fixes" makes sense in that, well, if you send a patch to this
code and cc me I'll review it and put it in the tree. (This is true of any of the arm boards we have.)

[*] We have one thing tagged Orphan, which is bsd-user/, and some things tagged Odd Fixes with no listed maintainer, and some things tagged Odd Fixes which are in practice more like Orphan (for instance sh4), and we list "fpu/" as Odd Fixes despite having given it a pretty thorough overhaul very recently, and so on...

If you wanted a mechanizable rule, you could try something like "every file which is in status Odd Fixes or better must list with M: at least one named individual who has submitted a pull request in the last nine months" :-)

Quoted 8 lines
Quoted 1 line

Sounds like an excellent idea to me!

Well, for me "odd fixes" means that there is someone around who might pick up the patch and throw it into a PULL request. "Orphan" means it's mostly in vain to send patches for this subsystem, since there is nobody going to pick up your patch. So for the ARM boards, I'd say that "odd fixes" is a better choice, since Peter still picks up most of the patches via the "L: [email protected]" (big thanks for this, by the way!).

I think there should be a named person, though. A list isn't a maintainer (at least not for the big whole subsystem lists we have).

thanks
-- PMM

#7 lore raw
Quoted 33 lines · Peter Maydell
Quoted 32 lines · Thomas Huth
Quoted 31 lines · Markus Armbruster
Quoted 28 lines · Peter Maydell
Quoted 9 lines · Thomas Huth
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

This looks more as "Orphan" to me...

I'll leave it up to Peter for the final decision...

I think we're not very consistent[*] in our usage of the various statuses in the MAINTAINERS file. I guess "Odd Fixes" makes sense in that, well, if you send a patch to this
code and cc me I'll review it and put it in the tree. (This is true of any of the arm boards we have.)

[*] We have one thing tagged Orphan, which is bsd-user/, and some things tagged Odd Fixes with no listed maintainer, and some things tagged Odd Fixes which are in practice more like Orphan (for instance sh4), and we list "fpu/" as Odd Fixes despite having given it a pretty thorough overhaul very recently, and so on...

If you wanted a mechanizable rule, you could try something like "every file which is in status Odd Fixes or better must list with M: at least one named individual who has submitted a pull request in the last nine months" :-)

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

Sounds like an excellent idea to me!

Well, for me "odd fixes" means that there is someone around who might pick up the patch and throw it into a PULL request.

That someone should be listed with M:.

Quoted 9 lines
Quoted 5 lines

"Orphan" means it's
mostly in vain to send patches for this subsystem, since there is nobody going to pick up your patch. So for the ARM boards, I'd say that "odd fixes" is a better choice, since Peter still picks up most of the patches via the "L: [email protected]" (big thanks for this, by the way!).

I think there should be a named person, though. A list isn't a maintainer (at least not for the big whole subsystem lists we have).

Agree.

Applied
#8 lore raw
In reply to Thomas Huth
Quoted 16 lines · Thomas Huth

There is no active maintainer, but since Peter is picking up patches via [email protected], I think we could at least use "Odd Fixes" as status here.

Signed-off-by Thomas Huth <[email protected]>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +0 -0
index 0499e11..471cf72 100644
@@ -592,6 +592,12 @@ F: hw/*/pxa2xx*
 F: hw/misc/mst_fpga.c
 F: include/hw/arm/pxa.h

MAINTAINERS F: hw/*/pxa2xx* · line 603

Quoted 10 lines
MAINTAINERS +6 -0
 
+Sharp SL-5500 (Collie) PDA
+L: [email protected]
+S: Odd Fixes
+F: hw/arm/collie.c
+F: hw/arm/strongarm*
+
 Stellaris
 M: Peter Maydell <[email protected]>
 L: [email protected]

Applied to target-arm.next with myself added as an M: contact, thanks.

-- PMM