Skip to contentSkip to conversation

Fixes for Tegra soctherm

PATCH Superseded Wei Ni 2 participants 13 messages Nov 13, 2018 – Nov 23, 2018

Subsystems (2)

v2 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Wei Ni

author
#0 lore raw

v2 cover Fixes for Tegra soctherm

This series fixed some issues for Tegra soctherm

Main changes from v1:
1. Acked by Thierry Reding <[email protected]> for the patch "thermal: tegra: fix memory allocation".
2. Print out the sensor name when register failed.
2. Remove patch "thermal: tegra: fix coverity defect"

Wei Ni (3):
thermal: tegra: continue if sensor register fails
thermal: tegra: remove unnecessary warnings
thermal: tegra: fix memory allocation

 drivers/thermal/tegra/soctherm.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 1/3 thermal: tegra: continue if sensor register fails

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 32 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#3 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

Wei.

Quoted 35 lines
Quoted 33 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
#4 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 13 lines · Wei Ni
Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 5 lines

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

Ignoring errors is not the way to go to support different platforms. Fix the DT.

Quoted 2 lines

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

I meant sensor for thermal zone getting really high temperature.

Quoted 34 lines
Quoted 34 lines
Quoted 32 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#5 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 14 lines · Daniel Lezcano
Quoted 13 lines · Wei Ni
Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 8 lines
Quoted 5 lines

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

Ignoring errors is not the way to go to support different platforms. Fix the DT.

The issue isn't in DT file. The Tegra soc thermal include 4 sensors:
cpu, gpu, mem, pll. But in some platforms, for example, we may only need to support 2 sensors, such as cpu and gpu, so we only configure these two senors in DT file. But the driver will always try to register 4 sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So in this case we need to ignoring the failure, and continue to enable the driver.

Quoted 6 lines
Quoted 4 lines

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

I meant sensor for thermal zone getting really high temperature.

We doesn't have the critical sensors. We set the critical trip temp for all registered sensors. And these trip temp is set to the Tegra hardware. So it mean if the temperature reached the critical trip point, then the system will be shutdown directly.

Quoted 38 lines
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
#6 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 26 lines · Wei Ni
Quoted 14 lines · Daniel Lezcano
Quoted 13 lines · Wei Ni
Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 8 lines
Quoted 5 lines

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

Ignoring errors is not the way to go to support different platforms. Fix the DT.

Quoted 7 lines

The issue isn't in DT file. The Tegra soc thermal include 4 sensors:
cpu, gpu, mem, pll. But in some platforms, for example, we may only need to support 2 sensors, such as cpu and gpu, so we only configure these two senors in DT file. But the driver will always try to register 4 sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So in this case we need to ignoring the failure, and continue to enable the driver.

You can fix this by changing the driver to support the platform and register the sensor you are interested in.

Ignoring errors is not a good idea.

Quoted 48 lines
Quoted 4 lines
Quoted 2 lines

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

I meant sensor for thermal zone getting really high temperature.

We doesn't have the critical sensors. We set the critical trip temp for all registered sensors. And these trip temp is set to the Tegra hardware. So it mean if the temperature reached the critical trip point, then the system will be shutdown directly.

Quoted 38 lines
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#7 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 35 lines · Daniel Lezcano
Quoted 26 lines · Wei Ni
Quoted 14 lines · Daniel Lezcano
Quoted 13 lines · Wei Ni
Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 8 lines
Quoted 5 lines

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

Ignoring errors is not the way to go to support different platforms. Fix the DT.

Quoted 7 lines

The issue isn't in DT file. The Tegra soc thermal include 4 sensors:
cpu, gpu, mem, pll. But in some platforms, for example, we may only need to support 2 sensors, such as cpu and gpu, so we only configure these two senors in DT file. But the driver will always try to register 4 sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So in this case we need to ignoring the failure, and continue to enable the driver.

Quoted 4 lines

You can fix this by changing the driver to support the platform and register the sensor you are interested in.

Ignoring errors is not a good idea.

If hit the errors, the driver will print out the warning. In current code, the driver probe routine will return failure directly, indeed it didn't do anything either except print out warnings.
I think this error should not block other sensors' registration. Let's consider this case, we have four sensors, if the one sensor register failed, then the driver return probe failure, so the drive will not be enabled, and other sensor can't work either, it mean the device may boot up without any thermal sensors.
Or if the error is the -ENODEV, that mean the we didn't set corresponding sensor id in the dt file, so we can continue to register. If the error is other value, then we can return directly.

Wei.

Quoted 52 lines
Quoted 50 lines
Quoted 6 lines
Quoted 4 lines

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

I meant sensor for thermal zone getting really high temperature.

We doesn't have the critical sensors. We set the critical trip temp for all registered sensors. And these trip temp is set to the Tegra hardware. So it mean if the temperature reached the critical trip point, then the system will be shutdown directly.

Quoted 38 lines
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
#8 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Hi wei,

Quoted 43 lines · Wei Ni
Quoted 35 lines · Daniel Lezcano
Quoted 26 lines · Wei Ni
Quoted 14 lines · Daniel Lezcano
Quoted 13 lines · Wei Ni
Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 8 lines
Quoted 5 lines

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

Ignoring errors is not the way to go to support different platforms. Fix the DT.

Quoted 7 lines

The issue isn't in DT file. The Tegra soc thermal include 4 sensors:
cpu, gpu, mem, pll. But in some platforms, for example, we may only need to support 2 sensors, such as cpu and gpu, so we only configure these two senors in DT file. But the driver will always try to register 4 sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So in this case we need to ignoring the failure, and continue to enable the driver.

Quoted 4 lines

You can fix this by changing the driver to support the platform and register the sensor you are interested in.

Ignoring errors is not a good idea.

Quoted 11 lines

If hit the errors, the driver will print out the warning. In current code, the driver probe routine will return failure directly, indeed it didn't do anything either except print out warnings.
I think this error should not block other sensors' registration. Let's consider this case, we have four sensors, if the one sensor register failed, then the driver return probe failure, so the drive will not be enabled, and other sensor can't work either, it mean the device may boot up without any thermal sensors.
Or if the error is the -ENODEV, that mean the we didn't set corresponding sensor id in the dt file, so we can continue to register. If the error is other value, then we can return directly.

It is a possibility but may be there are a couple of alternatives:

1. If there is a compatible string for the platform variant, use it to probe the right sensors

or

2. Use the qoriq driver approach by reparsing the DT and find out the thermal zone and their respective sensor id.

Quoted 50 lines
Quoted 50 lines
Quoted 48 lines
Quoted 4 lines
Quoted 2 lines

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

I meant sensor for thermal zone getting really high temperature.

We doesn't have the critical sensors. We set the critical trip temp for all registered sensors. And these trip temp is set to the Tegra hardware. So it mean if the temperature reached the critical trip point, then the system will be shutdown directly.

Quoted 38 lines
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#9 lore raw

Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails

Quoted 61 lines · Daniel Lezcano

Hi wei,

Quoted 43 lines · Wei Ni
Quoted 35 lines · Daniel Lezcano
Quoted 26 lines · Wei Ni
Quoted 14 lines · Daniel Lezcano
Quoted 13 lines · Wei Ni
Quoted 9 lines · Daniel Lezcano
Quoted 4 lines · Wei Ni

Don't bail when a sensor fails to register with the thermal zone and allow other sensors to register. This allows other sensors to register with thermal framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the real situation you want to overcome ? How do you differentiate critical sensors ?

Quoted 8 lines
Quoted 5 lines

The driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but if the dts file doesn't set the corresponding sensors, then the register will be failed.
Normally, the dts file will set all 4 sensors, but there may have some platform doesn't support them all. So we post this patch.

Ignoring errors is not the way to go to support different platforms. Fix the DT.

Quoted 7 lines

The issue isn't in DT file. The Tegra soc thermal include 4 sensors:
cpu, gpu, mem, pll. But in some platforms, for example, we may only need to support 2 sensors, such as cpu and gpu, so we only configure these two senors in DT file. But the driver will always try to register 4 sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So in this case we need to ignoring the failure, and continue to enable the driver.

Quoted 4 lines

You can fix this by changing the driver to support the platform and register the sensor you are interested in.

Ignoring errors is not a good idea.

Quoted 11 lines

If hit the errors, the driver will print out the warning. In current code, the driver probe routine will return failure directly, indeed it didn't do anything either except print out warnings.
I think this error should not block other sensors' registration. Let's consider this case, we have four sensors, if the one sensor register failed, then the driver return probe failure, so the drive will not be enabled, and other sensor can't work either, it mean the device may boot up without any thermal sensors.
Or if the error is the -ENODEV, that mean the we didn't set corresponding sensor id in the dt file, so we can continue to register. If the error is other value, then we can return directly.

It is a possibility but may be there are a couple of alternatives:

Quoted 7 lines

1. If there is a compatible string for the platform variant, use it to probe the right sensors

or

2. Use the qoriq driver approach by reparsing the DT and find out the thermal zone and their respective sensor id.

Daniel, thanks for your comments, will consider it in my next version.

Wei.

Quoted 54 lines
Quoted 52 lines
Quoted 52 lines
Quoted 50 lines
Quoted 6 lines
Quoted 4 lines

BTW, what do you mean "critical sensors"? We will set critical trip temp for all sensors.

I meant sensor for thermal zone getting really high temperature.

We doesn't have the critical sensors. We set the critical trip temp for all registered sensors. And these trip temp is set to the Tegra hardware. So it mean if the temperature reached the critical trip point, then the system will be shutdown directly.

Quoted 38 lines
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines
---
 drivers/thermal/tegra/soctherm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +5 -3
index ed28110a3535..a824d2e63af3 100644
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 							 &tegra_of_thermal_ops);
 		if (IS_ERR(z)) {
 			err = PTR_ERR(z);
-			dev_err(&pdev->dev, "failed to register sensor: %d\n",
-				err);
-			goto disable_clocks;
+			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
+				 soc->ttgs[i]->name, err);
+			continue;
 		}
 
 		zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
 		struct thermal_zone_device *tz;
 
 		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+		if (!tz)
+			continue;
 		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
 		if (err) {
 			dev_err(&pdev->dev,
author
#10 lore raw

PATCH v2 2/3 thermal: tegra: remove unnecessary warnings

In reply to Wei Ni

Convert warnings to info as not all platforms may
have all the thresholds and sensors enabled.

---
 drivers/thermal/tegra/soctherm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/thermal/tegra/soctherm.c +3 -3
index a824d2e63af3..161ef242bcca 100644
@@ -550,7 +550,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev,
 
 	ret = tz->ops->get_crit_temp(tz, &temperature);
 	if (ret) {
-		dev_warn(dev, "thermtrip: %s: missing critical temperature\n",
+		dev_info(dev, "thermtrip: %s: missing critical temperature\n",
 			 sg->name);
 		goto set_throttle;
 	}
@@ -569,7 +569,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev,
 set_throttle:
 	ret = get_hot_temp(tz, &trip, &temperature);
 	if (ret) {
-		dev_warn(dev, "throttrip: %s: missing hot temperature\n",
+		dev_info(dev, "throttrip: %s: missing hot temperature\n",
 			 sg->name);
 		return 0;
 	}
@@ -600,7 +600,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev,
 	}
 
 	if (i == THROTTLE_SIZE)
-		dev_warn(dev, "throttrip: %s: missing throttle cdev\n",
+		dev_info(dev, "throttrip: %s: missing throttle cdev\n",
 			 sg->name);
 
 	return 0;
Signature · 1 line
2.7.4
author
#11 lore raw

PATCH v2 3/3 thermal: tegra: fix memory allocation

In reply to Wei Ni

Fix memory allocation to store the pointers to
thermal_zone_device.

---
 drivers/thermal/tegra/soctherm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/tegra/soctherm.c +1 -1
index 161ef242bcca..96ca10789f17 100644
@@ -1339,7 +1339,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 	}
 
 	tegra->thermctl_tzs = devm_kcalloc(&pdev->dev,
-					   soc->num_ttgs, sizeof(*z),
+					   soc->num_ttgs, sizeof(z),
 					   GFP_KERNEL);
 	if (!tegra->thermctl_tzs)
 		return -ENOMEM;
Signature · 1 line
2.7.4
author
#12 lore raw
In reply to Wei Ni

Hi all,
Do you have any comments on this serial?

Thanks.
Wei.

Quoted 16 lines · Wei Ni

This series fixed some issues for Tegra soctherm

Main changes from v1:
1. Acked by Thierry Reding <[email protected]> for the patch "thermal: tegra: fix memory allocation".
2. Print out the sensor name when register failed.
2. Remove patch "thermal: tegra: fix coverity defect"

Wei Ni (3):
thermal: tegra: continue if sensor register fails
thermal: tegra: remove unnecessary warnings
thermal: tegra: fix memory allocation

 drivers/thermal/tegra/soctherm.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)