Skip to contentSkip to conversation

s390x/pci: Set the iommu region size as guest wants

PATCH New Pierre Morel 4 participants 13 messages Jan 10, 2019 – Jan 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 s390x/pci: Set the iommu region size as guest wants

Changed the subject (kept only in cover letter)

Changed the commit message to specify that the PAL/PBA values are given by the guest through the mpcifc call.

Pierre Morel (1):
s390x/pci: Set the iommu region size mpcifc request

 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 s390x/pci: Set the iommu region size mpcifc request

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
     char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
     memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                              TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);
     iommu->enabled = true;
     memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
     g_free(name);
Signature · 1 line
2.7.4
#2 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 5 lines · On Thu, 10 Jan 2019 14:00:07 +0100 Pierre Morel <[email protected]> wrote:

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:

s/Let/Let's/

Quoted 12 lines

(PCI Address Limit) - (PCI Base Address) + 1.

---
 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/s390x/s390-pci-bus.c +0 -0
index 69e0671..e97696a 100644

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 666

Quoted 8 lines
hw/s390x/s390-pci-bus.c +1 -1
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
     char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
     memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                              TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);
     iommu->enabled = true;
     memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
     g_free(name);

Looks good to me. Collin, can I get an ack from you so I can queue it?

Acked-by on v2 1/1
#3 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

In reply to Pierre Morel
Quoted 18 lines · Pierre Morel

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
  hw/s390x/s390-pci-bus.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/s390x/s390-pci-bus.c +0 -0
index 69e0671..e97696a 100644

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 666

Quoted 8 lines
hw/s390x/s390-pci-bus.c +1 -1
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
      char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
      memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                               TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);
      iommu->enabled = true;
      memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
      g_free(name);
#4 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 13 lines · On Tue, 15 Jan 2019 10:35:42 -0500 Collin Walling <[email protected]> wrote:
Quoted 12 lines · Pierre Morel

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
  hw/s390x/s390-pci-bus.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 663

Quoted 10 lines
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
      char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
      memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                               TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);

From the the look of this, I would say we basically used the address denoting the end of the region as the size of the region. This smells like a bug to me, but the commit message and the title ain't clear about this, and there is no fixes tag. Because of the latter I did some digging and came to commit f7c40aa "s390x/pci: fix failures of dma map/unmap" (Yi Min Zhao, 2016-06-19) which basically did the inverse of this commit!

My initial motivation was to check if this is stable material. But now I'm very confused. I'm admittedly zPCI incompetent. Could some of the people that understand what is going on help me feel better about this patch?

Regards,
Halil

Quoted 8 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 666

Quoted 4 lines
hw/s390x/s390-pci-bus.c +0 -0
      iommu->enabled = true;
      memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
      g_free(name);
#5 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 35 lines · Halil Pasic
Quoted 13 lines · On Tue, 15 Jan 2019 10:35:42 -0500 Collin Walling <[email protected]> wrote:
Quoted 12 lines · Pierre Morel

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
   hw/s390x/s390-pci-bus.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 663

Quoted 10 lines
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
       char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
       memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                                TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);

From the the look of this, I would say we basically used the address
denoting the end of the region as the size of the region. This smells like a bug to me, but the commit message and the title ain't clear about this, and there is no fixes tag. Because of the latter I did some digging and came to commit f7c40aa "s390x/pci: fix failures of dma map/unmap" (Yi Min Zhao, 2016-06-19) which basically did the inverse of this commit!

Quoted 7 lines

My initial motivation was to check if this is stable material. But now I'm very confused. I'm admittedly zPCI incompetent. Could some of the people that understand what is going on help me feel better about this patch?

Regards,
Halil

The patch you speak about corrected the problem described in its comment by setting the offset address of the subregion to 0, making sure VFIO_PCI works for Z but introduced a bug we did not see at that time by making the subregion too large.

This patch correct the bug, I can add a reference to this with:
fixing: commit f7c40aa1e7feb50bc4d4bc171fa811bdd9a93e51

Regards,
Pierre

Quoted 12 lines
Quoted 11 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 666

Quoted 7 lines
hw/s390x/s390-pci-bus.c +0 -0
       iommu->enabled = true;
       memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
       g_free(name);
Signature · 2 lines
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
#6 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 45 lines · On Wed, 16 Jan 2019 15:16:44 +0100 Pierre Morel <[email protected]> wrote:
Quoted 35 lines · Halil Pasic
Quoted 13 lines · On Tue, 15 Jan 2019 10:35:42 -0500 Collin Walling <[email protected]> wrote:
Quoted 12 lines · Pierre Morel

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
   hw/s390x/s390-pci-bus.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 663

Quoted 10 lines
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
       char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
       memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                                TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);  

From the the look of this, I would say we basically used the address
denoting the end of the region as the size of the region. This smells like a bug to me, but the commit message and the title ain't clear about this, and there is no fixes tag. Because of the latter I did some digging and came to commit f7c40aa "s390x/pci: fix failures of dma map/unmap" (Yi Min Zhao, 2016-06-19) which basically did the inverse of this commit!

Quoted 7 lines

My initial motivation was to check if this is stable material. But now I'm very confused. I'm admittedly zPCI incompetent. Could some of the people that understand what is going on help me feel better about this patch?

Regards,
Halil

Quoted 7 lines

The patch you speak about corrected the problem described in its comment by setting the offset address of the subregion to 0, making sure VFIO_PCI works for Z but introduced a bug we did not see at that time by making the subregion too large.

This patch correct the bug, I can add a reference to this with:
fixing: commit f7c40aa1e7feb50bc4d4bc171fa811bdd9a93e51

The patch is already queued, but I can add

Fixes f7c40aa1e7 ("s390x/pci: fix failures of dma map/unmap")
Quoted 18 lines

Regards,
Pierre

Quoted 12 lines
Quoted 11 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 666

Quoted 7 lines
hw/s390x/s390-pci-bus.c +0 -0
       iommu->enabled = true;
       memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
       g_free(name);
#7 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

In reply to Pierre Morel
Quoted 45 lines · On Wed, 16 Jan 2019 15:16:44 +0100 Pierre Morel <[email protected]> wrote:
Quoted 35 lines · Halil Pasic
Quoted 13 lines · On Tue, 15 Jan 2019 10:35:42 -0500 Collin Walling <[email protected]> wrote:
Quoted 12 lines · Pierre Morel

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
   hw/s390x/s390-pci-bus.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 663

Quoted 10 lines
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
       char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
       memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                                TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);

From the the look of this, I would say we basically used the address
denoting the end of the region as the size of the region. This smells like a bug to me, but the commit message and the title ain't clear about this, and there is no fixes tag. Because of the latter I did some digging and came to commit f7c40aa "s390x/pci: fix failures of dma map/unmap" (Yi Min Zhao, 2016-06-19) which basically did the inverse of this commit!

Quoted 7 lines

My initial motivation was to check if this is stable material. But now I'm very confused. I'm admittedly zPCI incompetent. Could some of the people that understand what is going on help me feel better about this patch?

Regards,
Halil

Quoted 8 lines

The patch you speak about corrected the problem described in its comment by setting the offset address of the subregion to 0, making sure VFIO_PCI works for Z but introduced a bug we did not see at that time by making the subregion too large.

This patch correct the bug, I can add a reference to this with:
fixing: commit f7c40aa1e7feb50bc4d4bc171fa811bdd9a93e51

@Connie, will you add the Fixes tag? Do we need a cc stable (since broken since 2016-06-19)?

@Pierre: So you say it's a bug. What can go wrong because of this? For example if we interpret pal as a size, I guess we could end up with the memory region not fitting the guest memory, or? I'm still pretty much in the dark about the implications of this bug.

Regards,
Halil

#8 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 57 lines · Halil Pasic
Quoted 45 lines · On Wed, 16 Jan 2019 15:16:44 +0100 Pierre Morel <[email protected]> wrote:
Quoted 35 lines · Halil Pasic
Quoted 13 lines · On Tue, 15 Jan 2019 10:35:42 -0500 Collin Walling <[email protected]> wrote:
Quoted 12 lines · Pierre Morel

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
    hw/s390x/s390-pci-bus.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

hw/s390x/s390-pci-bus.c void s390_pci_iommu_enable(S390PCIIOMMU *iommu) · line 663

Quoted 10 lines
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
        char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
        memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                                 TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);

From the the look of this, I would say we basically used the address
denoting the end of the region as the size of the region. This smells like a bug to me, but the commit message and the title ain't clear about this, and there is no fixes tag. Because of the latter I did some digging and came to commit f7c40aa "s390x/pci: fix failures of dma map/unmap" (Yi Min Zhao, 2016-06-19) which basically did the inverse of this commit!

Quoted 7 lines

My initial motivation was to check if this is stable material. But now I'm very confused. I'm admittedly zPCI incompetent. Could some of the people that understand what is going on help me feel better about this patch?

Regards,
Halil

Quoted 8 lines

The patch you speak about corrected the problem described in its comment by setting the offset address of the subregion to 0, making sure VFIO_PCI works for Z but introduced a bug we did not see at that time by making the subregion too large.

This patch correct the bug, I can add a reference to this with:
fixing: commit f7c40aa1e7feb50bc4d4bc171fa811bdd9a93e51

Quoted 7 lines

@Connie, will you add the Fixes tag? Do we need a cc stable (since broken since 2016-06-19)?

@Pierre: So you say it's a bug.
What can go wrong because of this?
For example if we interpret pal as a size, I guess we could end up with the memory region not fitting the guest memory,

The memory region will be too large compared with what the guest required.

Quoted 6 lines

or? I'm still pretty
much in the dark about the implications of this bug.

Regards,
Halil

Signature · 2 lines
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
#9 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 11 lines · On Wed, 16 Jan 2019 16:44:09 +0100 Pierre Morel <[email protected]> wrote:
Quoted 7 lines · Halil Pasic

@Connie, will you add the Fixes tag? Do we need a cc stable (since broken since 2016-06-19)?

@Pierre: So you say it's a bug.
What can go wrong because of this?
For example if we interpret pal as a size, I guess we could end up with the memory region not fitting the guest memory,

The memory region will be too large compared with what the guest required.

Honestly, this does not look like QEMU stable material to me.

#10 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 8 lines · On Wed, 16 Jan 2019 17:41:30 +0100 Cornelia Huck <[email protected]> wrote:
Quoted 5 lines · On Wed, 16 Jan 2019 16:44:09 +0100 Pierre Morel <[email protected]> wrote:
Quoted 3 lines · Halil Pasic

@Connie, will you add the Fixes tag? Do we need a cc stable (since broken since 2016-06-19)?

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines

@Pierre: So you say it's a bug.
What can go wrong because of this?
For example if we interpret pal as a size, I guess we could end up with the memory region not fitting the guest memory,

The memory region will be too large compared with what the guest required.

Honestly, this does not look like QEMU stable material to me.

Based on Pierre's offline explanation, from which I understood, the worst thing that can happen is, that a buggy guest can render it's pci function unusable, I have to agree: not stable material.

My problem is my non-existent understanding of zPCI. My intuition was this should be much nastier than that. I would have appreciated a better explanation on why this is not a problem in practice though -- best as a part of the commit message.

Regards,
Halil

#11 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

In reply to Pierre Morel
Quoted 11 lines · On Thu, 10 Jan 2019 14:00:07 +0100 Pierre Morel <[email protected]> wrote:

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

---
 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.

#12 lore raw

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

Quoted 10 lines · Cornelia Huck
Quoted 7 lines · On Thu, 10 Jan 2019 14:00:07 +0100 Pierre Morel <[email protected]> wrote:

The size of the accessible iommu memory region in the guest is given to the IOMMU by the guest through the mpcifc request specifying the PCI Base Address and the PCI Address Limit.

Let set the size of the IOMMU region to:
(PCI Address Limit) - (PCI Base Address) + 1.

Quoted 7 lines
Quoted 4 lines
---
  hw/s390x/s390-pci-bus.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.

Thanks. :)

Signature · 2 lines
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany