Skip to contentSkip to conversation

s390x/pci: Set the iommu region size as guest wants

PATCH Superseded Pierre Morel 2 participants 3 messages Jan 8, 2019 – Jan 10, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x/pci: Set the iommu region size as guest wants

The size of the accessible iommu memory region in the guest is calculated by the gues as:
(PCI Address Limit) - (PCI Base Address) + 1.

Let's use this value to limit the IOMMU region size.

---
 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
     char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
     memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                              TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);
     iommu->enabled = true;
     memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
     g_free(name);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · On Tue, 8 Jan 2019 18:33:39 +0100 Pierre Morel <[email protected]> wrote:

The size of the accessible iommu memory region in the guest is calculated by the gues as:

s/gues/guest/

Quoted 3 lines

(PCI Address Limit) - (PCI Base Address) + 1.

Let's use this value to limit the IOMMU region size.

These are values provided by the guest in the mpcifc call, aren't they? Let's mention that in the patch description, so it is more obvious :)

Quoted 19 lines
---
 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/s390x/s390-pci-bus.c +1 -1
index 69e0671..e97696a 100644
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
     char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
     memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
                              TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
-                             name, iommu->pal + 1);
+                             name, iommu->pal - iommu->pba + 1);
     iommu->enabled = true;
     memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
     g_free(name);
#2 lore raw
Quoted 6 lines · Cornelia Huck
Quoted 2 lines · On Tue, 8 Jan 2019 18:33:39 +0100 Pierre Morel <[email protected]> wrote:

The size of the accessible iommu memory region in the guest is calculated by the gues as:

Quoted 9 lines

s/gues/guest/

Quoted 3 lines

(PCI Address Limit) - (PCI Base Address) + 1.

Let's use this value to limit the IOMMU region size.

These are values provided by the guest in the mpcifc call, aren't they? Let's mention that in the patch description, so it is more obvious :)

OK thanks.

Regards,
Pierre

Signature · 2 lines
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany