Skip to contentSkip to conversation

tracing: initialize variable in create_dyn_event()

PATCH Superseded [email protected] 3 participants 5 messages Jan 25, 2019 – Mar 15, 2019 Tracing

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: initialize variable in create_dyn_event()

From: Frank Rowand <[email protected]>

Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized].

Fixes 5448d44c3855 ("tracing: Add unified dynamic event framework")

---

Compile and boot tested only. Please verify the initialization value of zero is correct.

There is also a sparse warning you might want to check into (when ARCH=arm, so 32 bit):

include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

 kernel/trace/trace_dynevent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_dynevent.c +1 -1
index dd1f43588d70..4f633476c307 100644
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
 static int create_dyn_event(int argc, char **argv)
 {
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = 0;
 
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
Signature · 1 line
Frank Rowand <[email protected]>
#1 lore raw

Hi Steve,

Ping.

-Frank

Quoted 36 lines · On 1/24/19 6:17 PM, [email protected] wrote:

From: Frank Rowand <[email protected]>

Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized].

Fixes 5448d44c3855 ("tracing: Add unified dynamic event framework")

---

Compile and boot tested only. Please verify the initialization value of zero is correct.

There is also a sparse warning you might want to check into (when ARCH=arm, so 32 bit):

include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

 kernel/trace/trace_dynevent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_dynevent.c +1 -1
index dd1f43588d70..4f633476c307 100644
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
 static int create_dyn_event(int argc, char **argv)
 {
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = 0;
 
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
maintainer
#2 lore raw
Quoted 3 lines · On Thu, 14 Mar 2019 14:05:02 -0700 Frank Rowand <[email protected]> wrote:

Hi Steve,

Ping.

Thanks, this got buried.

Quoted 5 lines

kernel/trace/trace_dynevent.c int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type) · line 77

Quoted 5 lines

static int create_dyn_event(int argc, char **argv) {

kernel/trace/trace_dynevent.c +1 -1
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = 0;

Probably should be ret = -ENODEV;

As if ret doesn't get set, then no dynamic code has been registered, and something is truly wrong.

-- Steve

Quoted 4 lines
Quoted 4 lines
kernel/trace/trace_dynevent.c +0 -0
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
maintainer
#3 lore raw

Hi Frank and Steve,

Thank you for pointing it out :)

Quoted 17 lines · On Thu, 14 Mar 2019 18:19:08 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 3 lines · On Thu, 14 Mar 2019 14:05:02 -0700 Frank Rowand <[email protected]> wrote:

Hi Steve,

Ping.

Thanks, this got buried.

Quoted 5 lines

kernel/trace/trace_dynevent.c int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type) · line 77

Quoted 5 lines

static int create_dyn_event(int argc, char **argv) {

kernel/trace/trace_dynevent.c +1 -1
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = 0;

Probably should be ret = -ENODEV;

Quoted 2 lines

As if ret doesn't get set, then no dynamic code has been registered, and something is truly wrong.

I Agreed to return -ENODEV instead of 0.

Thank you,

Quoted 9 lines

-- Steve

Quoted 4 lines
Quoted 4 lines
kernel/trace/trace_dynevent.c +0 -0
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
Signature · 1 line
Masami Hiramatsu <[email protected]>
#4 lore raw
Quoted 24 lines · Masami Hiramatsu

Hi Frank and Steve,

Thank you for pointing it out :)

Quoted 17 lines · On Thu, 14 Mar 2019 18:19:08 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 3 lines · On Thu, 14 Mar 2019 14:05:02 -0700 Frank Rowand <[email protected]> wrote:

Hi Steve,

Ping.

Thanks, this got buried.

Quoted 5 lines

kernel/trace/trace_dynevent.c int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type) · line 77

Quoted 5 lines

static int create_dyn_event(int argc, char **argv) {

kernel/trace/trace_dynevent.c +1 -1
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = 0;

Probably should be ret = -ENODEV;

Quoted 18 lines
Quoted 2 lines

As if ret doesn't get set, then no dynamic code has been registered, and something is truly wrong.

I Agreed to return -ENODEV instead of 0.

Thank you,

Quoted 9 lines

-- Steve

Quoted 4 lines
Quoted 4 lines
kernel/trace/trace_dynevent.c +0 -0
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);

Thanks, I'll fix and resend.