x86/altp2m: Fix build with !CONFIG_HVM
PATCH 1/1 x86/altp2m: Fix build with !CONFIG_HVM
c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.
Introduce one to fix the build.
Spotted by Travis.
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Juergen Gross <[email protected]>
--- xen/include/asm-x86/altp2m.h | 1 + 1 file changed, 1 insertion(+)
xen/include/asm-x86/altp2m.h +1 -0
@@ -50,6 +50,7 @@ static inline bool altp2m_active(const struct domain *d)/* Only declaration is needed. DCE will optimise it out when linking. */ uint16_t altp2m_vcpu_idx (const struct vcpu *v); +void altp2m_vcpu_disable_ve (struct vcpu *v);#endif
Signature · 7 lines
2.1.4 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Andrew Cooper
c/s
0ec9b4ef3148"x86/vmx: Fix security issue when a guest balloons out the c/se72ecc761541"x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.Introduce one to fix the build.
Spotted by Travis.
I think you meant Gitlab CI?
Quoted 2 lines
Signed-off-by Andrew Cooper <[email protected]>
Quoted 24 lines
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Juergen Gross <[email protected]>--- xen/include/asm-x86/altp2m.h | 1 + 1 file changed, 1 insertion(+)xen/include/asm-x86/altp2m.h +1
-0@@ -50,6 +50,7 @@ static inline bool altp2m_active(const struct domain *d)/* Only declaration is needed. DCE will optimise it out when linking. */ uint16_t altp2m_vcpu_idx (const struct vcpu *v); +void altp2m_vcpu_disable_ve (struct vcpu *v);#endif Signature · 1 line
2.1.4
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 9 lines · Wei Liu
Quoted 7 lines · Andrew Cooper
c/s
0ec9b4ef3148"x86/vmx: Fix security issue when a guest balloons out the c/se72ecc761541"x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.Introduce one to fix the build.
Spotted by Travis.
I think you meant Gitlab CI?
Nope.
https://travis-ci.org/andyhhp/xen/builds/499776732
Gitlab doesn't appear to have noticed yet.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 6 lines · Andrew Cooper
Quoted 5 lines · Wei Liu
Quoted 4 lines · Andrew Cooper
c/s
0ec9b4ef3148"x86/vmx: Fix security issue when a guest balloons out the c/se72ecc761541"x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
Introduce one to fix the build.
Spotted by Travis.
I think you meant Gitlab CI?
Nope.
Oh, I forgot they used the same script. Sorry for the noise.
Wei.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 28.02.19 at 13:51, <[email protected]> wrote:
c/s
0ec9b4ef3148"x86/vmx: Fix security issue when a guest balloons out the c/se72ecc761541"x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.Introduce one to fix the build.
Spotted by Travis.
Signed-off-by Andrew Cooper <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 1 line · Andrew Cooper
c/s
0ec9b4ef3148"x86/vmx: Fix security issue when a guest balloons out the
Lovely, and git too out the line starting with #VE here.
I'll adjust suitably on commit.
~Andrew
Quoted 2 lines
c/s
e72ecc761541"x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 9 lines · Andrew Cooper
c/s
0ec9b4ef3148"x86/vmx: Fix security issue when a guest balloons out the c/se72ecc761541"x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.Introduce one to fix the build.
Spotted by Travis.
Signed-off-by Andrew Cooper <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel