Skip to contentSkip to conversation

x86/altp2m: Fix build with !CONFIG_HVM

PATCH In review Andrew Cooper 4 participants 7 messages Feb 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/altp2m: Fix build with !CONFIG_HVM

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

Introduce one to fix the build.

Spotted by Travis.

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Juergen Gross <[email protected]>

---
 xen/include/asm-x86/altp2m.h | 1 +
 1 file changed, 1 insertion(+)
xen/include/asm-x86/altp2m.h +1 -0
index 8139bf8..b206e95 100644
@@ -50,6 +50,7 @@ static inline bool altp2m_active(const struct domain *d)
 
 /* Only declaration is needed. DCE will optimise it out when linking. */
 uint16_t altp2m_vcpu_idx(const struct vcpu *v);
+void altp2m_vcpu_disable_ve(struct vcpu *v);
 
 #endif
 
Signature · 7 lines
2.1.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Andrew Cooper

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

Introduce one to fix the build.

Spotted by Travis.

I think you meant Gitlab CI?

Quoted 2 lines
Quoted 24 lines

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Juergen Gross <[email protected]>

---
 xen/include/asm-x86/altp2m.h | 1 +
 1 file changed, 1 insertion(+)
xen/include/asm-x86/altp2m.h +1 -0
index 8139bf8..b206e95 100644
@@ -50,6 +50,7 @@ static inline bool altp2m_active(const struct domain *d)
 
 /* Only declaration is needed. DCE will optimise it out when linking. */
 uint16_t altp2m_vcpu_idx(const struct vcpu *v);
+void altp2m_vcpu_disable_ve(struct vcpu *v);
 
 #endif
 
Signature · 1 line
2.1.4

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 9 lines · Wei Liu
Quoted 7 lines · Andrew Cooper

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

Introduce one to fix the build.

Spotted by Travis.

I think you meant Gitlab CI?

Nope.

https://travis-ci.org/andyhhp/xen/builds/499776732

Gitlab doesn't appear to have noticed yet.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 6 lines · Andrew Cooper
Quoted 5 lines · Wei Liu
Quoted 4 lines · Andrew Cooper

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

Introduce one to fix the build.

Spotted by Travis.

I think you meant Gitlab CI?

Nope.

https://travis-ci.org/andyhhp/xen/builds/499776732

Oh, I forgot they used the same script. Sorry for the noise.

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#4 lore raw
In reply to Andrew Cooper
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 28.02.19 at 13:51, <[email protected]> wrote:

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

Introduce one to fix the build.

Spotted by Travis.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
In reply to Andrew Cooper
Quoted 1 line · Andrew Cooper

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the

Lovely, and git too out the line starting with #VE here.

I'll adjust suitably on commit.

~Andrew

Quoted 2 lines

c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
In reply to Andrew Cooper
Quoted 9 lines · Andrew Cooper

c/s 0ec9b4ef3148 "x86/vmx: Fix security issue when a guest balloons out the c/s e72ecc761541 "x86/altp2m: Rework #VE enable/disable paths" didn't have a suitable prototype in the !CONFIG_HVM case.

Introduce one to fix the build.

Spotted by Travis.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel