pwm: imx27: use devm_platform_ioremap_resource() to simplify code
Subsystems (2)
PATCH 1/1 pwm: imx27: use devm_platform_ioremap_resource() to simplify code
Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.
--- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-imx27.c +1 -3
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);static int pwm_imx27_probe (struct platform_device *pdev) {struct pwm_imx27_chip *imx; -struct resource *r; imx =devm_kzalloc (&pdev->dev,sizeof (*imx),GFP_KERNEL );if (imx ==NULL )
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) imx->chip.of_xlate = of_pwm_xlate_with_flags; imx->chip.of_pwm_n_cells =3 ; - r =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - imx->mmio_base =devm_ioremap_resource (&pdev->dev, r); + imx->mmio_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (imx->mmio_base))return PTR_ERR (imx->mmio_base);
Signature · 1 line
2.7.4
Quoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>
Cheers,
-Mukesh
Quoted 26 lines
--- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/pwm/pwm-imx27.c +1
-3@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);static int pwm_imx27_probe (struct platform_device *pdev) {struct pwm_imx27_chip *imx; -struct resource *r; imx =devm_kzalloc (&pdev->dev,sizeof (*imx),GFP_KERNEL );if (imx ==NULL )@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) imx->chip.of_xlate = of_pwm_xlate_with_flags; imx->chip.of_pwm_n_cells =3 ; - r =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - imx->mmio_base =devm_ioremap_resource (&pdev->dev, r); + imx->mmio_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (imx->mmio_base))return PTR_ERR (imx->mmio_base);
Quoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>
Cheers,
-Mukesh
Quoted 26 lines
--- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/pwm/pwm-imx27.c +1
-3@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);static int pwm_imx27_probe (struct platform_device *pdev) {struct pwm_imx27_chip *imx; -struct resource *r; imx =devm_kzalloc (&pdev->dev,sizeof (*imx),GFP_KERNEL );if (imx ==NULL )@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) imx->chip.of_xlate = of_pwm_xlate_with_flags; imx->chip.of_pwm_n_cells =3 ; - r =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - imx->mmio_base =devm_ioremap_resource (&pdev->dev, r); + imx->mmio_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (imx->mmio_base))return PTR_ERR (imx->mmio_base);
Quoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>
Cheers,
-Mukesh
Quoted 26 lines
--- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/pwm/pwm-imx27.c +1
-3@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);static int pwm_imx27_probe (struct platform_device *pdev) {struct pwm_imx27_chip *imx; -struct resource *r; imx =devm_kzalloc (&pdev->dev,sizeof (*imx),GFP_KERNEL );if (imx ==NULL )@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) imx->chip.of_xlate = of_pwm_xlate_with_flags; imx->chip.of_pwm_n_cells =3 ; - r =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - imx->mmio_base =devm_ioremap_resource (&pdev->dev, r); + imx->mmio_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (imx->mmio_base))return PTR_ERR (imx->mmio_base);
Ping...
Quoted 52 lines
-----Original Message-----
From: Mukesh Ojha [mailto:[email protected]]
Sent: Monday, April 1, 2019 4:01 PM
To: Anson Huang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux-arm- [email protected]; [email protected]
Cc: dl-linux-imx <[email protected]>
Subject: Re: [PATCH] pwm: imx27: usedevm_platform_ioremap_resource()to simplify codeQuoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>Reviewed-by Mukesh Ojha <[email protected]>Cheers,
-Mukeshdrivers/pwm/pwm-imx27.c static int pwm_imx27_probe(struct
Quoted 17 lines
--- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/pwm/pwm-imx27.c index renamed from drivers/pwm/pwm-imx27.c +0
-08061306..434a351 100644
drivers/pwm/pwm-imx27.c +0
-1@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);static int pwm_imx27_probe (struct platform_device *pdev) {struct pwm_imx27_chip *imx; -struct resource *r; imx =devm_kzalloc (&pdev->dev,sizeof (*imx),GFP_KERNEL );if (imx ==NULL )@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct
platform_device*pdev)Quoted 9 lines
drivers/pwm/pwm-imx27.c +1
-2imx->chip.of_xlate = of_pwm_xlate_with_flags; imx->chip.of_pwm_n_cells =3 ; - r =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - imx->mmio_base =devm_ioremap_resource (&pdev->dev, r); + imx->mmio_base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (imx->mmio_base))return PTR_ERR (imx->mmio_base);
Thierry Reding
AppliedQuoted 8 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>--- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
Thierry