Skip to contentSkip to conversation

pwm: imx27: use devm_platform_ioremap_resource() to simplify code

PATCH Applied Anson Huang 4 participants 7 messages Apr 1, 2019 – May 9, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwm: imx27: use devm_platform_ioremap_resource() to simplify code

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

---
 drivers/pwm/pwm-imx27.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-imx27.c +1 -3
index 8061306..434a351 100644
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
 static int pwm_imx27_probe(struct platform_device *pdev)
 {
 	struct pwm_imx27_chip *imx;
-	struct resource *r;
 
 	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
 	if (imx == NULL)
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
 	imx->chip.of_xlate = of_pwm_xlate_with_flags;
 	imx->chip.of_pwm_n_cells = 3;
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
+	imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(imx->mmio_base))
 		return PTR_ERR(imx->mmio_base);
 
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#2 lore raw
In reply to Anson Huang
Quoted 5 lines · Anson Huang

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

Cheers,
-Mukesh

Quoted 26 lines
---
  drivers/pwm/pwm-imx27.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-imx27.c +1 -3
index 8061306..434a351 100644
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
  static int pwm_imx27_probe(struct platform_device *pdev)
  {
  	struct pwm_imx27_chip *imx;
-	struct resource *r;
 
  	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
  	if (imx == NULL)
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
  	imx->chip.of_xlate = of_pwm_xlate_with_flags;
  	imx->chip.of_pwm_n_cells = 3;
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
+	imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(imx->mmio_base))
  		return PTR_ERR(imx->mmio_base);
 
Reviewed-by on v1 1/1
#3 lore raw
In reply to Anson Huang
Quoted 5 lines · Anson Huang

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

Cheers,
-Mukesh

Quoted 26 lines
---
  drivers/pwm/pwm-imx27.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-imx27.c +1 -3
index 8061306..434a351 100644
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
  static int pwm_imx27_probe(struct platform_device *pdev)
  {
  	struct pwm_imx27_chip *imx;
-	struct resource *r;
 
  	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
  	if (imx == NULL)
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
  	imx->chip.of_xlate = of_pwm_xlate_with_flags;
  	imx->chip.of_pwm_n_cells = 3;
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
+	imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(imx->mmio_base))
  		return PTR_ERR(imx->mmio_base);
 
Reviewed-by on v1 1/1
#4 lore raw
In reply to Anson Huang
Quoted 5 lines · Anson Huang

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

Cheers,
-Mukesh

Quoted 26 lines
---
  drivers/pwm/pwm-imx27.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-imx27.c +1 -3
index 8061306..434a351 100644
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
  static int pwm_imx27_probe(struct platform_device *pdev)
  {
  	struct pwm_imx27_chip *imx;
-	struct resource *r;
 
  	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
  	if (imx == NULL)
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
  	imx->chip.of_xlate = of_pwm_xlate_with_flags;
  	imx->chip.of_pwm_n_cells = 3;
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
+	imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(imx->mmio_base))
  		return PTR_ERR(imx->mmio_base);
 
#5 lore raw

Ping...

Quoted 52 lines

-----Original Message-----
From: Mukesh Ojha [mailto:[email protected]]
Sent: Monday, April 1, 2019 4:01 PM
To: Anson Huang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux-arm- [email protected]; [email protected]
Cc: dl-linux-imx <[email protected]>
Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code

Quoted 5 lines · Anson Huang

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

Cheers,
-Mukesh

drivers/pwm/pwm-imx27.c static int pwm_imx27_probe(struct

Quoted 17 lines
---
  drivers/pwm/pwm-imx27.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pwm/pwm-imx27.c index renamed from drivers/pwm/pwm-imx27.c +0 -0

8061306..434a351 100644

drivers/pwm/pwm-imx27.c +0 -1
@@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
  static int pwm_imx27_probe(struct platform_device *pdev)
  {
  	struct pwm_imx27_chip *imx;
-	struct resource *r;
 
  	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
  	if (imx == NULL)
@@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct

platform_device *pdev)

Quoted 9 lines
drivers/pwm/pwm-imx27.c +1 -2
  	imx->chip.of_xlate = of_pwm_xlate_with_flags;
  	imx->chip.of_pwm_n_cells = 3;
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
+	imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(imx->mmio_base))
  		return PTR_ERR(imx->mmio_base);
 
#6 lore raw
In reply to Anson Huang
Quoted 8 lines · Anson Huang

Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.

---
 drivers/pwm/pwm-imx27.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

Thierry