ASoC: codec: hdac_hdmi: no checking monitor in hw_params
PATCH 1/1 ASoC: codec: hdac_hdmi: no checking monitor in hw_params
From: Libin Yang <[email protected]>
Some userspace apps, like pulseaudio, may call open, hw_params, prepare to judge whether the pcm is ready or not. Current hdac_hdmi will return -ENODEV if monitor is not connected, which will cause the apps believe the pcm is not ready. Actually PCM for hdmi is ready, even the monitor is not connected.
This patch removes the check of monitor presence in hw_params, just like what the legacy HD-Audio driver does.
--- sound/soc/codecs/hdac_hdmi.c | 13 ------------- 1 file changed, 13 deletions(-)
sound/soc/codecs/hdac_hdmi.c +0 -13
@@ -455,24 +455,11 @@ static int hdac_hdmi_set_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *hparams, struct snd_soc_dai *dai) { struct hdac_hdmi_priv *hdmi = snd_soc_dai_get_drvdata(dai); -struct hdac_device *hdev = hdmi->hdev;struct hdac_hdmi_dai_port_map *dai_map; -struct hdac_hdmi_port *port;struct hdac_hdmi_pcm *pcm;int format; dai_map = &hdmi->dai_map[dai->id]; - port = dai_map->port; - -if (!port) -return -ENODEV ; - -if ((!port->eld.monitor_present) || (!port->eld.eld_valid)) { -dev_err (&hdev->dev, -"device is not configured for this pin:port%d:%d\n" , - port->pin->nid, port->id); -return -ENODEV ; - } format = snd_hdac_calc_stream_format(params_rate(hparams), params_channels(hparams), params_format(hparams),
Signature · 1 line
2.7.4
Quoted 9 lines · On Tue, 07 May 2019 08:33:11 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
Some userspace apps, like pulseaudio, may call open,
hw_params, prepare to judge whether the pcm is ready or not. Currenthdac_hdmiwill return-ENODEVif monitor is not connected, which will cause the apps believe the pcm is not ready. Actually PCM for hdmi is ready, even the monitor is not connected.
Quoted 4 lines
This patch removes the check of monitor presence in
hw_params, just like what the legacy HD-Audio driver does.Signed-off-by Libin Yang <[email protected]>
LTGM,
thanks,
Takashi
Pierre-Louis Bossart
Acked-byQuoted 11 lines · Takashi Iwai
Quoted 9 lines · On Tue, 07 May 2019 08:33:11 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
Some userspace apps, like pulseaudio, may call open,
hw_params, prepare to judge whether the pcm is ready or not. Currenthdac_hdmiwill return-ENODEVif monitor is not connected, which will cause the apps believe the pcm is not ready. Actually PCM for hdmi is ready, even the monitor is not connected.
Quoted 7 lines
Quoted 4 lines
This patch removes the check of monitor presence in
hw_params, just like what the legacy HD-Audio driver does.Signed-off-by Libin Yang <[email protected]>LTGM,
Reviewed-by Takashi Iwai <[email protected]>
Quoted 10 lines
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainerApplied "ASoC: codec: hdac_hdmi: no checking monitor in hw_params" to the asoc tree
In reply to [email protected]The patch
ASoC: codec: hdac_hdmi: no checking monitor in hw_params
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
939507f2779836919271ba0311723d1001d3993bMon Sep 17 00:00:00 2001
From: Libin Yang <[email protected]>
Date: Tue, 7 May 2019 14:33:11 +0800
Subject: [PATCH] ASoC: codec: hdac_hdmi: no checking monitor in hw_params
Some userspace apps, like pulseaudio, may call open, hw_params, prepare to judge whether the pcm is ready or not. Current hdac_hdmi will return -ENODEV if monitor is not connected, which will cause the apps believe the pcm is not ready. Actually PCM for hdmi is ready, even the monitor is not connected.
This patch removes the check of monitor presence in hw_params, just like what the legacy HD-Audio driver does.
--- sound/soc/codecs/hdac_hdmi.c | 13 ------------- 1 file changed, 13 deletions(-)
sound/soc/codecs/hdac_hdmi.c +0 -13
@@ -455,24 +455,11 @@ static int hdac_hdmi_set_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *hparams, struct snd_soc_dai *dai) { struct hdac_hdmi_priv *hdmi = snd_soc_dai_get_drvdata(dai); -struct hdac_device *hdev = hdmi->hdev;struct hdac_hdmi_dai_port_map *dai_map; -struct hdac_hdmi_port *port;struct hdac_hdmi_pcm *pcm;int format; dai_map = &hdmi->dai_map[dai->id]; - port = dai_map->port; - -if (!port) -return -ENODEV ; - -if ((!port->eld.monitor_present) || (!port->eld.eld_valid)) { -dev_err (&hdev->dev, -"device is not configured for this pin:port%d:%d\n" , - port->pin->nid, port->id); -return -ENODEV ; - } format = snd_hdac_calc_stream_format(params_rate(hparams), params_channels(hparams), params_format(hparams),
Signature · 1 line
2.20.1