Skip to contentSkip to conversation

riscv: qemu: Enable PCI host ECAM generic driver

PATCH New Bin Meng 3 participants 12 messages May 15, 2019 – Jun 5, 2019 1 message not in the archive RISC-V

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
board/emulation/qemu-riscv/Kconfig +4 -0
index 20ea6dc..2a03e43 100644
@@ -36,5 +36,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply OF_BOARD_SETUP
 	imply SIFIVE_SERIAL
 	imply SMP
+	imply PCI
+	imply DM_PCI
+	imply PCIE_ECAM_GENERIC
+	imply CMD_PCI
 
 endif
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 riscv: qemu: Enable e1000 and nvme support

Since we have added the PCI support to the 'virt' target, enable e1000 and NVME as alternate network and storage devices for these virtio based devices.

---

 board/emulation/qemu-riscv/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
board/emulation/qemu-riscv/Kconfig +2 -0
index 2a03e43..7f9a74d 100644
@@ -40,5 +40,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply DM_PCI
 	imply PCIE_ECAM_GENERIC
 	imply CMD_PCI
+	imply E1000
+	imply NVME
 
 endif
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 riscv: qemu: Enable e1000 and nvme support

Quoted 15 lines · Bin Meng

Since we have added the PCI support to the 'virt' target, enable e1000 and NVME as alternate network and storage devices for these virtio based devices.

---

 board/emulation/qemu-riscv/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
board/emulation/qemu-riscv/Kconfig +0 -0
index 2a03e43..7f9a74d 100644

board/emulation/qemu-riscv/Kconfig config BOARD_SPECIFIC_OPTIONS # dummy · line 46

Quoted 7 lines
board/emulation/qemu-riscv/Kconfig +2 -0
@@ -40,5 +40,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply DM_PCI
 	imply PCIE_ECAM_GENERIC
 	imply CMD_PCI
+	imply E1000
+	imply NVME
 
 endif

Tested the series in QEMU master with an e1000 and a NVMe device, accessing them from U-Boot.

author
#4 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

Regards,
Bin

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi BIn

Quoted 12 lines

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

OK
I will apply it today.

Thanks
Rick

Quoted 2 lines

Regards,
Bin

#7 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Quoted 24 lines

Hi BIn

Quoted 21 lines

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

Applied to u-boot-riscv/master, thanks!

Quoted 9 lines

OK
I will apply it today.

Thanks
Rick

Quoted 2 lines

Regards,
Bin

author
#8 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi Rick,

Quoted 20 lines · Rick Chen
Quoted 20 lines

Hi BIn

Quoted 16 lines

Hi Rick,

Quoted 12 lines · Lukas
Quoted 9 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

Could you please apply this series for v2019.07?

Applied to u-boot-riscv/master, thanks!

Thanks for applying.

By searching riscv patches from patchwork, it seems there are some old patches that are not cleaned up. I am not sure about their status. Maybe they are already applied.

http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=

Could you please do some house keeping?

Regards,
Bin

#9 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi Bin

Bin Meng <[email protected]> 於 2019年6月4日 週二 下午2:27寫道:

Quoted 30 lines

Hi Rick,

Quoted 26 lines · Rick Chen
Quoted 25 lines

Hi BIn

Quoted 21 lines

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

Quoted 7 lines
Quoted 1 line

Applied to u-boot-riscv/master, thanks!

Thanks for applying.

By searching riscv patches from patchwork, it seems there are some old patches that are not cleaned up. I am not sure about their status. Maybe they are already applied.

I will rebase to u-boot/master before applying the patchs. If they are already applied, there will have conflictions, right ?

Quoted 4 lines

http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=

Could you please do some house keeping?

I am not sure what do you mean about house keeping ?

Quoted 3 lines

Regards,
Bin

author
#10 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi Rick,

Quoted 36 lines · Rick Chen

Hi Bin

Bin Meng <[email protected]> 於 2019年6月4日 週二 下午2:27寫道:

Quoted 32 lines

Hi Rick,

Quoted 27 lines · Rick Chen
Quoted 25 lines

Hi BIn

Quoted 21 lines

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

Applied to u-boot-riscv/master, thanks!

Quoted 9 lines
Quoted 5 lines

Thanks for applying.

By searching riscv patches from patchwork, it seems there are some old patches that are not cleaned up. I am not sure about their status. Maybe they are already applied.

I will rebase to u-boot/master before applying the patchs. If they are already applied, there will have conflictions, right ?

Not sure if there will be conflicts, so simply not applied (skipped). You can try.

Quoted 6 lines
Quoted 4 lines

http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=

Could you please do some house keeping?

I am not sure what do you mean about house keeping ?

I meant that you should clean up all these patches in your queue. Either mark them as accepted, or superseded, etc.

Regards,
Bin

#11 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi Bin

Bin Meng <[email protected]> 於 2019年6月5日 週三 下午5:29寫道:

Quoted 54 lines

Hi Rick,

Quoted 36 lines · Rick Chen

Hi Bin

Bin Meng <[email protected]> 於 2019年6月4日 週二 下午2:27寫道:

Quoted 32 lines

Hi Rick,

Quoted 27 lines · Rick Chen
Quoted 25 lines

Hi BIn

Quoted 21 lines

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

Applied to u-boot-riscv/master, thanks!

Quoted 9 lines
Quoted 5 lines

Thanks for applying.

By searching riscv patches from patchwork, it seems there are some old patches that are not cleaned up. I am not sure about their status. Maybe they are already applied.

I will rebase to u-boot/master before applying the patchs. If they are already applied, there will have conflictions, right ?

Not sure if there will be conflicts, so simply not applied (skipped). You can try.

Quoted 1 line
Quoted 1 line
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=

Could you please do some house keeping?

I am not sure what do you mean about house keeping ?

I meant that you should clean up all these patches in your queue. Either mark them as accepted, or superseded, etc.

I just applied your patchs yesterday. And its state became Accepted.
https://patchwork.ozlabs.org/project/uboot/list/?order=delegate&state=*

I thought it will change by my actions automatically. How can I change state from New to Accepted ?

Thanks
Rick

Quoted 2 lines

Regards,
Bin

author
#12 lore raw

PATCH 1/2 riscv: qemu: Enable PCI host ECAM generic driver

Hi Rick,

Quoted 62 lines · Rick Chen

Hi Bin

Bin Meng <[email protected]> 於 2019年6月5日 週三 下午5:29寫道:

Quoted 58 lines

Hi Rick,

Quoted 36 lines · Rick Chen

Hi Bin

Bin Meng <[email protected]> 於 2019年6月4日 週二 下午2:27寫道:

Quoted 32 lines

Hi Rick,

Quoted 27 lines · Rick Chen
Quoted 25 lines

Hi BIn

Quoted 21 lines

Hi Rick,

Quoted 8 lines · Lukas
Quoted 6 lines · Bin Meng

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host. Enable the driver for it.

---

Quoted 6 lines
Quoted 3 lines
 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Could you please apply this series for v2019.07?

Applied to u-boot-riscv/master, thanks!

Quoted 9 lines
Quoted 5 lines

Thanks for applying.

By searching riscv patches from patchwork, it seems there are some old patches that are not cleaned up. I am not sure about their status. Maybe they are already applied.

I will rebase to u-boot/master before applying the patchs. If they are already applied, there will have conflictions, right ?

Not sure if there will be conflicts, so simply not applied (skipped). You can try.

Quoted 5 lines
Quoted 4 lines

http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=

Could you please do some house keeping?

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

I am not sure what do you mean about house keeping ?

I meant that you should clean up all these patches in your queue. Either mark them as accepted, or superseded, etc.

I just applied your patchs yesterday. And its state became Accepted.

I cleaned up my patches because I have the privilege to change patch status.

Quoted 3 lines

https://patchwork.ozlabs.org/project/uboot/list/?order=delegate&state=*

I thought it will change by my actions automatically.

No, it won't.

Quoted 2 lines

How can I change state from New to Accepted ?

You need change the state manually. I don't know other patches' status, so I left them to you. In the end, you are the RISC-V custodian.

Regards,
Bin