Skip to contentSkip to conversation

Panel rotation patches

PATCH Superseded Derek Basehore 5 participants 12 messages Jun 22, 2019 – Jul 2, 2019

Subsystems (6)

v3 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

v3 cover Panel rotation patches

This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present.

v3 changes:
-changed from attach/detach callbacks to directly setting fixed panel
values in drm_panel_attach
-removed update to Documentation
-added separate function for quirked panel orientation property init

v2 changes:
fixed build errors in i915

Derek Basehore (4):
drm/panel: Add helper for reading DT rotation drm/panel: set display info in panel attach drm/connector: Split out orientation quirk detection drm/mtk: add panel orientation property

 drivers/gpu/drm/drm_connector.c    | 45 ++++++++++++++-----
 drivers/gpu/drm/drm_panel.c        | 70 ++++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_dp.c    |  4 +-
 drivers/gpu/drm/i915/vlv_dsi.c     |  5 +--
 drivers/gpu/drm/mediatek/mtk_dsi.c |  8 ++++
 include/drm/drm_connector.h        |  2 +
 include/drm/drm_panel.h            | 21 +++++++++
 7 files changed, 138 insertions(+), 17 deletions(-)
Signature · 6 lines
2.22.0.410.gd8fdbe21b5-goog

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v3 1/4 drm/panel: Add helper for reading DT rotation

This adds a helper function for reading the rotation (panel orientation) from the device tree.

---
 drivers/gpu/drm/drm_panel.c | 42 +++++++++++++++++++++++++++++++++++++
 include/drm/drm_panel.h     |  7 +++++++
 2 files changed, 49 insertions(+)
drivers/gpu/drm/drm_panel.c +42 -0
index dbd5b873e8f2..507099af4b57 100644
@@ -172,6 +172,48 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)
 	return ERR_PTR(-EPROBE_DEFER);
 }
 EXPORT_SYMBOL(of_drm_find_panel);
+
+/**
+ * of_drm_get_panel_orientation - look up the rotation of the panel using a
+ * device tree node
+ * @np: device tree node of the panel
+ * @orientation: orientation enum to be filled in
+ *
+ * Looks up the rotation of a panel in the device tree. The rotation in the
+ * device tree is counter clockwise.
+ *
+ * Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the
+ * rotation property doesn't exist. -EERROR otherwise.
+ */
+int of_drm_get_panel_orientation(const struct device_node *np,
+				 enum drm_panel_orientation *orientation)
+{
+	int rotation, ret;
+
+	ret = of_property_read_u32(np, "rotation", &rotation);
+	if (ret == -EINVAL) {
+		/* Don't return an error if there's no rotation property. */
+		*orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+		return 0;
+	}
+
+	if (ret < 0)
+		return ret;
+
+	if (rotation == 0)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL;
+	else if (rotation == 90)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP;
+	else if (rotation == 180)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP;
+	else if (rotation == 270)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP;
+	else
+		return -EINVAL;
+
+	return 0;
+}
+EXPORT_SYMBOL(of_drm_get_panel_orientation);
 #endif
 
 MODULE_AUTHOR("Thierry Reding <[email protected]>");
include/drm/drm_panel.h +7 -0
index 8c738c0e6e9f..3564952f1a4f 100644
@@ -197,11 +197,18 @@ int drm_panel_detach(struct drm_panel *panel);
 
 #if defined(CONFIG_OF) && defined(CONFIG_DRM_PANEL)
 struct drm_panel *of_drm_find_panel(const struct device_node *np);
+int of_drm_get_panel_orientation(const struct device_node *np,
+				 enum drm_panel_orientation *orientation);
 #else
 static inline struct drm_panel *of_drm_find_panel(const struct device_node *np)
 {
 	return ERR_PTR(-ENODEV);
 }
+int of_drm_get_panel_orientation(const struct device_node *np,
+				 enum drm_panel_orientation *orientation)
+{
+	return -ENODEV;
+}
 #endif
 
 #endif
Signature · 6 lines
2.22.0.410.gd8fdbe21b5-goog

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [PATCH v3 1/4] drm/panel: Add helper for reading DT rotation

Hi Derek.

Quoted 20 lines · Derek Basehore

This adds a helper function for reading the rotation (panel orientation) from the device tree.

---
 drivers/gpu/drm/drm_panel.c | 42 +++++++++++++++++++++++++++++++++++++
 include/drm/drm_panel.h     |  7 +++++++
 2 files changed, 49 insertions(+)
drivers/gpu/drm/drm_panel.c +3 -0
index dbd5b873e8f2..507099af4b57 100644
@@ -172,6 +172,48 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)
 	return ERR_PTR(-EPROBE_DEFER);
 }
 EXPORT_SYMBOL(of_drm_find_panel);
+
+/**
+ * of_drm_get_panel_orientation - look up the rotation of the panel using a

drivers/gpu/drm/drm_panel.c struct drm_panel *of_drm_find_panel(const struct device_node *np) · line 187

Quoted 10 lines
drivers/gpu/drm/drm_panel.c +10 -0
+ * device tree node
+ * @np: device tree node of the panel
+ * @orientation: orientation enum to be filled in
+ *
+ * Looks up the rotation of a panel in the device tree. The rotation in the
+ * device tree is counter clockwise.
+ *
+ * Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the
+ * rotation property doesn't exist. -EERROR otherwise.
+ */

This function should better spell out why it talks about rotation versus orientation.

It happens that orientation, due to bad design choices is named rotation in DT.
But then this function is all about orientation, that just happens to be named rotation in DT.
And the comments associated to the function should reflect this.

something like:
/**
* of_drm_get_panel_orientation - look up the orientation of the panel using a
* device tree node
* @np: device tree node of the panel
* @orientation: orientation enum to be filled in
*
* Looks up the rotation property of a panel in the device tree.
* The orientation of the panel is expressed as a property named
* "rotation" in the device tree.
* The rotation in the device tree is counter clockwise.
*
* Return: 0 when a valid orientation value (0, 90, 180, or 270) is read or the
* rotation property doesn't exist. -EERROR otherwise.
*/

This would at least remove some of my confusiuon.
And then maybe add a bit more explanation to the binding property description too.

Sam

Quoted 57 lines
drivers/gpu/drm/drm_panel.c +29 -0
+int of_drm_get_panel_orientation(const struct device_node *np,
+				 enum drm_panel_orientation *orientation)
+{
+	int rotation, ret;
+
+	ret = of_property_read_u32(np, "rotation", &rotation);
+	if (ret == -EINVAL) {
+		/* Don't return an error if there's no rotation property. */
+		*orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+		return 0;
+	}
+
+	if (ret < 0)
+		return ret;
+
+	if (rotation == 0)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL;
+	else if (rotation == 90)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP;
+	else if (rotation == 180)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP;
+	else if (rotation == 270)
+		*orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP;
+	else
+		return -EINVAL;
+
+	return 0;
+}
+EXPORT_SYMBOL(of_drm_get_panel_orientation);
 #endif
 
 MODULE_AUTHOR("Thierry Reding <[email protected]>");
include/drm/drm_panel.h +7 -0
index 8c738c0e6e9f..3564952f1a4f 100644
@@ -197,11 +197,18 @@ int drm_panel_detach(struct drm_panel *panel);
 
 #if defined(CONFIG_OF) && defined(CONFIG_DRM_PANEL)
 struct drm_panel *of_drm_find_panel(const struct device_node *np);
+int of_drm_get_panel_orientation(const struct device_node *np,
+				 enum drm_panel_orientation *orientation);
 #else
 static inline struct drm_panel *of_drm_find_panel(const struct device_node *np)
 {
 	return ERR_PTR(-ENODEV);
 }
+int of_drm_get_panel_orientation(const struct device_node *np,
+				 enum drm_panel_orientation *orientation)
+{
+	return -ENODEV;
+}
 #endif
 
 #endif
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
#3 lore raw

Re: [PATCH v3 1/4] drm/panel: Add helper for reading DT rotation

Quoted 43 lines · Sam Ravnborg

Hi Derek.

Quoted 20 lines · Derek Basehore

This adds a helper function for reading the rotation (panel orientation) from the device tree.

---
 drivers/gpu/drm/drm_panel.c | 42 +++++++++++++++++++++++++++++++++++++
 include/drm/drm_panel.h     |  7 +++++++
 2 files changed, 49 insertions(+)
drivers/gpu/drm/drm_panel.c +3 -0
index dbd5b873e8f2..507099af4b57 100644
@@ -172,6 +172,48 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)
      return ERR_PTR(-EPROBE_DEFER);
 }
 EXPORT_SYMBOL(of_drm_find_panel);
+
+/**
+ * of_drm_get_panel_orientation - look up the rotation of the panel using a

drivers/gpu/drm/drm_panel.c struct drm_panel *of_drm_find_panel(const struct device_node *np) · line 187

Quoted 10 lines
drivers/gpu/drm/drm_panel.c +10 -0
+ * device tree node
+ * @np: device tree node of the panel
+ * @orientation: orientation enum to be filled in
+ *
+ * Looks up the rotation of a panel in the device tree. The rotation in the
+ * device tree is counter clockwise.
+ *
+ * Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the
+ * rotation property doesn't exist. -EERROR otherwise.
+ */

This function should better spell out why it talks about rotation versus orientation.

It happens that orientation, due to bad design choices is named rotation in DT.
But then this function is all about orientation, that just happens to be named rotation in DT.
And the comments associated to the function should reflect this.

Quoted 15 lines

something like:
/**
* of_drm_get_panel_orientation - look up the orientation of the panel using a
* device tree node
* @np: device tree node of the panel
* @orientation: orientation enum to be filled in
*
* Looks up the rotation property of a panel in the device tree.
* The orientation of the panel is expressed as a property named
* "rotation" in the device tree.
* The rotation in the device tree is counter clockwise.
*
* Return: 0 when a valid orientation value (0, 90, 180, or 270) is read or the
* rotation property doesn't exist. -EERROR otherwise.
*/

I'll clear this up in the next patch set.

Quoted 4 lines

This would at least remove some of my confusiuon.
And then maybe add a bit more explanation to the binding property description too.

Tried this, yet I got told off for adding kernel details to the DT documentation (which is frowned upon).

Quoted 68 lines

Sam

Quoted 54 lines
drivers/gpu/drm/drm_panel.c +29 -0
+int of_drm_get_panel_orientation(const struct device_node *np,
+                              enum drm_panel_orientation *orientation)
+{
+     int rotation, ret;
+
+     ret = of_property_read_u32(np, "rotation", &rotation);
+     if (ret == -EINVAL) {
+             /* Don't return an error if there's no rotation property. */
+             *orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+             return 0;
+     }
+
+     if (ret < 0)
+             return ret;
+
+     if (rotation == 0)
+             *orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL;
+     else if (rotation == 90)
+             *orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP;
+     else if (rotation == 180)
+             *orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP;
+     else if (rotation == 270)
+             *orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP;
+     else
+             return -EINVAL;
+
+     return 0;
+}
+EXPORT_SYMBOL(of_drm_get_panel_orientation);
 #endif
 
 MODULE_AUTHOR("Thierry Reding <[email protected]>");
include/drm/drm_panel.h +7 -0
index 8c738c0e6e9f..3564952f1a4f 100644
@@ -197,11 +197,18 @@ int drm_panel_detach(struct drm_panel *panel);
 
 #if defined(CONFIG_OF) && defined(CONFIG_DRM_PANEL)
 struct drm_panel *of_drm_find_panel(const struct device_node *np);
+int of_drm_get_panel_orientation(const struct device_node *np,
+                              enum drm_panel_orientation *orientation);
 #else
 static inline struct drm_panel *of_drm_find_panel(const struct device_node *np)
 {
      return ERR_PTR(-ENODEV);
 }
+int of_drm_get_panel_orientation(const struct device_node *np,
+                              enum drm_panel_orientation *orientation)
+{
+     return -ENODEV;
+}
 #endif
 
Quoted 3 lines
Quoted 3 lines
include/drm/drm_panel.h +0 -1
 #endif
--

2.22.0.410.gd8fdbe21b5-goog

Thanks for the review
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

PATCH v3 2/4 drm/panel: set display info in panel attach

In reply to Derek Basehore

Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_panel_attach function. These values are stored from probe in the drm_panel struct.

---
 drivers/gpu/drm/drm_panel.c | 28 ++++++++++++++++++++++++++++
 include/drm/drm_panel.h     | 14 ++++++++++++++
 2 files changed, 42 insertions(+)
drivers/gpu/drm/drm_panel.c +28 -0
index 507099af4b57..5690fca30236 100644
@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);
  */
 int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector)
 {
+	struct drm_display_info *info;
+
 	if (panel->connector)
 		return -EBUSY;
 
 	panel->connector = connector;
 	panel->drm = connector->dev;
+	info = &connector->display_info;
+	info->width_mm = panel->width_mm;
+	info->height_mm = panel->height_mm;
+	info->bpc = panel->bpc;
+	info->panel_orientation = panel->orientation;
+	info->bus_flags = panel->bus_flags;
+	if (panel->bus_formats)
+		drm_display_info_set_bus_formats(&connector->display_info,
+						 panel->bus_formats,
+						 panel->num_bus_formats);
 
 	return 0;
 }
@@ -128,6 +140,22 @@ EXPORT_SYMBOL(drm_panel_attach);
  */
 int drm_panel_detach(struct drm_panel *panel)
 {
+	struct drm_display_info *info;
+
+	if (!panel->connector)
+		goto out;
+
+	info = &panel->connector->display_info;
+	info->width_mm = 0;
+	info->height_mm = 0;
+	info->bpc = 0;
+	info->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+	info->bus_flags = 0;
+	kfree(info->bus_formats);
+	info->bus_formats = NULL;
+	info->num_bus_formats = 0;
+
+out:
 	panel->connector = NULL;
 	panel->drm = NULL;
 
include/drm/drm_panel.h +14 -0
index 3564952f1a4f..760ca5865962 100644
@@ -37,6 +37,8 @@ struct display_timing;
  * struct drm_panel_funcs - perform operations on a given panel
  * @disable: disable panel (turn off back light, etc.)
  * @unprepare: turn off panel
+ * @detach: detach panel->connector (clear internal state, etc.)
+ * @attach: attach panel->connector (update internal state, etc.)
  * @prepare: turn on panel and perform set up
  * @enable: enable panel (turn on back light, etc.)
  * @get_modes: add modes to the connector that the panel is attached to and
@@ -93,6 +95,18 @@ struct drm_panel {
 
 	const struct drm_panel_funcs *funcs;
 
+	/*
+	 * panel information to be set in the connector when the panel is
+	 * attached.
+	 */
+	unsigned int width_mm;
+	unsigned int height_mm;
+	unsigned int bpc;
+	int orientation;
+	const u32 *bus_formats;
+	unsigned int num_bus_formats;
+	u32 bus_flags;
+
 	struct list_head list;
 };
 
Signature · 6 lines
2.22.0.410.gd8fdbe21b5-goog

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

Re: [PATCH v3 2/4] drm/panel: set display info in panel attach

Quoted 83 lines · Derek Basehore

Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_panel_attach function. These values are stored from probe in the drm_panel struct.

---
 drivers/gpu/drm/drm_panel.c | 28 ++++++++++++++++++++++++++++
 include/drm/drm_panel.h     | 14 ++++++++++++++
 2 files changed, 42 insertions(+)
drivers/gpu/drm/drm_panel.c +28 -0
index 507099af4b57..5690fca30236 100644
@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);
  */
 int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector)
 {
+       struct drm_display_info *info;
+
        if (panel->connector)
                return -EBUSY;
 
        panel->connector = connector;
        panel->drm = connector->dev;
+       info = &connector->display_info;
+       info->width_mm = panel->width_mm;
+       info->height_mm = panel->height_mm;
+       info->bpc = panel->bpc;
+       info->panel_orientation = panel->orientation;
+       info->bus_flags = panel->bus_flags;
+       if (panel->bus_formats)
+               drm_display_info_set_bus_formats(&connector->display_info,
+                                                panel->bus_formats,
+                                                panel->num_bus_formats);
 
        return 0;
 }
@@ -128,6 +140,22 @@ EXPORT_SYMBOL(drm_panel_attach);
  */
 int drm_panel_detach(struct drm_panel *panel)
 {
+       struct drm_display_info *info;
+
+       if (!panel->connector)
+               goto out;
+
+       info = &panel->connector->display_info;
+       info->width_mm = 0;
+       info->height_mm = 0;
+       info->bpc = 0;
+       info->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+       info->bus_flags = 0;
+       kfree(info->bus_formats);
+       info->bus_formats = NULL;
+       info->num_bus_formats = 0;
+
+out:
        panel->connector = NULL;
        panel->drm = NULL;
 
include/drm/drm_panel.h +3 -0
index 3564952f1a4f..760ca5865962 100644
@@ -37,6 +37,8 @@ struct display_timing;
  * struct drm_panel_funcs - perform operations on a given panel
  * @disable: disable panel (turn off back light, etc.)
  * @unprepare: turn off panel
+ * @detach: detach panel->connector (clear internal state, etc.)
+ * @attach: attach panel->connector (update internal state, etc.)
  * @prepare: turn on panel and perform set up
  * @enable: enable panel (turn on back light, etc.)
  * @get_modes: add modes to the connector that the panel is attached to and
@@ -93,6 +95,18 @@ struct drm_panel {
 
        const struct drm_panel_funcs *funcs;
 
+       /*

include/drm/drm_panel.h struct drm_panel { · line 108

Quoted 10 lines
include/drm/drm_panel.h +10 -0
+        * panel information to be set in the connector when the panel is
+        * attached.
+        */
+       unsigned int width_mm;
+       unsigned int height_mm;
+       unsigned int bpc;
+       int orientation;
+       const u32 *bus_formats;
+       unsigned int num_bus_formats;
+       u32 bus_flags;

Should probably put these in a struct to ensure the connector and panel have the same data types. Will do in a following patch if we stay with this.

Quoted 7 lines
include/drm/drm_panel.h +1 -1
+
        struct list_head list;
 };
 
--

2.22.0.410.gd8fdbe21b5-goog

#6 lore raw

PATCH v3 3/4 drm/connector: Split out orientation quirk detection

In reply to Derek Basehore

Not every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks.

---
 drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++++++++++++---------
 drivers/gpu/drm/i915/intel_dp.c |  4 +--
 drivers/gpu/drm/i915/vlv_dsi.c  |  5 ++--
 include/drm/drm_connector.h     |  2 ++
 4 files changed, 39 insertions(+), 17 deletions(-)
drivers/gpu/drm/drm_connector.c +33 -12
index e17586aaa80f..c4b01adf927a 100644
@@ -1894,31 +1894,23 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property);
  * drm_connector_init_panel_orientation_property -
  *	initialize the connecters panel_orientation property
  * @connector: connector for which to init the panel-orientation property.
- * @width: width in pixels of the panel, used for panel quirk detection
- * @height: height in pixels of the panel, used for panel quirk detection
  *
  * This function should only be called for built-in panels, after setting
  * connector->display_info.panel_orientation first (if known).
  *
- * This function will check for platform specific (e.g. DMI based) quirks
- * overriding display_info.panel_orientation first, then if panel_orientation
- * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
- * "panel orientation" property to the connector.
+ * This function will check if the panel_orientation is not
+ * DRM_MODE_PANEL_ORIENTATION_UNKNOWN. If not, it will attach the "panel
+ * orientation" property to the connector.
  *
  * Returns:
  * Zero on success, negative errno on failure.
  */
 int drm_connector_init_panel_orientation_property(
-	struct drm_connector *connector, int width, int height)
+	struct drm_connector *connector)
 {
 	struct drm_device *dev = connector->dev;
 	struct drm_display_info *info = &connector->display_info;
 	struct drm_property *prop;
-	int orientation_quirk;
-
-	orientation_quirk = drm_get_panel_orientation_quirk(width, height);
-	if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
-		info->panel_orientation = orientation_quirk;
 
 	if (info->panel_orientation == DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
 		return 0;
@@ -1941,6 +1933,35 @@ int drm_connector_init_panel_orientation_property(
 }
 EXPORT_SYMBOL(drm_connector_init_panel_orientation_property);
 
+/**
+ * drm_connector_init_panel_orientation_property_quirk -
+ *	initialize the connecters panel_orientation property with a quirk
+ *	override
+ * @connector: connector for which to init the panel-orientation property.
+ * @width: width in pixels of the panel, used for panel quirk detection
+ * @height: height in pixels of the panel, used for panel quirk detection
+ *
+ * This function will check for platform specific (e.g. DMI based) quirks
+ * overriding display_info.panel_orientation first, then if panel_orientation
+ * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
+ * "panel orientation" property to the connector.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_connector_init_panel_orientation_property_quirk(
+	struct drm_connector *connector, int width, int height)
+{
+	int orientation_quirk;
+
+	orientation_quirk = drm_get_panel_orientation_quirk(width, height);
+	if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
+		connector->display_info.panel_orientation = orientation_quirk;
+
+	return drm_connector_init_panel_orientation_property(connector);
+}
+EXPORT_SYMBOL(drm_connector_init_panel_orientation_property_quirk);
+
 int drm_connector_set_obj_prop(struct drm_mode_object *obj,
 				    struct drm_property *property,
 				    uint64_t value)
drivers/gpu/drm/i915/intel_dp.c +2 -2
index b099a9dc28fd..7d4e61cf5463 100644
@@ -7282,8 +7282,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
 	intel_panel_setup_backlight(connector, pipe);
 
 	if (fixed_mode)
-		drm_connector_init_panel_orientation_property(
-			connector, fixed_mode->hdisplay, fixed_mode->vdisplay);
+		drm_connector_init_panel_orientation_property_quirk(connector,
+				fixed_mode->hdisplay, fixed_mode->vdisplay);
 
 	return true;
 
drivers/gpu/drm/i915/vlv_dsi.c +2 -3
index bfe2891eac37..fa9833dbe359 100644
@@ -1650,6 +1650,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
 	if (connector->panel.fixed_mode) {
 		u32 allowed_scalers;
+		int orientation;
 
 		allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) | BIT(DRM_MODE_SCALE_FULLSCREEN);
 		if (!HAS_GMCH(dev_priv))
@@ -1660,9 +1661,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
 		connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
 
-		connector->base.display_info.panel_orientation =
-			vlv_dsi_get_panel_orientation(connector);
-		drm_connector_init_panel_orientation_property(
+		drm_connector_init_panel_orientation_property_quirk(
 				&connector->base,
 				connector->panel.fixed_mode->hdisplay,
 				connector->panel.fixed_mode->vdisplay);
include/drm/drm_connector.h +2 -0
index 47e749b74e5f..0468fd9a4418 100644
@@ -1370,6 +1370,8 @@ void drm_connector_set_link_status_property(struct drm_connector *connector,
 void drm_connector_set_vrr_capable_property(
 		struct drm_connector *connector, bool capable);
 int drm_connector_init_panel_orientation_property(
+	struct drm_connector *connector);
+int drm_connector_init_panel_orientation_property_quirk(
 	struct drm_connector *connector, int width, int height);
 int drm_connector_attach_max_bpc_property(struct drm_connector *connector,
 					  int min, int max);
Signature · 6 lines
2.22.0.410.gd8fdbe21b5-goog

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v3 3/4
#7 lore raw

Re: [Intel-gfx] [PATCH v3 3/4] drm/connector: Split out orientation quirk detection

Hi,

Quoted 109 lines · Derek Basehore

Not every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks.

---
  drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++++++++++++---------
  drivers/gpu/drm/i915/intel_dp.c |  4 +--
  drivers/gpu/drm/i915/vlv_dsi.c  |  5 ++--
  include/drm/drm_connector.h     |  2 ++
  4 files changed, 39 insertions(+), 17 deletions(-)
drivers/gpu/drm/drm_connector.c +33 -12
index e17586aaa80f..c4b01adf927a 100644
@@ -1894,31 +1894,23 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property);
   * drm_connector_init_panel_orientation_property -
   *	initialize the connecters panel_orientation property
   * @connector: connector for which to init the panel-orientation property.
- * @width: width in pixels of the panel, used for panel quirk detection
- * @height: height in pixels of the panel, used for panel quirk detection
   *
   * This function should only be called for built-in panels, after setting
   * connector->display_info.panel_orientation first (if known).
   *
- * This function will check for platform specific (e.g. DMI based) quirks
- * overriding display_info.panel_orientation first, then if panel_orientation
- * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
- * "panel orientation" property to the connector.
+ * This function will check if the panel_orientation is not
+ * DRM_MODE_PANEL_ORIENTATION_UNKNOWN. If not, it will attach the "panel
+ * orientation" property to the connector.
   *
   * Returns:
   * Zero on success, negative errno on failure.
   */
  int drm_connector_init_panel_orientation_property(
-	struct drm_connector *connector, int width, int height)
+	struct drm_connector *connector)
  {
  	struct drm_device *dev = connector->dev;
  	struct drm_display_info *info = &connector->display_info;
  	struct drm_property *prop;
-	int orientation_quirk;
-
-	orientation_quirk = drm_get_panel_orientation_quirk(width, height);
-	if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
-		info->panel_orientation = orientation_quirk;
 
  	if (info->panel_orientation == DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
  		return 0;
@@ -1941,6 +1933,35 @@ int drm_connector_init_panel_orientation_property(
  }
  EXPORT_SYMBOL(drm_connector_init_panel_orientation_property);
 
+/**
+ * drm_connector_init_panel_orientation_property_quirk -
+ *	initialize the connecters panel_orientation property with a quirk
+ *	override
+ * @connector: connector for which to init the panel-orientation property.
+ * @width: width in pixels of the panel, used for panel quirk detection
+ * @height: height in pixels of the panel, used for panel quirk detection
+ *
+ * This function will check for platform specific (e.g. DMI based) quirks
+ * overriding display_info.panel_orientation first, then if panel_orientation
+ * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
+ * "panel orientation" property to the connector.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_connector_init_panel_orientation_property_quirk(
+	struct drm_connector *connector, int width, int height)
+{
+	int orientation_quirk;
+
+	orientation_quirk = drm_get_panel_orientation_quirk(width, height);
+	if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
+		connector->display_info.panel_orientation = orientation_quirk;
+
+	return drm_connector_init_panel_orientation_property(connector);
+}
+EXPORT_SYMBOL(drm_connector_init_panel_orientation_property_quirk);
+
  int drm_connector_set_obj_prop(struct drm_mode_object *obj,
  				    struct drm_property *property,
  				    uint64_t value)
drivers/gpu/drm/i915/intel_dp.c +2 -2
index b099a9dc28fd..7d4e61cf5463 100644
@@ -7282,8 +7282,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
  	intel_panel_setup_backlight(connector, pipe);
 
  	if (fixed_mode)
-		drm_connector_init_panel_orientation_property(
-			connector, fixed_mode->hdisplay, fixed_mode->vdisplay);
+		drm_connector_init_panel_orientation_property_quirk(connector,
+				fixed_mode->hdisplay, fixed_mode->vdisplay);
 
  	return true;
 
drivers/gpu/drm/i915/vlv_dsi.c +0 -0
index bfe2891eac37..fa9833dbe359 100644

drivers/gpu/drm/i915/vlv_dsi.c static void intel_dsi_add_properties(struct intel_connector *connector) · line 1656

Quoted 7 lines
drivers/gpu/drm/i915/vlv_dsi.c +1 -0
@@ -1650,6 +1650,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
  	if (connector->panel.fixed_mode) {
  		u32 allowed_scalers;
+		int orientation;
 
  		allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) | BIT(DRM_MODE_SCALE_FULLSCREEN);
  		if (!HAS_GMCH(dev_priv))

The above chunk seems to be a leftover from the previous version of this series.

Otherwise this patch looks good, with this fixed you can add my:

Regards,

Hans

Quoted 25 lines
drivers/gpu/drm/i915/vlv_dsi.c +1 -3
@@ -1660,9 +1661,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
  		connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
 
-		connector->base.display_info.panel_orientation =
-			vlv_dsi_get_panel_orientation(connector);
-		drm_connector_init_panel_orientation_property(
+		drm_connector_init_panel_orientation_property_quirk(
  				&connector->base,
  				connector->panel.fixed_mode->hdisplay,
  				connector->panel.fixed_mode->vdisplay);
include/drm/drm_connector.h +2 -0
index 47e749b74e5f..0468fd9a4418 100644
@@ -1370,6 +1370,8 @@ void drm_connector_set_link_status_property(struct drm_connector *connector,
  void drm_connector_set_vrr_capable_property(
  		struct drm_connector *connector, bool capable);
  int drm_connector_init_panel_orientation_property(
+	struct drm_connector *connector);
+int drm_connector_init_panel_orientation_property_quirk(
  	struct drm_connector *connector, int width, int height);
  int drm_connector_attach_max_bpc_property(struct drm_connector *connector,
  					  int min, int max);
#8 lore raw

Re: [Intel-gfx] [PATCH v3 3/4] drm/connector: Split out orientation quirk detection

In reply to Derek Basehore
Quoted 117 lines · Derek Basehore

Not every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks.

---
 drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++++++++++++---------
 drivers/gpu/drm/i915/intel_dp.c |  4 +--
 drivers/gpu/drm/i915/vlv_dsi.c  |  5 ++--
 include/drm/drm_connector.h     |  2 ++
 4 files changed, 39 insertions(+), 17 deletions(-)
drivers/gpu/drm/drm_connector.c +33 -12
index e17586aaa80f..c4b01adf927a 100644
@@ -1894,31 +1894,23 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property);
  * drm_connector_init_panel_orientation_property -
  *	initialize the connecters panel_orientation property
  * @connector: connector for which to init the panel-orientation property.
- * @width: width in pixels of the panel, used for panel quirk detection
- * @height: height in pixels of the panel, used for panel quirk detection
  *
  * This function should only be called for built-in panels, after setting
  * connector->display_info.panel_orientation first (if known).
  *
- * This function will check for platform specific (e.g. DMI based) quirks
- * overriding display_info.panel_orientation first, then if panel_orientation
- * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
- * "panel orientation" property to the connector.
+ * This function will check if the panel_orientation is not
+ * DRM_MODE_PANEL_ORIENTATION_UNKNOWN. If not, it will attach the "panel
+ * orientation" property to the connector.
  *
  * Returns:
  * Zero on success, negative errno on failure.
  */
 int drm_connector_init_panel_orientation_property(
-	struct drm_connector *connector, int width, int height)
+	struct drm_connector *connector)
 {
 	struct drm_device *dev = connector->dev;
 	struct drm_display_info *info = &connector->display_info;
 	struct drm_property *prop;
-	int orientation_quirk;
-
-	orientation_quirk = drm_get_panel_orientation_quirk(width, height);
-	if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
-		info->panel_orientation = orientation_quirk;
 
 	if (info->panel_orientation == DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
 		return 0;
@@ -1941,6 +1933,35 @@ int drm_connector_init_panel_orientation_property(
 }
 EXPORT_SYMBOL(drm_connector_init_panel_orientation_property);
 
+/**
+ * drm_connector_init_panel_orientation_property_quirk -
+ *	initialize the connecters panel_orientation property with a quirk
+ *	override
+ * @connector: connector for which to init the panel-orientation property.
+ * @width: width in pixels of the panel, used for panel quirk detection
+ * @height: height in pixels of the panel, used for panel quirk detection
+ *
+ * This function will check for platform specific (e.g. DMI based) quirks
+ * overriding display_info.panel_orientation first, then if panel_orientation
+ * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
+ * "panel orientation" property to the connector.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_connector_init_panel_orientation_property_quirk(
+	struct drm_connector *connector, int width, int height)
+{
+	int orientation_quirk;
+
+	orientation_quirk = drm_get_panel_orientation_quirk(width, height);
+	if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
+		connector->display_info.panel_orientation = orientation_quirk;
+
+	return drm_connector_init_panel_orientation_property(connector);
+}
+EXPORT_SYMBOL(drm_connector_init_panel_orientation_property_quirk);
+
 int drm_connector_set_obj_prop(struct drm_mode_object *obj,
 				    struct drm_property *property,
 				    uint64_t value)
drivers/gpu/drm/i915/intel_dp.c +2 -2
index b099a9dc28fd..7d4e61cf5463 100644
@@ -7282,8 +7282,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
 	intel_panel_setup_backlight(connector, pipe);
 
 	if (fixed_mode)
-		drm_connector_init_panel_orientation_property(
-			connector, fixed_mode->hdisplay, fixed_mode->vdisplay);
+		drm_connector_init_panel_orientation_property_quirk(connector,
+				fixed_mode->hdisplay, fixed_mode->vdisplay);
 
 	return true;
 
drivers/gpu/drm/i915/vlv_dsi.c +1 -0
index bfe2891eac37..fa9833dbe359 100644
@@ -1650,6 +1650,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
 	if (connector->panel.fixed_mode) {
 		u32 allowed_scalers;
+		int orientation;
 
 		allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) | BIT(DRM_MODE_SCALE_FULLSCREEN);
 		if (!HAS_GMCH(dev_priv))

drivers/gpu/drm/i915/vlv_dsi.c static void intel_dsi_add_properties(struct intel_connector *connector) · line 1664

Quoted 5 lines
drivers/gpu/drm/i915/vlv_dsi.c +0 -2
@@ -1660,9 +1661,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
 		connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
 
-		connector->base.display_info.panel_orientation =
-			vlv_dsi_get_panel_orientation(connector);

Where did that go?

Quoted 25 lines
drivers/gpu/drm/i915/vlv_dsi.c +1 -1
-		drm_connector_init_panel_orientation_property(
+		drm_connector_init_panel_orientation_property_quirk(
 				&connector->base,
 				connector->panel.fixed_mode->hdisplay,
 				connector->panel.fixed_mode->vdisplay);
include/drm/drm_connector.h +2 -0
index 47e749b74e5f..0468fd9a4418 100644
@@ -1370,6 +1370,8 @@ void drm_connector_set_link_status_property(struct drm_connector *connector,
 void drm_connector_set_vrr_capable_property(
 		struct drm_connector *connector, bool capable);
 int drm_connector_init_panel_orientation_property(
+	struct drm_connector *connector);
+int drm_connector_init_panel_orientation_property_quirk(
 	struct drm_connector *connector, int width, int height);
 int drm_connector_attach_max_bpc_property(struct drm_connector *connector,
 					  int min, int max);
Signature · 6 lines
2.22.0.410.gd8fdbe21b5-goog

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Ville Syrjälä
Intel
#9 lore raw

Re: [Intel-gfx] [PATCH v3 3/4] drm/connector: Split out orientation quirk detection

Quoted 120 lines · Ville Syrjälä
Quoted 118 lines · Derek Basehore

Not every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks.

---
 drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++++++++++++---------
 drivers/gpu/drm/i915/intel_dp.c |  4 +--
 drivers/gpu/drm/i915/vlv_dsi.c  |  5 ++--
 include/drm/drm_connector.h     |  2 ++
 4 files changed, 39 insertions(+), 17 deletions(-)
drivers/gpu/drm/drm_connector.c +33 -12
index e17586aaa80f..c4b01adf927a 100644
@@ -1894,31 +1894,23 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property);
  * drm_connector_init_panel_orientation_property -
  *   initialize the connecters panel_orientation property
  * @connector: connector for which to init the panel-orientation property.
- * @width: width in pixels of the panel, used for panel quirk detection
- * @height: height in pixels of the panel, used for panel quirk detection
  *
  * This function should only be called for built-in panels, after setting
  * connector->display_info.panel_orientation first (if known).
  *
- * This function will check for platform specific (e.g. DMI based) quirks
- * overriding display_info.panel_orientation first, then if panel_orientation
- * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
- * "panel orientation" property to the connector.
+ * This function will check if the panel_orientation is not
+ * DRM_MODE_PANEL_ORIENTATION_UNKNOWN. If not, it will attach the "panel
+ * orientation" property to the connector.
  *
  * Returns:
  * Zero on success, negative errno on failure.
  */
 int drm_connector_init_panel_orientation_property(
-     struct drm_connector *connector, int width, int height)
+     struct drm_connector *connector)
 {
      struct drm_device *dev = connector->dev;
      struct drm_display_info *info = &connector->display_info;
      struct drm_property *prop;
-     int orientation_quirk;
-
-     orientation_quirk = drm_get_panel_orientation_quirk(width, height);
-     if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
-             info->panel_orientation = orientation_quirk;
 
      if (info->panel_orientation == DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
              return 0;
@@ -1941,6 +1933,35 @@ int drm_connector_init_panel_orientation_property(
 }
 EXPORT_SYMBOL(drm_connector_init_panel_orientation_property);
 
+/**
+ * drm_connector_init_panel_orientation_property_quirk -
+ *   initialize the connecters panel_orientation property with a quirk
+ *   override
+ * @connector: connector for which to init the panel-orientation property.
+ * @width: width in pixels of the panel, used for panel quirk detection
+ * @height: height in pixels of the panel, used for panel quirk detection
+ *
+ * This function will check for platform specific (e.g. DMI based) quirks
+ * overriding display_info.panel_orientation first, then if panel_orientation
+ * is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the
+ * "panel orientation" property to the connector.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_connector_init_panel_orientation_property_quirk(
+     struct drm_connector *connector, int width, int height)
+{
+     int orientation_quirk;
+
+     orientation_quirk = drm_get_panel_orientation_quirk(width, height);
+     if (orientation_quirk != DRM_MODE_PANEL_ORIENTATION_UNKNOWN)
+             connector->display_info.panel_orientation = orientation_quirk;
+
+     return drm_connector_init_panel_orientation_property(connector);
+}
+EXPORT_SYMBOL(drm_connector_init_panel_orientation_property_quirk);
+
 int drm_connector_set_obj_prop(struct drm_mode_object *obj,
                                  struct drm_property *property,
                                  uint64_t value)
drivers/gpu/drm/i915/intel_dp.c +2 -2
index b099a9dc28fd..7d4e61cf5463 100644
@@ -7282,8 +7282,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
      intel_panel_setup_backlight(connector, pipe);
 
      if (fixed_mode)
-             drm_connector_init_panel_orientation_property(
-                     connector, fixed_mode->hdisplay, fixed_mode->vdisplay);
+             drm_connector_init_panel_orientation_property_quirk(connector,
+                             fixed_mode->hdisplay, fixed_mode->vdisplay);
 
      return true;
 
drivers/gpu/drm/i915/vlv_dsi.c +1 -0
index bfe2891eac37..fa9833dbe359 100644
@@ -1650,6 +1650,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
      if (connector->panel.fixed_mode) {
              u32 allowed_scalers;
+             int orientation;
 
              allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) | BIT(DRM_MODE_SCALE_FULLSCREEN);
              if (!HAS_GMCH(dev_priv))
@@ -1660,9 +1661,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 
Quoted 6 lines

drivers/gpu/drm/i915/vlv_dsi.c static void intel_dsi_add_properties(struct intel_connector *connector) · line 1664

Quoted 4 lines
drivers/gpu/drm/i915/vlv_dsi.c +0 -2
              connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
 
-             connector->base.display_info.panel_orientation =
-                     vlv_dsi_get_panel_orientation(connector);

Where did that go?

Oops. Nice catch.

Quoted 22 lines
Quoted 22 lines
drivers/gpu/drm/i915/vlv_dsi.c +1 -1
-             drm_connector_init_panel_orientation_property(
+             drm_connector_init_panel_orientation_property_quirk(
                              &connector->base,
                              connector->panel.fixed_mode->hdisplay,
                              connector->panel.fixed_mode->vdisplay);
include/drm/drm_connector.h +2 -1
index 47e749b74e5f..0468fd9a4418 100644
@@ -1370,6 +1370,8 @@ void drm_connector_set_link_status_property(struct drm_connector *connector,
 void drm_connector_set_vrr_capable_property(
              struct drm_connector *connector, bool capable);
 int drm_connector_init_panel_orientation_property(
+     struct drm_connector *connector);
+int drm_connector_init_panel_orientation_property_quirk(
      struct drm_connector *connector, int width, int height);
 int drm_connector_attach_max_bpc_property(struct drm_connector *connector,
                                        int min, int max);
--

2.22.0.410.gd8fdbe21b5-goog

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel

Thanks for the review

#10 lore raw

PATCH v4 4/4 drm/mtk: add panel orientation property

In reply to Derek Basehore

This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN.

---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/mediatek/mtk_dsi.c +8 -0
index 4a0b9150a7bb..08ffdc7526dd 100644
@@ -782,10 +782,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)
 			DRM_ERROR("Failed to attach panel to drm\n");
 			goto err_connector_cleanup;
 		}
+
+		ret = drm_connector_init_panel_orientation_property(&dsi->conn);
+		if (ret) {
+			DRM_ERROR("Failed to init panel orientation\n");
+			goto err_panel_detach;
+		}
 	}
 
 	return 0;
 
+err_panel_detach:
+	drm_panel_detach(dsi->panel);
 err_connector_cleanup:
 	drm_connector_cleanup(&dsi->conn);
 	return ret;
Signature · 6 lines
2.22.0.410.gd8fdbe21b5-goog

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v4 4/4
#11 lore raw

Re: [PATCH v4 4/4] drm/mtk: add panel orientation property

Hi, Derek:

Quoted 4 lines · Derek Basehore

This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN.

Quoted 18 lines
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/mediatek/mtk_dsi.c +5 -0
index 4a0b9150a7bb..08ffdc7526dd 100644
@@ -782,10 +782,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)
 			DRM_ERROR("Failed to attach panel to drm\n");
 			goto err_connector_cleanup;
 		}
+
+		ret = drm_connector_init_panel_orientation_property(&dsi->conn);
+		if (ret) {
+			DRM_ERROR("Failed to init panel orientation\n");
+			goto err_panel_detach;

drivers/gpu/drm/mediatek/mtk_dsi.c static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi) · line 799

Quoted 10 lines
drivers/gpu/drm/mediatek/mtk_dsi.c +3 -0
+		}
 	}
 
 	return 0;
 
+err_panel_detach:
+	drm_panel_detach(dsi->panel);
 err_connector_cleanup:
 	drm_connector_cleanup(&dsi->conn);
 	return ret;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx