Skip to contentSkip to conversation

Support distro boot in pico-imx7d BL33 case

PATCH New Jun Nie 4 participants 17 messages Jul 16, 2019 – Oct 17, 2019

Subsystems (2)
lore
Share & tools
lore

Jun Nie

author
#0 lore raw

cover Support distro boot in pico-imx7d BL33 case

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37 +++++++++++------------------------
 3 files changed, 13 insertions(+), 43 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/3 pico-imx7d: add config to enable CAAM

Add config to enable CAAM so that hardware random number generator works.

---
 configs/pico-imx7d_bl33_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/pico-imx7d_bl33_defconfig +1 -0
index b609b6d..5ef55d3 100644
@@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x87800000
 CONFIG_SPL_GPIO_SUPPORT=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
 CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_SECURE_BOOT=y
 CONFIG_TARGET_PICO_IMX7D=y
 CONFIG_SPL_MMC_SUPPORT=y
 CONFIG_SPL_SERIAL_SUPPORT=y
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 2/3 pico-imx7d: Support distro boot for FIT image case

In reply to Jun Nie

Support distro boot for pico imx7d in FIT image case.

---
 include/configs/pico-imx7d.h | 37 +++++++++++--------------------------
 1 file changed, 11 insertions(+), 26 deletions(-)
include/configs/pico-imx7d.h +11 -26
index 9101540..7b2bd00 100644
@@ -55,17 +55,17 @@
 /* When booting with FIT specify the node entry containing boot.scr */
 #if defined(CONFIG_FIT)
 #define PICO_BOOT_ENV \
-	"bootscr_fitimage_name=bootscr\0" \
-	"bootscriptaddr=0x83200000\0" \
-	"fdtovaddr=0x83100000\0" \
-	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV)"\0" \
-	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
-	"mmcargs=setenv bootargs console=${console},${baudrate} " \
-		"rootwait rw;\0" \
-	"loadbootscript=" \
-		"load mmc ${mmcdev}:${mmcpart} ${bootscriptaddr} ${script};\0" \
-	"bootscript=echo Running bootscript from mmc ...; " \
-	"source ${bootscriptaddr}:${bootscr_fitimage_name}\0"
+	BOOTENV								\
+	"fdtovaddr=0x83100000\0"					\
+	"scriptaddr=0x83200000\0"					\
+	"mmcargs=setenv bootargs console=${console},${baudrate} "	\
+		"rootwait rw\0"						\
+	"boot_a_script="						\
+		"load ${devtype} ${devnum}:${distro_bootpart} "		\
+			"${scriptaddr} ${prefix}${script}; "		\
+		"iminfo ${scriptaddr};"					\
+		"if test $? -eq 1; then hab_failsafe; fi;"		\
+		"source ${scriptaddr}:bootscr\0"
 #else
 #define PICO_BOOT_ENV \
 	"bootmenu_0=Boot using PICO-Hobbit baseboard=" \
@@ -107,21 +107,6 @@
 	"setup_emmc=mmc dev 0; gpt write mmc 0 $partitions; reset;\0" \
 	PICO_BOOT_ENV
 
-#if defined(CONFIG_FIT)
-#define CONFIG_BOOTCOMMAND \
-	"mmc dev ${mmcdev};" \
-	"mmc dev ${mmcdev}; if mmc rescan; then " \
-		"if run loadbootscript; then " \
-			"iminfo ${bootscriptaddr};" \
-			"if test $? -eq 1; then hab_failsafe; fi;" \
-			"run bootscript; " \
-		"else " \
-			"echo Fail to load fitImage with boot script;" \
-			"hab_failsafe;" \
-		"fi; " \
-	"fi"
-#endif
-
 #define BOOT_TARGET_DEVICES(func) \
 	func(MMC, mmc, 0) \
 	func(USB, usb, 0) \
Signature · 1 line
2.7.4
#3 lore raw

PATCH 2/3 pico-imx7d: Support distro boot for FIT image case

Hi Jun,

Quoted 66 lines · Jun Nie

Support distro boot for pico imx7d in FIT image case.

---
 include/configs/pico-imx7d.h | 37 +++++++++++--------------------------
 1 file changed, 11 insertions(+), 26 deletions(-)
include/configs/pico-imx7d.h +11 -11
index 9101540..7b2bd00 100644
@@ -55,17 +55,17 @@
 /* When booting with FIT specify the node entry containing boot.scr */
 #if defined(CONFIG_FIT)
 #define PICO_BOOT_ENV \
-       "bootscr_fitimage_name=bootscr\0" \
-       "bootscriptaddr=0x83200000\0" \
-       "fdtovaddr=0x83100000\0" \
-       "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV)"\0" \
-       "mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
-       "mmcargs=setenv bootargs console=${console},${baudrate} " \
-               "rootwait rw;\0" \
-       "loadbootscript=" \
-               "load mmc ${mmcdev}:${mmcpart} ${bootscriptaddr}
 ${script};\0" \
-       "bootscript=echo Running bootscript from mmc ...; " \
-       "source ${bootscriptaddr}:${bootscr_fitimage_name}\0"
+       BOOTENV                                                         \
+       "fdtovaddr=0x83100000\0"                                        \
+       "scriptaddr=0x83200000\0"                                       \
+       "mmcargs=setenv bootargs console=${console},${baudrate} "       \
+               "rootwait rw\0"                                         \
+       "boot_a_script="                                                \
+               "load ${devtype} ${devnum}:${distro_bootpart} "         \
+                       "${scriptaddr} ${prefix}${script}; "            \
+               "iminfo ${scriptaddr};"                                 \
+               "if test $? -eq 1; then hab_failsafe; fi;"              \
+               "source ${scriptaddr}:bootscr\0"
 #else
 #define PICO_BOOT_ENV \
        "bootmenu_0=Boot using PICO-Hobbit baseboard=" \
include/configs/pico-imx7d.h +0 -16
@@ -107,21 +107,6 @@
        "setup_emmc=mmc dev 0; gpt write mmc 0 $partitions; reset;\0" \
        PICO_BOOT_ENV
 
-#if defined(CONFIG_FIT)
-#define CONFIG_BOOTCOMMAND \
-       "mmc dev ${mmcdev};" \
-       "mmc dev ${mmcdev}; if mmc rescan; then " \
-               "if run loadbootscript; then " \
-                       "iminfo ${bootscriptaddr};" \
-                       "if test $? -eq 1; then hab_failsafe; fi;" \
-                       "run bootscript; " \
-               "else " \
-                       "echo Fail to load fitImage with boot script;" \
-                       "hab_failsafe;" \
-               "fi; " \
-       "fi"
-#endif
-
 #define BOOT_TARGET_DEVICES(func) \
        func(MMC, mmc, 0) \
        func(USB, usb, 0) \
--

2.7.4

Quoted 1 line

It's work from my side

for my setup i disable iminfo and hab_failsafe

See log:

run bootcmd
switch to partitions #0, OK
mmc0(part 0) is current device
Scanning mmc 0:1...
Found U-Boot script /boot.scr
245 bytes read in 8 ms (29.3 KiB/s) Unknown command 'iminfo' - try 'help' Unknown command 'hab_failsafe' - try 'help' ## Executing script at 83200000
8961308 bytes read in 217 ms (39.4 MiB/s) ## Loading kernel from FIT Image at 86000000 ...
Using 'conf at imx7d-pico-pi.dtb' configuration Trying 'kernel at 1' kernel subimage

     Description:  Linux kernel
     Type:         Kernel Image
     Compression:  uncompressed
     Data Start:   0x86000114
     Data Size:    8925040 Bytes = 8.5 MiB
     Architecture: ARM
     OS:           Linux
     Load Address: 0x80008000
     Entry Point:  0x80008000
     Hash algo:    sha1
     Hash value:   7d8af1016b4cf8ea90fa1a767bfbeda052043f6c

Verifying Hash Integrity ... sha1+ OK
## Loading fdt from FIT Image at 86000000 ...
Using 'conf at imx7d-pico-pi.dtb' configuration Trying 'fdt at imx7d-pico-pi.dtb' fdt subimage

     Description:  Flattened Device Tree blob
     Type:         Flat Device Tree
     Compression:  uncompressed
     Data Start:   0x86883188
     Data Size:    34325 Bytes = 33.5 KiB

Architecture: ARM
Hash algo: sha1
Hash value: 75c81556e9bb9681cd14c96c4627da04205b2583
Verifying Hash Integrity ... sha1+ OK Booting using the fdt blob at 0x86883188 Loading Kernel Image ... OK
Using Device Tree in place at 86883188, end 8688e79c

Starting kernel ...

Best Regards,
Joris Offouga

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#4 lore raw

PATCH 2/3 pico-imx7d: Support distro boot for FIT image case

In reply to Jun Nie
Quoted 3 lines

Support distro boot for pico imx7d in FIT image case.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#5 lore raw

PATCH 3/3 pico-imx7d: polish uart clock id definition

In reply to Jun Nie

Polish uart clock id definition. Default IMX7 UART ID is UART1 as original parameter in imx_get_uartclk().

---
 arch/arm/include/asm/arch-mx7/clock.h | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
arch/arm/include/asm/arch-mx7/clock.h +1 -17
index 1d07fde..a8e6097 100644
@@ -175,23 +175,7 @@ enum clk_root_index {
 	CLK_ROOT_MAX,
 };
 
-#if (CONFIG_CONS_INDEX == 0)
-#define UART_CLK_ROOT UART1_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 1)
-#define UART_CLK_ROOT UART2_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 2)
-#define UART_CLK_ROOT UART3_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 3)
-#define UART_CLK_ROOT UART4_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 4)
-#define UART_CLK_ROOT UART5_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 5)
-#define UART_CLK_ROOT UART6_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 6)
-#define UART_CLK_ROOT UART7_CLK_ROOT
-#else
-#error "Invalid IMX UART ID for serial console is defined"
-#endif
+#define UART_CLK_ROOT (UART1_CLK_ROOT + CONFIG_CONS_INDEX)
 
 struct clk_root_setting {
 	enum clk_root_index root;
Signature · 1 line
2.7.4
#6 lore raw

PATCH 3/3 pico-imx7d: polish uart clock id definition

Hi Jun,

I am just trying to check if some patch was silently lost, I found yours:

Quoted 28 lines · Jun Nie

Polish uart clock id definition. Default IMX7 UART ID is UART1 as original parameter in imx_get_uartclk().

---
 arch/arm/include/asm/arch-mx7/clock.h | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
arch/arm/include/asm/arch-mx7/clock.h +0 -11
index 1d07fde..a8e6097 100644
@@ -175,23 +175,7 @@ enum clk_root_index {
 	CLK_ROOT_MAX,
 };
 
-#if (CONFIG_CONS_INDEX == 0)
-#define UART_CLK_ROOT UART1_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 1)
-#define UART_CLK_ROOT UART2_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 2)
-#define UART_CLK_ROOT UART3_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 3)
-#define UART_CLK_ROOT UART4_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 4)
-#define UART_CLK_ROOT UART5_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 5)

arch/arm/include/asm/arch-mx7/clock.h enum clk_root_index { · line 181

Quoted 10 lines
arch/arm/include/asm/arch-mx7/clock.h +1 -6
-#define UART_CLK_ROOT UART6_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 6)
-#define UART_CLK_ROOT UART7_CLK_ROOT
-#else
-#error "Invalid IMX UART ID for serial console is defined"
-#endif
+#define UART_CLK_ROOT (UART1_CLK_ROOT + CONFIG_CONS_INDEX)
 
 struct clk_root_setting {
 	enum clk_root_index root;

It looks ok but CONFIG_CONS_INDEX *must* be set, else it breaks boards. Patch breaks at least the colibri boards.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#7 lore raw

PATCH 3/3 pico-imx7d: polish uart clock id definition

Quoted 48 lines · Stefano Babic <[email protected]> 于2019年10月13日周日 下午9:35写道:

Hi Jun,

I am just trying to check if some patch was silently lost, I found yours:

Quoted 28 lines · Jun Nie

Polish uart clock id definition. Default IMX7 UART ID is UART1 as original parameter in imx_get_uartclk().

---
 arch/arm/include/asm/arch-mx7/clock.h | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
arch/arm/include/asm/arch-mx7/clock.h +0 -11
index 1d07fde..a8e6097 100644
@@ -175,23 +175,7 @@ enum clk_root_index {
      CLK_ROOT_MAX,
 };
 
-#if (CONFIG_CONS_INDEX == 0)
-#define UART_CLK_ROOT UART1_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 1)
-#define UART_CLK_ROOT UART2_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 2)
-#define UART_CLK_ROOT UART3_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 3)
-#define UART_CLK_ROOT UART4_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 4)
-#define UART_CLK_ROOT UART5_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 5)

arch/arm/include/asm/arch-mx7/clock.h enum clk_root_index { · line 181

Quoted 10 lines
arch/arm/include/asm/arch-mx7/clock.h +1 -6
-#define UART_CLK_ROOT UART6_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 6)
-#define UART_CLK_ROOT UART7_CLK_ROOT
-#else
-#error "Invalid IMX UART ID for serial console is defined"
-#endif
+#define UART_CLK_ROOT (UART1_CLK_ROOT + CONFIG_CONS_INDEX)
 
 struct clk_root_setting {
      enum clk_root_index root;

It looks ok but CONFIG_CONS_INDEX *must* be set, else it breaks boards. Patch breaks at least the colibri boards.

Quoted 2 lines

Best regards,
Stefano

Thanks for finding the bug! I will test more boards in next round. This patch is an independent optimization patch to other patches. So I will sumit next version later.

Regards,
Jun

#8 lore raw

PATCH 3/3 pico-imx7d: polish uart clock id definition

Quoted 49 lines · Jun Nie
Quoted 48 lines · Stefano Babic <[email protected]> 于2019年10月13日周日 下午9:35写道:

Hi Jun,

I am just trying to check if some patch was silently lost, I found yours:

Quoted 28 lines · Jun Nie

Polish uart clock id definition. Default IMX7 UART ID is UART1 as original parameter in imx_get_uartclk().

---
 arch/arm/include/asm/arch-mx7/clock.h | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
arch/arm/include/asm/arch-mx7/clock.h +0 -11
index 1d07fde..a8e6097 100644
@@ -175,23 +175,7 @@ enum clk_root_index {
      CLK_ROOT_MAX,
 };
 
-#if (CONFIG_CONS_INDEX == 0)
-#define UART_CLK_ROOT UART1_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 1)
-#define UART_CLK_ROOT UART2_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 2)
-#define UART_CLK_ROOT UART3_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 3)
-#define UART_CLK_ROOT UART4_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 4)
-#define UART_CLK_ROOT UART5_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 5)

arch/arm/include/asm/arch-mx7/clock.h enum clk_root_index { · line 181

Quoted 10 lines
arch/arm/include/asm/arch-mx7/clock.h +1 -6
-#define UART_CLK_ROOT UART6_CLK_ROOT
-#elif (CONFIG_CONS_INDEX == 6)
-#define UART_CLK_ROOT UART7_CLK_ROOT
-#else
-#error "Invalid IMX UART ID for serial console is defined"
-#endif
+#define UART_CLK_ROOT (UART1_CLK_ROOT + CONFIG_CONS_INDEX)
 
 struct clk_root_setting {
      enum clk_root_index root;

It looks ok but CONFIG_CONS_INDEX *must* be set, else it breaks boards. Patch breaks at least the colibri boards.

Quoted 6 lines
Quoted 2 lines

Best regards,
Stefano

Thanks for finding the bug! I will test more boards in next round. This patch is an independent optimization patch to other patches. So I will sumit next version later.

Ok, thanks !

Regards,
Stefano

Quoted 4 lines

Regards,
Jun

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#9 lore raw

cover Support distro boot in pico-imx7d BL33 case

In reply to Jun Nie
Quoted 5 lines · Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写道:

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Hi,

any comments?

Thanks!
Jun

author
#10 lore raw

cover Support distro boot in pico-imx7d BL33 case

In reply to Jun Nie
Quoted 10 lines · Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写道:

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

Quoted 6 lines
 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37 +++++++++++------------------------
 3 files changed, 13 insertions(+), 43 deletions(-)

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it now? Thanks!

Best Regards
Jun

author
#11 lore raw

cover Support distro boot in pico-imx7d BL33 case

Quoted 17 lines · Jun Nie <[email protected]> 于2019年8月8日周四 下午12:04写道:
Quoted 15 lines · Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写道:

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37 +++++++++++------------------------
 3 files changed, 13 insertions(+), 43 deletions(-)
Quoted 8 lines
Quoted 1 line

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it now? Thanks!

Best Regards
Jun

Hi,

Does anyone has comments on these patches? Maybe we can merge them as no comments for a long time. Thanks!

Regards,
Jun

#12 lore raw

cover Support distro boot in pico-imx7d BL33 case

Hi Jun,

Quoted 28 lines

Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 7 lines · Jun Nie <[email protected]> 于2019年8月8日周四 下午12:04写道:
Quoted 5 lines · Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写道:

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Quoted 8 lines
Quoted 8 lines

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37

+++++++++++------------------------

Quoted 7 lines
Quoted 3 lines
 3 files changed, 13 insertions(+), 43 deletions(-)

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it now?

Thanks!

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

Best Regards
Jun

Hi,

Does anyone has comments on these patches? Maybe we can merge them as no comments for a long time. Thanks!

I could merge this patchset into nxp-imx and send pull request to Stefano, if you are fine with that.

Regards,
Peng.

Quoted 3 lines

Regards,
Jun

author
#13 lore raw

cover Support distro boot in pico-imx7d BL33 case

Quoted 36 lines · Peng Fan <[email protected]> 于2019年9月3日周二 上午9:39写道:

Hi Jun,

Quoted 33 lines

Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 7 lines · Jun Nie <[email protected]> 于2019年8月8日周四 下午12:04写道:
Quoted 5 lines · Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写道:

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Quoted 8 lines
Quoted 8 lines

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37

+++++++++++------------------------

Quoted 7 lines
Quoted 3 lines
 3 files changed, 13 insertions(+), 43 deletions(-)

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it now?

Thanks!

Quoted 3 lines

Best Regards
Jun

Hi,

Quoted 8 lines
Quoted 2 lines

Does anyone has comments on these patches? Maybe we can merge them as no comments for a long time. Thanks!

I could merge this patchset into nxp-imx and send pull request to Stefano, if you are fine with that.

Regards,
Peng.

Hi Peng,

I am fine. Thank you!

Jun

Quoted 4 lines
Quoted 4 lines

Regards,
Jun

author
#14 lore raw

cover Support distro boot in pico-imx7d BL33 case

In reply to Peng Fan
Quoted 36 lines · Peng Fan <[email protected]> 于2019年9月3日周二 上午9:39写道:

Hi Jun,

Quoted 33 lines

Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 7 lines · Jun Nie <[email protected]> 于2019年8月8日周四 下午12:04写道:
Quoted 5 lines · Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写道:

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Quoted 8 lines
Quoted 8 lines

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37

+++++++++++------------------------

Quoted 7 lines
Quoted 3 lines
 3 files changed, 13 insertions(+), 43 deletions(-)

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it now?

Thanks!

Quoted 3 lines

Best Regards
Jun

Hi,

Quoted 8 lines
Quoted 2 lines

Does anyone has comments on these patches? Maybe we can merge them as no comments for a long time. Thanks!

I could merge this patchset into nxp-imx and send pull request to Stefano, if you are fine with that.

Regards,
Peng.

Peng,

It is appreciated to help on this. Any comments from Stefan? Thanks!

Regards,
Jun

Quoted 4 lines
Quoted 4 lines

Regards,
Jun

#15 lore raw

cover Support distro boot in pico-imx7d BL33 case

Quoted 57 lines

-----Original Message-----
From: Jun Nie <[email protected]>
Sent: 2019年9月9日 21:47
To: Peng Fan <[email protected]>
Cc: Stefano Babic <[email protected]>; Fabio Estevam <[email protected]>; Otavio Salvador <[email protected]>; Vanessa Maegima <[email protected]>; Bryan O'Donoghue <[email protected]>; U-Boot Mailing List <[email protected]>
Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 8 lines · Peng Fan <[email protected]> 于2019年9月3日周二 上午9:39写道:

Hi Jun,

Quoted 5 lines

Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 2 lines · Jun Nie <[email protected]> 于2019年8月8日周四 下午12:04写道:

Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写

道:

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37
Quoted 8 lines
Quoted 8 lines

+++++++++++------------------------

Quoted 7 lines
Quoted 3 lines
 3 files changed, 13 insertions(+), 43 deletions(-)

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it

now?

Quoted 13 lines
Quoted 9 lines

Thanks!

Quoted 3 lines

Best Regards
Jun

Hi,

Does anyone has comments on these patches? Maybe we can merge them as no comments for a long time. Thanks!

I could merge this patchset into nxp-imx and send pull request to Stefano, if you are fine with that.

Quoted 6 lines
Quoted 2 lines

Regards,
Peng.

Peng,

It is appreciated to help on this. Any comments from Stefan? Thanks!

CI build failed:
https://travis-ci.org/MrVan/u-boot/jobs/583445551
I need drop your patchset.

Thanks,
Peng.

Quoted 7 lines

Regards,
Jun

Quoted 4 lines
Quoted 4 lines

Regards,
Jun

author
#16 lore raw

cover Support distro boot in pico-imx7d BL33 case

Quoted 63 lines · Peng Fan <[email protected]> 于2019年9月11日周三 下午2:02写道:
Quoted 63 lines

-----Original Message-----
From: Jun Nie <[email protected]>
Sent: 2019年9月9日 21:47
To: Peng Fan <[email protected]>
Cc: Stefano Babic <[email protected]>; Fabio Estevam <[email protected]>; Otavio Salvador <[email protected]>; Vanessa Maegima <[email protected]>; Bryan O'Donoghue <[email protected]>; U-Boot Mailing List <[email protected]>
Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 8 lines · Peng Fan <[email protected]> 于2019年9月3日周二 上午9:39写道:

Hi Jun,

Quoted 5 lines

Subject: Re: [PATCH 0/3] Support distro boot in pico-imx7d BL33 case

Quoted 2 lines · Jun Nie <[email protected]> 于2019年8月8日周四 下午12:04写道:

Jun Nie <[email protected]> 于2019年7月16日周二 下午3:43写

道:

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

Support distro boot in pico-imx7d BL33 case with changing the enviroment variables. While the other two patches are for polishing clock code and for feature enablement.

Jun Nie (3):
pico-imx7d: add config to enable CAAM
pico-imx7d: Support distro boot for FIT image case
pico-imx7d: polish uart clock id definition

 arch/arm/include/asm/arch-mx7/clock.h | 18 +----------------
 configs/pico-imx7d_bl33_defconfig     |  1 +
 include/configs/pico-imx7d.h          | 37
Quoted 8 lines
Quoted 8 lines

+++++++++++------------------------

Quoted 7 lines
Quoted 3 lines
 3 files changed, 13 insertions(+), 43 deletions(-)

--

Hi Vanessa,

Do you have any comments on these 3 patches? Or we can merge it

now?

Quoted 7 lines
Quoted 7 lines

Thanks!

Quoted 3 lines

Best Regards
Jun

Hi,

Quoted 8 lines
Quoted 2 lines

Does anyone has comments on these patches? Maybe we can merge them as no comments for a long time. Thanks!

I could merge this patchset into nxp-imx and send pull request to Stefano, if you are fine with that.

Regards,
Peng.

Peng,

Quoted 8 lines
Quoted 1 line

It is appreciated to help on this. Any comments from Stefan? Thanks!

CI build failed:
https://travis-ci.org/MrVan/u-boot/jobs/583445551
I need drop your patchset.

Thanks,
Peng.

Thanks for the result. Can you help to only drop the patch for polishing clock? The three patches are not tightly coupled actually.

Regards,
Jun

Quoted 8 lines
Quoted 8 lines

Regards,
Jun

Quoted 4 lines
Quoted 4 lines

Regards,
Jun