i2c: Aspeed: Add AST2600 compatible string
Subsystems (4)
cover i2c: Aspeed: Add AST2600 compatible string
Update the Aspeed I2C driver with the AST2600 compatible string. The default driver behavior works fine with the AST2600. A new compatible string is needed to avoid the AST2400 and AST2500 behavior.
Eddie James (2):
i2c: Aspeed: Add AST2600 compatible
dt-bindings: i2c: Aspeed: Add AST2600 compatible
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++- drivers/i2c/busses/i2c-aspeed.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.3.1
PATCH 1/2 i2c: Aspeed: Add AST2600 compatible
The driver default behavior works with the AST2600. We need a new compatible though to make sure the driver doesn't enable AST2400 or AST2500 behavior.
--- drivers/i2c/busses/i2c-aspeed.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/i2c/busses/i2c-aspeed.c +4 -0
@@ -938,6 +938,10 @@ static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus) .compatible = "aspeed,ast2500-i2c-bus", .data = aspeed_i2c_25xx_get_clk_reg_val, }, + { + .compatible = "aspeed,ast2600-i2c-bus", + .data = aspeed_i2c_25xx_get_clk_reg_val, + }, { }, };MODULE_DEVICE_TABLE (of, aspeed_i2c_bus_of_table);
Signature · 1 line
1.8.3.1
Re: [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible
Quoted 5 lines · Eddie James
The driver default behavior works with the AST2600. We need a new compatible though to make sure the driver doesn't enable AST2400 or AST2500 behavior.
Signed-off-by Eddie James <[email protected]>
Thanks!
Wolfram Sang
AppliedRe: [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible
In reply to Eddie JamesQuoted 5 lines · Eddie James
The driver default behavior works with the AST2600. We need a new compatible though to make sure the driver doesn't enable AST2400 or AST2500 behavior.
Signed-off-by Eddie James <[email protected]>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/2281d57d/attachment.sig>
PATCH 2/2 dt-bindings: i2c: Aspeed: Add AST2600 compatible
In reply to Eddie JamesDocument the AST2600 I2C bus compatible string.
--- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +2 -1
@@ -1,4 +1,4 @@ -Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs. +Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs. Required Properties: - #address-cells : should be 1
@@ -6,6 +6,7 @@ Required Properties: - reg : address offset and range of bus - compatible : should be "aspeed,ast2400-i2c-bus" or "aspeed,ast2500-i2c-bus" + or "aspeed,ast2600-i2c-bus" - clocks : root clock of bus, should reference the APB clock in the second cell - resets : phandle to reset controller with the reset number in
Signature · 1 line
1.8.3.1
Re: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible
Quoted 3 lines · Eddie James
Document the AST2600 I2C bus compatible string.
Signed-off-by Eddie James <[email protected]>
Thanks!
Re: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible
In reply to Eddie JamesQuoted 12 lines · Eddie James
Document the AST2600 I2C bus compatible string.
Signed-off-by Eddie James <[email protected]>--- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +0
-0
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt line 1
Quoted 2 lines
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +1
-1@@ -1,4 +1,4 @@ -Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs. +Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs.
Perhaps s/buses/busses/ while you're here.
Quoted 14 lines
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +1
-0Required Properties: - #address-cells : should be 1@@ -6,6 +6,7 @@ Required Properties: - reg : address offset and range of bus - compatible : should be "aspeed,ast2400-i2c-bus" or "aspeed,ast2500-i2c-bus" + or "aspeed,ast2600-i2c-bus" - clocks : root clock of bus, should reference the APB clock in the second cell - resets : phandle to reset controller with the reset number inSignature · 1 line
1.8.3.1
Wolfram Sang
AppliedRe: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible
In reply to Eddie JamesQuoted 3 lines · Eddie James
Document the AST2600 I2C bus compatible string.
Signed-off-by Eddie James <[email protected]>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/f1b1e391/attachment.sig>