Skip to contentSkip to conversation

i2c: Aspeed: Add AST2600 compatible string

PATCH Applied Eddie James 4 participants 8 messages Sep 13, 2019 – Oct 21, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover i2c: Aspeed: Add AST2600 compatible string

Update the Aspeed I2C driver with the AST2600 compatible string. The default driver behavior works fine with the AST2600. A new compatible string is needed to avoid the AST2400 and AST2500 behavior.

Eddie James (2):
i2c: Aspeed: Add AST2600 compatible
dt-bindings: i2c: Aspeed: Add AST2600 compatible

 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++-
 drivers/i2c/busses/i2c-aspeed.c                      | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/2 i2c: Aspeed: Add AST2600 compatible

The driver default behavior works with the AST2600. We need a new compatible though to make sure the driver doesn't enable AST2400 or AST2500 behavior.

---
 drivers/i2c/busses/i2c-aspeed.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/i2c/busses/i2c-aspeed.c +4 -0
index fa66951..c2a6e5a 100644
@@ -938,6 +938,10 @@ static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus)
 		.compatible = "aspeed,ast2500-i2c-bus",
 		.data = aspeed_i2c_25xx_get_clk_reg_val,
 	},
+	{
+		.compatible = "aspeed,ast2600-i2c-bus",
+		.data = aspeed_i2c_25xx_get_clk_reg_val,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, aspeed_i2c_bus_of_table);
Signature · 1 line
1.8.3.1
#4 lore raw

PATCH 2/2 dt-bindings: i2c: Aspeed: Add AST2600 compatible

In reply to Eddie James

Document the AST2600 I2C bus compatible string.

---
 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +2 -1
index 8fbd863..b47f6cc 100644
@@ -1,4 +1,4 @@
-Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs.
+Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs.
 
 Required Properties:
 - #address-cells	: should be 1
@@ -6,6 +6,7 @@ Required Properties:
 - reg			: address offset and range of bus
 - compatible		: should be "aspeed,ast2400-i2c-bus"
 			  or "aspeed,ast2500-i2c-bus"
+			  or "aspeed,ast2600-i2c-bus"
 - clocks		: root clock of bus, should reference the APB
 			  clock in the second cell
 - resets		: phandle to reset controller with the reset number in
Signature · 1 line
1.8.3.1
maintainer Acked-by on v1 2/2
#6 lore raw

Re: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible

In reply to Eddie James
Quoted 12 lines · Eddie James

Document the AST2600 I2C bus compatible string.

---
 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +0 -0
index 8fbd863..b47f6cc 100644

Documentation/devicetree/bindings/i2c/i2c-aspeed.txt line 1

Quoted 2 lines
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +1 -1
@@ -1,4 +1,4 @@
-Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs.
+Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs.

Perhaps s/buses/busses/ while you're here.

Quoted 14 lines
Documentation/devicetree/bindings/i2c/i2c-aspeed.txt +1 -0
 Required Properties:
 - #address-cells	: should be 1
@@ -6,6 +6,7 @@ Required Properties:
 - reg			: address offset and range of bus
 - compatible		: should be "aspeed,ast2400-i2c-bus"
 			  or "aspeed,ast2500-i2c-bus"
+			  or "aspeed,ast2600-i2c-bus"
 - clocks		: root clock of bus, should reference the APB
 			  clock in the second cell
 - resets		: phandle to reset controller with the reset number in
Signature · 1 line
1.8.3.1
Applied
#3 lore raw

Re: [PATCH 1/2] i2c: Aspeed: Add AST2600 compatible

In reply to Eddie James
Quoted 5 lines · Eddie James

The driver default behavior works with the AST2600. We need a new compatible though to make sure the driver doesn't enable AST2400 or AST2500 behavior.

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/2281d57d/attachment.sig>

Applied
#7 lore raw

Re: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible

In reply to Eddie James
Quoted 3 lines · Eddie James

Document the AST2600 I2C bus compatible string.

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/f1b1e391/attachment.sig>