riscv: Skip checking CSR privilege level in debugger mode
PATCH 1/1 riscv: Skip checking CSR privilege level in debugger mode
If we are in debugger mode, skip the CSR privilege level checking so that we can read/write all CSRs. Otherwise we get:
(gdb) p/x $mtvec
Could not fetch register "mtvec"; remote failure reply 'E14'
when the hart is currently in S-mode.
Reported-by Zong Li <[email protected]>
Signed-off-by Bin Meng <[email protected]>
---
target/riscv/csr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
target/riscv/csr.c +4 -1
@@ -801,7 +801,10 @@ int riscv_csrrw(CPURISCVState *env, int csrno, target_ulong *ret_value,#if !defined(CONFIG_USER_ONLY )int csr_priv =get_field (csrno,0x300 );int read_only =get_field (csrno,0xC00 ) ==3 ; -if ((write_mask && read_only) || (env->priv < csr_priv)) { +if ((!env->debugger) && (env->priv < csr_priv)) { +return -1 ; + } +if (write_mask && read_only) {return -1 ; }#endif
Signature · 1 line
2.7.4
Quoted 11 lines · Bin Meng
If we are in debugger mode, skip the CSR privilege level checking so that we can read/write all CSRs. Otherwise we get:
(gdb) p/x $mtvec
Could not fetch register "mtvec"; remote failure reply 'E14'when the hart is currently in S-mode.
Reported-by Zong Li <[email protected]>Signed-off-by Bin Meng <[email protected]>
Reviewed-by Alistair Francis <[email protected]>
Alistair
Quoted 25 lines
---
target/riscv/csr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)target/riscv/csr.c +4
-2@@ -801,7 +801,10 @@ int riscv_csrrw(CPURISCVState *env, int csrno, target_ulong *ret_value,#if !defined(CONFIG_USER_ONLY )int csr_priv =get_field (csrno,0x300 );int read_only =get_field (csrno,0xC00 ) ==3 ; -if ((write_mask && read_only) || (env->priv < csr_priv)) { +if ((!env->debugger) && (env->priv < csr_priv)) { +return -1 ; + } +if (write_mask && read_only) {return -1 ; }#endif --2.7.4