powerpc: expose secure variables to the kernel and userspace
Subsystems (7)
v9 cover powerpc: expose secure variables to the kernel and userspace
In order to verify the OS kernel on PowerNV systems, secure boot requires X.509 certificates trusted by the platform. These are stored in secure variables controlled by OPAL, called OPAL secure variables. In order to enable users to manage the keys, the secure variables need to be exposed to userspace.
OPAL provides the runtime services for the kernel to be able to access the secure variables[1]. This patchset defines the kernel interface for the OPAL APIs. These APIs are used by the hooks, which load these variables to the keyring and expose them to the userspace for reading/writing.
The previous version[2] of the patchset added support only for the sysfs interface. This patch adds two more patches that involves loading of the firmware trusted keys to the kernel keyring.
Overall, this patchset adds the following support:
* expose secure variables to the kernel via OPAL Runtime API interface
* expose secure variables to the userspace via kernel sysfs interface
* load kernel verification and revocation keys to .platform and .blacklist keyring respectively.
The secure variables can be read/written using simple linux utilities cat/hexdump.
For example:
Path to the secure variables is:/sys/firmware/secvar/vars
Each secure variable is listed as directory.
$ ls -l total 0 drwxr-xr-x. 2 root root 0 Aug 20 21:20 db drwxr-xr-x. 2 root root 0 Aug 20 21:20 KEK drwxr-xr-x. 2 root root 0 Aug 20 21:20 PK
The attributes of each of the secure variables are(for example: PK):
[db]$ ls -l
total 0
-r--r--r--. 1 root root 4096 Oct 1 15:10 data -r--r--r--. 1 root root 65536 Oct 1 15:10 size --w-------. 1 root root 4096 Oct 1 15:12 update
The "data" is used to read the existing variable value using hexdump. The data is stored in ESL format.
The "update" is used to write a new value using cat. The update is to be submitted as AUTH file.
[1] Depends on skiboot OPAL API changes which removes metadata from the API. https://lists.ozlabs.org/pipermail/skiboot/2019-September/015203.html.
[2] https://lkml.org/lkml/2019/6/13/1644
Changelog:
v9:
* Updated Patch 1,2,4 to search secvar device tree node based on generic compatible string.
* Renamed "backend" attribute to "format" attribute, and updated it with the value of "format" property of secvar backend
* Updated Patch 4/4 to look for "format" property to ensure edk2-compat-v1 variables format
v8
* rebased on v5.4-rc6
* Patch 2 related to sysfs
* fixed error message as per Greg's feedback
* fixed minor formatting
* renamed error code from ret to rc in backend_show()
* Patch 4 - loading of keys to keyring
* as per Michael's feedback, removed select for LOAD_PPC_KEYS, instead made it default "yes" if the pre-requisites are satisfied
* fixed an error message for more clarity
v7 (on behalf of Nayna, by Eric Richter):
* secvar-sysfs now a bool rather than a tristate option
* added documentation for backend sysfs entry
v6 (on behalf of Nayna, by Eric Richter):
* updated device tree layout
* secvar node now sets compatible based on backend
* all ibm,secvar-v1 compatible-checking code checks for
ibm,edk2-compat-v1
* added backend attribute to secvar-sysfs to expose backend version to userspace
* loading certs from db now depends on backend (not all backends may have a "db")
* fixed device node leaks
* fixed leaking string on early exit
v5:
* rebased to v5.4-rc3
* includes Oliver's feedbacks
* changed OPAL API as platform driver
* sysfs are made default enabled and dependent on PPC_SECURE_BOOT
* fixed code specific changes in both OPAL API and sysfs
* reading size of the "data" and "update" file from device-tree.
* fixed sysfs documentation to also reflect the data and update file size interpretation
* This patchset is no more dependent on ima-arch/blacklist patchset
v4:
* rebased to v5.4-rc1
* uses __BIN_ATTR_WO macro to create binary attribute as suggested by Greg
* removed email id from the file header
* renamed argument keysize to keybufsize in get_next() function
* updated default binary file sizes to 0, as firmware handles checking against the maximum size
* fixed minor formatting issues in Patch 4/4
* added Greg's and Mimi's Reviewed-by and Ack-by
v3:
* includes Greg's feedbacks:
* fixes in Patch 2/4
* updates the Documentation.
* fixes code feedbacks
* adds SYSFS Kconfig dependency for SECVAR_SYSFS
* fixes mixed tabs and spaces
* removes "name" attribute for each of the variable name based directories
* fixes using __ATTR_RO() and __BIN_ATTR_RO() and statics and const
* fixes the racing issue by using kobj_type default groups. Also, fixes the kobject leakage.
* removes extra print messages
* updates patch description for Patch 3/4
* removes file name from Patch 4/4 file header comment and removed def_bool y from the LOAD_PPC_KEYS Kconfig
* includes Oliver's feedbacks:
* fixes Patch 1/2
* moves OPAL API wrappers after opal_nx_proc_init(), fixed the naming, types and removed extern.
* fixes spaces
* renames get_variable() to get(), get_next_variable() to get_next() and set_variable() to set()
* removed get_secvar_ops() and defined secvar_ops as global
* fixes consts and statics
* removes generic secvar_init() and defined platform specific opal_secar_init()
* updates opal_secvar_supported() to check for secvar support even before checking the OPAL APIs support and also fixed the error codes.
* addes function that converts OPAL return codes to linux errno
* moves secvar check support in the opal_secvar_init() and defined its prototype in opal.h
* fixes Patch 2/2
* fixes static/const
* defines macro for max name size
* replaces OPAL error codes with linux errno and also updated error handling
* moves secvar support check before creating sysfs kobjects in secvar_sysfs_init()
* fixes spaces
v2:
* removes complete efi-sms from the sysfs implementation and is simplified
* includes Greg's and Oliver's feedbacks:
* adds sysfs documentation
* moves sysfs code to arch/powerpc
* other code related feedbacks.
* adds two new patches to load keys to .platform and .blacklist keyring. These patches are added to this series as they are also dependent on OPAL APIs.
Nayna Jain (4):
powerpc/powernv: Add OPAL API interface to access secure variable
powerpc: expose secure variables to userspace via sysfs x86/efi: move common keyring handler functions to new file
powerpc: load firmware trusted keys/hashes into kernel keyring
Documentation/ABI/testing/sysfs-secvar | 46 ++++ arch/powerpc/Kconfig | 11 + arch/powerpc/include/asm/opal-api.h | 5 +- arch/powerpc/include/asm/opal.h | 7 + arch/powerpc/include/asm/secvar.h | 35 +++ arch/powerpc/kernel/Makefile | 3 +- arch/powerpc/kernel/secvar-ops.c | 16 ++ arch/powerpc/kernel/secvar-sysfs.c | 248 +++++++++++++++++++++ arch/powerpc/platforms/powernv/Makefile | 2 +- arch/powerpc/platforms/powernv/opal-call.c | 3 + arch/powerpc/platforms/powernv/opal-secvar.c | 140 ++++++++++++ arch/powerpc/platforms/powernv/opal.c | 3 + security/integrity/Kconfig | 9 + security/integrity/Makefile | 7 +- .../integrity/platform_certs/keyring_handler.c | 80 +++++++ .../integrity/platform_certs/keyring_handler.h | 32 +++ security/integrity/platform_certs/load_powerpc.c | 99 ++++++++ security/integrity/platform_certs/load_uefi.c | 67 +----- 18 files changed, 742 insertions(+), 71 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-secvar create mode 100644 arch/powerpc/include/asm/secvar.h create mode 100644 arch/powerpc/kernel/secvar-ops.c create mode 100644 arch/powerpc/kernel/secvar-sysfs.c create mode 100644 arch/powerpc/platforms/powernv/opal-secvar.c create mode 100644 security/integrity/platform_certs/keyring_handler.c create mode 100644 security/integrity/platform_certs/keyring_handler.h create mode 100644 security/integrity/platform_certs/load_powerpc.c
Signature · 1 line
2.13.6
PATCH v9 1/4 powerpc/powernv: Add OPAL API interface to access secure variable
The X.509 certificates trusted by the platform and required to secure boot the OS kernel are wrapped in secure variables, which are controlled by OPAL.
This patch adds firmware/kernel interface to read and write OPAL secure variables based on the unique key.
This support can be enabled using CONFIG_OPAL_SECVAR.
--- arch/powerpc/include/asm/opal-api.h | 5 +- arch/powerpc/include/asm/opal.h | 7 ++ arch/powerpc/include/asm/secvar.h | 35 +++++++ arch/powerpc/kernel/Makefile | 2 +- arch/powerpc/kernel/secvar-ops.c | 16 +++ arch/powerpc/platforms/powernv/Makefile | 2 +- arch/powerpc/platforms/powernv/opal-call.c | 3 + arch/powerpc/platforms/powernv/opal-secvar.c | 140 +++++++++++++++++++++++++++ arch/powerpc/platforms/powernv/opal.c | 3 + 9 files changed, 210 insertions(+), 3 deletions(-) create mode 100644 arch/powerpc/include/asm/secvar.h create mode 100644 arch/powerpc/kernel/secvar-ops.c create mode 100644 arch/powerpc/platforms/powernv/opal-secvar.c
arch/powerpc/include/asm/opal-api.h +4 -1
@@ -211,7 +211,10 @@#define OPAL_MPIPL_UPDATE 173#define OPAL_MPIPL_REGISTER_TAG 174#define OPAL_MPIPL_QUERY_TAG 175 -#define OPAL_LAST 175 +#define OPAL_SECVAR_GET 176 +#define OPAL_SECVAR_GET_NEXT 177 +#define OPAL_SECVAR_ENQUEUE_UPDATE 178 +#define OPAL_LAST 178#define QUIESCE_HOLD 1/* Spin all calls at entry */ #define QUIESCE_REJECT 2/* Fail all calls with OPAL_BUSY */
arch/powerpc/include/asm/opal.h +7 -0
@@ -298,6 +298,13 @@ int opal_sensor_group_clear(u32 group_hndl, int token);int opal_sensor_group_enable (u32 group_hndl,int token,bool enable);int opal_nx_coproc_init (uint32_t chip_id,uint32_t ct); +int opal_secvar_get (const char *key,uint64_t key_len,u8 *data, +uint64_t *data_size); +int opal_secvar_get_next (const char *key,uint64_t *key_len, +uint64_t key_buf_size); +int opal_secvar_enqueue_update (const char *key,uint64_t key_len,u8 *data, +uint64_t data_size); +s64 opal_mpipl_update (enum opal_mpipl_ops op,u64 src,u64 dest,u64 size);s64 opal_mpipl_register_tag (enum opal_mpipl_tags tag,u64 addr);s64 opal_mpipl_query_tag (enum opal_mpipl_tags tag,u64 *addr);
arch/powerpc/include/asm/secvar.h new file +35 -0
@@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (C) 2019 IBM Corporation +* Author: Nayna Jain +* +* PowerPC secure variable operations. +*/ +#ifndef SECVAR_OPS_H +#define SECVAR_OPS_H + +#include <linux/types.h> +#include <linux/errno.h> + +extern const struct secvar_operations *secvar_ops; + +struct secvar_operations { +int (*get)(const char *key,uint64_t key_len,u8 *data, +uint64_t *data_size); +int (*get_next)(const char *key,uint64_t *key_len, +uint64_t keybufsize); +int (*set)(const char *key,uint64_t key_len,u8 *data, +uint64_t data_size); +}; + +#ifdef CONFIG_PPC_SECURE_BOOT + +extern void set_secvar_ops (const struct secvar_operations *ops); + +#else + +static inline void set_secvar_ops (const struct secvar_operations *ops) { } + +#endif + +#endif
arch/powerpc/kernel/Makefile +1 -1
@@ -161,7 +161,7 @@ ifneq ($(CONFIG_PPC_POWERNV)$(CONFIG_PPC_SVM),) obj-y += ucall.o endif -obj-$(CONFIG_PPC_SECURE_BOOT) += secure_boot.o ima_arch.o +obj-$(CONFIG_PPC_SECURE_BOOT) += secure_boot.o ima_arch.o secvar-ops.o # Disable GCOV, KCOV & sanitizers in odd or sensitive code GCOV_PROFILE_prom_init.o := n
arch/powerpc/kernel/secvar-ops.c new file +16 -0
@@ -0,0 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2019 IBM Corporation +* Author: Nayna Jain +* +* This file initializes secvar operations for PowerPC Secureboot +*/ + +#include <asm/secvar.h> + +const struct secvar_operations *secvar_ops; + +void set_secvar_ops (const struct secvar_operations *ops) +{ + secvar_ops = ops; +}
arch/powerpc/platforms/powernv/Makefile +1 -1
@@ -4,7 +4,7 @@ obj-y += idle.o opal-rtc.o opal-nvram.o opal-lpc.o opal-flash.o obj-y += rng.o opal-elog.o opal-dump.o opal-sysparam.o opal-sensor.o obj-y += opal-msglog.o opal-hmi.o opal-power.o opal-irqchip.o obj-y += opal-kmsg.o opal-powercap.o opal-psr.o opal-sensor-groups.o -obj-y += ultravisor.o +obj-y += ultravisor.o opal-secvar.o obj-$(CONFIG_SMP) += smp.o subcore.o subcore-asm.o obj-$(CONFIG_FA_DUMP) += opal-fadump.o
arch/powerpc/platforms/powernv/opal-call.c +3 -0
@@ -290,3 +290,6 @@ OPAL_CALL(opal_nx_coproc_init, OPAL_NX_COPROC_INIT);OPAL_CALL (opal_mpipl_update,OPAL_MPIPL_UPDATE );OPAL_CALL (opal_mpipl_register_tag,OPAL_MPIPL_REGISTER_TAG );OPAL_CALL (opal_mpipl_query_tag,OPAL_MPIPL_QUERY_TAG ); +OPAL_CALL (opal_secvar_get,OPAL_SECVAR_GET ); +OPAL_CALL (opal_secvar_get_next,OPAL_SECVAR_GET_NEXT ); +OPAL_CALL (opal_secvar_enqueue_update,OPAL_SECVAR_ENQUEUE_UPDATE );
arch/powerpc/platforms/powernv/opal-secvar.c new file +140 -0
140 lines not on this page · raw message
arch/powerpc/platforms/powernv/opal.c +3 -0
@@ -1002,6 +1002,9 @@ static int __init opal_init(void)/* Initialise OPAL Power control interface */ opal_power_control_init (); +/* Initialize OPAL secure variables */ +opal_pdev_init ("ibm,secvar-backend" ); +return 0 ; }machine_subsys_initcall (powernv, opal_init);
Signature · 1 line
2.13.6
Re: [PATCH v9 1/4] powerpc/powernv: Add OPAL API interface to access secure variable
Quoted 4 lines · Nayna Jain
The X.509 certificates trusted by the platform and required to secure boot the OS kernel are wrapped in secure variables, which are controlled by OPAL.
Quoted 8 lines
This patch adds
firmware/kernelinterface to read and write OPAL secure variables based on the unique key.This support can be enabled using
CONFIG_OPAL_SECVAR.Signed-off-by Claudio Carvalho <[email protected]>Signed-off-by Nayna Jain <[email protected]>Signed-off-by Eric Richter <[email protected]>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/9155e2341aa8b5df057dc1c77633b33d1a4f17d2
cheers
PATCH v9 2/4 powerpc: expose secure variables to userspace via sysfs
In reply to Nayna JainPowerNV secure variables, which store the keys used for OS kernel verification, are managed by the firmware. These secure variables need to be accessed by the userspace for addition/deletion of the certificates.
This patch adds the sysfs interface to expose secure variables for PowerNV secureboot. The users shall use this interface for manipulating the keys stored in the secure variables.
--- Documentation/ABI/testing/sysfs-secvar | 46 ++++++ arch/powerpc/Kconfig | 11 ++ arch/powerpc/kernel/Makefile | 1 + arch/powerpc/kernel/secvar-sysfs.c | 248 +++++++++++++++++++++++++++++++++ 4 files changed, 306 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-secvar create mode 100644 arch/powerpc/kernel/secvar-sysfs.c
Documentation/ABI/testing/sysfs-secvar new file +46 -0
@@ -0,0 +1,46 @@ +What: /sys/firmware/secvar +Date: August 2019 +Contact: Nayna Jain <[email protected]> +Description: This directory is created if the POWER firmware supports OS + secureboot, thereby secure variables. It exposes interface + for reading/writing the secure variables + +What: /sys/firmware/secvar/vars +Date: August 2019 +Contact: Nayna Jain <[email protected]> +Description: This directory lists all the secure variables that are supported + by the firmware. + +What: /sys/firmware/secvar/format +Date: August 2019 +Contact: Nayna Jain <[email protected]> +Description: A string indicating which backend is in use by the firmware. + This determines the format of the variable and the accepted + format of variable updates. + +What: /sys/firmware/secvar/vars/<variable name> +Date: August 2019 +Contact: Nayna Jain <[email protected]> +Description: Each secure variable is represented as a directory named as + <variable_name>. The variable name is unique and is in ASCII + representation. The data and size can be determined by reading + their respective attribute files. + +What: /sys/firmware/secvar/vars/<variable_name>/size +Date: August 2019 +Contact: Nayna Jain <[email protected]> +Description: An integer representation of the size of the content of the + variable. In other words, it represents the size of the data. + +What: /sys/firmware/secvar/vars/<variable_name>/data +Date: August 2019 +Contact: Nayna Jain h<[email protected]> +Description: A read-only file containing the value of the variable. The size + of the file represents the maximum size of the variable data. + +What: /sys/firmware/secvar/vars/<variable_name>/update +Date: August 2019 +Contact: Nayna Jain <[email protected]> +Description: A write-only file that is used to submit the new value for the + variable. The size of the file represents the maximum size of + the variable data that can be written.
arch/powerpc/Kconfig +11 -0
@@ -945,6 +945,17 @@ config PPC_SECURE_BOOT to enable OS secure boot on systems that have firmware support for it. If in doubt say N. +config PPC_SECVAR_SYSFS + bool "Enable sysfs interface for POWER secure variables" + default y + depends on PPC_SECURE_BOOT + depends on SYSFS + help + POWER secure variables are managed and controlled by firmware. + These variables are exposed to userspace via sysfs to enable + read/write operations on these variables. Say Y if you have + secure boot enabled and want to expose variables to userspace. + endmenu config ISA_DMA_API
arch/powerpc/kernel/Makefile +1 -0
@@ -162,6 +162,7 @@ obj-y += ucall.o endif obj-$(CONFIG_PPC_SECURE_BOOT) += secure_boot.o ima_arch.o secvar-ops.o +obj-$(CONFIG_PPC_SECVAR_SYSFS) += secvar-sysfs.o # Disable GCOV, KCOV & sanitizers in odd or sensitive code GCOV_PROFILE_prom_init.o := n
arch/powerpc/kernel/secvar-sysfs.c new file +248 -0
248 lines not on this page · raw message
Signature · 1 line
2.13.6
PATCH v9 3/4 x86/efi: move common keyring handler functions to new file
In reply to Nayna JainThe handlers to add the keys to the .platform keyring and blacklisted hashes to the .blacklist keyring is common for both the uefi and powerpc mechanisms of loading the keys/hashes from the firmware.
This patch moves the common code from load_uefi.c to keyring_handler.c
--- security/integrity/Makefile | 3 +- .../integrity/platform_certs/keyring_handler.c | 80 ++++++++++++++++++++++ .../integrity/platform_certs/keyring_handler.h | 32 +++++++++ security/integrity/platform_certs/load_uefi.c | 67 +----------------- 4 files changed, 115 insertions(+), 67 deletions(-) create mode 100644 security/integrity/platform_certs/keyring_handler.c create mode 100644 security/integrity/platform_certs/keyring_handler.h
security/integrity/Makefile +2 -1
@@ -11,7 +11,8 @@ integrity-$(CONFIG_INTEGRITY_SIGNATURE) += digsig.o integrity-$(CONFIG_INTEGRITY_ASYMMETRIC_KEYS) += digsig_asymmetric.o integrity-$(CONFIG_INTEGRITY_PLATFORM_KEYRING) += platform_certs/platform_keyring.o integrity-$(CONFIG_LOAD_UEFI_KEYS) += platform_certs/efi_parser.o \ - platform_certs/load_uefi.o + platform_certs/load_uefi.o \ + platform_certs/keyring_handler.o integrity-$(CONFIG_LOAD_IPL_KEYS) += platform_certs/load_ipl_s390.o obj-$(CONFIG_IMA) += ima/
security/integrity/platform_certs/keyring_handler.c new file +80 -0
80 lines not on this page · raw message
security/integrity/platform_certs/keyring_handler.h new file +32 -0
@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef PLATFORM_CERTS_INTERNAL_H +#define PLATFORM_CERTS_INTERNAL_H + +#include <linux/efi.h> + +void blacklist_hash (const char *source,const void *data, +size_t len,const char *type, +size_t type_len); + +/* +* Blacklist an X509 TBS hash. +*/ +void blacklist_x509_tbs (const char *source,const void *data,size_t len); + +/* +* Blacklist the hash of an executable. +*/ +void blacklist_binary (const char *source,const void *data,size_t len); + +/* +* Return the handler for particular signature list types found in the db. +*/ +efi_element_handler_t get_handler_for_db (const efi_guid_t *sig_type); + +/* +* Return the handler for particular signature list types found in the dbx. +*/ +efi_element_handler_t get_handler_for_dbx (const efi_guid_t *sig_type); + +#endif
security/integrity/platform_certs/load_uefi.c +1 -66
79 lines not on this page · raw message
Signature · 1 line
2.13.6
PATCH v9 4/4 powerpc: load firmware trusted keys/hashes into kernel keyring
In reply to Nayna JainThe keys used to verify the Host OS kernel are managed by firmware as secure variables. This patch loads the verification keys into the .platform keyring and revocation hashes into .blacklist keyring. This enables verification and loading of the kernels signed by the boot time keys which are trusted by firmware.
--- security/integrity/Kconfig | 9 +++ security/integrity/Makefile | 4 +- security/integrity/platform_certs/load_powerpc.c | 99 ++++++++++++++++++++++++ 3 files changed, 111 insertions(+), 1 deletion(-) create mode 100644 security/integrity/platform_certs/load_powerpc.c
security/integrity/Kconfig +9 -0
@@ -72,6 +72,15 @@ config LOAD_IPL_KEYS depends on S390 def_bool y +config LOAD_PPC_KEYS + bool "Enable loading of platform and blacklisted keys for POWER" + depends on INTEGRITY_PLATFORM_KEYRING + depends on PPC_SECURE_BOOT + default y + help + Enable loading of keys to the .platform keyring and blacklisted + hashes to the .blacklist keyring for powerpc based platforms. + config INTEGRITY_AUDIT bool "Enables integrity auditing support " depends on AUDIT
security/integrity/Makefile +3 -1
@@ -14,6 +14,8 @@ integrity-$(CONFIG_LOAD_UEFI_KEYS) += platform_certs/efi_parser.o \ platform_certs/load_uefi.o \ platform_certs/keyring_handler.o integrity-$(CONFIG_LOAD_IPL_KEYS) += platform_certs/load_ipl_s390.o - +integrity-$(CONFIG_LOAD_PPC_KEYS) += platform_certs/efi_parser.o \ + platform_certs/load_powerpc.o \ + platform_certs/keyring_handler.o obj-$(CONFIG_IMA) += ima/ obj-$(CONFIG_EVM) += evm/
security/integrity/platform_certs/load_powerpc.c new file +99 -0
99 lines not on this page · raw message
Signature · 1 line
2.13.6
On 11/10/19 7:10 PM, Nayna Jain wrote:
Hi Nayna,
Quoted 5 lines
In order to verify the OS kernel on PowerNV systems, secure boot requires X.509 certificates trusted by the platform. These are stored in secure variables controlled by OPAL, called OPAL secure variables. In order to enable users to manage the keys, the secure variables need to be exposed to userspace.
Are you planning to split the patches in this patch set into smaller chunks so that it is easier to code review and also perhaps make it easier when merging the changes?
Just a suggestion - but if, folks familiar with this code base don't have any objections, please feel free to ignore my comment.
Patch #1
1, opal-api.h which adds the #defines OPAL_SECVAR_ and the API signature. 2, secvar.h then adds secvar_operations struct
3, powerpc/kernel for the Interface definitions
4, powernv/opal-secvar.c for the API implementations
5, powernv/opal-call.c for the API calls
6, powernv/opal.c for the secvar init calls.
Patch #2
1, Definitions of attribute functions like backend_show, size_show, etc. 2, secvar_sysfs_load
3, secvar_sysfs_init
4, secvar_sysfs_exit
thanks,
-lakshmi
Michael Ellerman
reviewerQuoted 4 lines · Lakshmi Ramasubramanian
On 11/10/19 7:10 PM, Nayna Jain wrote:
Hi Nayna,
Quoted 8 lines
Quoted 5 lines
In order to verify the OS kernel on PowerNV systems, secure boot requires X.509 certificates trusted by the platform. These are stored in secure variables controlled by OPAL, called OPAL secure variables. In order to enable users to manage the keys, the secure variables need to be exposed to userspace.
Are you planning to split the patches in this patch set into smaller chunks so that it is easier to code review and also perhaps make it easier when merging the changes?
I don't think splitting them would add any value. They're already split into the firmware specific bits (patch 1), and the sysfs parts (patch 2), which is sufficient for me.
cheers