Skip to contentSkip to conversation

Add minimal boot support for IPQ6018

PATCH Superseded Sricharan R 2 participants 8 messages Jan 9, 2020 – Jan 16, 2020

Subsystems (7)

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v4 cover Add minimal boot support for IPQ6018

The IPQ6018 is Qualcomm\u2019s 802.11ax SoC for Routers, Gateways and Access Points.

This series adds minimal board boot support for ipq6018-cp01 board.

[v4]
* Addressed review comments in pinctrl bindings from Rob.
* Ran make dt_binding_check and no issues was reported.
* Deleted absahu email id from patch 4, since its bouncing now.
* Patch 4 arm64: dts: Add ipq6018 SoC and CP01 board support has build dependency with,

	https://lkml.org/lkml/2020/1/9/84

[V3]
* Removed clock driver and bindings from this patch series, and added them as a different series.
* Removed qpic_padN from pinctrl driver.
* Addressed review comments in dts, and added the remaining fixed clocks their
* Fixed review comments in pinctrl bindings
* Patch 4 arm64: dts: Add ipq6018 SoC and CP01 board support has build dependency with,

	https://patchwork.ozlabs.org/patch/1217293/

[v2]
* Splitted dt bindings and driver into different patches. Added missing bindings and some style changes.
* Added ipq6018 schema
* Addressed review comments for gcc clock bindings.
* Removed all clk critical flags, removed 1/1 factor clocks, moved to new way of specifying clk parents, and addressed other review comments.
* Sorted nodes based on address, name, label. Removed unused clock nodes, Addressed other review comments.

Sricharan R (5):
dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl bindings
pinctrl: qcom: Add ipq6018 pinctrl driver
dt-bindings: qcom: Add ipq6018 bindings
arm64: dts: Add ipq6018 SoC and CP01 board support
arm64: defconfig: Enable qcom ipq6018 clock and pinctrl

 Documentation/devicetree/bindings/arm/qcom.yaml    |    8 +
 .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml     |  174 +++
 arch/arm64/boot/dts/qcom/Makefile                  |    1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts       |   30 +
 arch/arm64/boot/dts/qcom/ipq6018.dtsi              |  263 +++++
 arch/arm64/configs/defconfig                       |    3 +
 drivers/pinctrl/qcom/Kconfig                       |   10 +
 drivers/pinctrl/qcom/Makefile                      |    1 +
 drivers/pinctrl/qcom/pinctrl-ipq6018.c             | 1107 ++++++++++++++++++++
 9 files changed, 1597 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
 create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq6018.c
Signature · 1 line
1.9.1
#1 lore raw

PATCH v4 1/5 dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl bindings

Add device tree binding Documentation details for ipq6018 pinctrl driver.

---
[V4]
* cleaned-up schema as per Rob's comments.
* Ran make dt_binding_check and no issues.

 .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml     | 140 +++++++++++++++++++++
 1 file changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +140 -0
new file mode 100644
index 0000000..68c3c8c
@@ -0,0 +1,140 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,ipq6018-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. IPQ6018 TLMM block
+
+maintainers:
+  - Sricharan R <[email protected]>
+
+description: |
+  This binding describes the Top Level Mode Multiplexer block found in the
+  IPQ6018 platform.
+
+properties:
+  compatible:
+    const: qcom,ipq6018-pinctrl
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description: Specifies the TLMM summary IRQ
+    maxItems: 1
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    description:
+      Specifies the PIN numbers and Flags, as defined in defined in
+      include/dt-bindings/interrupt-controller/irq.h
+    const: 2
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description: Specifying the pin number and flags, as defined in
+      include/dt-bindings/gpio/gpio.h
+    const: 2
+
+  gpio-ranges:
+    description: Documentation/devicetree/bindings/gpio/gpio.txt
+    maxItems: 1
+
+#PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+    type: object
+    description:
+      Pinctrl node's client devices use subnodes for desired pin configuration.
+      Client device subnodes use below standard properties.
+    allOf:
+      - $ref: "/schemas/pinctrl/pincfg-node.yaml"
+
+    properties:
+      pins:
+        description:
+          List of gpio pins affected by the properties specified in this
+          subnode.
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/string"
+          - enum: ['gpio$', sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
+            sdc2_data, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2,
+            qdsd_data3]
+
+      function:
+        description:
+          Specify the alternative function to be configured for the specified
+          pins.
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/string"
+          - enum: [ adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char,
+            atest_char0, atest_char1, atest_char2, atest_char3, atest_combodac,
+            atest_gpsadc0, atest_gpsadc1, atest_tsens, atest_wlan0,
+            atest_wlan1, backlight_en, bimc_dte0, bimc_dte1, blsp_i2c1,
+            blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_i2c6,  blsp_spi1,
+            blsp_spi1_cs1, blsp_spi1_cs2, blsp_spi1_cs3, blsp_spi2,
+            blsp_spi2_cs1, blsp_spi2_cs2, blsp_spi2_cs3, blsp_spi3,
+            blsp_spi3_cs1, blsp_spi3_cs2, blsp_spi3_cs3, blsp_spi4, blsp_spi5,
+            blsp_spi6, blsp_uart1, blsp_uart2, blsp_uim1, blsp_uim2, cam1_rst,
+            cam1_standby, cam_mclk0, cam_mclk1, cci_async, cci_i2c, cci_timer0,
+            cci_timer1, cci_timer2, cdc_pdm0, codec_mad, dbg_out, display_5v,
+            dmic0_clk, dmic0_data, dsi_rst, ebi0_wrcdc, euro_us, ext_lpass,
+            flash_strobe, gcc_gp1_clk_a, gcc_gp1_clk_b, gcc_gp2_clk_a,
+            gcc_gp2_clk_b, gcc_gp3_clk_a, gcc_gp3_clk_b, gpio, gsm0_tx0,
+            gsm0_tx1, gsm1_tx0, gsm1_tx1, gyro_accl, kpsns0, kpsns1, kpsns2,
+            ldo_en, ldo_update, mag_int, mdp_vsync, modem_tsync, m_voc,
+            nav_pps, nav_tsync, pa_indicator, pbs0, pbs1, pbs2, pri_mi2s,
+            pri_mi2s_ws, prng_rosc, pwr_crypto_enabled_a, pwr_crypto_enabled_b,
+            pwr_modem_enabled_a,  pwr_modem_enabled_b, pwr_nav_enabled_a,
+            pwr_nav_enabled_b, qdss_ctitrig_in_a0, qdss_ctitrig_in_a1,
+            qdss_ctitrig_in_b0, qdss_ctitrig_in_b1, qdss_ctitrig_out_a0,
+            qdss_ctitrig_out_a1, qdss_ctitrig_out_b0, qdss_ctitrig_out_b1,
+            qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b,
+            qdss_tracedata_a, qdss_tracedata_b, reset_n, sd_card, sd_write,
+            sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3,
+            uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst ]
+
+      drive-strength:
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/uint32"
+          - enum: [2, 4, 6, 8, 10, 12, 14, 16]
+        description:
+          Selects the drive strength for the specified pins, in mA.
+
+    required:
+      - pins
+      - function
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - '#interrupt-cells'
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges
+
+examples:
+  - |
+        #include <dt-bindings/interrupt-controller/arm-gic.h>
+        tlmm: pinctrl@1000000 {
+              compatible = "qcom,ipq6018-pinctrl";
+              reg = <0x01000000 0x300000>;
+              interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+              gpio-controller;
+              #gpio-cells = <2>;
+              gpio-ranges = <&tlmm 0 80>;
+              interrupt-controller;
+              #interrupt-cells = <2>;
+
+              serial3-pinmux {
+                      pins = "gpio44", "gpio45";
+                      function = "blsp2_uart";
+                      drive-strength = <8>;
+                      bias-pull-down;
+              };
+        };
Signature · 1 line
2.7.4
maintainer
#2 lore raw

Re: [PATCH V4 1/5] dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl bindings

Quoted 25 lines · Sricharan R

Add device tree binding Documentation details for ipq6018 pinctrl driver.

---
[V4]
* cleaned-up schema as per Rob's comments.
* Ran make dt_binding_check and no issues.

 .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml     | 140 +++++++++++++++++++++
 1 file changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +0 -0
new file mode 100644
index 0000000..68c3c8c

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 1

Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +1 -0
@@ -0,0 +1,140 @@
+# SPDX-License-Identifier: GPL-2.0-or-later

Dual license please.

(GPL-2.0-only or BSD-2-Clause)

Quoted 51 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +51 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,ipq6018-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. IPQ6018 TLMM block
+
+maintainers:
+  - Sricharan R <[email protected]>
+
+description: |
+  This binding describes the Top Level Mode Multiplexer block found in the
+  IPQ6018 platform.
+
+properties:
+  compatible:
+    const: qcom,ipq6018-pinctrl
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description: Specifies the TLMM summary IRQ
+    maxItems: 1
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    description:
+      Specifies the PIN numbers and Flags, as defined in defined in
+      include/dt-bindings/interrupt-controller/irq.h
+    const: 2
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description: Specifying the pin number and flags, as defined in
+      include/dt-bindings/gpio/gpio.h
+    const: 2
+
+  gpio-ranges:
+    description: Documentation/devicetree/bindings/gpio/gpio.txt
+    maxItems: 1
+
+#PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+    type: object
+    description:
+      Pinctrl node's client devices use subnodes for desired pin configuration.
+      Client device subnodes use below standard properties.

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 62

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+    allOf:
+      - $ref: "/schemas/pinctrl/pincfg-node.yaml"
+
+    properties:
+      pins:
+        description:
+          List of gpio pins affected by the properties specified in this
+          subnode.
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/string"

No need for type ref as the common binding does this.

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 72

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+          - enum: ['gpio$', sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
+            sdc2_data, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2,
+            qdsd_data3]
+
+      function:
+        description:
+          Specify the alternative function to be configured for the specified
+          pins.
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/string"

Same here.

Quoted 20 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +20 -0
+          - enum: [ adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char,
+            atest_char0, atest_char1, atest_char2, atest_char3, atest_combodac,
+            atest_gpsadc0, atest_gpsadc1, atest_tsens, atest_wlan0,
+            atest_wlan1, backlight_en, bimc_dte0, bimc_dte1, blsp_i2c1,
+            blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_i2c6,  blsp_spi1,
+            blsp_spi1_cs1, blsp_spi1_cs2, blsp_spi1_cs3, blsp_spi2,
+            blsp_spi2_cs1, blsp_spi2_cs2, blsp_spi2_cs3, blsp_spi3,
+            blsp_spi3_cs1, blsp_spi3_cs2, blsp_spi3_cs3, blsp_spi4, blsp_spi5,
+            blsp_spi6, blsp_uart1, blsp_uart2, blsp_uim1, blsp_uim2, cam1_rst,
+            cam1_standby, cam_mclk0, cam_mclk1, cci_async, cci_i2c, cci_timer0,
+            cci_timer1, cci_timer2, cdc_pdm0, codec_mad, dbg_out, display_5v,
+            dmic0_clk, dmic0_data, dsi_rst, ebi0_wrcdc, euro_us, ext_lpass,
+            flash_strobe, gcc_gp1_clk_a, gcc_gp1_clk_b, gcc_gp2_clk_a,
+            gcc_gp2_clk_b, gcc_gp3_clk_a, gcc_gp3_clk_b, gpio, gsm0_tx0,
+            gsm0_tx1, gsm1_tx0, gsm1_tx1, gyro_accl, kpsns0, kpsns1, kpsns2,
+            ldo_en, ldo_update, mag_int, mdp_vsync, modem_tsync, m_voc,
+            nav_pps, nav_tsync, pa_indicator, pbs0, pbs1, pbs2, pri_mi2s,
+            pri_mi2s_ws, prng_rosc, pwr_crypto_enabled_a, pwr_crypto_enabled_b,
+            pwr_modem_enabled_a,  pwr_modem_enabled_b, pwr_nav_enabled_a,
+            pwr_nav_enabled_b, qdss_ctitrig_in_a0, qdss_ctitrig_in_a1,

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 102

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+            qdss_ctitrig_in_b0, qdss_ctitrig_in_b1, qdss_ctitrig_out_a0,
+            qdss_ctitrig_out_a1, qdss_ctitrig_out_b0, qdss_ctitrig_out_b1,
+            qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b,
+            qdss_tracedata_a, qdss_tracedata_b, reset_n, sd_card, sd_write,
+            sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3,
+            uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst ]
+
+      drive-strength:
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/uint32"

Same here.

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 103

Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +1 -0
+          - enum: [2, 4, 6, 8, 10, 12, 14, 16]

default?

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 109

Quoted 7 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +6 -0
+        description:
+          Selects the drive strength for the specified pins, in mA.
 
+
+    required:
+      - pins
+      - function

additionalProperties: false

You'll need to list any other properties you use. Based on the example, you'll need 'bias-pull-down: true'.

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 119

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - '#interrupt-cells'
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges

additionalProperties: false

Quoted 5 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +5 -0
+
+examples:
+  - |
+        #include <dt-bindings/interrupt-controller/arm-gic.h>
+        tlmm: pinctrl@1000000 {

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 134

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+              compatible = "qcom,ipq6018-pinctrl";
+              reg = <0x01000000 0x300000>;
+              interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+              gpio-controller;
+              #gpio-cells = <2>;
+              gpio-ranges = <&tlmm 0 80>;
+              interrupt-controller;
+              #interrupt-cells = <2>;
+
+              serial3-pinmux {

Doesn't match the schema.

Quoted 9 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +6 -0
+                      pins = "gpio44", "gpio45";
+                      function = "blsp2_uart";
+                      drive-strength = <8>;
+                      bias-pull-down;
+              };
+        };
Signature · 1 line
2.7.4
#3 lore raw

Re: [PATCH V4 1/5] dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl bindings

Hi Rob,
Thanks for the review, fixed all below comments and posted V5.

Quoted 30 lines · Rob Herring
Quoted 25 lines · Sricharan R

Add device tree binding Documentation details for ipq6018 pinctrl driver.

---
[V4]
* cleaned-up schema as per Rob's comments.
* Ran make dt_binding_check and no issues.

 .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml     | 140 +++++++++++++++++++++
 1 file changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +0 -0
new file mode 100644
index 0000000..68c3c8c

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 1

Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +1 -0
@@ -0,0 +1,140 @@
+# SPDX-License-Identifier: GPL-2.0-or-later

Dual license please.

Quoted 2 lines

(GPL-2.0-only or BSD-2-Clause)

ok, fixed in V5

Quoted 55 lines
Quoted 55 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +55 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,ipq6018-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. IPQ6018 TLMM block
+
+maintainers:
+  - Sricharan R <[email protected]>
+
+description: |
+  This binding describes the Top Level Mode Multiplexer block found in the
+  IPQ6018 platform.
+
+properties:
+  compatible:
+    const: qcom,ipq6018-pinctrl
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description: Specifies the TLMM summary IRQ
+    maxItems: 1
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    description:
+      Specifies the PIN numbers and Flags, as defined in defined in
+      include/dt-bindings/interrupt-controller/irq.h
+    const: 2
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description: Specifying the pin number and flags, as defined in
+      include/dt-bindings/gpio/gpio.h
+    const: 2
+
+  gpio-ranges:
+    description: Documentation/devicetree/bindings/gpio/gpio.txt
+    maxItems: 1
+
+#PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+    type: object
+    description:
+      Pinctrl node's client devices use subnodes for desired pin configuration.
+      Client device subnodes use below standard properties.
+    allOf:
+      - $ref: "/schemas/pinctrl/pincfg-node.yaml"
+
+    properties:
Quoted 9 lines

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 62

Quoted 6 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +6 -0
+      pins:
+        description:
+          List of gpio pins affected by the properties specified in this
+          subnode.
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/string"

No need for type ref as the common binding does this.

ok. fixed in V5.

Quoted 11 lines

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 72

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+          - enum: ['gpio$', sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
+            sdc2_data, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2,
+            qdsd_data3]
+
+      function:
+        description:
+          Specify the alternative function to be configured for the specified
+          pins.
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/string"
Quoted 2 lines

Same here.

ok, fixed in V5.

Quoted 31 lines
Quoted 20 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +20 -0
+          - enum: [ adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char,
+            atest_char0, atest_char1, atest_char2, atest_char3, atest_combodac,
+            atest_gpsadc0, atest_gpsadc1, atest_tsens, atest_wlan0,
+            atest_wlan1, backlight_en, bimc_dte0, bimc_dte1, blsp_i2c1,
+            blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_i2c6,  blsp_spi1,
+            blsp_spi1_cs1, blsp_spi1_cs2, blsp_spi1_cs3, blsp_spi2,
+            blsp_spi2_cs1, blsp_spi2_cs2, blsp_spi2_cs3, blsp_spi3,
+            blsp_spi3_cs1, blsp_spi3_cs2, blsp_spi3_cs3, blsp_spi4, blsp_spi5,
+            blsp_spi6, blsp_uart1, blsp_uart2, blsp_uim1, blsp_uim2, cam1_rst,
+            cam1_standby, cam_mclk0, cam_mclk1, cci_async, cci_i2c, cci_timer0,
+            cci_timer1, cci_timer2, cdc_pdm0, codec_mad, dbg_out, display_5v,
+            dmic0_clk, dmic0_data, dsi_rst, ebi0_wrcdc, euro_us, ext_lpass,
+            flash_strobe, gcc_gp1_clk_a, gcc_gp1_clk_b, gcc_gp2_clk_a,
+            gcc_gp2_clk_b, gcc_gp3_clk_a, gcc_gp3_clk_b, gpio, gsm0_tx0,
+            gsm0_tx1, gsm1_tx0, gsm1_tx1, gyro_accl, kpsns0, kpsns1, kpsns2,
+            ldo_en, ldo_update, mag_int, mdp_vsync, modem_tsync, m_voc,
+            nav_pps, nav_tsync, pa_indicator, pbs0, pbs1, pbs2, pri_mi2s,
+            pri_mi2s_ws, prng_rosc, pwr_crypto_enabled_a, pwr_crypto_enabled_b,
+            pwr_modem_enabled_a,  pwr_modem_enabled_b, pwr_nav_enabled_a,
+            pwr_nav_enabled_b, qdss_ctitrig_in_a0, qdss_ctitrig_in_a1,

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 102

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +10 -0
+            qdss_ctitrig_in_b0, qdss_ctitrig_in_b1, qdss_ctitrig_out_a0,
+            qdss_ctitrig_out_a1, qdss_ctitrig_out_b0, qdss_ctitrig_out_b1,
+            qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b,
+            qdss_tracedata_a, qdss_tracedata_b, reset_n, sd_card, sd_write,
+            sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3,
+            uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst ]
+
+      drive-strength:
+        allOf:
+          - $ref: "/schemas/types.yaml#/definitions/uint32"
Quoted 2 lines

Same here.

fixed in v5.

Quoted 4 lines

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 103

Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +1 -0
+          - enum: [2, 4, 6, 8, 10, 12, 14, 16]

default?

fixed in v5.

Quoted 8 lines

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 109

Quoted 7 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +6 -0
+        description:
+          Selects the drive strength for the specified pins, in mA.
 
+
+    required:
+      - pins
+      - function
Quoted 5 lines

additionalProperties: false

You'll need to list any other properties you use. Based on the example, you'll need 'bias-pull-down: true'.

ok, fixed in v5.

Quoted 4 lines
Quoted 4 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +4 -0
+
+required:
+  - compatible
+  - reg
Quoted 9 lines

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 119

Quoted 6 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +6 -0
+  - interrupts
+  - interrupt-controller
+  - '#interrupt-cells'
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges

additionalProperties: false

ok, fixed in v5.

Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +9 -0
+
+examples:
+  - |
+        #include <dt-bindings/interrupt-controller/arm-gic.h>
+        tlmm: pinctrl@1000000 {
+              compatible = "qcom,ipq6018-pinctrl";
+              reg = <0x01000000 0x300000>;
+              interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+              gpio-controller;
Quoted 8 lines

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml line 134

Quoted 6 lines
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml new file +6 -0
+              #gpio-cells = <2>;
+              gpio-ranges = <&tlmm 0 80>;
+              interrupt-controller;
+              #interrupt-cells = <2>;
+
+              serial3-pinmux {

Doesn't match the schema.

fixed in v5.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#4 lore raw

PATCH v4 2/5 pinctrl: qcom: Add ipq6018 pinctrl driver

In reply to Sricharan R

Add initial pinctrl driver to support pin configuration with pinctrl framework for ipq6018.

---
 drivers/pinctrl/qcom/Kconfig           |   10 +
 drivers/pinctrl/qcom/Makefile          |    1 +
 drivers/pinctrl/qcom/pinctrl-ipq6018.c | 1107 ++++++++++++++++++++++++++++++++
 3 files changed, 1118 insertions(+)
 create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq6018.c
drivers/pinctrl/qcom/Kconfig +10 -0
index 811af2f8..c5d4428 100644
@@ -50,6 +50,16 @@ config PINCTRL_IPQ8074
 	  Qualcomm Technologies Inc. IPQ8074 platform. Select this for
 	  IPQ8074.
 
+config PINCTRL_IPQ6018
+	tristate "Qualcomm Technologies, Inc. IPQ6018 pin controller driver"
+	depends on GPIOLIB && OF
+	select PINCTRL_MSM
+	help
+	  This is the pinctrl, pinmux, pinconf and gpiolib driver for
+	  the Qualcomm Technologies Inc. TLMM block found on the
+	  Qualcomm Technologies Inc. IPQ6018 platform. Select this for
+	  IPQ6018.
+
 config PINCTRL_MSM8660
 	tristate "Qualcomm 8660 pin controller driver"
 	depends on GPIOLIB && OF
drivers/pinctrl/qcom/Makefile +1 -0
index c2c2f9a..d9e0904 100644
@@ -6,6 +6,7 @@ obj-$(CONFIG_PINCTRL_APQ8084)	+= pinctrl-apq8084.o
 obj-$(CONFIG_PINCTRL_IPQ4019)	+= pinctrl-ipq4019.o
 obj-$(CONFIG_PINCTRL_IPQ8064)	+= pinctrl-ipq8064.o
 obj-$(CONFIG_PINCTRL_IPQ8074)	+= pinctrl-ipq8074.o
+obj-$(CONFIG_PINCTRL_IPQ6018)	+= pinctrl-ipq6018.o
 obj-$(CONFIG_PINCTRL_MSM8660)	+= pinctrl-msm8660.o
 obj-$(CONFIG_PINCTRL_MSM8960)	+= pinctrl-msm8960.o
 obj-$(CONFIG_PINCTRL_MSM8X74)	+= pinctrl-msm8x74.o
drivers/pinctrl/qcom/pinctrl-ipq6018.c new file +1107 -0

1,107 lines not on this page · raw message

Signature · 1 line
2.7.4
#5 lore raw

PATCH v4 3/5 dt-bindings: qcom: Add ipq6018 bindings

In reply to Sricharan R

Document the new ipq6018 SOC/board device tree bindings.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +8 -0
index 529d924..164177e 100644
@@ -28,6 +28,7 @@ description: |
         apq8074
         apq8084
         apq8096
+        ipq6018
         ipq8074
         mdm9615
         msm8916
@@ -41,6 +42,7 @@ description: |
   The 'board' element must be one of the following strings:
 
         cdp
+        cp01-c1
         dragonboard
         hk01
         idp
@@ -150,4 +152,10 @@ properties:
           - enum:
               - qcom,sc7180-idp
           - const: qcom,sc7180
+
+      - items:
+          - enum:
+              - qcom,ipq6018-cp01-c1
+          - const: qcom,ipq6018
+
 ...
Signature · 1 line
2.7.4
#6 lore raw

PATCH v4 4/5 arm64: dts: Add ipq6018 SoC and CP01 board support

In reply to Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

---
 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  30 ++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 215 +++++++++++++++++++++++++++
 3 files changed, 246 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 973c0f0..204775f 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-longcheer-l8150.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +30 -0
new file mode 100644
index 0000000..897b4b2
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ6018 CP01 board device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq6018.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
+	compatible = "qcom,ipq6018-cp01", "qcom,ipq6018";
+
+	aliases {
+		serial0 = &blsp1_uart3;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+		bootargs-append = " swiotlb=1";
+	};
+};
+
+&blsp1_uart3 {
+	pinctrl-0 = <&serial_3_pins>;
+	pinctrl-names = "default";
+	status = "ok";
+};
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +215 -0

215 lines not on this page · raw message

Signature · 1 line
2.7.4
#7 lore raw

PATCH v4 5/5 arm64: defconfig: Enable qcom ipq6018 clock and pinctrl

In reply to Sricharan R

These configs are required for booting kernel in qcom ipq6018 boards.

---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/configs/defconfig +2 -0
index 28fed08..5e0b696 100644
@@ -405,6 +405,7 @@ CONFIG_PINCTRL_IMX8MN=y
 CONFIG_PINCTRL_IMX8MQ=y
 CONFIG_PINCTRL_IMX8QXP=y
 CONFIG_PINCTRL_IPQ8074=y
+CONFIG_PINCTRL_IPQ6018=y
 CONFIG_PINCTRL_MSM8916=y
 CONFIG_PINCTRL_MSM8994=y
 CONFIG_PINCTRL_MSM8996=y
@@ -714,6 +715,7 @@ CONFIG_QCOM_CLK_APCS_MSM8916=y
 CONFIG_QCOM_CLK_SMD_RPM=y
 CONFIG_QCOM_CLK_RPMH=y
 CONFIG_IPQ_GCC_8074=y
+CONFIG_IPQ_GCC_6018=y
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_GCC_8994=y
 CONFIG_MSM_MMCC_8996=y
Signature · 1 line
2.7.4