Skip to contentSkip to conversation

Add Cortina Access basic DM drivers

PATCH Superseded Alex Nemirovsky 2 participants 13 messages Jan 30, 2020

Subsystems (5)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add Cortina Access basic DM drivers

Cortina Access management has decided that we want to add formal upstream support of u-boot going forward for our line of SoCs and evaluation boards.

Our line of SoC’s all begin with the “CA” designation followed by 4 digits. i.e. CAxxxx. The CAxxxx series supports both ARM and MIPS ISA based custom cores.

All our drivers have cross platform support for both CPU ISAs. They will be placed in the normal drivers tree in u-boot.

In addition, our SoCs and development boards share common Cortina specific features which are not driver related. Those changes will be maintained in board/cortina/common. While specific development boards will be in board/cortina/board_name.

We would like to have a git-mailrc alias of "cortina" to allow us to better maintain and support our boards and common features found in the board/cortina subtree.

Changes in v3:
- Remove CA ARM and MIPS common subdirectories from board/cortina/common after further discussions with trini
- clean up comment blocks
- fix rmw of baud rate bitfield change
- fixed dts closing bracket indentation
- presidio.h: remove deadcode from presidio.h
- presidio.h: remove CA_REG_READ/CA_REG_WRITE wrapper macros
- presidio.h: remove CA77xx define replace use CA common Kconfig SoC selection instead
- select SOC_CA7774 via board's Kconfig
- select BIT64 via board's Kconfig instead of presidio.h

Changes in v2:
- Modified filepath for CA ARM and MIPS per trini's recommendation
- Rename driver in DT namespace for consistency between all CA drivers.
- Remove blank line after SPDX identifier
- Remove Authorship as it is already recorded within Git and is redundant
- Replace printf() as debug()
- Rename driver in DT namespace for consistency between all CA drivers.
- Remove blank line after SPDX identifier
- Remove authorship comment as it is already recorded within Git and is redundant
- Use setbits_32() for read-modify-write operation.
- Rename driver in DT namespace for consistency between all CA drivers.
- Remove blank line after SPDX identifier
- Remove authorship comment as it is already recorded within Git and is redundant
- Merge serial_cortina.h reg defines into serial_cortina.c
- Modify ca_serial_pending() and API to get resource.

Alex Nemirovsky (2):
MAINTAINERS, git-mailrc: cortina: add Custodian for Cortina Access
Inc.
board: presidio-asic: Add basic G3 engr. development board support

Jason Li (4):
gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs
gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs
watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs
serial: serial_cortina: add UART DM driver for CAxxxx SoCs

 MAINTAINERS                                  |  16 +++
 arch/arm/Kconfig                             |   5 +
 arch/arm/dts/Makefile                        |   2 +
 arch/arm/dts/ca-presidio-engboard.dts        |  69 +++++++++++
 arch/arm/include/asm/gpio.h                  |   2 +-
 arch/arm/mach-cortina/Makefile               |   5 +
 board/cortina/common/Kconfig                 |   6 +
 board/cortina/presidio-asic/Kconfig          |  18 +++
 board/cortina/presidio-asic/MAINTAINERS      |   6 +
 board/cortina/presidio-asic/Makefile         |   8 ++
 board/cortina/presidio-asic/lowlevel_init.S  |  87 ++++++++++++++
 board/cortina/presidio-asic/presidio.c       | 134 ++++++++++++++++++++++
 configs/cortina_presidio-asic-base_defconfig |  45 ++++++++
 doc/git-mailrc                               |   2 +
 drivers/gpio/Kconfig                         |   8 ++
 drivers/gpio/Makefile                        |   1 +
 drivers/gpio/cortina_gpio.c                  | 111 ++++++++++++++++++
 drivers/serial/Kconfig                       |   7 ++
 drivers/serial/Makefile                      |   2 +-
 drivers/serial/serial_cortina.c              | 164 +++++++++++++++++++++++++++
 drivers/watchdog/Kconfig                     |   8 ++
 drivers/watchdog/Makefile                    |   1 +
 drivers/watchdog/cortina_wdt.c               | 138 ++++++++++++++++++++++
 include/configs/presidio_asic.h              | 114 +++++++++++++++++++
 24 files changed, 957 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/dts/ca-presidio-engboard.dts
 create mode 100644 arch/arm/mach-cortina/Makefile
 create mode 100644 board/cortina/common/Kconfig
 create mode 100644 board/cortina/presidio-asic/Kconfig
 create mode 100644 board/cortina/presidio-asic/MAINTAINERS
 create mode 100644 board/cortina/presidio-asic/Makefile
 create mode 100644 board/cortina/presidio-asic/lowlevel_init.S
 create mode 100644 board/cortina/presidio-asic/presidio.c
 create mode 100644 configs/cortina_presidio-asic-base_defconfig
 create mode 100644 drivers/gpio/cortina_gpio.c
 create mode 100644 drivers/serial/serial_cortina.c
 create mode 100644 drivers/watchdog/cortina_wdt.c
 create mode 100644 include/configs/presidio_asic.h
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/6 MAINTAINERS, git-mailrc: cortina: add Custodian for Cortina Access Inc.

Assign Alex Nemirovsky as custodian for all
Cortina Access (CA) for ARM and MIPS based SoCs.

Currently Cortina Access CAxxxx family of SoCs support both ARM and MIPS ISA. Drivers have cross platform support for both architectures.

---

Changes in v3:
- Remove CA ARM and MIPS common subdirectories from board/cortina/common after further discussions with trini

Changes in v2:
- Modified filepath for CA ARM and MIPS per trini's recommendation

 MAINTAINERS                  | 16 ++++++++++++++++
 board/cortina/common/Kconfig |  6 ++++++
 doc/git-mailrc               |  2 ++
 3 files changed, 24 insertions(+)
 create mode 100644 board/cortina/common/Kconfig
MAINTAINERS +16 -0
index 438fb22..2a5f41d 100644
@@ -173,6 +173,14 @@ F:	doc/README.bcm7xxx
 F:	drivers/mmc/bcmstb_sdhci.c
 F:	drivers/spi/bcmstb_spi.c
 
+ARM CORTINA ACCESS CAxxxx
+M:	Alex Nemirovsky <[email protected]>
+S:	Supported
+F:	board/cortina/common/
+F:	drivers/gpio/cortina_gpio.c
+F:	drivers/watchdog/cortina_wdt.c
+F:	drivers/serial/serial_cortina.c
+
 ARM/CZ.NIC TURRIS MOX SUPPORT
 M:	Marek Behun <[email protected]>
 S:	Maintained
@@ -647,6 +655,14 @@ S:	Maintained
 T:	git https://gitlab.denx.de/u-boot/custodians/u-boot-mips.git
 F:	arch/mips/
 
+MIPS CORTINA ACCESS CAxxxx
+M:	Alex Nemirovsky <[email protected]>
+S:	Supported
+F:	board/cortina/common/
+F:	drivers/gpio/cortina_gpio.c
+F:	drivers/watchdog/cortina_wdt.c
+F:	drivers/serial/serial_cortina.c
+
 MIPS MSCC
 M:	Gregory CLEMENT <[email protected]>
 M:	Lars Povlsen <[email protected]>
board/cortina/common/Kconfig new file +6 -0
new file mode 100644
index 0000000..00c709e
@@ -0,0 +1,6 @@
+config CORTINA_PLATFORM
+       bool "Cortina-Access Platform"
+       default y
+       help
+         Select this option for Cortina-Access platforms
+	 to enables selection of CAxxxx drivers
doc/git-mailrc +2 -0
index d29416a..33d1814 100644
@@ -15,6 +15,7 @@ alias abrodkin       Alexey Brodkin <[email protected]>
 alias afleming       Andy Fleming <[email protected]>
 alias ag             Anatolij Gustschin <[email protected]>
 alias agraf          Alexander Graf <[email protected]>
+alias alexnemirovsky Alex Nemirovsky <[email protected]>
 alias alisonwang     Alison Wang <[email protected]>
 alias angelo_ts      Angelo Dureghello <[email protected]>
 alias bmeng          Bin Meng <[email protected]>
@@ -56,6 +57,7 @@ alias arc            uboot, abrodkin
 
 alias arm            uboot, trini
 alias at91           uboot, abiessmann
+alias cortina        uboot, alexnemirovsky
 alias davinci        ti
 alias imx            uboot, sbabic
 alias kirkwood       uboot, stroese
Signature · 1 line
2.7.4
#2 lore raw

PATCH v3 1/6 MAINTAINERS, git-mailrc: cortina: add Custodian for Cortina Access Inc.

Quoted 9 lines · Alex Nemirovsky

Assign Alex Nemirovsky as custodian for all
Cortina Access (CA) for ARM and MIPS based SoCs.

Currently Cortina Access CAxxxx family of SoCs support both ARM and MIPS ISA. Drivers have cross platform support for both architectures.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200130/0f2f856d/attachment.sig>
#3 lore raw

PATCH v3 2/6 gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs

In reply to Alex Nemirovsky

From: Jason Li <[email protected]>

The Cortina CAxxxx GPIO driver maintains DM_GPIO support across different CPU ISA in the CAxxxx Soc Family; Not just ARM. Therefore, it is not desirable to split out and maintain separete gpio header file for each CPU architecture.

---

Changes in v3: None
Changes in v2: None

 arch/arm/include/asm/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/gpio.h +1 -1
index 6ff5f42..10af1e1 100644
@@ -3,7 +3,7 @@
 	!defined(CONFIG_ARCH_BCM63158) && !defined(CONFIG_ARCH_ROCKCHIP) && \
 	!defined(CONFIG_ARCH_LX2160A) && !defined(CONFIG_ARCH_LS1028A) && \
 	!defined(CONFIG_ARCH_LS2080A) && !defined(CONFIG_ARCH_LS1088A) && \
-	!defined(CONFIG_ARCH_ASPEED)
+	!defined(CONFIG_ARCH_ASPEED) && !defined(CONFIG_CORTINA_PLATFORM)
 #include <asm/arch/gpio.h>
 #endif
 #include <asm-generic/gpio.h>
Signature · 1 line
2.7.4
#4 lore raw

PATCH v3 2/6 gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs

Quoted 10 lines · Alex Nemirovsky

From: Jason Li <[email protected]>

The Cortina CAxxxx GPIO driver maintains DM_GPIO support across different CPU ISA in the CAxxxx Soc Family; Not just ARM. Therefore, it is not desirable to split out and maintain separete gpio header file for each CPU architecture.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200130/84c97659/attachment.sig>
#5 lore raw

PATCH v3 3/6 gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs

In reply to Alex Nemirovsky

From: Jason Li <[email protected]>

DM_GPIO based GPIO controller driver for CAxxxx SoCs. This driver support multiple CPU architectures and Cortina Access SoC platforms.

---

Changes in v3: None
Changes in v2:
- Rename driver in DT namespace for consistency between all CA drivers.
- Remove blank line after SPDX identifier
- Remove Authorship as it is already recorded within Git and is redundant
- Replace printf() as debug()

 drivers/gpio/Kconfig        |   8 ++++
 drivers/gpio/Makefile       |   1 +
 drivers/gpio/cortina_gpio.c | 111 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 120 insertions(+)
 create mode 100644 drivers/gpio/cortina_gpio.c
drivers/gpio/Kconfig +8 -0
index 1de6f52..8a7aa5a 100644
@@ -59,6 +59,14 @@ config BCM6345_GPIO
 	help
 	  This driver supports the GPIO banks on BCM6345 SoCs.
 
+config CORTINA_GPIO
+	bool "Cortina-Access GPIO driver"
+	depends on DM_GPIO && CORTINA_PLATFORM
+	help
+	  Enable support for the GPIO controller in Cortina CAxxxx SoCs.
+	  This driver supports all CPU ISA variants supported by Cortina
+	  Access CAxxxx SoCs.
+
 config DWAPB_GPIO
 	bool "DWAPB GPIO driver"
 	depends on DM && DM_GPIO
drivers/gpio/Makefile +1 -0
index 449046b..ceae612 100644
@@ -17,6 +17,7 @@ endif
 obj-$(CONFIG_AT91_GPIO)	+= at91_gpio.o
 obj-$(CONFIG_ATMEL_PIO4)	+= atmel_pio4.o
 obj-$(CONFIG_BCM6345_GPIO)	+= bcm6345_gpio.o
+obj-$(CONFIG_CORTINA_GPIO)      += cortina_gpio.o
 obj-$(CONFIG_INTEL_GPIO)	+= intel_gpio.o
 obj-$(CONFIG_INTEL_ICH6_GPIO)	+= intel_ich6_gpio.o
 obj-$(CONFIG_INTEL_BROADWELL_GPIO)	+= intel_broadwell_gpio.o
drivers/gpio/cortina_gpio.c new file +111 -0

111 lines not on this page · raw message

Signature · 1 line
2.7.4
#6 lore raw

PATCH v3 4/6 watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs

In reply to Alex Nemirovsky

From: Jason Li <[email protected]>

Add support for hardware watchdog timer on all Cortina Access CAxxxx family of SoCs.

---

Changes in v3: None
Changes in v2:
- Rename driver in DT namespace for consistency between all CA drivers.
- Remove blank line after SPDX identifier
- Remove authorship comment as it is already recorded within Git and is redundant
- Use setbits_32() for read-modify-write operation.

 drivers/watchdog/Kconfig       |   8 +++
 drivers/watchdog/Makefile      |   1 +
 drivers/watchdog/cortina_wdt.c | 138 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 147 insertions(+)
 create mode 100644 drivers/watchdog/cortina_wdt.c
drivers/watchdog/Kconfig +8 -0
index 8c16d69..2f7dedb 100644
@@ -99,6 +99,14 @@ config WDT_CDNS
 	   Select this to enable Cadence watchdog timer, which can be found on some
 	   Xilinx Microzed Platform.
 
+config WDT_CORTINA
+	bool "Cortina Access CAxxxx watchdog timer support"
+	depends on WDT
+	help
+	  Cortina Access CAxxxx watchdog timer support.
+	  This driver support all CPU ISAs supported by Cortina
+          Access CAxxxx SoCs.
+
 config WDT_MPC8xx
 	bool "MPC8xx watchdog timer support"
 	depends on WDT && MPC8xx
drivers/watchdog/Makefile +1 -0
index 955caef..87f92a4 100644
@@ -20,6 +20,7 @@ obj-$(CONFIG_WDT_SANDBOX) += sandbox_wdt.o
 obj-$(CONFIG_WDT_ARMADA_37XX) += armada-37xx-wdt.o
 obj-$(CONFIG_WDT_ASPEED) += ast_wdt.o
 obj-$(CONFIG_WDT_BCM6345) += bcm6345_wdt.o
+obj-$(CONFIG_WDT_CORTINA) += cortina_wdt.o
 obj-$(CONFIG_WDT_ORION) += orion_wdt.o
 obj-$(CONFIG_WDT_CDNS) += cdns_wdt.o
 obj-$(CONFIG_WDT_MPC8xx) += mpc8xx_wdt.o
drivers/watchdog/cortina_wdt.c new file +138 -0

138 lines not on this page · raw message

Signature · 1 line
2.7.4
#7 lore raw

PATCH v3 5/6 serial: serial_cortina: add UART DM driver for CAxxxx SoCs

In reply to Alex Nemirovsky

From: Jason Li <[email protected]>

Add serial UART driver support for all Cortina Access CAxxxx family of SoCs.

---

Changes in v3:
- clean up comment blocks
- fix rmw of baud rate bitfield change

Changes in v2:
- Rename driver in DT namespace for consistency between all CA drivers.
- Remove blank line after SPDX identifier
- Remove authorship comment as it is already recorded within Git and is redundant
- Merge serial_cortina.h reg defines into serial_cortina.c
- Modify ca_serial_pending() and API to get resource.

 drivers/serial/Kconfig          |   7 ++
 drivers/serial/Makefile         |   2 +-
 drivers/serial/serial_cortina.c | 164 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 172 insertions(+), 1 deletion(-)
 create mode 100644 drivers/serial/serial_cortina.c
drivers/serial/Kconfig +7 -0
index ece7d87..9f76596 100644
@@ -539,6 +539,13 @@ config BCM6345_SERIAL
 	help
 	  Select this to enable UART on BCM6345 SoCs.
 
+config CORTINA_UART
+	bool "Cortina UART support"
+	depends on DM_SERIAL
+	help
+	  Select this to enable UART support for Cortina-Access UART devices
+	  found on CAxxxx SoCs.
+
 config FSL_LINFLEXUART
 	bool "Freescale Linflex UART support"
 	depends on DM_SERIAL
drivers/serial/Makefile +1 -1
index 06ee306..c8f2db4 100644
@@ -28,13 +28,13 @@ obj-$(CONFIG_PL010_SERIAL) += serial_pl01x.o
 obj-$(CONFIG_PL011_SERIAL) += serial_pl01x.o
 obj-$(CONFIG_SYS_NS16550_SERIAL) += serial_ns16550.o
 endif
-
 obj-$(CONFIG_ALTERA_UART) += altera_uart.o
 obj-$(CONFIG_ALTERA_JTAG_UART) += altera_jtag_uart.o
 obj-$(CONFIG_AR933X_UART) += serial_ar933x.o
 obj-$(CONFIG_ARM_DCC) += arm_dcc.o
 obj-$(CONFIG_ATMEL_USART) += atmel_usart.o
 obj-$(CONFIG_BCM6345_SERIAL) += serial_bcm6345.o
+obj-$(CONFIG_CORTINA_UART) += serial_cortina.o
 obj-$(CONFIG_EFI_APP) += serial_efi.o
 obj-$(CONFIG_LPC32XX_HSUART) += lpc32xx_hsuart.o
 obj-$(CONFIG_MCFUART) += mcfuart.o
drivers/serial/serial_cortina.c new file +164 -0

164 lines not on this page · raw message

Signature · 1 line
2.7.4
#8 lore raw

PATCH v3 6/6 board: presidio-asic: Add basic G3 engr. development board support

In reply to Alex Nemirovsky

Add basic Presidio G3 engineering board support

---

Changes in v3:
- fixed dts closing bracket indentation
- presidio.h: remove deadcode from presidio.h
- presidio.h: remove CA_REG_READ/CA_REG_WRITE wrapper macros
- presidio.h: remove CA77xx define replace use CA common Kconfig SoC selection instead
- select SOC_CA7774 via board's Kconfig
- select BIT64 via board's Kconfig instead of presidio.h

Changes in v2: None

 arch/arm/Kconfig                             |   5 +
 arch/arm/dts/Makefile                        |   2 +
 arch/arm/dts/ca-presidio-engboard.dts        |  69 ++++++++++++++
 arch/arm/mach-cortina/Makefile               |   5 +
 board/cortina/presidio-asic/Kconfig          |  18 ++++
 board/cortina/presidio-asic/MAINTAINERS      |   6 ++
 board/cortina/presidio-asic/Makefile         |   8 ++
 board/cortina/presidio-asic/lowlevel_init.S  |  87 +++++++++++++++++
 board/cortina/presidio-asic/presidio.c       | 134 +++++++++++++++++++++++++++
 configs/cortina_presidio-asic-base_defconfig |  45 +++++++++
 include/configs/presidio_asic.h              | 114 +++++++++++++++++++++++
 11 files changed, 493 insertions(+)
 create mode 100644 arch/arm/dts/ca-presidio-engboard.dts
 create mode 100644 arch/arm/mach-cortina/Makefile
 create mode 100644 board/cortina/presidio-asic/Kconfig
 create mode 100644 board/cortina/presidio-asic/MAINTAINERS
 create mode 100644 board/cortina/presidio-asic/Makefile
 create mode 100644 board/cortina/presidio-asic/lowlevel_init.S
 create mode 100644 board/cortina/presidio-asic/presidio.c
 create mode 100644 configs/cortina_presidio-asic-base_defconfig
 create mode 100644 include/configs/presidio_asic.h
arch/arm/Kconfig +5 -0
index 36c9c2f..6d95cde 100644
@@ -1638,6 +1638,10 @@ config TARGET_DURIAN
 	  Support for durian platform.
 	  It has 2GB Sdram, uart and pcie.
 
+config TARGET_PRESIDIO_ASIC
+	bool "Support Cortina Presidio ASIC Platform"
+	select ARM64
+
 endchoice
 
 config ARCH_SUPPORT_TFABOOT
@@ -1782,6 +1786,7 @@ source "board/Marvell/gplugd/Kconfig"
 source "board/armadeus/apf27/Kconfig"
 source "board/armltd/vexpress/Kconfig"
 source "board/armltd/vexpress64/Kconfig"
+source "board/cortina/presidio-asic/Kconfig"
 source "board/broadcom/bcm23550_w1d/Kconfig"
 source "board/broadcom/bcm28155_ap/Kconfig"
 source "board/broadcom/bcm963158/Kconfig"
arch/arm/dts/Makefile +2 -0
index 0127a91..81db1e6 100644
@@ -849,6 +849,8 @@ dtb-$(CONFIG_TARGET_VEXPRESS_CA15_TC2) += vexpress-v2p-ca15_a7.dtb
 
 dtb-$(CONFIG_TARGET_DURIAN) += phytium-durian.dtb
 
+dtb-$(CONFIG_TARGET_PRESIDIO_ASIC) += ca-presidio-engboard.dtb
+
 targets += $(dtb-y)
 
 # Add any required device tree compiler flags here
arch/arm/dts/ca-presidio-engboard.dts new file +69 -0

69 lines not on this page · raw message

arch/arm/mach-cortina/Makefile new file +5 -0
new file mode 100644
index 0000000..ffb8692
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# (C) Copyright 2020 Cortina Access Inc.
+#
+obj-y += lowlevel_init.o
board/cortina/presidio-asic/Kconfig new file +18 -0
new file mode 100644
index 0000000..8e6f6cf
@@ -0,0 +1,18 @@
+if TARGET_PRESIDIO_ASIC
+config BIT64
+       bool
+       default y
+
+select SOC_CA7774
+
+config SYS_BOARD
+	default "presidio-asic"
+
+config SYS_VENDOR
+	default "cortina"
+
+config SYS_CONFIG_NAME
+	default "presidio_asic"
+
+source "board/cortina/common/Kconfig"
+endif
board/cortina/presidio-asic/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000..9db17bd
@@ -0,0 +1,6 @@
+Cortina Presidio ASIC G3 Engineering BOARD
+M:	Alex Nemirovsky <[email protected]>
+S:	Supported
+F:	board/cortina/presidio-asic/
+F:	include/configs/presidio_asic.h
+F:	configs/cortina_presidio-asic*defconfig
board/cortina/presidio-asic/Makefile new file +8 -0
new file mode 100644
index 0000000..d167a15
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier:	GPL-2.0+
+#
+# (C) Copyright 2020 Cortina-Access.Inc.
+#
+#
+
+obj-y	:= presidio.o
+obj-y	+= lowlevel_init.o
board/cortina/presidio-asic/lowlevel_init.S new file +87 -0

87 lines not on this page · raw message

board/cortina/presidio-asic/presidio.c new file +134 -0

134 lines not on this page · raw message

configs/cortina_presidio-asic-base_defconfig new file +45 -0

45 lines not on this page · raw message

include/configs/presidio_asic.h new file +114 -0

114 lines not on this page · raw message

Signature · 1 line
2.7.4
#9 lore raw

PATCH v3 6/6 board: presidio-asic: Add basic G3 engr. development board support

Quoted 3 lines · Alex Nemirovsky

Add basic Presidio G3 engineering board support

[snip]

Quoted 1 line
 create mode 100644 arch/arm/dts/ca-presidio-engboard.dts

What is the status of upstreaming this file to Linux?

[snip]

configs/cortina_presidio-asic-base_defconfig line 1

Quoted 7 lines
configs/cortina_presidio-asic-base_defconfig new file +1 -0
new file mode 100644
index 0000000..45b911c
@@ -0,0 +1,45 @@
+# Cortina-Access Ltd. Presidio ASIC Board

This file is re-generated frequently. Please use 'savedefconfig' on this next and use that version.

Quoted 15 lines
include/configs/presidio_asic.h new file +9 -0
new file mode 100644
index 0000000..22679ca
@@ -0,0 +1,114 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2020 Cortina Access Inc.
+ *
+ * Configuration for Cortina-Access Presidio board.
+ */
+
+#ifndef __PRESIDIO_ASIC_H
+#define __PRESIDIO_ASIC_H

include/configs/presidio_asic.h line 19

Quoted 10 lines
include/configs/presidio_asic.h new file +10 -0
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_GICV2
+
+#define CONFIG_SUPPORT_RAW_INITRD
+#define CONFIG_ARMV8_MULTIENTRY
+
+/* SMP jump address in DRAM */
+#define CPU_RELEASE_ADDR		0x0740fff8

non-CONFIG symbols need to be in other header files, not this one.

Quoted 72 lines
include/configs/presidio_asic.h new file +72 -0
+
+#define CONFIG_SYS_INIT_SP_ADDR		0x00100000
+#define CONFIG_SYS_BOOTM_LEN		0x00c00000
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY		25000000
+#define CONFIG_SYS_TIMER_RATE COUNTER_FREQUENCY
+#define CONFIG_SYS_TIMER_COUNTER 0xf4321008
+
+/* Generic Interrupt Controller Definitions */
+#define GICD_BASE			0xf7011000
+#define GICC_BASE			0xf7012000
+
+#define CONFIG_SYS_MEMTEST_SCRATCH	0x00100000
+#define CONFIG_SYS_MEMTEST_START	0x05000000
+#define CONFIG_SYS_MEMTEST_END		0x0D000000
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (8 << 20))
+
+#define CONFIG_SYS_TIMER_BASE		0xf4321000
+
+/* Use external clock source */
+#define PRESIDIO_APB_CLK		125000000
+#define CORTINA_PER_IO_FREQ		PRESIDIO_APB_CLK
+
+/* Cortina Serial Configuration */
+#define CORTINA_UART_CLOCK		(PRESIDIO_APB_CLK)
+#define CORTINA_SERIAL_PORTS		{(void *)CONFIG_SYS_SERIAL0, \
+					 (void *)CONFIG_SYS_SERIAL1}
+
+#define CONFIG_BAUDRATE			115200
+#define CONFIG_SYS_SERIAL0		PER_UART0_CFG
+#define CONFIG_SYS_SERIAL1		PER_UART1_CFG
+
+/* BLOCK Reset Definitions */
+#define RESET_OTPROM			BIT(29)
+#define RESET_SD			BIT(28)
+#define RESET_EAXI			BIT(27)
+#define RESET_FBM			BIT(26)
+#define RESET_LDMA			BIT(25)
+#define RESET_RCRYPTO			BIT(24)
+#define RESET_SADB			BIT(22)
+#define RESET_RCPU1			BIT(21)
+#define RESET_RCPU0			BIT(20)
+#define RESET_PE1			BIT(19)
+#define RESET_PE0			BIT(18)
+#define RESET_RTC			BIT(17)
+#define RESET_DMA			BIT(16)
+#define RESET_PER			BIT(15)
+#define RESET_FLASH			BIT(14)
+#define RESET_GIC400			BIT(10)
+#define RESET_SATA			BIT(9)
+#define RESET_PCIE2			BIT(8)
+#define RESET_PCIE1			BIT(7)
+#define RESET_PCIE0			BIT(6)
+#define RESET_TQM			BIT(5)
+#define RESET_SDRAM			BIT(4)
+#define RESET_L3FE			BIT(3)
+#define RESET_L2TM			BIT(2)
+#define RESET_L2FE			BIT(1)
+#define RESET_NI			BIT(0)
+
+/* BOOTP options */
+#define CONFIG_BOOTP_BOOTFILESIZE
+
+/* Miscellaneous configurable options */
+#define DDR_BASE			0x00000000
+#define CONFIG_SYS_LOAD_ADDR		(DDR_BASE + 0x10000000)
+#define CONFIG_LAST_STAGE_INIT
+
+/* Physical Memory Map */

include/configs/presidio_asic.h line 101

Quoted 10 lines
include/configs/presidio_asic.h new file +10 -0
+
+/* SDRAM Bank #1 */
+#define PHYS_SDRAM_1			DDR_BASE
+#define PHYS_SDRAM_1_SIZE		0x80000000 /* 2GB */
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+
+/* Initial environment variables */
+
+#define CONFIG_EXTRA_ENV_SETTINGS	"silent=y\0"
+#define CONFIG_BOOTARGS			"earlycon=serial,0xf4329148 console=ttyS0,115200 root=/dev/ram0"

Note that BOOTARGS belongs in the defconfig file.

Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200130/c1ec7c3b/attachment.sig>
#10 lore raw

PATCH v3 6/6 board: presidio-asic: Add basic G3 engr. development board support

Quoted 13 lines · Tom Rini
Quoted 3 lines · Alex Nemirovsky

Add basic Presidio G3 engineering board support

[snip]

Quoted 1 line

create mode 100644 arch/arm/dts/ca-presidio-engboard.dts

What is the status of upstreaming this file to Linux?

Tom,
May I assume you are asking about DT board files in Linux because
your workflow typically copies the DT files from Linux upstream for reuse by u-boot without modification? Essential making it the defacto source for all the DT board files in u-boot?

The rest of your feedback items should be address in rev 4 of the patch series that I just recently submitted.

Quoted 130 lines

[snip]

configs/cortina_presidio-asic-base_defconfig line 1

Quoted 7 lines
configs/cortina_presidio-asic-base_defconfig new file +1 -0
new file mode 100644
index 0000000..45b911c
@@ -0,0 +1,45 @@
+# Cortina-Access Ltd. Presidio ASIC Board

This file is re-generated frequently. Please use 'savedefconfig' on this next and use that version.

Quoted 15 lines
include/configs/presidio_asic.h new file +9 -0
new file mode 100644
index 0000000..22679ca
@@ -0,0 +1,114 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2020 Cortina Access Inc.
+ *
+ * Configuration for Cortina-Access Presidio board.
+ */
+
+#ifndef __PRESIDIO_ASIC_H
+#define __PRESIDIO_ASIC_H

include/configs/presidio_asic.h line 19

Quoted 10 lines
include/configs/presidio_asic.h new file +10 -0
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_GICV2
+
+#define CONFIG_SUPPORT_RAW_INITRD
+#define CONFIG_ARMV8_MULTIENTRY
+
+/* SMP jump address in DRAM */
+#define CPU_RELEASE_ADDR		0x0740fff8

non-CONFIG symbols need to be in other header files, not this one.

Quoted 72 lines
include/configs/presidio_asic.h new file +72 -0
+
+#define CONFIG_SYS_INIT_SP_ADDR		0x00100000
+#define CONFIG_SYS_BOOTM_LEN		0x00c00000
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY		25000000
+#define CONFIG_SYS_TIMER_RATE COUNTER_FREQUENCY
+#define CONFIG_SYS_TIMER_COUNTER 0xf4321008
+
+/* Generic Interrupt Controller Definitions */
+#define GICD_BASE			0xf7011000
+#define GICC_BASE			0xf7012000
+
+#define CONFIG_SYS_MEMTEST_SCRATCH	0x00100000
+#define CONFIG_SYS_MEMTEST_START	0x05000000
+#define CONFIG_SYS_MEMTEST_END		0x0D000000
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (8 << 20))
+
+#define CONFIG_SYS_TIMER_BASE		0xf4321000
+
+/* Use external clock source */
+#define PRESIDIO_APB_CLK		125000000
+#define CORTINA_PER_IO_FREQ		PRESIDIO_APB_CLK
+
+/* Cortina Serial Configuration */
+#define CORTINA_UART_CLOCK		(PRESIDIO_APB_CLK)
+#define CORTINA_SERIAL_PORTS		{(void *)CONFIG_SYS_SERIAL0, \
+					 (void *)CONFIG_SYS_SERIAL1}
+
+#define CONFIG_BAUDRATE			115200
+#define CONFIG_SYS_SERIAL0		PER_UART0_CFG
+#define CONFIG_SYS_SERIAL1		PER_UART1_CFG
+
+/* BLOCK Reset Definitions */
+#define RESET_OTPROM			BIT(29)
+#define RESET_SD			BIT(28)
+#define RESET_EAXI			BIT(27)
+#define RESET_FBM			BIT(26)
+#define RESET_LDMA			BIT(25)
+#define RESET_RCRYPTO			BIT(24)
+#define RESET_SADB			BIT(22)
+#define RESET_RCPU1			BIT(21)
+#define RESET_RCPU0			BIT(20)
+#define RESET_PE1			BIT(19)
+#define RESET_PE0			BIT(18)
+#define RESET_RTC			BIT(17)
+#define RESET_DMA			BIT(16)
+#define RESET_PER			BIT(15)
+#define RESET_FLASH			BIT(14)
+#define RESET_GIC400			BIT(10)
+#define RESET_SATA			BIT(9)
+#define RESET_PCIE2			BIT(8)
+#define RESET_PCIE1			BIT(7)
+#define RESET_PCIE0			BIT(6)
+#define RESET_TQM			BIT(5)
+#define RESET_SDRAM			BIT(4)
+#define RESET_L3FE			BIT(3)
+#define RESET_L2TM			BIT(2)
+#define RESET_L2FE			BIT(1)
+#define RESET_NI			BIT(0)
+
+/* BOOTP options */
+#define CONFIG_BOOTP_BOOTFILESIZE
+
+/* Miscellaneous configurable options */
+#define DDR_BASE			0x00000000
+#define CONFIG_SYS_LOAD_ADDR		(DDR_BASE + 0x10000000)
+#define CONFIG_LAST_STAGE_INIT
+
+/* Physical Memory Map */

include/configs/presidio_asic.h line 101

Quoted 10 lines
include/configs/presidio_asic.h new file +10 -0
+
+/* SDRAM Bank #1 */
+#define PHYS_SDRAM_1			DDR_BASE
+#define PHYS_SDRAM_1_SIZE		0x80000000 /* 2GB */
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+
+/* Initial environment variables */
+
+#define CONFIG_EXTRA_ENV_SETTINGS	"silent=y\0"
+#define CONFIG_BOOTARGS			"earlycon=serial,0xf4329148 console=ttyS0,115200 root=/dev/ram0"

Note that BOOTARGS belongs in the defconfig file.

Thanks!

Signature · 1 line
Tom
#11 lore raw

PATCH v3 6/6 board: presidio-asic: Add basic G3 engr. development board support

Quoted 10 lines · Alex Nemirovsky
Quoted 10 lines · Tom Rini
Quoted 3 lines · Alex Nemirovsky

Add basic Presidio G3 engineering board support

[snip]

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

create mode 100644 arch/arm/dts/ca-presidio-engboard.dts

What is the status of upstreaming this file to Linux?

Tom,
May I assume you are asking about DT board files in Linux because
your workflow typically copies the DT files from Linux upstream for reuse by u-boot without modification? Essential making it the defacto source for all the DT board files in u-boot?

Yes. We do have some platforms that do not have a Linux upstream to them and need to be more careful in their reviews. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200130/7ee14dd4/attachment.sig>
#12 lore raw

PATCH v3 6/6 board: presidio-asic: Add basic G3 engr. development board support

Tom,

For now, please consider our boards on the small list of boards for which
DT files from Linux are not available for reuse by u-boot.
Although the attached DT file pass patman parsing without warnings, feel free to give them more scrutiny as there is no immediate effort to upstream Linux support.

BR
-AN

Quoted 27 lines · Tom Rini
Quoted 10 lines · Alex Nemirovsky
Quoted 10 lines · Tom Rini
Quoted 3 lines · Alex Nemirovsky

Add basic Presidio G3 engineering board support

[snip]

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

create mode 100644 arch/arm/dts/ca-presidio-engboard.dts

What is the status of upstreaming this file to Linux?

Tom,
May I assume you are asking about DT board files in Linux because
your workflow typically copies the DT files from Linux upstream for reuse by u-boot without modification? Essential making it the defacto source for all the DT board files in u-boot?

Yes. We do have some platforms that do not have a Linux upstream to them and need to be more careful in their reviews. Thanks!

Signature · 1 line
Tom