PCI: dwc: fix compile err for pcie-tagra194
PATCH 1/1 PCI: dwc: fix compile err for pcie-tagra194
make allmodconfig
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2
need to export the symbols.
--- drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pci/controller/dwc/pcie-designware-ep.c +3 -0
@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)pci_epc_linkup (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_linkup);void dw_pcie_ep_init_notify (struct dw_pcie_ep *ep) {
@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)pci_epc_init_notify (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_notify);static void __dw_pcie_ep_reset_bar (struct dw_pcie *pci,enum pci_barno bar,int flags)
@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)return 0 ; } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_complete);int dw_pcie_ep_init (struct dw_pcie_ep *ep) {
Signature · 1 line
1.8.3.1
Quoted 8 lines · Qiujun Huang
make allmodconfig
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2
Quoted 6 lines
need to export the symbols.
Signed-off-by Qiujun Huang <[email protected]>--- drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++ 1 file changed, 3 insertions(+)
I have squashed this in with the original patch.
@Vidya: is this something we missed in the review cycle ? Asking just to make sure it was not me who made a mistake while merging the code.
Thanks,
Lorenzo
Quoted 31 lines
drivers/pci/controller/dwc/pcie-designware-ep.c +3
-0@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)pci_epc_linkup (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_linkup);void dw_pcie_ep_init_notify (struct dw_pcie_ep *ep) {@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)pci_epc_init_notify (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_notify);static void __dw_pcie_ep_reset_bar (struct dw_pcie *pci,enum pci_barno bar,int flags)@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)return 0 ; } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_complete);int dw_pcie_ep_init (struct dw_pcie_ep *ep) {Signature · 1 line
1.8.3.1
Quoted 19 lines · Lorenzo Pieralisi
External email: Use caution opening links or attachments
Quoted 8 lines · Qiujun Huang
make allmodconfig
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2Quoted 6 lines
need to export the symbols.
Signed-off-by Qiujun Huang <[email protected]>--- drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++ 1 file changed, 3 insertions(+)
Quoted 4 lines
I have squashed this in with the original patch.
@Vidya: is this something we missed in the review cycle ? Asking just to make sure it was not me who made a mistake while merging the code.
My apologies. I wasn't compiling the driver as a module (instead built into the kernel image) BTW, I see
ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! also along with the above three. So I think even dw_pcie_ep_init() needs to be exported.
Thanks,
Vidya Sagar
Quoted 35 lines
Thanks,
LorenzoQuoted 31 lines
drivers/pci/controller/dwc/pcie-designware-ep.c +3
-1@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)pci_epc_linkup (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_linkup);void dw_pcie_ep_init_notify (struct dw_pcie_ep *ep) {@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)pci_epc_init_notify (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_notify);static void __dw_pcie_ep_reset_bar (struct dw_pcie *pci,enum pci_barno bar,int flags)@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)return 0 ; } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_complete);int dw_pcie_ep_init (struct dw_pcie_ep *ep) { --1.8.3.1
Quoted 27 lines · Vidya Sagar
Quoted 19 lines · Lorenzo Pieralisi
External email: Use caution opening links or attachments
Quoted 8 lines · Qiujun Huang
make allmodconfig
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2Quoted 6 lines
need to export the symbols.
Signed-off-by Qiujun Huang <[email protected]>--- drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++ 1 file changed, 3 insertions(+)Quoted 4 lines
I have squashed this in with the original patch.
@Vidya: is this something we missed in the review cycle ? Asking just to make sure it was not me who made a mistake while merging the code.
Quoted 7 lines
My apologies. I wasn't compiling the driver as a module (instead built into the kernel image)
BTW, I see
ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! also along with the above three. So I think evendw_pcie_ep_init()needs to be exported.
OK, I'll send v2 to add dw_pcie_ep_init.
Quoted 38 lines
Thanks,
Vidya SagarQuoted 35 lines
Thanks,
LorenzoQuoted 31 lines
drivers/pci/controller/dwc/pcie-designware-ep.c +3
-1@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)pci_epc_linkup (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_linkup);void dw_pcie_ep_init_notify (struct dw_pcie_ep *ep) {@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)pci_epc_init_notify (epc); } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_notify);static void __dw_pcie_ep_reset_bar (struct dw_pcie *pci,enum pci_barno bar,int flags)@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)return 0 ; } +EXPORT_SYMBOL_GPL (dw_pcie_ep_init_complete);int dw_pcie_ep_init (struct dw_pcie_ep *ep) { --1.8.3.1