Skip to contentSkip to conversation

ARM: dts: gw552x: add USB OTG support

PATCH Superseded Tim Harvey 2 participants 5 messages Apr 24, 2020 – May 13, 2020

Subsystems (2)
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 ARM: dts: gw552x: add USB OTG support

The GW552x-B board revision adds USB OTG support.

Enable the device-tree node and configure the OTG_ID pin.

---
 arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +14 -2
index dc646b7..133a1e3 100644
@@ -12,8 +12,6 @@
 		led1 = &led1;
 		led2 = &led2;
 		nand = &gpmi;
-		usb0 = &usbh1;
-		usb1 = &usbotg;
 	};
 
 	chosen {
@@ -258,6 +256,14 @@
 	status = "okay";
 };
 
+&usbotg {
+	vbus-supply = <&reg_5p0v>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	disable-over-current;
+	status = "okay";
+};
+
 &wdog1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdog>;
@@ -359,6 +365,12 @@
 		>;
 	};
 
+	pinctrl_usbotg: usbotggrp {
+		fsl,pins = <
+			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID	0x13059
+		>;
+	};
+
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
 			MX6QDL_PAD_DISP0_DAT8__WDOG1_B		0x1b0b0
Signature · 7 lines
2.7.4


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 14 lines · Tim Harvey

The GW552x-B board revision adds USB OTG support.

Enable the device-tree node and configure the OTG_ID pin.

---
 arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +0 -0
index dc646b7..133a1e3 100644

arch/arm/boot/dts/imx6qdl-gw552x.dtsi line 16

Quoted 5 lines
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +0 -2
@@ -12,8 +12,6 @@
 		led1 = &led1;
 		led2 = &led2;
 		nand = &gpmi;
-		usb0 = &usbh1;
-		usb1 = &usbotg;

Have some comments about this change in the commit log?

Shawn

Quoted 34 lines
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +14 -0
 	};
 
 	chosen {
@@ -258,6 +256,14 @@
 	status = "okay";
 };
 
+&usbotg {
+	vbus-supply = <&reg_5p0v>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	disable-over-current;
+	status = "okay";
+};
+
 &wdog1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdog>;
@@ -359,6 +365,12 @@
 		>;
 	};
 
+	pinctrl_usbotg: usbotggrp {
+		fsl,pins = <
+			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID	0x13059
+		>;
+	};
+
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
 			MX6QDL_PAD_DISP0_DAT8__WDOG1_B		0x1b0b0
Signature · 1 line
2.7.4
author
#2 lore raw
Quoted 11 lines · Shawn Guo
Quoted 9 lines · Tim Harvey

The GW552x-B board revision adds USB OTG support.

Enable the device-tree node and configure the OTG_ID pin.

---
 arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
Quoted 13 lines

arch/arm/boot/dts/imx6qdl-gw552x.dtsi line 16

Quoted 10 lines
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +0 -2
index dc646b7..133a1e3 100644
@@ -12,8 +12,6 @@
              led1 = &led1;
              led2 = &led2;
              nand = &gpmi;
-             usb0 = &usbh1;
-             usb1 = &usbotg;

Have some comments about this change in the commit log?

Shawn,

I shouldn't have removed those... will submit a v2. Thank you for catching this!

Tim

author
#3 lore raw

PATCH v2 1/1 ARM: dts: gw552x: add USB OTG support

In reply to Tim Harvey

The GW552x-B board revision adds USB OTG support.

Enable the device-tree node and configure the OTG_ID pin.

---
 arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +14 -0
index dc646b7..bb35971 100644
@@ -258,6 +258,14 @@
 	status = "okay";
 };
 
+&usbotg {
+	vbus-supply = <&reg_5p0v>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	disable-over-current;
+	status = "okay";
+};
+
 &wdog1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdog>;
@@ -359,6 +367,12 @@
 		>;
 	};
 
+	pinctrl_usbotg: usbotggrp {
+		fsl,pins = <
+			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID	0x13059
+		>;
+	};
+
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
 			MX6QDL_PAD_DISP0_DAT8__WDOG1_B		0x1b0b0
Signature · 1 line
2.7.4
#4 lore raw
Quoted 5 lines · Tim Harvey

The GW552x-B board revision adds USB OTG support.

Enable the device-tree node and configure the OTG_ID pin.

Changed prefix to 'ARM: dts: imx6qdl-gw552x: ' and applied patch.

Shawn

Quoted 39 lines
---
 arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/imx6qdl-gw552x.dtsi +14 -0
index dc646b7..bb35971 100644
@@ -258,6 +258,14 @@
 	status = "okay";
 };
 
+&usbotg {
+	vbus-supply = <&reg_5p0v>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	disable-over-current;
+	status = "okay";
+};
+
 &wdog1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdog>;
@@ -359,6 +367,12 @@
 		>;
 	};
 
+	pinctrl_usbotg: usbotggrp {
+		fsl,pins = <
+			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID	0x13059
+		>;
+	};
+
 	pinctrl_wdog: wdoggrp {
 		fsl,pins = <
 			MX6QDL_PAD_DISP0_DAT8__WDOG1_B		0x1b0b0
Signature · 1 line
2.7.4