Skip to contentSkip to conversation

staging: vt6656: vt6655: clean Makefiles

PATCH Superseded Matej Dujava 2 participants 3 messages May 9, 2020 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6656: vt6655: clean Makefiles

This patch is removing CFLAGS that are defining flags that are not used.

---
 drivers/staging/vt6655/Makefile      | 27 ++++++++++++---------------
 drivers/staging/vt6655/device_main.c |  1 -
 drivers/staging/vt6656/Makefile      |  7 ++-----
 3 files changed, 14 insertions(+), 21 deletions(-)
drivers/staging/vt6655/Makefile +12 -15
index a151f30fc46f..eda08a1516ab 100644
@@ -1,18 +1,15 @@
 # SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__
-ccflags-y += -DHOSTAP
-
-vt6655_stage-y +=	device_main.o \
-	card.o \
-	channel.o \
-	mac.o \
-	baseband.o \
-	rxtx.o \
-	dpc.o \
-	power.o \
-	srom.o \
-	key.o \
-	rf.o
 
 obj-$(CONFIG_VT6655) +=	vt6655_stage.o
+
+vt6655_stage-y +=	device_main.o \
+			card.o \
+			channel.o \
+			mac.o \
+			baseband.o \
+			rxtx.o \
+			dpc.o \
+			power.o \
+			srom.o \
+			key.o \
+			rf.o
drivers/staging/vt6655/device_main.c +0 -1
index 5889023d19c4..41cbec4134b0 100644
@@ -32,7 +32,6 @@
  *
  * Revision History:
  */
-#undef __NO_VERSION__
 
 #include <linux/file.h>
 #include "device.h"
drivers/staging/vt6656/Makefile +2 -5
index a0f3862dea75..aac323d6a684 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
-ccflags-y += -DHOSTAP
+
+obj-$(CONFIG_VT6656) +=	vt6656_stage.o
 
 vt6656_stage-y +=	main_usb.o \
 			card.o  \
@@ -14,5 +13,3 @@ vt6656_stage-y +=	main_usb.o \
 			rf.o \
 			usbpipe.o \
 			channel.o
-
-obj-$(CONFIG_VT6656) +=	vt6656_stage.o
Signature · 1 line
2.26.2
#1 lore raw
Quoted 1 line · Matej Dujava

This patch is removing CFLAGS that are defining flags that are not used.

You are also modifying the indentation and moving lines around for no reason :(

Please only do one thing for a patch, and always describe everything you do in the changelog text.

Can you fix this up and send a v2?

thanks,

greg k-h

#2 lore raw
Quoted 8 lines · Greg Kroah-Hartman
Quoted 1 line · Matej Dujava

This patch is removing CFLAGS that are defining flags that are not used.

You are also modifying the indentation and moving lines around for no reason :(

Please only do one thing for a patch, and always describe everything you do in the changelog text.

sorry, I will split it into two separate patches and resend as v2

Thanks,
Matej

Quoted 6 lines

Can you fix this up and send a v2?

thanks,

greg k-h