x86: baytrail: acpi: Create buffers outside of the methods
PATCH 1/3 x86: baytrail: acpi: Create buffers outside of the methods
Create buffers outside of the methods as ACPICA 20200430 complains about this:
Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.PCI0.LPCB.IURT._CRS)
---
arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
arch/x86/include/asm/arch-baytrail/acpi/lpc.asl +12 -12
@@ -136,20 +136,20 @@ Device (LPCB) Store(0, C1EN) } - Method(_CRS, 0, Serialized) + Name(BUF0, ResourceTemplate() { - Name(BUF0, ResourceTemplate() - { - IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08) - IRQNoFlags() { 3 } - }) - - Name(BUF1, ResourceTemplate() - { - IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08) - IRQNoFlags() { 4 } - }) + IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08) + IRQNoFlags() { 3 } + }) + Name(BUF1, ResourceTemplate() + { + IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08) + IRQNoFlags() { 4 } + }) + + Method(_CRS, 0, Serialized) + { If (LLessEqual(SRID, 0x04)) { Return (BUF0) } Else {
Signature · 1 line
2.7.4
PATCH 1/3 x86: baytrail: acpi: Create buffers outside of the methods
Quoted 8 lines · Bin Meng
Create buffers outside of the methods as ACPICA 20200430 complains about this:
Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.PCI0.LPCB.IURT._CRS)
Quoted 6 lines
Signed-off-by Bin Meng <[email protected]>---
arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
applied to u-boot-x86, thanks!
PATCH 2/3 x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge
In reply to Bin MengPCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:
Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)
---
arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl +1 -1
@@ -11,7 +11,7 @@ Device (PCI0) Name(_HID, EISAID("PNP0A08")) /* PCIe */ Name(_CID, EISAID("PNP0A03")) /* PCI */ - Name(_ADR, 0) + Name(_UID, 0) Name(_BBN, 0) Name(MCRS, ResourceTemplate()
Signature · 1 line
2.7.4
PATCH 2/3 x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge
Quoted 5 lines · Bin Meng
PCI Firmware specification requires
_UID()and doesn't require_ADR()to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:
Quoted 9 lines
Warning 3073 - Multiple types (Device object requires either a
_HIDor_ADR, but not both)Signed-off-by Bin Meng <[email protected]>---
arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
applied to u-boot-x86, thanks!
PATCH 3/3 x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
In reply to Bin MengPCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:
Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)
---
arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/arch-quark/acpi/southcluster.asl +1 -1
@@ -8,7 +8,7 @@ Device (PCI0) Name(_HID, EISAID("PNP0A08")) /* PCIe */ Name(_CID, EISAID("PNP0A03")) /* PCI */ - Name(_ADR, 0) + Name(_UID, 0) Name(_BBN, 0) Name(MCRS, ResourceTemplate()
Signature · 1 line
2.7.4
PATCH 3/3 x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
Quoted 7 lines · Bin Meng
PCI Firmware specification requires
_UID()and doesn't require_ADR()to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:Warning 3073 - Multiple types (Device object requires either a
_HIDor_ADR, but not both)
For all three:
Quoted 22 lines
Signed-off-by Bin Meng <[email protected]>---
arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/include/asm/arch-quark/acpi/southcluster.asl +1
-1@@ -8,7 +8,7 @@ Device (PCI0) Name(_HID, EISAID("PNP0A08")) /* PCIe */ Name(_CID, EISAID("PNP0A03")) /* PCI */ - Name(_ADR, 0) + Name(_UID, 0) Name(_BBN, 0) Name(MCRS, ResourceTemplate()Signature · 1 line
2.7.4
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 3/3 x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge
Quoted 6 lines · Andy Shevchenko
Quoted 4 lines · Bin Meng
PCI Firmware specification requires
_UID()and doesn't require_ADR()to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:
Quoted 13 lines
Quoted 3 lines
Warning 3073 - Multiple types (Device object requires either a
_HIDor_ADR, but not both)For all three:
Reviewed-by Andy Shevchenko <[email protected]>Quoted 6 lines
Signed-off-by Bin Meng <[email protected]>---
arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
applied to u-boot-x86, thanks!