Skip to contentSkip to conversation

x86: baytrail: acpi: Create buffers outside of the methods

PATCH New Bin Meng 2 participants 7 messages Jun 1, 2020 – Jun 2, 2020 x86

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/3 x86: baytrail: acpi: Create buffers outside of the methods

Create buffers outside of the methods as ACPICA 20200430 complains about this:

Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.PCI0.LPCB.IURT._CRS)

---

 arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
arch/x86/include/asm/arch-baytrail/acpi/lpc.asl +12 -12
index 08b2f53..69455d9 100644
@@ -136,20 +136,20 @@ Device (LPCB)
 			Store(0, C1EN)
 		}
 
-		Method(_CRS, 0, Serialized)
+		Name(BUF0, ResourceTemplate()
 		{
-			Name(BUF0, ResourceTemplate()
-			{
-				IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
-				IRQNoFlags() { 3 }
-			})
-
-			Name(BUF1, ResourceTemplate()
-			{
-				IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
-				IRQNoFlags() { 4 }
-			})
+			IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
+			IRQNoFlags() { 3 }
+		})
 
+		Name(BUF1, ResourceTemplate()
+		{
+			IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
+			IRQNoFlags() { 4 }
+		})
+
+		Method(_CRS, 0, Serialized)
+		{
 			If (LLessEqual(SRID, 0x04)) {
 				Return (BUF0)
 			} Else {
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/3 x86: baytrail: acpi: Create buffers outside of the methods

Quoted 8 lines · Bin Meng

Create buffers outside of the methods as ACPICA 20200430 complains about this:

Remark 2173 - Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.PCI0.LPCB.IURT._CRS)

Quoted 6 lines

---

 arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

applied to u-boot-x86, thanks!

author
#2 lore raw

PATCH 2/3 x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge

In reply to Bin Meng

PCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:

Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)

---

 arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl +1 -1
index 2a1c31c..3b220c7 100644
@@ -11,7 +11,7 @@ Device (PCI0)
 	Name(_HID, EISAID("PNP0A08"))	/* PCIe */
 	Name(_CID, EISAID("PNP0A03"))	/* PCI */
 
-	Name(_ADR, 0)
+	Name(_UID, 0)
 	Name(_BBN, 0)
 
 	Name(MCRS, ResourceTemplate()
Signature · 1 line
2.7.4
author
#3 lore raw

PATCH 2/3 x86: baytrail: acpi: Replace _ADR() by _UID() in description of PCI host bridge

Quoted 5 lines · Bin Meng

PCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:

Quoted 9 lines

Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)

---

 arch/x86/include/asm/arch-baytrail/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-x86, thanks!

author
#4 lore raw

PATCH 3/3 x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge

In reply to Bin Meng

PCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:

Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)

---

 arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/arch-quark/acpi/southcluster.asl +1 -1
index fe9edc1..384dab2 100644
@@ -8,7 +8,7 @@ Device (PCI0)
 	Name(_HID, EISAID("PNP0A08"))	/* PCIe */
 	Name(_CID, EISAID("PNP0A03"))	/* PCI */
 
-	Name(_ADR, 0)
+	Name(_UID, 0)
 	Name(_BBN, 0)
 
 	Name(MCRS, ResourceTemplate()
Signature · 1 line
2.7.4
#5 lore raw

PATCH 3/3 x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge

Quoted 7 lines · Bin Meng

PCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:

Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)

For all three:

Quoted 22 lines

---

 arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/arch-quark/acpi/southcluster.asl +1 -1
index fe9edc1..384dab2 100644
@@ -8,7 +8,7 @@ Device (PCI0)
 	Name(_HID, EISAID("PNP0A08"))	/* PCIe */
 	Name(_CID, EISAID("PNP0A03"))	/* PCI */
 
-	Name(_ADR, 0)
+	Name(_UID, 0)
 	Name(_BBN, 0)
 
 	Name(MCRS, ResourceTemplate()
Signature · 1 line
2.7.4
Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#6 lore raw

PATCH 3/3 x86: quark: acpi: Replace _ADR() by _UID() in description of PCI host bridge

Quoted 6 lines · Andy Shevchenko
Quoted 4 lines · Bin Meng

PCI Firmware specification requires _UID() and doesn't require _ADR() to be set. Replace latter by former. This fixes the following warning reported by ACPICA 20200430:

Quoted 13 lines
Quoted 3 lines

Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)

For all three:

Quoted 6 lines

---

 arch/x86/include/asm/arch-quark/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-x86, thanks!